Re: [PATCH 10/24] staging: wilc1000: move wilc_multicast_mac_addr_list to 'wilc_vif' struct

2018-08-24 Thread Adham Abozaeid
On Fri, 24 Aug 2018 11:47:14 +0300 Claudiu Beznea wrote: > > > On 23.08.2018 13:00, Ajay Singh wrote: > > Unless ndo_set_rx_mode() gets called quickly I don't think there is any > > issue here. > > I don't agree with this. It would be safer that the mcast list be passed to wilc_setup_multica

Re: [PATCH 09/24] staging: wilc1000: move static variable clients_count to 'wilc' structure

2018-08-24 Thread Adham Abozaeid
On Thu, 23 Aug 2018 11:09:56 +0300 Claudiu Beznea wrote: > > > On 14.08.2018 09:50, Ajay Singh wrote: > > Avoid use of static variable 'clients_count' and move it part of 'wilc' > > structure. > > > > Signed-off-by: Ajay Singh > > --- > > drivers/staging/wilc1000/host_interface.c | 9 +++

[PATCH] staging: wilc1000: Avoid overriding rates_no while parsing ies element.

2018-05-23 Thread Adham Abozaeid
by passing reference to rates_no to host_int_parse_join_bss_param() and by incrementing reference of auth_total_cnt Fixes: d4b4aaba515a (staging: wilc1000: fix line over 80 characters in host_int_parse_join_bss_param()) Signed-off-by: Adham Abozaeid --- drivers/staging/wilc1000/host_interf