[PATCH v2] staging: lustre: Fix sparse warnings for static declarations

2014-11-10 Thread Adrian Nicoara
All the changes are against variables/functions that are only accessed from within the same file. If the scope needs to change later on, the static keyword can be removed. Build tested. Signed-off-by: Adrian Nicoara --- drivers/staging/lustre/lnet/lnet/module.c | 2 +- drivers

Re: [PATCH] staging: lustre: Fix sparse warnings for static declarations

2014-11-10 Thread Adrian Nicoara
> All the changes are against variables/functions that are only accessed from > within the same file. If the scope needs to change later on, the static > keyword > can be removed. > > Compile tested. Correction - I somehow missed a compile error. Disregard this patch, I'll follow up with a correct

[PATCH] staging: lustre: Fix sparse warnings for static declarations

2014-11-10 Thread Adrian Nicoara
All the changes are against variables/functions that are only accessed from within the same file. If the scope needs to change later on, the static keyword can be removed. Compile tested. Signed-off-by: Adrian Nicoara --- There are 73 such warnings remaining by my last count. They, however

Re: [PATCH v2 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

2014-09-08 Thread Adrian Nicoara
Cleanup checkpatch.pl warnings. Signed-off-by: Adrian Nicoara --- Somehow I missed the comment Tobias made on the line indentation. I fixed the patch, and added here as a reply - the previous patch should be ignored. drivers/staging/ozwpan/ozhcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

2014-09-08 Thread Adrian Nicoara
Cleanup checkpatch.pl warnings. Signed-off-by: Adrian Nicoara --- drivers/staging/ozwpan/ozhcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index ba2168f..4cfe56e 100644 --- a/drivers/staging/ozwpan/ozhcd.c

[PATCH v2 3/4] staging: ozwpan: fix redundant return in void function

2014-09-08 Thread Adrian Nicoara
Cleanup checkpatch.pl warnings. Signed-off-by: Adrian Nicoara --- drivers/staging/ozwpan/ozproto.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c index cae0e6f..3d3a3a8 100644 --- a/drivers/staging/ozwpan/ozproto.c +++ b

[PATCH v2 2/4] staging: ozwpan: fix redundant else after break or return

2014-09-08 Thread Adrian Nicoara
Cleanup checkpatch.pl warnings. Signed-off-by: Adrian Nicoara --- drivers/staging/ozwpan/ozhcd.c | 8 +++- drivers/staging/ozwpan/ozpd.c | 10 -- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index

[PATCH v2 1/4] staging: ozwpan: fix missing blank line after declaration

2014-09-08 Thread Adrian Nicoara
Cleanup checkpatch.pl warnings. Signed-off-by: Adrian Nicoara --- drivers/staging/ozwpan/ozcdev.c| 5 + drivers/staging/ozwpan/ozeltbuf.c | 1 + drivers/staging/ozwpan/ozpd.c | 6 ++ drivers/staging/ozwpan/ozproto.c | 4 drivers/staging/ozwpan/ozusbsvc.c | 2