Thanks Dan for your review!!
On Thu, Apr 02, 2020 at 01:29:06PM +0300, Dan Carpenter wrote:
> Looks good. Thanks!
>
> Reviewed-by: Dan Carpenter
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linu
(u8)psecuritypriv->
+ XGrpKeyid);
WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid'
652: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:652:
+ (u8)psecuritypriv->
+
This patch fixes the following warning in rtl871x_xmit.c:
WARNING: line over 80 characters
130: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:130:
+ pxmitbuf->pallocated_buf = kmalloc(MAX_XMITBUF_SZ +
XMITBUF_ALIGN_SZ,
Signed-off-by: Aiman Najjar
---
drivers/staging/rtl8
1. Refactor make_wlanhdr to improve code style.
2. Use ether_addr_copy instead of memcpy to copy addresses.
Suggested-by: Joe Perches
Signed-off-by: Aiman Najjar
---
drivers/staging/rtl8712/rtl871x_xmit.c | 123 -
drivers/staging/rtl8712/rtl871x_xmit.h | 2 +-
2 files
XGrpKeyid].skey);
Signed-off-by: Aiman Najjar
---
drivers/staging/rtl8712/rtl871x_xmit.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c
b/drivers/staging/rtl8712/rtl871x_xmit.c
index 454c26f83406..0f789c821552 1
: drivers/staging//rtl8712/rtl871x_xmit.c:79:
+ kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4,
GFP_ATOMIC);
Signed-off-by: Aiman Najjar
---
drivers/staging/rtl8712/rtl871x_xmit.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712
Make several improvements to code style of rtl871x_xmit.c and rtl871x_xmit.h.
v1 -> v2: changes
* Break up single pach into patchset of small patches
v2 -> v3 changes:
* [PATCH 4/5]: Applied suggestions by Joe to improve overall code quality
(thanks Joe!)
Aiman Najjar (5):
staging: r
On Sat, Mar 28, 2020 at 12:17:19PM -0700, Joe Perches wrote:
> On Fri, 2020-03-27 at 20:08 -0400, aimannajjar wrote:
> > This patch fixes the following checkpatch warning in
> > rtl8712x_xmit.c:
> >
> > WARNING: Avoid multiple line dereference - prefer
> > 'psta->sta_xmitpriv.txseq_tid[pattrib->p
This patch fixes remaining warnings in rtl871x_xmit.c of
rtl8712 staging driver
The following warnings are resolved:
WARNING: line over 80 characters
\#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74:
+ * Please allocate memory with the sz = (struct xmit_frame) *
NR_XMITFRAME,
WARNIN
