[PATCH v4] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
Stack allocated buffers cannot be used for DMA on all architectures so allocate hci_packet buffer using kmalloc. Signed-off-by: Amey Narkhede --- Changes in v4: - Use struct_size to allocate memory for hci_packet - Fix memory corruption drivers/staging/gdm724x/gdm_usb.c | 10

Re: [PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
On 21/02/10 06:19PM, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 08:31:33PM +0530, Amey Narkhede wrote: > > On 21/02/10 03:55PM, Greg KH wrote: > > > On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote: > > > > Stack allocated buffers cannot

Re: [PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
On 21/02/10 03:55PM, Greg KH wrote: > On Wed, Feb 10, 2021 at 07:55:12PM +0530, Amey Narkhede wrote: > > Stack allocated buffers cannot be used for DMA > > on all architectures so allocate hci_packet buffer > > using kmalloc. > > > > Signed-off-by: Amey Na

[PATCH v3] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
Stack allocated buffers cannot be used for DMA on all architectures so allocate hci_packet buffer using kmalloc. Signed-off-by: Amey Narkhede --- Changes in v3: - Remove superfluous buf pointer - Reduce size of allocation of hci_packet to match number of bytes used for

Re: [PATCH v2] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
On 21/02/10 10:09AM, Greg KH wrote: > On Wed, Feb 10, 2021 at 02:28:11PM +0530, Amey Narkhede wrote: > > On 21/02/10 09:06AM, Greg KH wrote: > > > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote: > > > > Stack allocated buffers cannot be used for DMA &

Re: [PATCH v2] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
On 21/02/10 12:04PM, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 02:28:11PM +0530, Amey Narkhede wrote: > > On 21/02/10 09:06AM, Greg KH wrote: > > > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote: > > > > Stack allocated buffers cannot

Re: [PATCH v2] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
On 21/02/10 09:06AM, Greg KH wrote: > On Wed, Feb 10, 2021 at 01:31:34PM +0530, Amey Narkhede wrote: > > Stack allocated buffers cannot be used for DMA > > on all architectures so allocate hci_packet buffer > > using kzalloc(). > > > > Signed-off-by: Amey Na

[PATCH v2] staging: gdm724x: Fix DMA from stack

2021-02-10 Thread Amey Narkhede
Stack allocated buffers cannot be used for DMA on all architectures so allocate hci_packet buffer using kzalloc(). Signed-off-by: Amey Narkhede --- Changes in v2: - Fixed build warning - Fixed memory leak using kfree drivers/staging/gdm724x/gdm_usb.c | 9 +++-- 1 file

Re: [PATCH] staging: gdm724x: Fix DMA from stack

2021-02-09 Thread Amey Narkhede
On 21/02/09 06:40PM, Greg KH wrote: > On Tue, Feb 09, 2021 at 08:24:15PM +0530, ameynarkhed...@gmail.com wrote: > > From: Amey Narkhede > > > > Stack allocated buffers cannot be used for DMA > > on all architectures so allocate usbdev buffer > > using kmall

Re: [PATCH] staging: qlge/qlge_main: Use min_t instead of min

2021-02-05 Thread Amey Narkhede
On 21/02/04 03:58PM, Nathan Chancellor wrote: > On Fri, Feb 05, 2021 at 03:24:51AM +0530, ameynarkhed...@gmail.com wrote: > > From: Amey Narkhede > > > > Use min_t instead of min function in qlge/qlge_main.c > > Fixes following checkpatch.pl warning: > > WARNIN