Re: [PATCH v2] Staging: comedi: das08_cs: Fix block comments use * on subsequent lines.

On Tue, Sep 6, 2016 at 4:18 PM, Ian Abbott wrote: > On 05/09/16 17:45, Amit Ghadge wrote: >> >> Fixes checkpatch warning in das08_cs.c file: >> WARNING: Block comments use * on subsequent lines >> >> Added * in blank line in comment block. >> >> S

[PATCH v2] Staging: comedi: das08_cs: Fix block comments use * on subsequent lines.

Fixes checkpatch warning in das08_cs.c file: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/das08_cs.c | 76 +++ 1 file changed, 38 insertions(+), 38 deletions

Re: [PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Mon, Sep 5, 2016 at 9:42 PM, Ian Abbott wrote: > On 05/09/16 17:05, Amit Ghadge wrote: >> >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Added * in blank line in comment block.

[PATCH v3] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 60 +-- 1 file changed, 30

[PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 60 +-- 1 file changed, 30

[PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26

Re: [PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Mon, Sep 5, 2016 at 6:45 PM, Ian Abbott wrote: > On 03/09/16 21:11, Amit Ghadge wrote: >> >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> >> WARNING: Block comments use * on subsequent lines >> >> Signed-off-by: Amit Ghadge &g

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

On Mon, Sep 5, 2016 at 7:02 PM, Ian Abbott wrote: > On 03/09/16 21:11, Amit Ghadge wrote: >> >> Fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid >> of check

[PATCH] Staging: rtl8188eu: ioctl_linux: Clean up if function returned NULL on failure.

Clean some all functions to return NULL on failure. Used !x instead of x==NULL. Signed-off-by: Amit Ghadge --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep

[PATCH] Staging: comedi: das08_cs: Fix block comments use * on subsequent lines.

Fixes checkpatch warning in das08_cs.c file: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/das08_cs.c | 70 +++ 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/staging/comedi

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

] > [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for > convenience) to record what (public, well-known) commit your patch series was > built on] > [Check https://git-scm.com/docs/git-format-patch for more information] > > url: > https://gith

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

I will be send individual patches. I was try, make M=drivers/staging/comedi/ No issue generated, Is there have any other option to test these changes? Amit G On Sun, Sep 4, 2016 at 2:05 PM, Greg KH wrote: > On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote: >> Fixes c

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 3:12 PM, Giedrius Statkevičius wrote: > On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge wrote: >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Signed-off-by: Amit Gha

[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge wrote: > This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: > > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Amit Ghadge > --- > drivers/staging/comedi/comedidev.h| 8 ++-

[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/comedidev.h| 8 ++--- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 2

[PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a

[PATCH 2/2] Staging: comedi: pcl726.c, ni_670x.c: Fix warnings and check.

ace CamelCase range_0_20mA to range_0_20ma. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_670x.c | 66 drivers/staging/comedi/drivers/pcl726.c | 2 +- 2 files changed, 33 insertions(+), 35 deletions(-) diff --git a/drivers/staging/comedi/dr

[PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a

[PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

Fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid of checkpatch.pl "CHECK" output "Prefer using the BIT macro". Replace Avoid CamelCase range_0_20mA to range_0_20ma. Signed-off-by:

[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a

[PATCH] [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a

Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

op-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top Thanks for this valuable information. > > On Tue, May 17, 2016 at 09:31:56AM +0530, Amit Ghadge wrote: &

[PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue

This is a patch to the quatech_daqp_cs.c file that fixes by using unsigned int instead of unsigned, following warning found by checkpatch. * WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/quatech_daqp

Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

Hello Greg KH, I make patch same like other, I'm new and I nerver see changelog in other patches. Where to add changelog? I followed you are tutorial. Thanks, Amit Ghadge On Mon, May 16, 2016 at 08:34:55PM -0700, Greg KH wrote: > > A: No. > Q: Should I include quotations

Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

tch reduced the warning message. On Mon, May 16, 2016 at 11:19:05AM -0700, Greg KH wrote: > On Mon, May 16, 2016 at 11:04:31PM +0530, Amit Ghadge wrote: > > Fixed a warning issue to use 'unsigned int'. > > > > build warning?

[PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

Fixed a warning issue to use 'unsigned int'. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech

[PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'.

Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c index e9e4313..802f51e 100644 --- a/drivers