On Tue, Aug 29, 2017 at 11:44:37AM +0300, Alex Briskin wrote:
> A change was made to the commit message itself.
> In V1, as pointed out by Andy, I left module_driver instead of
> module_usb_driver in the commit message.
Dont't forget to fix the subject. "Driver registration ..." is not
compliant t
On Sun, Aug 27, 2017 at 08:22:10AM +0300, Alex Briskin wrote:
> Register with module_driver macro instead of module_init/module_exit.
It must be the module_usb_driver. Also in the subject.
Hint: use the imperative sentence for the subject, like
"staging: most: hdm_usb: use module_usb_driver ..."
On Fri, Aug 25, 2017 at 06:40:18PM +0300, Alex Briskin wrote:
> 1. Remove redundant functions.
> 2. Remove potentially missleading return code (-EIO).
> 3. Add module_driver driver registration macro.
s/module_driver/module_usb_driver/
/andy
> * Will also remove pr_info messages.
>
> Signed-off-
nt __init __driver##_init(void) \
> { \
> return __register(&(__driver) , ##__VA_ARGS__); \
> } \
> module_init(__driver##_init); \
> static void __exit __driver##_exit(void) \
> { \
> __unregister(&(__driver) , ##__VA_ARGS__); \
> } \
> module_exit(_
On Fri, Aug 25, 2017 at 12:47:33PM +0300, Alex Briskin wrote:
> 1. Remove redundant functions.
> 2. Remove potentially misleading return code (-EIO).
> 3. Add module_driver driver registration macro.
> * Will also remove pr_info messages.
>
> Signed-off-by: Alex Briskin
> ---
> drivers/staging/m
On Tue, Jun 20, 2017 at 10:56:43PM +0300, Dan Carpenter wrote:
> On Tue, Jun 20, 2017 at 05:11:51PM +0200, Christian Gromm wrote:
> > @@ -411,21 +428,31 @@ static int aim_rx_data(struct mbo *mbo)
> > struct sk_buff *skb;
> > struct net_device *dev;
> > unsigned int skb_len;
> > + int
On Sun, Sep 25, 2016 at 03:41:11PM +, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the audio_set_hw_params() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun
Signed-off-b
On Fri, Sep 16, 2016 at 02:44:37PM +0300, Dan Carpenter wrote:
> On Thu, Sep 15, 2016 at 04:19:03PM +0200, Christian Gromm wrote:
> > From: Andrey Shvetsov
> >
> > The DIM2 HDM checks the parameters passed to the function
> > configure_channel() and adapts the buffer
On Fri, Mar 18, 2016 at 06:32:15PM +0530, Amitoj Kaur Chawla wrote:
> Commit 3eced21a5afb ("staging: most: hdm-dim2: Replace request_irq
> with devm_request_irq") introduced the following static checker
> warning:
> drivers/staging/most/hdm-dim2/dim2_hdm.c:841 dim2_probe()
> error: 'dev->netinfo_ta
On Fri, Mar 18, 2016 at 01:41:19PM +0100, Geert Uytterhoeven wrote:
> On Fri, Mar 18, 2016 at 6:42 AM, Linux Kernel Mailing List
> wrote:
> > Web:
> > https://git.kernel.org/torvalds/c/f45b0fba43f415f69982df743dfa9b5d1b57785e
> > Commit: f45b0fba43f415f69982df743dfa9b5d1b57785e
> > Par
On Mon, Sep 07, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote:
> On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote:
> > On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote:
> > > The platform driver core will set the owner value, we do not need to
On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote:
> The platform driver core will set the owner value, we do not need to do
> it in the module.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --gi
On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote:
> Using 'extern' is not necessary for function prototypes.
>
We use them to mark dependency inversions (callbacks).
I thought about comments instead of, but I'm not sure what is worse.
--
Regards,
Andrey
___
On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote:
> Return NULL instead of 0 for invalid input.
>
> Signed-off-by: Tomas Melin
Signed-off-by: Andrey Shvetsov
> ---
> drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
14 matches
Mail list logo
