[RFCv2 2/3] media: uapi: Add VP9 v4l2 library

2021-05-05 Thread Andrzej Pietrasiewicz
Provide code common to vp9 drivers in one central location. Signed-off-by: Andrzej Pietrasiewicz --- drivers/media/v4l2-core/Kconfig|4 + drivers/media/v4l2-core/Makefile |1 + drivers/media/v4l2-core/v4l2-vp9.c | 1831 include/media/v4l2-vp9.h

[RFCv2 3/3] media: rkvdec: Add the VP9 backend

2021-05-05 Thread Andrzej Pietrasiewicz
From: Boris Brezillon The Rockchip VDEC supports VP9 profile 0 up to 4096x2304@30fps. Add a backend for this new format. Signed-off-by: Boris Brezillon Signed-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/rkvdec/Kconfig

[RFCv2 1/3] media: uapi: Add VP9 stateless decoder controls

2021-05-05 Thread Andrzej Pietrasiewicz
Add the VP9 stateless decoder controls plus the documentation that goes with it. Signed-off-by: Boris Brezillon Signed-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- .../userspace-api/media/v4l/biblio.rst| 10 + .../media/v4l/ext-ctrls

[RFCv2 0/3] vp9 v4l2 stateless uapi

2021-05-05 Thread Andrzej Pietrasiewicz
eoconvert ! video/x-raw,format=I420 ! filesink location=out.yuv I kindly ask for your comments. Andrzej Pietrasiewicz (2): media: uapi: Add VP9 stateless decoder controls media: uapi: Add VP9 v4l2 library Boris Brezillon (1): media: rkvdec: Add the VP9 backend .../userspace-a

[PATCHv2 3/3] media: cedrus: Fix .buf_prepare

2021-05-05 Thread Andrzej Pietrasiewicz
which might be then written to hw registers by the driver in cedrus_h264.c or cedrus_vp8.c. Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/cedrus

[PATCHv2 2/3] media: hantro: Fix .buf_prepare

2021-05-05 Thread Andrzej Pietrasiewicz
which might be then written to hw registers by the driver in hantro_g1_h264_dec.c. Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/hantro/hantro_v4l2.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/hantro/hantro_v4l2.c b/drivers

[PATCHv2 1/3] media: rkvdec: Fix .buf_prepare

2021-05-05 Thread Andrzej Pietrasiewicz
ned-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/rkvdec/rkvdec.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c index d821661d30f3..cd65ad2af8d4 100644 --- a/drivers/staging/me

[PATCHv2 0/3] Fix .buf_prepare

2021-05-05 Thread Andrzej Pietrasiewicz
which might be then written to hw registers by the driver. Andrzej Pietrasiewicz (2): media: hantro: Fix .buf_prepare media: cedrus: Fix .buf_prepare Ezequiel Garcia (1): media: rkvdec: Fix .buf_prepare drivers/staging/media/hantro/hantro_v4l2.c| 9 - drivers/staging/media

Re: [PATCH] media: rkvdec: Fix .buf_prepare

2021-05-05 Thread Andrzej Pietrasiewicz
Hi Ezequiel, W dniu 04.05.2021 o 13:56, Ezequiel Garcia pisze: Hi Andrzej, Thanks a lot for picking this up. On Tue, 2021-05-04 at 13:37 +0200, Andrzej Pietrasiewicz wrote: From: Ezequiel Garcia The driver should only set the payload on .buf_prepare if the buffer is CAPTURE type. If an

[PATCH] media: rkvdec: Fix .buf_prepare

2021-05-04 Thread Andrzej Pietrasiewicz
ned-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- @Hans: I haven't had anyone complain about the issue. The fix is needed for the rkvdec vp9 work, so I think 5.14 is fine. drivers/staging/media/rkvdec/rkvdec.c | 10 +- 1 file changed, 9 i

Re: [RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

2021-04-30 Thread Andrzej Pietrasiewicz
Hi Hans, Thank you for the review. I'm working on a v2 to address your comments. Also please see inline. Andrzej W dniu 29.04.2021 o 12:20, Hans Verkuil pisze: On 21/04/2021 12:00, Andrzej Pietrasiewicz wrote: Add the VP9 stateless decoder controls plus the documentation that goes wi

[RFC RESEND 3/3] media: rkvdec: Add the VP9 backend

2021-04-21 Thread Andrzej Pietrasiewicz
From: Boris Brezillon The Rockchip VDEC supports VP9 profile 0 up to 4096x2304@30fps. Add a backend for this new format. Signed-off-by: Boris Brezillon Signed-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/rkvdec/Makefile

[RFC RESEND 2/3] media: uapi: Add VP9 stateless decoder controls

2021-04-21 Thread Andrzej Pietrasiewicz
Add the VP9 stateless decoder controls plus the documentation that goes with it. Signed-off-by: Boris Brezillon Signed-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- .../userspace-api/media/v4l/biblio.rst| 10 + .../media/v4l/ext-ctrls

[RFC RESEND 1/3] media: rkvdec: Fix .buf_prepare

2021-04-21 Thread Andrzej Pietrasiewicz
ned-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/rkvdec/rkvdec.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c index d8

[RFC RESEND 0/3] vp9 v4l2 stateless uapi

2021-04-21 Thread Andrzej Pietrasiewicz
ver. Rebased onto media_tree. I kindly ask for your comments. TODO: - potentially fine-tune the uAPI (add/remove fields, move between structs) - write another driver (intended g2 @ iMX8) - verify the added documentation Regards, Andrzej Andrzej Pietrasiewicz (1): media: uapi: Add VP9 stateles

[RFC 3/3] media: rkvdec: Add the VP9 backend

2021-04-21 Thread Andrzej Pietrasiewicz
From: Boris Brezillon The Rockchip VDEC supports VP9 profile 0 up to 4096x2304@30fps. Add a backend for this new format. Signed-off-by: Boris Brezillon Signed-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/rkvdec/Makefile

[RFC 2/3] media: uapi: Add VP9 stateless decoder controls

2021-04-21 Thread Andrzej Pietrasiewicz
Add the VP9 stateless decoder controls plus the documentation that goes with it. Signed-off-by: Boris Brezillon Signed-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- .../userspace-api/media/v4l/biblio.rst| 10 + .../media/v4l/ext-ctrls

[RFC 1/3] media: rkvdec: Fix .buf_prepare

2021-04-21 Thread Andrzej Pietrasiewicz
ned-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/rkvdec/rkvdec.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c index d8

Re: [PATCH 0/4] Hantro VPU JPEG encoder fixes

2020-02-07 Thread Andrzej Pietrasiewicz
Hi All, I've just tested RK3288, and this series is indeed fixing these issues. So for all patches: Tested-by: Ezequiel Garcia A kind reminder. The series fixes serious encoding quality problems in both rk3399 and rk3288, so it seems it should be included. A review is needed, though, at l

[PATCH 4/4] media: hantro: Write quantization table registers in increasing addresses order

2020-01-27 Thread Andrzej Pietrasiewicz
non-relaxed variant doesn't help. This patch removes this premature optimization and after this change the macroblocking artifacts around contrasting edges are gone. Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/hantro/hantro_h1_jpeg_enc.c | 6 ++ drivers/staging/

[PATCH 2/4] media: hantro: Use standard luma quantization table

2020-01-27 Thread Andrzej Pietrasiewicz
The table is actually different in the document than in this file, so align this file with the document. Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/media/hantro/hantro_jpeg.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media

[PATCH 0/4] Hantro VPU JPEG encoder fixes

2020-01-27 Thread Andrzej Pietrasiewicz
whole luma quantization table must be written first, and then the chroma quantization is written. In other words, while patch 3/4 changes what goes into which register, this patch changes when each register is written to. It also affects rk3288 and hasn't been tested with it. Andrzej Pietrasiewi

[PATCH 3/4] media: hantro: Write the quantization tables in proper order

2020-01-27 Thread Andrzej Pietrasiewicz
d for properly reordered quantization tables, to be read with get_unaligned_be32() and linearly written to the registers. The "ctx" parameter is not needed any more for hantro_jpeg_get_qtable(). Signed-off-by: Andrzej Pietrasiewicz --- .../staging/media/hantro/hantro_h1_jpeg_enc.c |

[PATCH 1/4] media: hantro: Read be32 words starting at every fourth byte

2020-01-27 Thread Andrzej Pietrasiewicz
Since (luma/chroma)_qtable is an array of unsigned char, indexing it returns consecutive byte locations, but we are supposed to read the arrays in four-byte words. Consequently, we should be pointing get_unaligned_be32() at consecutive word locations instead. Signed-off-by: Andrzej Pietrasiewicz

[PATCH] staging: comedi: ni_mio_common: add "no_channel" versions of some functions

2015-11-14 Thread Andrzej Pietrasiewicz
anges is suppressesing 4 sparse warnings: "warning: shift too big (4294967295) for type int". Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/comedi/drivers/ni_mio_common.c | 82 +++--- 1 file changed, 49 insertions(+), 33 deletions(-) diff --git a/drivers

[PATCH] staging: rtl8188eu: eliminate spaces before commas

2015-06-08 Thread Andrzej Pietrasiewicz
ords the changes are limited to cases where the patch generated is itself checkpatch-correct. Rebased onto next-20150605. Signed-off-by: Andrzej Pietrasiewicz --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme.c| 8 drivers/st