Re: [PATCH v3] staging: vt6655: ioctl.c - missing __user annotation

2014-07-30 Thread Anil Shashikumar Belur
On Thursday 31 July 2014 05:38 AM, Greg KH wrote: > > This patch doesn't apply against my tree at all, what did you make it > against? > > Always work against linux-next, or the staging-next branch of my > staging.git tree on git.kernel.org. > > thanks, > > greg k-h Hi, I am working on staging.gi

Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation

2014-07-29 Thread Anil Shashikumar Belur
On Tuesday 29 July 2014 02:47 PM, Dan Carpenter wrote: > On Tue, Jul 29, 2014 at 10:05:38AM +0200, Tobias Klauser wrote: > >> Wouldn't it be better to annotate the data member in struct tagSCmdRequest >> with __user instead of introducing all these casts? Hi, Yes, having the data member annotate

Re: [PATCH 1/1] drivers: staging: cxt1e1: linux.c - missing __user annotation

2014-07-27 Thread Anil Shashikumar Belur
On Monday 28 July 2014 08:43 AM, Greg KH wrote: > On Mon, Jul 28, 2014 at 08:38:29AM +0530, Anil Belur wrote: >> Signed-off-by: Anil Belur >> --- >> drivers/staging/cxt1e1/linux.c | 30 +++--- >> 1 file changed, 15 insertions(+), 15 deletions(-) > This file is no longer i

Re: [PATCH 1/2] staging: rtl8723au: core: rtw_ap.c - removed NULL pointer check before kfree()

2014-07-10 Thread Anil Shashikumar Belur
On Thursday 10 July 2014 11:25 AM, Anil Belur wrote: > From: Anil Belur > > - as kfree() internally check for NULL, additional check it not > required. > Sorry - please ignore this patch set, they are already fixed by someone else recently. ___ devel

Re: [PATCH 2/2] staging: nokia_h4p: nokia_core.c - removed IRQF_DISABLED macro

2014-07-09 Thread Anil Shashikumar Belur
On Wednesday 09 July 2014 05:16 PM, Pavel Machek wrote: > I wonder if it would maek sense to do > ./include/linux/interrupt.h:#define IRQF_DISABLED 0 to make it extra > clear that it is nop now? Pavel yes - it makes sense. there are still a few references to the macro in the code. Cheers, Anil _

Re: [PATCH 1/1] staging: speakup: main.c - use time_after()

2014-07-08 Thread Anil Shashikumar Belur
On Wednesday 09 July 2014 05:21 AM, Greg KH wrote: > This change is already in my tree, what branch are you working > against? greg k-h Hi Greg, I am using staging.git. I try to make sure and rebase any changes in my branch with staging-next before sending out the patches. Not sure, if I am miss

Re: [PATCH v2 1/1] staging: lustre: libcfs: nidstrings.c - use ARRAY_SIZE macro

2014-07-08 Thread Anil Shashikumar Belur
On Wednesday 09 July 2014 05:18 AM, Greg KH wrote: > Someone sent this same patch just before you did, sorry :( > Ah - no worries - sorry for the noise. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/l

Re: [PATCH 1/1] staging: media: msi3101: sdr-msi3101.c - replace with time_before_eq()

2014-06-29 Thread Anil Shashikumar Belur
On Monday 30 June 2014 12:47 AM, Antti Palosaari wrote: > Moikka! > That is already fixed by someone else and patch is somewhere Mauro or > Hans queue. > > regards > Antti > Moikka :) Ah no worries - I could not find the changes with the latest updates. Thanks ___