[PATCH] staging: speakup: Simplify NULL comparisons

2017-03-09 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/fakekey.c

[PATCH] staging: speakup: fix "Alignment match open parenthesis"

2017-03-09 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 40 +++--- 2 files change

[PATCH 3/4] staging: speakup: Alignment match open parenthesis

2017-03-09 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - Aligned the lines which are not aligned in previous patch. --- drivers/staging/speakup/i18n.c | 2 +- drivers

[PATCH 4/4] staging: speakup: Placed Logical on the previous line

2017-03-09 Thread Arushi Singhal
Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/d

[PATCH 2/4] staging: speakup:indentation should use tabs

2017-03-09 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/i18n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c

[PATCH 0/4] staging: speakup: checkpatch guided cleanups

2017-03-09 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (4): staging: speakup: Comparison to NULL could be written staging: speakup:indentation should use tabs staging: speakup: Alignment match open parenthesis staging: speakup: Placed Logical

[PATCH 1/4] staging: speakup: Comparison to NULL could be written

2017-03-09 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - fixed coding style error and upto the coding style. --- drivers/staging/s

[PATCH] staging: ks7010: removed code in comments.

2017-03-09 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal

[PATCH 1/3] staging: sm750fb: fixes add blank line after function/struct/union/enum declarations

2017-03-05 Thread Arushi Singhal
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/sm750fb/ddk750_display.h | 1 + drivers/staging/sm750fb/ddk750_mode.h

[PATCH 3/3] staging: sm750fb: Alignment should match open parenthesis

2017-03-05 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/sm750fb/ddk750_mode.c | 69 +-- 1 file changed, 34 insertions(+), 35 deletions(-) diff

[PATCH 2/3] staging: sm750fb: function prototype argument should have an identifier name

2017-03-05 Thread Arushi Singhal
function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/ddk750_mode.h| 2 +- drivers/s

[PATCH 0/3] multiple checkpatch issues

2017-03-05 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in sm750fb driver. Arushi Singhal (3): staging: sm750fb: fixes add blank line after function/struct/union/enum declarations staging: sm750fb: function prototype argument should have an identifier name staging: sm750fb: Alignment

[PATCH 3/6] staging: speakup: identation should use tabs

2017-03-04 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/speakup_decpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/s

[PATCH 5/6] staging: wilc1000: function prototype argument should have identifier name

2017-03-04 Thread Arushi Singhal
function prototype argument should have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/wilc1000/wilc_wlan.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wi

[PATCH 6/6] staging: wilc1000: Logical continuations should be on the previous line

2017-03-04 Thread Arushi Singhal
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/wilc1000/wilc_spi.c | 4 ++-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.

[PATCH 4/6] staging: wilc1000: Alignment should match open parenthesis

2017-03-04 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/wilc_spi.c | 2 +- drivers/

[PATCH 2/6] staging: speakup: Avoid multiple assignments on same line

2017-03-04 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/

[PATCH 1/6] staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-04 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 3 ++- drivers/staging/speakup/speakup_decext.c | 6 +++--- d

[PATCH 0/6] multiple checkpatch issues

2017-03-04 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues. Arushi Singhal (6): staging: speakup: fixes braces {} should be used on all arms of this statement staging: speakup: Avoid multiple assignments on same line staging: speakup: identation should use tabs staging: wilc1000

[PATCH 5/6] staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-03 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 32 +++- 1 file changed, 19 insertions(

[PATCH 3/6] staging: speakup: Blank lines removed after an open brace '{'

2017-03-03 Thread Arushi Singhal
Blank lines aren't necessary after an open brace '{' as reported by Checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/kobjects.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/s

[PATCH 2/6] staging: speakup: Logical continuations should be on the previous line

2017-03-03 Thread Arushi Singhal
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-)

[PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations

2017-03-03 Thread Arushi Singhal
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c

[PATCH 6/6] staging: speakup: Comparison to NULL could be written

2017-03-03 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/varhandlers.c | 6 +++--- 2

[PATCH 4/6] staging: speakup: Avoid multiple assignments on same line

2017-03-03 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 0/6] multiple checkpatch issues

2017-03-03 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: Add blank line after function/struct/union/enum declarations staging: speakup: Logical continuations should be on the previous line staging: speakup: Blank lines removed

[PATCH 5/6] staging: speakup: Avoid multiple assignments on same line

2017-03-03 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-03 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 29 +++-- 1 file changed, 19 insertions(+), 10 del

[PATCH 4/6] staging: speakup: Blank lines removed after an open brace '{'

2017-03-03 Thread Arushi Singhal
Blank lines aren't necessary after an open brace '{' as reported by Checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/kobjects.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/s

[PATCH 3/6] staging: speakup: Logical continuations should be on the previous line

2017-03-03 Thread Arushi Singhal
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-)

[PATCH 0/6] multiple checkpatch issues

2017-03-03 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: Add blank line after function/struct/union/enum declarations staging: speakup: simple_strtoul is replaced with kstrtoul staging: speakup: Logical continuations should

[PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations

2017-03-03 Thread Arushi Singhal
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c

[PATCH 2/6] staging: speakup: simple_strtoul is replaced with kstrtoul

2017-03-03 Thread Arushi Singhal
This patch fixes "simple_strtoul is obsolete, use kstrtoul instead" warning. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/kobjects.c| 4 ++-- drivers/staging/speakup/main.c| 2 +- drivers/staging/speakup/varhandlers.c

[PATCH] staging: speakup: else is not generally useful after a break or return

2017-03-03 Thread Arushi Singhal
fixed checkpatch.pl warning: else is not generally useful after a break or return. Removed the else without affecting the logic. Dead code is also eliminated. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/keyhelp.

[PATCH 4/4] staging: speakup: Alignment should match open parenthesis

2017-03-02 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/spe

[PATCH 3/4] staging: speakup: identation should use tabs

2017-03-02 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/s

[PATCH 1/4] staging: speakup: Placed Logical on the previous line

2017-03-02 Thread Arushi Singhal
Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/d

[PATCH 0/4] Fix multiple checkpatch issues

2017-03-02 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (4): staging: speakup: Placed Logical on the previous line staging: speakup: spaces preferred around operator staging: speakup: identation should use tabs staging: speakup: Alignment should match

[PATCH 2/4] staging: speakup: spaces preferred around operator

2017-03-02 Thread Arushi Singhal
Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal <arushisingh

[PATCH 4/4] staging: speakup: Alignment should match open parenthesis

2017-03-02 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/spe

[PATCH 3/4] staging: speakup: identation should use tabs

2017-03-02 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h b/drivers/s

[PATCH 1/4] staging: speakup: Placed Logical on the previous line

2017-03-02 Thread Arushi Singhal
Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/d

[PATCH 2/4] staging: speakup: spaces preferred around operator

2017-03-02 Thread Arushi Singhal
Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal <arushisingh

[PATCH] staging: speakup: Alignment match open parenthesis

2017-03-02 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - Aligned the lines which are not aligned in previous patch. drivers/staging/speakup/i18n.c | 2 +- drivers

[PATCH v2] staging: speakup: Comparison to NULL could be written

2017-03-02 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - fixed coding style error and upto the coding style. drivers/staging/speakup/fak

[PATCH] staging: speakup: Alignment match open parenthesis

2017-03-01 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 38 +++--- 2 files change

[PATCH] staging: speakup:indentation should use tabs

2017-03-01 Thread Arushi Singhal
Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/i18n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c

[PATCH] staging: speakup: Comparison to NULL could be written

2017-03-01 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/fakekey.c | 2 +- drivers/staging/speakup/kobjects.c | 2 +- drivers/s

[PATCH] staging: iio: ad9832: Move header file content to source file

2017-03-01 Thread Arushi Singhal
The contents of the header file are used only by this single source file. Move content into .c and remove .h. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/iio/frequency/ad9832.c | 100 +- drivers/staging/iio/frequency/ad9832.h

[PATCH] staging: xgifb: Improved coding style

2017-03-01 Thread Arushi Singhal
New variable is added to make the code more readable. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/xgifb/XGI_main_26.c | 29 ++--- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_2

[PATCH] staging: ks7010: Unnecessary parentheses removed and improved coding style.

2017-03-01 Thread Arushi Singhal
ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 23 +++ drivers/staging/ks7010/ks_wlan_net.c | 18 +- 2 files changed, 20 insertions(+), 21 deletions(-)

[PATCH] staging: ks7010: Unnecessary parentheses removed and improved coding style.

2017-02-28 Thread Arushi Singhal
ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/st

[PATCH v7] staging: xgifb: correct the multiple line dereference

2017-02-28 Thread Arushi Singhal
Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v7 - Improve the coding style. - Introduced new variables. drive

[PATCH v6] staging: xgifb: correct the multiple line dereference

2017-02-27 Thread Arushi Singhal
Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable and also to correct about mentioned error as by itroducing new variables line is not exceeding 80 characters. Signed-off-by: Arushi Singhal <arush

[PATCH v5] staging: xgifb: correct the multiple line dereference

2017-02-27 Thread Arushi Singhal
Error reported by checkpatch.pl as "avoid multiple line dereference". Addition of new variables to make the code more readable and also to correct about mentioned error as by itroducing new variables line is not exceeding 80 characters. Signed-off-by: Arushi Singhal <arush

[PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Arushi Singhal
N); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- Changes in v4: - Commit message made more accurate and as per the changes. - previously versions were not marked. drivers/sta

[PATCH v4 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Arushi Singhal
N); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- Changes in v4: - Commit message made more accurate and as per the changes. drivers/staging/ks7010/ks_hostif.c | 24 1 file changed,

[PATCH v4] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Arushi Singhal
Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v4

[PATCH v2] staging: ks7010: remove code in comments.

2017-02-26 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal

[PATCH v3] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Arushi Singhal
Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v3

[PATCH v2] staging: xgifb: correct the multiple line dereference

2017-02-24 Thread Arushi Singhal
line exceeding 80 characters length. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- changes in v2 - changes done such that no other errors can generate. --- drivers/staging/xgifb/XGI_main_26.c | 21 + drivers/staging/xgifb/vb_setmode.c

[PATCH] staging: ks7010: codes in the comments are removed

2017-02-24 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in thos patch codes in the comments are removed. Signed-off-by: Arushi Singhal

[PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

2017-02-21 Thread Arushi Singhal
N); memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 20 ++-- drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 20 insertions(+

[PATCH v2 2/2] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-19 Thread Arushi Singhal
Unnecessary parentheses should be avoided as reported by checkpatch.pl Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files chang

[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Arushi Singhal
Unnecessary parentheses should be avoided as reported by checkpatch.pl Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files chang

[PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Arushi Singhal
The following patch the checkpatch.pl warning: drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Arushi Singhal
Unnecessary parentheses as reported by checkpatch.pl Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/d

[PATCH] staging: ks7010: Block comments use * on subsequent lines

2017-02-18 Thread Arushi Singhal
Some of the block comments styles are not encouraged: for example: /* block comment without introductory * */ and /* * block comment with line terminating */ Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/ks7010/ks7010_sdio.c | 6 -- 1 file chan

[PATCH v2] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/d

[PATCH] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/d

[PATCH] staging: xgifb: function definition argument should also have an identifier name'

2017-02-18 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

[PATCH] staging: xgifb: function definition argument should also have an identifier name

2017-02-16 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

[PATCH] staging: xgifb: function definition argument should also have an identifier name

2017-02-15 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

[PATCH] staging: xgifb: function definition argument should also have an identifier name

2017-02-14 Thread Arushi Singhal
function definition argument 'struct vb_device_info *' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_in

[PATCH 2/2] staging: vt6656: Alignment match open parenthesis

2017-02-14 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/vt6656/rxtx.c | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff

[PATCH 1/2] staging: vt6656: Alignment should match open parenthesis

2017-02-14 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/vt6656/firmware.c | 34 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656

[PATCH] staging: fwserial: replace 'a' with '(a)' to avoid precedence issues

2017-02-14 Thread Arushi Singhal
Macro argument 'a' may be better as '(a)' to avoid precedence issues as reported by checkpatch.pl Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/fwserial/fwserial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fw

[PATCH] staging:nvec:nvec_ps2.c: Prefering kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...)

2017-02-14 Thread Arushi Singhal
Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct serio)...) as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/nvec/nvec_ps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagin

[PATCH] staging: vt6656: Alignment match open parenthesis

2017-02-12 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/vt6656/rxtx.c | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff

[PATCH] staging: vt6656: Alignment match open parenthesis

2017-02-12 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/vt6656/firmware.c | 34 +- drivers/staging/vt6656/key.h | 2 +- drivers/staging/vt6656

[PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue

2017-02-12 Thread Arushi Singhal
Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/vt6656/channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/

[PATCH] staging: rtl8192e: Aligning the * on each line in block comments

2017-02-12 Thread Arushi Singhal
This patch fixes the issue by aligning the * on each line in block comments. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/speakup/fakekey.c| 10 +- drivers/staging/speakup/i18n.c | 14 +++--- drivers/staging/speakup/

[PATCH] staging:vt6656:channel.h: fix function definition argument without identifier name issue

2017-02-09 Thread Arushi Singhal
Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/vt6656/channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/

[PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2017-02-09 Thread Arushi Singhal
Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> --- drivers/staging/vt6655/baseband.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/d

<    1   2   3