Fixes the checkpatch.pl warning: Avoid CamelCase
Signed-off-by: Aya Mahfouz
---
drivers/staging/gdm724x/gdm_lte.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.h
b/drivers/staging/gdm724x/gdm_lte.h
index 7ddeabc..3ecaff1 100644
--- a
On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote:
> On Oct 17, 2016, at 15:46, Aya Mahfouz wrote:
> >
> > class_devno_max is an inline function that returns
> > MAX_OBD_DEVICES. Replace all calls to the function
> > by MAX_OBD_DEVICES.
>
> Thanks
class_devno_max is an inline function that is not used
anymore. Hence, it is removed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/include/obd_class.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd_class.h
b/drivers/staging
class_devno_max is an inline function that returns
MAX_OBD_DEVICES. Replace all calls to the function
by MAX_OBD_DEVICES.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +++---
drivers/staging/lustre/lustre/obdclass/genops.c| 22
class_devno_max is an inline function that is written with
the sole purpose of returning the value of MAX_OBD_DEVICES.
Since no computations are made by the class_devno_max,
replace it with MAX_OBD_DEVICES.
Aya Mahfouz (2):
staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES
OBD_INIT_CHECK was previously used by a conditional group. This is
no longer the case so it can be removed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/obdclass/class_obd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c
b
Constifies tty_port_operations structure in
the tty code of the gdm724x driver since it
is not modified after its initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1
Constifies ptlrpc_sec_cops structures in the lustre driver
since they are not modified after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
Changelog:
v2: added const to a ptlrpc_sec_cops structure
in the
Constifies ptlrpc_sec_cops structures in the lustre driver
since they are not modified after their initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +-
drivers/staging/lustre
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/libcfs
Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
been replaced by is_power_of_2
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h
b/drivers
Concerned with the removal of IS_PO2 by replacing its use
with is_power_of_2 and then removing the definition.
Aya Mahfouz (2):
staging: lustre: hash.c: Replace IS_PO2 by is_power_of_2
staging: lustre: libcfs.h: remove IS_PO2 and __is_po2
drivers/staging/lustre/include/linux/libcfs/libcfs.h
On Fri, Nov 06, 2015 at 05:11:09PM -0800, Greg KH wrote:
> On Thu, Oct 29, 2015 at 03:00:24AM +0200, Aya Mahfouz wrote:
> > Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
> > been replaced by is_power_of_2
> >
> > Signed-off-by: Aya Mahfouz
> > ---
Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
been replaced by is_power_of_2
Signed-off-by: Aya Mahfouz
---
v2:
-became patch number 5 in the series
v3:
-no change
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 7 ---
1 file changed, 7 deletions(-)
diff
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz
---
v2:
-added new patch in patch set for selftest.h
v3
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
v3:
-no change
drivers
Concerned with the removal of IS_PO2 by replacing its uses
with is_power_of_2 and then removing the definition.
The second version handled warnings indicated by kbuild test robot.
The third version handled checkpatch.pl warnings indicated by Sudip
Mukherjee.
Aya Mahfouz (5):
staging: lustre
On Wed, Oct 28, 2015 at 12:11:59PM +0530, Sudip Mukherjee wrote:
> On Tue, Oct 27, 2015 at 07:43:34PM +0200, Aya Mahfouz wrote:
> > Replaces IS_PO2 by is_power_of_2. It is more accurate to use
> > is_power_of_2 since it returns 1 for numbers that are powers
> > of 2 only whe
Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
been replaced by is_power_of_2
Signed-off-by: Aya Mahfouz
---
v2:
-became patch number 5 in the series
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz
---
v2:
-added new patch in patch set for selftest.h
drivers
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
drivers/staging/lustre/lustre
Concerned with the removal of IS_PO2 by replacing its uses
with is_power_of_2 and then removing the definition.
This is the second version of the patch set. The commit messages
were changed and a new patch was added for a use of IS_PO2 indicated
by kbuild test robot.
Aya Mahfouz (5):
staging
Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
been replaced by is_power_of_2
Signed-off-by: Aya Mahfouz
---
v2:
-became patch number 5 in the series
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz
---
v2:
-added new patch in patch set for selftest.h
drivers
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Reviewed-by: Andreas Dilger
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
Replaces IS_PO2 by is_power_of_2. It is more accurate to use
is_power_of_2 since it returns 1 for numbers that are powers
of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
powers of 2.
Signed-off-by: Aya Mahfouz
---
v2:
-changed commit message
drivers/staging/lustre/lustre
Concerned with the removal of IS_PO2 by replacing its uses
with is_power_of_2 and then removing the definition.
This is the second version of the patch set. The commit messages
were changed and a new patch was added for a use of IS_PO2 indicated
by kbuild test robot.
Aya Mahfouz (5):
staging
On Fri, Oct 16, 2015 at 10:21:05PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:07:28AM +0200, Aya Mahfouz wrote:
> > Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
> > been replaced by is_power_of_2
> >
> > Signed-off-by: Aya Mahfouz
> > ---
&g
On Sat, Oct 17, 2015 at 12:47:13PM +0200, Julia Lawall wrote:
> On Sat, 17 Oct 2015, Aya Mahfouz wrote:
>
> > On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote:
> > > On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote:
> > > > Replaces IS_PO2 by i
On Fri, Oct 16, 2015 at 10:40:25PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:06:28AM +0200, Aya Mahfouz wrote:
> > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug
> > macros. In this case, it is CDEBUG. Note that the replacement changes
> > the ty
On Fri, Oct 16, 2015 at 10:41:09PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:05:44AM +0200, Aya Mahfouz wrote:
> > Replaces IS_PO2 by is_power_of_2. IS_PO2 is used with several debug
> > macros. In this case, it is LASSERT. Note that the replacement changes
> > the ty
On Fri, Oct 16, 2015 at 10:21:05PM -0700, Greg KH wrote:
> On Sat, Oct 17, 2015 at 12:07:28AM +0200, Aya Mahfouz wrote:
> > Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
> > been replaced by is_power_of_2
> >
> > Signed-off-by: Aya Mahfouz
> > ---
&g
Removes IS_PO2 and __is_po2 since the uses of IS_PO2 have
been replaced by is_power_of_2
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h
b/drivers
the return type is bool. This, however, has no impact,
because the actual argument is always of type int, and the return value
is always used as a boolean.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/libcfs/workitem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
the return type is bool. This, however, has no impact,
because the actual argument is always of type int, and the return value
is always used as a boolean.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/libcfs/hash.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
the return type is bool. This, however, has no
impact, because the actual argument is always of type int, and the
return value is always used as a boolean.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 5 -
1 file changed, 4 insertions(+), 1 deletion
Concerned with the removal of IS_PO2 by replacing its uses
with is_power_of_2 and then removing the definition
Aya Mahfouz (4):
staging: lustre: ldlm_extent.c: replace IS_PO2 by is_power_of_2
staging: lustre: hash.c: replace IS_PO2 by is_power_of_2
staging: lustre: workitem.c: replace
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya
All uses of container_of0 have been replaced by container_of.
container_of0 and __container_of can be safely removed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/lustre
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya
...@gmail.com
Cc: k...@mcmartin.ca
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
index
container_of0 can be replaced by the Linux kernel macro container_of.
The only difference is that container_of0 tries to evade type casting
when the pointer is erroneous or null. All uses of container_of0 have
been replaced by container_of and then the macro was removed in the last
patch.
Aya
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote:
> On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote:
> > On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote:
> > > On 01/28/2015 09:53 AM, Heba Aamer wrote:
> > > >This patch fix
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote:
> On 01/28/2015 09:53 AM, Heba Aamer wrote:
> >This patch fixes the following checkpatch.pl warning:
> >Prefer ether_addr_copy() over memcpy()
> >if the Ethernet addresses are __aligned(2)
> >
> >I used the following coccinelle script:
>
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> netdev_info was used since it is a network subsyst
cachelines: 1, members: 7 */
> /* last cacheline: 30 bytes */
> };
>
> Signed-off-by: Heba Aamer
Reviewed-by: Aya Mahfouz
> ---
> drivers/staging/vt6656/rxtx.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/rxtx.c
On Mon, Jan 19, 2015 at 02:30:25PM +0200, Mohamed Lotfy Hammad wrote:
> This patch fixes the following checkpatch.pl error:
> fix space prohibited before that ','
>
> Signed-off-by: Mohamed Lotfy Hammad
Reviewed-by: Aya Mahfouz
> ---
> drivers/staging/vt6655/mac.h
On Mon, Jan 19, 2015 at 12:16:30PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl error:
> fix space prohibited before that ','
>
> Signed-off-by: Heba Aamer
Reviewed-by: Aya Mahfouz
> ---
> v2: added Signed-off line
>
> drivers/s
This patch fixes the following checkpatch.pl warning:
space prohibited before semicolon
Signed-off-by: Aya Mahfouz
---
v1: This patch applies to Greg's tree.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dr
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote:
> Em Tue, 4 Nov 2014 23:43:07 +0200
> Aya Mahfouz escreveu:
>
> > This patches replaces one pr_debug call by dev_dbg and
> > changes the device used by one of the dev_err calls.
>
> Also doesn'
On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote:
> On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote:
> > This patches replaces one pr_debug call by dev_dbg and
> > changes the device used by one of the dev_err calls.
>
> i think you should mention
On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote:
> On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote:
> > On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote:
> > > On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
> >
This patches replaces one pr_debug call by dev_dbg and
changes the device used by one of the dev_err calls.
Signed-off-by: Aya Mahfouz
---
drivers/staging/media/lirc/lirc_zilog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b
On Sun, Nov 02, 2014 at 12:40:13PM +0100, Konrad Zapalowicz wrote:
> On 11/01, Aya Mahfouz wrote:
> > This patch removes one debug message and replaces a dev_err
> > call by pr_err.
>
> Usually you would like to send this as two separate patches because
> replacin
This patch replaces dev_err by pr_err since the value
of ir is NULL when the message is displayed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b/drivers
value
of ir is NULL when the message is displayed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b/drivers/staging/media/lirc/lirc_zilog.c
index 11a7cb1..ecdd71e
This patch removes one debug message and replaces a dev_err
call by pr_err.
Signed-off-by: Aya Mahfouz
---
drivers/staging/media/lirc/lirc_zilog.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b/drivers/staging/media/lirc
65 matches
Mail list logo
