Sorry about delay. Just sent the rebased patchset along with the comments
addressed.
Thanks & Regards,
Badhri.
On Mon, Sep 18, 2017 at 3:20 AM, Greg Kroah-Hartman
wrote:
> On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote:
>> The source and sink caps shou
On Fri, Sep 8, 2017 at 2:45 AM, Greg Kroah-Hartman
wrote:
> On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote:
>> The source and sink caps should follow the following rules.
>> This patch validates whether the src_caps/snk_caps adheres
>> to it.
>
.
Errors in source/sink_caps of the local port will prevent
the port registration. Whereas, errors in source caps of partner
device would only log them.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/pd.h | 2 +
drivers/staging/typec/tcpm.c | 107
the Object position field.
This enables the Sink to indicate that it requires more current/power
than is being offered. If the Sink requires a different voltage this
will be indicated by its Sink Capabilities message.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tc
PORT_RESET state
to make sure the CC lines are open.
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since previous version:
- Only one previous version of the patch was sent.
Numbering this V3 instead of V2 to keep the sequence
number in sync with the rest of the
through the unattached state.
Originally-from: Yueyao Zhu
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since previous version:
- Only one previous version of the patch was sent.
Numbering this V3 instead of V2 to keep the sequence
number in sync with the rest of th
C1
or CC2 pins for at least tPDDebounce and V BUS is detected. Alternatively,
the port shall transition to TryWait.SRC if SNK.Rp state is not detected
for tPDDebounce."
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since v1:
- Corrected tag
Changelog since v
,
but this event will not exceed tPDDebounce. The port shall transition to
Unattached.SNK when the state of both of the CC1 and CC2 pins is SNK.Open
for at least tPDDebounce."
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since v1:
- Corrected tag
Changelo
PING messages are used to monitor the connect/disconnect.
However, when PD is carried over CC, so this is not required.
Also, the spec does not clearly say if PD is possible when
Type-c is connected to Type-A/B. So, removing sending
PING messages altogether.
Signed-off-by: Badhri Jagan Sridharan
ected."
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since v1:
- Corrected tag
Changelog since v2:
- added Reviewed-by: Guenter Roeck
- fixed version/sequence numbers
drivers/staging/typec/tcpm.c | 33 -
1 file c
CC1: 2 -> 0, CC2: 0 -> 0 [state PORT_RESET, polarity 0,
disconnected]
[ 762.347206] state change PORT_RESET -> SRC_UNATTACHED
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since previous version:
- Only one previous version of the patch was sent.
Nu
-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since previous version:
- Only one previous version of the patch was sent.
Numbering this V3 instead of V2 to keep the sequence
number in sync with the rest of the patches in the
patch list.
- added Reviewed-by: Guenter
ich the port
enters TryWait.SRC(SRC_TRYWAIT) and re-enter SRC_TRYWAIT
only when CC keeps debouncing within tDRPTry.
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since v1:
- Corrected tag
Changelog since v2:
- added Reviewed-by: G
Enable Try.SRC or Try.SNK only when port_type is
DRP. Try.SRC or Try.SNK state machines are not
valid for SRC only or SNK only ports.
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since v1:
- Corrected tag
Changelog since v2:
- added Reviewed-by: Guenter Roeck
current
configuration.
Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Guenter Roeck
---
Changelog since v1:
- Corrected tag
Changelog since v2:
- added Reviewed-by: Guenter Roeck
- fixed version/sequence numbers
drivers/staging/typec/tcpm.c | 52
PORT_RESET state
to make sure the CC lines are open.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 9e0111dea7c4..47b8fec5ea36 100644
--- a
PING messages are used to monitor the connect/disconnect.
However, when PD is carried over CC, so this is not required.
Also, the spec does not clearly say if PD is possible when
Type-c is connected to Type-A/B. So, removing sending
PING messages altogether.
Signed-off-by: Badhri Jagan Sridharan
through the unattached state.
Originally-from: Yueyao Zhu
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 645f43ee83df..1f6827f32b29 10064
ected."
Signed-off-by: Badhri Jagan Sridharan
---
hangelog since v1:
- Corrected tag
drivers/staging/typec/tcpm.c | 33 -
1 file changed, 28 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 7e
ich the port
enters TryWait.SRC(SRC_TRYWAIT) and re-enter SRC_TRYWAIT
only when CC keeps debouncing within tDRPTry.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- Corrected tag
drivers/staging/typec/tcpm.c | 45
1 file changed, 29 i
current
configuration.
Signed-off-by: Badhri Jagan Sridharan
---
Changelog since v1:
- Corrected tag
drivers/staging/typec/tcpm.c | 52 ++--
1 file changed, 41 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec
CC1: 2 -> 0, CC2: 0 -> 0 [state PORT_RESET, polarity 0,
disconnected]
[ 762.347206] state change PORT_RESET -> SRC_UNATTACHED
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/driver
,
but this event will not exceed tPDDebounce. The port shall transition to
Unattached.SNK when the state of both of the CC1 and CC2 pins is SNK.Open
for at least tPDDebounce."
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 58 +++---
ected."
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 33 -
1 file changed, 28 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index 7eed04698ebe..fc179bdea7e4 100644
---
C1
or CC2 pins for at least tPDDebounce and V BUS is detected. Alternatively,
the port shall transition to TryWait.SRC if SNK.Rp state is not detected
for tPDDebounce."
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 68
1 fi
Enable Try.SRC or Try.SNK only when port_type is
DRP. Try.SRC or Try.SNK state machines are not
valid for SRC only or SNK only ports.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
ich the port
enters TryWait.SRC(SRC_TRYWAIT) and re-enter SRC_TRYWAIT
only when CC keeps debouncing within tDRPTry.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 45
1 file changed, 29 insertions(+), 16 deletions(
current
configuration.
Signed-off-by: Badhri Jagan Sridharan
---
drivers/staging/typec/tcpm.c | 52 ++--
1 file changed, 41 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
index a911cad41a59..6c045ac9c42a
28 matches
Mail list logo