Re: [PATCH v6 01/11] firmware: raspberrypi: Keep count of all consumers

2020-12-16 Thread Bartosz Golaszewski
consumers and introduce rpi_firmware_put() > which will permit automatically decrease the reference count upon > unbinding consumer drivers. > > Suggested-by: Uwe Kleine-König > Signed-off-by: Nicolas Saenz Julienne > Reviewed-by: Florian Fainelli

Re: [PATCH v6 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-12-16 Thread Bartosz Golaszewski
On Fri, Dec 11, 2020 at 5:48 PM Nicolas Saenz Julienne wrote: > > It'll simplify the firmware handling for most consumers. > > Suggested-by: Bartosz Golaszewski > Signed-off-by: Nicolas Saenz Julienne > Reviewed-by: Florian Fainelli > --- > > Changes since v4: &

Re: [PATCH v5 01/11] firmware: raspberrypi: Keep count of all consumers

2020-12-03 Thread Bartosz Golaszewski
On Mon, Nov 23, 2020 at 7:38 PM Nicolas Saenz Julienne wrote: > > When unbinding the firmware device we need to make sure it has no > consumers left. Otherwise we'd leave them with a firmware handle > pointing at freed memory. > > Keep a reference count of all consumers and introduce rpi_firmware_

Re: [PATCH v4 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-12 Thread Bartosz Golaszewski
On Thu, Nov 12, 2020 at 5:44 PM Nicolas Saenz Julienne wrote: > > Itroduce devm_rpi_firmware_get(), it'll simplify the firmware handling > for most consumers. > > Suggested-by: Bartosz Golaszewski > Signed-off-by: Nicolas Saenz Julienne > --- > >

Re: [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-05 Thread Bartosz Golaszewski
On Thu, Nov 5, 2020 at 10:28 AM Nicolas Saenz Julienne wrote: > > Hi Bartosz, thanks for the review. > > On Thu, 2020-11-05 at 10:13 +0100, Bartosz Golaszewski wrote: > > > +/** > > > + * devm_rpi_firmware_get - Get pointer to rpi_firmware structure. > > >

Re: [PATCH v3 01/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-11-05 Thread Bartosz Golaszewski
On Wed, Nov 4, 2020 at 11:39 AM Nicolas Saenz Julienne wrote: > > When unbinding the firmware device we need to make sure it has no > consumers left. Otherwise we'd leave them with a firmware handle > pointing at freed memory. > > Keep a reference count of all consumers and introduce > devm_rpi_fi

Re: [PATCH v3 03/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-11-05 Thread Bartosz Golaszewski
fw = devm_rpi_firmware_get(&pdev->dev, fw_node); > of_node_put(fw_node); > if (!fw) > return -EPROBE_DEFER; > -- > 2.29.1 > Acked-by: Bartosz Golaszewski ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 03/10] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-10-26 Thread Bartosz Golaszewski
On Thu, Oct 22, 2020 at 5:59 PM Nicolas Saenz Julienne wrote: > > Upon unbinding the device make sure we release RPi's firmware interface. > > Signed-off-by: Nicolas Saenz Julienne > --- > drivers/gpio/gpio-raspberrypi-exp.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-)

Re: [PATCH v2 03/10] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-10-26 Thread Bartosz Golaszewski
On Mon, Oct 26, 2020 at 3:42 PM Nicolas Saenz Julienne wrote: > > On Mon, 2020-10-26 at 15:40 +0100, Bartosz Golaszewski wrote: > > On Thu, Oct 22, 2020 at 5:59 PM Nicolas Saenz Julienne > > wrote: > > > Upon unbinding the device make sure we release RPi's firmwa

Re: [PATCH v1 0/3] Tegra GPIO: Minor code clean up

2020-01-07 Thread Bartosz Golaszewski
wt., 7 sty 2020 o 10:29 Linus Walleij napisał(a): > > On Tue, Jan 7, 2020 at 9:25 AM Bartosz Golaszewski > wrote: > > > pon., 6 sty 2020 o 23:59 Linus Walleij > > napisał(a): > > > On Sun, Dec 15, 2019 at 7:31 PM Dmitry Osipenko wrote: > > > > >

Re: [PATCH v1 0/3] Tegra GPIO: Minor code clean up

2020-01-07 Thread Bartosz Golaszewski
pon., 6 sty 2020 o 23:59 Linus Walleij napisał(a): > > On Sun, Dec 15, 2019 at 7:31 PM Dmitry Osipenko wrote: > > > I was investigating why CPU hangs during of GPIO driver suspend and in > > the end it turned out that it is a Broadcom WiFi driver problem because > > it keeps OOB wake-interrupt en

Re: [PATCH v1 1/3] gpio: tegra: Use generic readl_relaxed/writel_relaxed accessors

2019-12-19 Thread Bartosz Golaszewski
niedz., 15 gru 2019 o 19:31 Dmitry Osipenko napisał(a): > > There is no point in using old-style raw accessors, the generic accessors > do the same thing and also take into account CPU endianness. Tegra SoCs do > not support big-endian mode in the upstream kernel, but let's switch away > from the