: "a...@canonical.com"
Cc: vkuznets
Cc: "jasow...@redhat.com"
Cc: "marcelo.ce...@canonical.com"
Cc: KY Srinivasan
Link:
https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com
[bwh: Backported to 3.16:
- Don't use
:
https://lkml.kernel.org/r/1541303219-11142-3-git-send-email-mikel...@microsoft.com
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings
---
arch/x86/kernel/cpu/mshyperv.c | 11 +++
1 file changed, 11 insertions(+)
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86
&
> - pdu->u.cmd_submit.transfer_buffer_length <= INT_MAX) {
> + if (pdu->u.cmd_submit.transfer_buffer_length > 0) {
> priv->urb->transfer_buffer =
> kzalloc(pdu->u.cmd_submit.transfer_buffer_length,
>
ashmem_pin_unpin() reads asma->file and asma->size before taking the
ashmem_mutex, so it can race with other operations that modify them.
Build-tested only.
Cc: sta...@vger.kernel.org
Signed-off-by: Ben Hutchings
---
drivers/staging/android/ashmem.c | 19 +++
1 file chang
There's no net_device stashed in skb->cb, there's a net_device * there.
To make it *really* clear, also change the write of the dev pointer
into skb->cb from a memcpy() to an assignment.
Fixes: 3fe563249374 ("staging: rtl8192u: r8192U_core.c: Cleaning up ...")
Si
On Mon, 2016-02-29 at 17:50 -0500, David Miller wrote:
> From: Ben Hutchings
> Date: Mon, 29 Feb 2016 22:34:38 +
>
> > On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote:
> >> From: Simon Xiao
> >> Date: Thu, 25 Feb 2016 15:24:08 -0800
> >>
&g
for a memory-based transport, so "unknown"
is correct. The link is effectively full duplex though.
If the issue is that ethtool is a bit shouty about unknowns, let's
consider changing that in ethtool, not teaching drivers to lie.
Ben.
--
Ben Hutchings
If God had intended Man to program
On Mon, 2015-12-14 at 12:54 +, Fleck, John wrote:
> Please Pull:
>
> https://github.com/01org/opa-firmware.git
> Use the branch firmware-update
Pulled, thanks.
Ben.
--
Ben Hutchings
Power corrupts. Absolute power is kind of neat.
- John Lehman,
On Tue, Sep 29, 2015 at 01:52:39PM +0200, Vitaly Kuznetsov wrote:
> Ben Hutchings writes:
>
> > On Tue, 2015-09-29 at 10:47 +0200, Vitaly Kuznetsov wrote:
> >> Ben Hutchings writes:
> >>
> >> > Currently with this configuration I get:
>
On Tue, 2015-09-29 at 10:47 +0200, Vitaly Kuznetsov wrote:
> Ben Hutchings writes:
>
> > Currently with this configuration I get:
> >
> > arch/x86/built-in.o: In function `hv_machine_crash_shutdown':
> > mshyperv.c:(.text+0x29656): undefined reference to
Currently with this configuration I get:
arch/x86/built-in.o: In function `hv_machine_crash_shutdown':
mshyperv.c:(.text+0x29656): undefined reference to
`native_machine_crash_shutdown'
Fixes: b4370df2b1f5 ("Drivers: hv: vmbus: add special crash handler")
Signed-off-b
On Mon, 2015-09-14 at 16:29 -0400, Mark Hounschell wrote:
[...]
> +Driver: dgap - Digi International Acceleport Xr PCI, Acceleport Xr 920 PCI,
> + Acceleport Xem PCI, Acceleport C/X PCI, and Acceleport EPC/X
> + PCI families of adapters.
> +
> +File: dgap/cxcon.bin
> +Fi
-by: jasow...@redhat.com
Cc: gre...@linuxfoundation.org
Cc: de...@linuxdriverproject.org
Cc: o...@aepfle.de
Cc: a...@canonical.com
Link:
http://lkml.kernel.org/r/1421108762-3331-1-git-send-email-...@microsoft.com
Signed-off-by: Thomas Gleixner
Signed-off-by: Ben Hutchings
---
arch/x86/kernel/cpu/mshy
seems perfectly
readable as it is.
Ben.
--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
- Robert Coveyou
signature.asc
Description: This is a digitally sign
and won't come back unless someone supports it upstream. That gives any
interested developers another couple of years to rescue it if they want
it in Debian 9 'stretch'.
Ben.
--
Ben Hutchings
Man invented language to satisfy his deep need to complain. - Li
select FW_LOADER
> + ---help---
> + This is the driver for Realtek RTL8192EE 802.11 PCIe
> + wireless network adapters.
> +
> + If you choose to build it as a module, it will be called r8192ee
[...]
--
Ben Hutchings
Humans are not rational beings; they are rationa
On Mon, 2014-05-19 at 00:50 +0100, Ben Hutchings wrote:
> These patches fix a deadlock that can occur when using speakup to paste
> a selection. I tested them against 3.12.9, but there don't appear to be
> any later changes in this area.
[...]
Actually, these have also been te
disc input flow control concurrency-friendly',
and 'tty: Fix unsafe vt paste_selection()'.
References: https://bugs.debian.org/735202
References: https://bugs.debian.org/744015
Reported-by: Paul Gevers
Reported-and-tested-by: Jarek Czekalski
Signed-off-by: Ben Hutchings
Cc: #
rrent, even though it's not running in process
context.
Move it into a work item and make sure to cancel it on exit.
References: https://bugs.debian.org/735202
References: https://bugs.debian.org/744015
Reported-by: Paul Gevers
Reported-and-tested-by: Jarek Czekalski
Signed-off-by: Ben Hut
These patches fix a deadlock that can occur when using speakup to paste
a selection. I tested them against 3.12.9, but there don't appear to be
any later changes in this area.
Ben.
Ben Hutchings (2):
Staging: speakup: Move pasting into a work item
Staging: speakup: U
e flag in my code.
I think most other drivers have a 1-1 mapping between hardware RX queues
and the RX queue indices reported to Linux. It appears that in this
case sub_channel_index is the 'hardware' queue number, but you think
there is not a 1-1 mapping. Why is that?
Ben.
--
Ben
8f, 0xb0,
> + 0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,
> + 0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,
> + 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa
> +};
[...]
Same for this one.
Ben.
--
Ben Hutchings
I'm always amazed by the number of people who take u
IF_F_IP_CSUM;
Missing NETIF_F_IPV6_CSUM?
Ben.
> SET_ETHTOOL_OPS(net, ðtool_ops);
> SET_NETDEV_DEV(net, &dev->device);
--
Ben Hutchings
I say we take off; nuke the site from orbit. It's the only way to be sure.
signature.asc
Description: This is a digitally signed me
On Mon, 2014-01-27 at 18:28 +0800, Jason Wang wrote:
> On 01/27/2014 06:22 PM, Ben Hutchings wrote:
> > On Mon, 2014-01-27 at 17:40 +0800, Jason Wang wrote:
> >> On 01/27/2014 04:35 PM, David Miller wrote:
> >>> From: Jason Wang
> >>> Date: Mon, 27
olve the carrier to be on in this
> > way.
>
> True, we need a workqueue to synchronize them.
Whatever for? All you need to do is:
rtnl_lock();
register_netdevice();
netif_carrier_on();
rtnl_unlock();
It would be nice if we could make the current cod
There seems to be no reason why it can't be a module; in fact that is
currently supposed to be the default.
Signed-off-by: Ben Hutchings
---
Possibly the dependency on LUSTRE_FS should also be changed, as this can
be built-in independently.
Ben.
drivers/staging/lustre/lustre/Kconfig | 2
dressed my comments here:
<http://article.gmane.org/gmane.linux.network/284753>
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
__
netdev(net);
> if (ret != 0) {
> pr_err("Unable to register netdev.\n");
> @@ -453,6 +530,13 @@ static int netvsc_probe(struct hv_device *dev,
> return ret;
> }
> memcpy(net->dev_addr, device_info.mac_adr, ETH_ALEN);
&g
uot;status", 6)) {
> + DBG_88E("[%s] extra = %s\n", __func__, (__force char
> *)wrqu->data.pointer);
> + if (!memcmp((__force const char *)wrqu->data.pointer, "status", 6)) {
[...]
This is hiding the problem, not fixing it.
This private
n drivers/staging/rtl8188eu/include/wifi.h
with struct ieee80211_mgmt in include/linux/ieee80211.h.
Ben.
> tid = (param>>2)&0x0f;
> preorder_ctrl = &psta->recvreorder_ctrl[tid];
> preorder_ctrl->indicate_seq = 0x;
--
Ben Hutc
dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) {
Surely we want && here.
Ben.
> dev_err(&pdev->dev, "No usable DMA addressing method\n");
> rc = -EIO;
> goto err_release_res;
--
Ben Hutching
f. I would
suggest:
"The coherent mask can always be set to the same or a smaller mask than
the streaming mask."
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare pro
On Thu, 2013-09-12 at 14:48 -0700, Greg Kroah-Hartman wrote:
> On Thu, Sep 05, 2013 at 01:00:37AM +0100, Ben Hutchings wrote:
> > The Fastwel UNIOxx-5 is a PC/104 board, so put COMEDI_UNIOXX5 under
> > COMEDI_ISA_DRIVERS.
> >
> > The DIL/Net-PC 1486 is a 486 system,
We must not assume that the PCI device is already enabled.
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt829.c
A less ambitious set of fixes for the lirc_bt829 driver.
Ben.
Ben Hutchings (4):
[media] lirc_bt829: Fix physical address type
[media] lirc_bt829: Fix iomap and PCI device leaks
[media] lirc_bt829: Enable and disable device
[media] lirc_bt829: Note in TODO why it can't be a norma
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/TODO | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/media/lirc/TODO b/drivers/staging/media/lirc/TODO
index b6cb593..cbea5d8 100644
--- a/drivers/staging/media/lirc/TODO
+++ b/drivers/staging/media/lirc/TODO
We must call iounmap() and pci_dev_put() when removed and on
the probe failure path.
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b
Use phys_addr_t and log format %pa.
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt829.c
index fa31ee7..9c7be55 100644
On Mon, 2013-09-02 at 01:36 +0100, Ben Hutchings wrote:
> I noticed lirc_bt829 didn't have a module device ID table, so I set out
> to fix that and ended up with this series.
>
> It still appears to do everything else wrong (like reinventing
> i2c-algo-bit) though...
>
&
The Fastwel UNIOxx-5 is a PC/104 board, so put COMEDI_UNIOXX5 under
COMEDI_ISA_DRIVERS.
The DIL/Net-PC 1486 is a 486 system, so put COMEDI_SSV_DNP under
COMEDI_MISC_DRIVERS and add a dependency on X86_32 || COMPILE_TEST.
Signed-off-by: Ben Hutchings
---
v2: Fix typo in commit message; rebase on
On Mon, 2013-09-02 at 10:34 +0100, Ian Abbott wrote:
> On 2013-09-01 20:42, Ben Hutchings wrote:
> > The Fastwel UNIOxx-5 is a PCI/104 board so put COMEDI_UNIOXX5 under
> > COMEDI_ISA_DRIVERS.
>
> ITYM a PC/104 board.
Of course. There were lots of PCIs in this message alrea
On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote:
> On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings wrote:
>
> > pci_addr_phys = pdev->resource[0].start;
> > - dev_info(&pdev->dev, "memory at 0x%08X\n",
> > -(unsig
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt829.c
index c277bf3..8c5ba2a 100644
--- a/drivers/staging/media/lirc
We must call iounmap() when removed from a device.
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt829.c
index 8c5ba2a
We must not assume that the PCI device is already enabled.
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt829.c
driver wasn't
calling pci_dev_put().
Signed-off-by: Ben Hutchings
---
drivers/staging/media/lirc/lirc_bt829.c | 276 +---
1 file changed, 144 insertions(+), 132 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_bt829.c
b/drivers/staging/media/lirc/lirc_bt
I noticed lirc_bt829 didn't have a module device ID table, so I set out
to fix that and ended up with this series.
It still appears to do everything else wrong (like reinventing
i2c-algo-bit) though...
This is compile-tested only.
Ben.
Ben Hutchings (4):
[media] lirc_bt829: Make it a p
on X86_32 || COMPILE_TEST.
Signed-off-by: Ben Hutchings
---
drivers/staging/comedi/Kconfig | 51 +-
1 file changed, 26 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 8c8a551..aae9816 100644
Several speakup drivers are for ISA cards and are useless on systems
without ISA slots. Make them depend on ISA || COMPILE_TEST.
Signed-off-by: Ben Hutchings
---
drivers/staging/speakup/Kconfig | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/speakup/Kconfig b/drivers
he comment in the patch explaining why it is ok to continue.
[...]
But that is not nearly as easy to see as the comment that is
already *in the code* which your patch isn't updating.
Ben.
--
Ben Hutchings
We get into the habit of living
result
of wait_for_completion_timeout(). Maybe update the comment to
explain why it's OK to continue anyway?
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
___
51 matches
Mail list logo
