[PATCH 3.16 139/305] clockevents/drivers/i8253: Add support for PIT shutdown quirk

2019-02-03 Thread Ben Hutchings
..@canonical.com" Cc: vkuznets Cc: "jasow...@redhat.com" Cc: "marcelo.ce...@canonical.com" Cc: KY Srinivasan Link: https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com [bwh: Backported to 3.16: - Don't use __ro_after_init

[PATCH 3.16 140/305] x86/hyper-v: Enable PIT shutdown quirk

2019-02-03 Thread Ben Hutchings
https://lkml.kernel.org/r/1541303219-11142-3-git-send-email-mikel...@microsoft.com [bwh: Backported to 3.16: adjust context] Signed-off-by: Ben Hutchings --- arch/x86/kernel/cpu/mshyperv.c | 11 +++ 1 file changed, 11 insertions(+) --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kern

Re: [PATCH 3.16] staging: usbip stub_rx fix static checker warning on unnecessary checks

2018-11-10 Thread Ben Hutchings
d_submit.transfer_buffer_length <= INT_MAX) { > + if (pdu->u.cmd_submit.transfer_buffer_length > 0) { > priv->urb->transfer_buffer = > kzalloc(pdu->u.cmd_submit.transfer_buffer_length, > GFP_KERNEL); -- Be

[PATCH] staging: android: ashmem: Fix a race condition in pin ioctls

2018-02-03 Thread Ben Hutchings
ashmem_pin_unpin() reads asma->file and asma->size before taking the ashmem_mutex, so it can race with other operations that modify them. Build-tested only. Cc: sta...@vger.kernel.org Signed-off-by: Ben Hutchings <b...@decadent.org.uk> --- drivers/staging/android/a

Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

2016-03-01 Thread Ben Hutchings
On Mon, 2016-02-29 at 17:50 -0500, David Miller wrote: > From: Ben Hutchings <b...@decadent.org.uk> > Date: Mon, 29 Feb 2016 22:34:38 + > > > On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote: > >> From: Simon Xiao <six...@microsoft.com> > &

Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

2016-02-29 Thread Ben Hutchings
e the point. Link speed isn't meaingful for a memory-based transport, so "unknown" is correct.  The link is effectively full duplex though. If the issue is that ethtool is a bit shouty about unknowns, let's consider changing that in ethtool, not teaching drivers to lie. Ben. -

Re: [GIT PULL] pull requires: linux-firmware: Update OPA hfi1 firmware

2016-01-10 Thread Ben Hutchings
On Mon, 2015-12-14 at 12:54 +, Fleck, John wrote: > Please Pull: > > https://github.com/01org/opa-firmware.git  > Use the branch firmware-update Pulled, thanks. Ben. -- Ben Hutchings Power corrupts. Absolute power is kind of neat. - John Lehma

Re: [PATCH] hyperv: Fix build failure with HYPERVISOR_GUEST=y && KEXEC_CORE=n

2015-09-29 Thread Ben Hutchings
On Tue, 2015-09-29 at 10:47 +0200, Vitaly Kuznetsov wrote: > Ben Hutchings <b...@decadent.org.uk> writes: > > > Currently with this configuration I get: > > > > arch/x86/built-in.o: In function `hv_machine_crash_shutdown': > > mshyperv.c:

Re: [PATCH] hyperv: Fix build failure with HYPERVISOR_GUEST=y && KEXEC_CORE=n

2015-09-29 Thread Ben Hutchings
On Tue, Sep 29, 2015 at 01:52:39PM +0200, Vitaly Kuznetsov wrote: > Ben Hutchings <b...@decadent.org.uk> writes: > > > On Tue, 2015-09-29 at 10:47 +0200, Vitaly Kuznetsov wrote: > >> Ben Hutchings <b...@decadent.org.uk> writes: > >> >

[PATCH] hyperv: Fix build failure with HYPERVISOR_GUEST=y && KEXEC_CORE=n

2015-09-26 Thread Ben Hutchings
Currently with this configuration I get: arch/x86/built-in.o: In function `hv_machine_crash_shutdown': mshyperv.c:(.text+0x29656): undefined reference to `native_machine_crash_shutdown' Fixes: b4370df2b1f5 ("Drivers: hv: vmbus: add special crash handler") Signed-off-by: Ben Hu

Re: [PATCH] linux-firmware: Add firmware blobs for Digi International Acceleport Xr cards

2015-09-14 Thread Ben Hutchings
On Mon, 2015-09-14 at 16:29 -0400, Mark Hounschell wrote: [...] > +Driver: dgap - Digi International Acceleport Xr PCI, Acceleport Xr 920 PCI, > + Acceleport Xem PCI, Acceleport C/X PCI, and Acceleport EPC/X > + PCI families of adapters. > + > +File: dgap/cxcon.bin >

[PATCH 3.2 123/152] x86, hyperv: Mark the Hyper-V clocksource as being continuous

2015-02-16 Thread Ben Hutchings
...@microsoft.com Acked-by: jasow...@redhat.com Cc: gre...@linuxfoundation.org Cc: de...@linuxdriverproject.org Cc: o...@aepfle.de Cc: a...@canonical.com Link: http://lkml.kernel.org/r/1421108762-3331-1-git-send-email-...@microsoft.com Signed-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Ben

Re: [PATCH] Revert staging: sm7xxfb: remove driver

2014-11-20 Thread Ben Hutchings
interested developers another couple of years to rescue it if they want it in Debian 9 'stretch'. Ben. -- Ben Hutchings Man invented language to satisfy his deep need to complain. - Lily Tomlin signature.asc Description: This is a digitally signed message part

Re: [PATCH 4/4] staging: r8192ee: Turn on build of the new driver

2014-05-26 Thread Ben Hutchings
--- + This is the driver for Realtek RTL8192EE 802.11 PCIe + wireless network adapters. + + If you choose to build it as a module, it will be called r8192ee [...] -- Ben Hutchings Humans are not rational beings; they are rationalising beings. signature.asc Description: This is a digitally

[PATCH 0/2] Staging: speakup: Fix deadlock when pasting

2014-05-18 Thread Ben Hutchings
These patches fix a deadlock that can occur when using speakup to paste a selection. I tested them against 3.12.9, but there don't appear to be any later changes in this area. Ben. Ben Hutchings (2): Staging: speakup: Move pasting into a work item Staging: speakup: Update

[PATCH 1/2] Staging: speakup: Move pasting into a work item

2014-05-18 Thread Ben Hutchings
...@poczta.onet.pl Signed-off-by: Ben Hutchings b...@decadent.org.uk Cc: sta...@vger.kernel.org --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/selection.c | 38 +++-- drivers/staging/speakup/speakup.h | 1 + 3 files changed, 34 insertions(+), 6

[PATCH 2/2] Staging: speakup: Update __speakup_paste_selection() tty (ab)usage to match vt

2014-05-18 Thread Ben Hutchings
control concurrency-friendly', and 'tty: Fix unsafe vt paste_selection()'. References: https://bugs.debian.org/735202 References: https://bugs.debian.org/744015 Reported-by: Paul Gevers elb...@debian.org Reported-and-tested-by: Jarek Czekalski jarekc...@poczta.onet.pl Signed-off-by: Ben Hutchings b

Re: [PATCH 0/2] Staging: speakup: Fix deadlock when pasting

2014-05-18 Thread Ben Hutchings
On Mon, 2014-05-19 at 00:50 +0100, Ben Hutchings wrote: These patches fix a deadlock that can occur when using speakup to paste a selection. I tested them against 3.12.9, but there don't appear to be any later changes in this area. [...] Actually, these have also been tested on top of 3.14.2

Re: [PATCH net-next,v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-11 Thread Ben Hutchings
most other drivers have a 1-1 mapping between hardware RX queues and the RX queue indices reported to Linux. It appears that in this case sub_channel_index is the 'hardware' queue number, but you think there is not a 1-1 mapping. Why is that? Ben. -- Ben Hutchings Sturgeon's Law: Ninety percent

Re: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-17 Thread Ben Hutchings
, 0x7b, 0x30, 0xb4, + 0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c, + 0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa +}; [...] Same for this one. Ben. -- Ben Hutchings I'm always amazed by the number of people who take up solipsism because they heard someone else explain it. - E*Borg

Re: [PATCH 5/6] Drivers: net: hyperv: Enable send side checksum offload

2014-03-09 Thread Ben Hutchings
(net, ethtool_ops); SET_NETDEV_DEV(net, dev-device); -- Ben Hutchings I say we take off; nuke the site from orbit. It's the only way to be sure. signature.asc Description: This is a digitally signed message part ___ devel mailing list de

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread Ben Hutchings
for? All you need to do is: rtnl_lock(); register_netdevice(); netif_carrier_on(); rtnl_unlock(); It would be nice if we could make the current code work with a change in the core, though. Ben. -- Ben Hutchings If at first you don't succeed, you're doing about

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread Ben Hutchings
On Mon, 2014-01-27 at 18:28 +0800, Jason Wang wrote: On 01/27/2014 06:22 PM, Ben Hutchings wrote: On Mon, 2014-01-27 at 17:40 +0800, Jason Wang wrote: On 01/27/2014 04:35 PM, David Miller wrote: From: Jason Wang jasow...@redhat.com Date: Mon, 27 Jan 2014 15:30:54 +0800 Call

[PATCH] staging: lustre: Make LUSTRE_LLITE_LLOOP tristate

2013-12-29 Thread Ben Hutchings
There seems to be no reason why it can't be a module; in fact that is currently supposed to be the default. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- Possibly the dependency on LUSTRE_FS should also be changed, as this can be built-in independently. Ben. drivers/staging/lustre

Re: [PATCH 2/9 RESENT] staging: r8188eu: Fix Sparse warnings in rtw_wlan_util

2013-10-18 Thread Ben Hutchings
in include/linux/ieee80211.h. Ben. tid = (param2)0x0f; preorder_ctrl = psta-recvreorder_ctrl[tid]; preorder_ctrl-indicate_seq = 0x; -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job

Re: [PATCH 3/9 RESENT] staging: r8188eu: Fix sparse warnings in ioctl_linux.c

2013-10-18 Thread Ben Hutchings
, (__force char *)wrqu-data.pointer); + if (!memcmp((__force const char *)wrqu-data.pointer, status, 6)) { [...] This is hiding the problem, not fixing it. This private interface needs to be removed anyway. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's

Re: [PATCH 18/51] DMA-API: staging: et131x: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-09-20 Thread Ben Hutchings
{ + if (dma_set_mask_and_coherent(pdev-dev, DMA_BIT_MASK(64)) || + dma_set_mask_and_coherent(pdev-dev, DMA_BIT_MASK(32))) { Surely we want here. Ben. dev_err(pdev-dev, No usable DMA addressing method\n); rc = -EIO; goto err_release_res; -- Ben

Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

2013-09-19 Thread Ben Hutchings
to the same or a smaller mask than the streaming mask. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. ___ devel

Re: [PATCH v2] Staging: comedi: Fix dependencies for drivers misclassified as PCI

2013-09-12 Thread Ben Hutchings
On Thu, 2013-09-12 at 14:48 -0700, Greg Kroah-Hartman wrote: On Thu, Sep 05, 2013 at 01:00:37AM +0100, Ben Hutchings wrote: The Fastwel UNIOxx-5 is a PC/104 board, so put COMEDI_UNIOXX5 under COMEDI_ISA_DRIVERS. The DIL/Net-PC 1486 is a 486 system, so put COMEDI_SSV_DNP under

[PATCH 0/4] [media] Make lirc_bt829 a well-behaved PCI driver

2013-09-01 Thread Ben Hutchings
I noticed lirc_bt829 didn't have a module device ID table, so I set out to fix that and ended up with this series. It still appears to do everything else wrong (like reinventing i2c-algo-bit) though... This is compile-tested only. Ben. Ben Hutchings (4): [media] lirc_bt829: Make it a proper

[PATCH 1/4] [media] lirc_bt829: Make it a proper PCI driver

2013-09-01 Thread Ben Hutchings
, as the driver wasn't calling pci_dev_put(). Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 276 +--- 1 file changed, 144 insertions(+), 132 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging

[PATCH 4/4] [media] lirc_bt829: Enable and disable memory BAR

2013-09-01 Thread Ben Hutchings
We must not assume that the PCI device is already enabled. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media

[PATCH 3/4] [media] lirc_bt829: Fix iomap leak

2013-09-01 Thread Ben Hutchings
We must call iounmap() when removed from a device. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media/lirc

[PATCH 2/4] [media] lirc_bt829: Fix physical address type

2013-09-01 Thread Ben Hutchings
Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media/lirc/lirc_bt829.c index c277bf3..8c5ba2a 100644 --- a/drivers