e case of steps being 0 wasn't checked which is also now done.
Signed-off-by: Bernd Porr
---
drivers/staging/comedi/drivers/usbduxfast.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usbduxfast.c
b/drivers/staging/comedi/d
Signed-off-by: Bernd Porr
---
drivers/staging/comedi/drivers/usbduxfast.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usbduxfast.c
b/drivers/staging/comedi/drivers/usbduxfast.c
index 04bc488385e6..4af012968cb6
Reviewed-by: Bernd Porr m...@berndporr.me.uk
Ian Abbott wrote:
`devpriv-ao_timer` is used while an asynchronous command is running on
the AO subdevice. It also gets modified by the subdevice's `cmdtest`
handler for checking new asynchronous commands,
`usbduxsigma_ao_cmdtest()`, which
Reviewed-by: Bernd Porr m...@berndporr.me.uk
Ian Abbott wrote:
The `cmdtest` and `cmd` handlers for the AO subdevice
(`usbduxsigma_ao_cmdtest()` and `usbduxsigma_ao_cmd()`) support scan
timing of commands with all channels updated every scan period. There
is some disabled code to use convert
Reviewed-by: Bernd Porr m...@berndporr.me.uk
Ian Abbott wrote:
The return value of the `cmdtest` handler for a subdevice checks the
prospective new command in various steps and returns the step number at
which any problem was detected, or 0 if no problem was detected. It is
allowed to modify
Reviewed-by: Bernd Porr m...@berndporr.me.uk
Ian Abbott wrote:
The return value of the `cmdtest` handler for a subdevice checks the
prospective new command in various steps and returns the step number at
which any problem was detected, or 0 if no problem was detected. It is
allowed to modify
Reviewed-by: Bernd Porr m...@berndporr.me.uk
Ian Abbott wrote:
The AI subdevice `cmdtest` handler `usbduxsigma_ai_cmdtest()` ensures
that `cmd-scan_begin_src == TRIG_TIMER` by the end of step 2 of the
command checking code, so assume that this is the case for step 3
onwards and remove
Reviewed-by: Bernd Porr m...@berndporr.me.uk
Ian Abbott wrote:
`devpriv-ai_timer` is used while an asynchronous command is running on
the AI subdevice. It also gets modified by the subdevice's `cmdtest`
handler for checking new asynchronous commands
(`usbduxsigma_ai_cmdtest()`), which
...@mev.co.uk
Reviewed-by: Bernd Porr m...@berndporr.me.uk
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Indeed. It can be completely removed. I was intending to speed up DIO
reads during async acquisition but I decided against it because it would
create unpredictable latencies.
Thanks Ian for flagging it!
/Bernd
Ian Abbott wrote:
On 28/01/15 22:39, Rickard Strandqvist wrote:
Variable ar
Sweeten hswee...@visionengravers.com
Reviewed-by: Bernd Porr m...@berndporr.me.uk
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Bernd Porr m...@berndporr.me.uk
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Bernd Porr m...@berndporr.me.uk
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Bernd Porr m...@berndporr.me.uk
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Bernd Porr m...@berndporr.me.uk
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Updated the range of years, e-mail and added driver desription as
usually done in comedi.
Signed-off-by: Bernd Porr m...@berndporr.me.uk
---
drivers/staging/comedi/drivers/usbduxfast.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers
I've updated my contact details of the driver. I've also tested it
thoroughly and it works perfectly. I've changed the status to stable.
Signed-off-by: Bernd Porr m...@berndporr.me.uk
---
drivers/staging/comedi/drivers/usbduxsigma.c | 8
1 file changed, 4 insertions(+), 4 deletions
I've updated my contact details and removed obsolete comments.
Signed-off-by: Bernd Porr m...@berndporr.me.uk
---
drivers/staging/comedi/drivers/usbdux.c | 59 -
1 file changed, 28 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/comedi/drivers
the array as 0, 1, 2, 3, it accesses it as 0x00,
0x40, 0x80, 0xc0.
Fix this by storing the raw channel number in 'ao_chanlist' and doing the
bit-shift when creating the command.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Bernd Porr m
Ian Abbott wrote:
On 2013-12-28 21:31, Bernd Porr wrote:
Merging the un-registering of both the subdevices and the
main comedi device into one function and the module which
actually associated with it. The kernel oops observed before
was because the main device was un-registered first
Ian Abbott wrote:
On 2014-01-07 10:01, Bernd Porr wrote:
Ian Abbott wrote:
On 2013-12-28 21:31, Bernd Porr wrote:
This doesn't apply to linux-next any more. (For example,
cleanup_device() function was renamed amongst other stuff.) I've also
fixed a load of stuff related to this bug since
the auto attachement. The return command also prevents
printing out the offset value in case of a fault.
Signed-off-by: Bernd Porr m...@berndporr.me.uk
---
drivers/staging/comedi/drivers/usbduxsigma.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi
or
there is a mix of USB and PCI devices.
As Ian suggested we should report both the driver and the board
which might have different names, especially if one driver covers a
range of different boards.
Signed-off-by: Bernd Porr m...@berndporr.me.uk
---
drivers/staging/comedi/drivers.c | 20
Hi Dan,
see my re-submission of these patches. I did that properly with the git
email this time. Hope that's now all properly formatted. Thanks also for
the link.
Best,
/Bernd
Dan Carpenter wrote:
On Fri, Dec 20, 2013 at 11:48:31PM +, Bernd Porr wrote:
From
Signed-off-by should be after the description. :)
How did I manage that? ;)
Merging un-registering of both the subdevices and the
main comedi device into one function and the module which
actually associated with it. The kernel oops observed before
was because the main device was
/12/13 23:49, Bernd Porr wrote:
Signed-off-by: Bernd Porr m...@berndporr.me.uk
Signed-off-by should be after the description. :)
Merging un-registering of both the subdevices and the
main comedi device into one function and the module which
actually associated with it. The kernel oops observed
or a
mix of USB and PCI devices.
As Ian suggested we should report both the driver and the board
which might have different names, esp if one driver covers a
range of different boards.
Signed-off-by: Bernd Porr m...@berndporr.me.uk
---
drivers/staging/comedi/drivers.c | 19 +--
1 file
Removed the word attached from the ADC_zero output which is
now reported by comedi itself at the end of the auto attach.
A negative value of the offset is an error and should be reported to
comedi auto config as an error. Output only the offset if no error
has been reported.
Signed-off-by: Bernd
been also tested with 'comedi_config -r' for
both autoconfigured and legacy devices.
Signed-off-by: Bernd Porr m...@berndporr.me.uk
---
drivers/staging/comedi/comedi_fops.c | 19 +++
drivers/staging/comedi/drivers.c | 18 --
2 files changed, 19 insertions(+), 18
or a
mix of USB and PCI devices.
Signed-off-by: Bernd Porr m...@berndporr.me.uk
---
drivers/staging/comedi/drivers.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index d6dc58a..58c7f23 100644
PM, Bernd Porr wrote:
Hi all,
I've added a success / fail message to comedi autoconfig. That's badly
needed to see which driver has been associated with which comedi dev in
udev. Also, as far as I know an error in the USB probe callback won't
cause the kernel to print any errors so tracking
in
autoconfig would be really tricky.
/Bernd
--
http://www.berndporr.me.uk
http://www.linux-usb-daq.co.uk
http://www.imdb.com/name/nm3293421/
+44 (0)7840 340069
From e516c966fb36a9a8fee3e743ec97d4732cd9285c Mon Sep 17 00:00:00 2001
From: Bernd Porr m...@berndporr.me.uk
Date: Sat, 21 Dec 2013 09:52:11
http://www.linux-usb-daq.co.uk
http://www.imdb.com/name/nm3293421/
+44 (0)7840 340069
From 5971245d01f25890826fc05f7bab0d2b8d6bfd63 Mon Sep 17 00:00:00 2001
From: Bernd Porr m...@berndporr.me.uk
Date: Fri, 20 Dec 2013 23:32:08 +
Subject: [PATCH 1/1] Moving un-registering of the subdevices
);
async-cmd.chanlist = NULL;
}
} else {
dev_err(dev-class_dev,
BUG: (?) do_become_nonbusy called with
async=NULL\n);
}
s-busy = NULL;
}
Ian Abbott wrote:
On 2013-12-10 21:07, Bernd Porr wrote:
Hi all,
here
of Glasgow
School of Engineering
Rankine Building, Oakfield Avenue,
Glasgow, G12 8LT
From d83a3e0cda7559e9b91759ab4ef8a6c3eb19fbc0 Mon Sep 17 00:00:00 2001
From: Bernd Porr m...@berndporr.me.uk
Date: Wed, 11 Dec 2013 11:45:09 +
Subject: [PATCH 1/1] If the channel list
Hi all,
I've just checked out after a while the newest RC kernel and the
usb-auto config/attach is broken. Seems so that the driver specific usb
attach is no longer called and no firmware is loaded. Hartly, can you
point me to the code bits which should call the driver spcific attach or
give
[ 4972.978644] ---[ end trace 69c2b5c4559cdf1b ]---
I guess that subdevice no longer exists at this point?
/Bernd
On 10/12/13 16:31, Hartley Sweeten wrote:
On Tuesday, December 10, 2013 4:48 AM, Bernd Porr wrote:
I've just checked out after a while the newest RC kernel and the
usb-auto config
gre...@linuxfoundation.org
Cc: Bernd Porr m...@berndporr.me.uk
Cc: Dan Carpenter dan.carpen...@oracle.com
---
drivers/staging/comedi/drivers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index a5d03b9
hacked cfc_check_trigger_src:
-
static inline int cfc_check_trigger_src(unsigned int *src, unsigned int
flags)
{
unsigned int orig_src = *src;
*src = orig_src flags;
printk(cfc_check_trigger_src: orig_src=%x, *src=%x
\n,orig_src,*src
39 matches
Mail list logo
