Make this const as it is only stored in a const field of a pci_dev
structure. Make the declaration in the header const too.
Structure found using Coccinelle and changes done by hand.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
d
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging
Make this const as it is only used in a copy operation.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/b
Make this const as it is only stored in a const field of a
video_device structure.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/media/omap4iss/iss_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss_vide
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/greybus/gbphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/g
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/usb/common/ulpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/common/ul
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/scsi/fcoe/fcoe_sysfs.c | 4 ++--
drivers/scsi/scsi_transport_iscsi.c | 4 ++--
2 files changed, 4 inse
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/remoteproc/remoteproc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remo
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/s390/crypto/ap_card.c | 2 +-
drivers/s390/crypto/ap_queue.c | 2 +-
2 files changed, 2 insertions
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/platform/x86/wmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platfo
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/pci/endpoint/pci-epf-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/mux/mux-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mux/mux-core.c b/d
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/phy/tegra/xusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/tegra/
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/misc/mei/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/bus.c b/d
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/media/rc/rc-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/rc-ma
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/mtd/mtdcore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdcore.c b/drive
Make this const as it is only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/media/i2c/soc_camera/mt9t031.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/med
Make device_type const. Done using Coccinelle.
Bhumika Goyal (15):
EDAC: make device_type const
drm: make device_type const
[media] i2c: make device_type const
[media] rc: make device_type const
mei: make device_type const
mtd: make device_type const
mux: make device_type const
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
---
drivers/gpu/drm/drm_sysfs.c | 2 +-
drivers/gpu/drm/ttm/ttm_module.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_sysfs.c
Make these const as they are only stored in the type field of a device
structure, which is const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/edac/edac_mc_sysfs.c | 8
drivers/edac/i7core_edac.c | 4 ++--
2 files changed, 6 insertions
On Thu, Aug 17, 2017 at 10:33 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Tue, Aug 08, 2017 at 09:15:42PM +0530, Bhumika Goyal wrote:
>> Make the structure const as it is only passed to the function
>> drm_fb_helper_prepare and the corresponding argument is of type
&g
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/media/tuners/tda18271-maps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/tuners/tda18271-map
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s
Make snd_pcm_hardware structures const.
Bhumika Goyal (6):
[media] usb: make snd_pcm_hardware const
[media] pci: make snd_pcm_hardware const
drm: bridge: dw-hdmi: make snd_pcm_hardware const
usb: gadget: make snd_pcm_hardware const
staging: bcm2835-audio: make snd_pcm_hardware const
Make this const as it is only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/d
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/media/pci/cobalt/cobalt-alsa-pcm.c | 4 ++--
drivers/media/pci/cx18/cx18-alsa-pcm.c | 2 +-
drivers/media/pci/cx23885/cx23885-alsa.c
Make this const as it is only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/usb/gadget/function/u_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/u_audio.c
b/drive
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/media/usb/cx231xx/cx231xx-audio.c | 2 +-
drivers/media/usb/em28xx/em28xx-audio.c | 2 +-
drivers/media/usb/go7007/snd-go7007.c
Make the structure const as it is only passed to the function
drm_fb_helper_prepare and the corresponding argument is of type
const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/vboxvideo/vbox_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 de
Declare echo_lock_ops object of type cl_lock_operations as const as it
is only passed to the function cl_lock_slice_add. The corresponding
argument is of type const, so make the object const.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/lustre/lustre/o
On Mon, Sep 12, 2016 at 8:14 PM, Jes Sorensen <jes.soren...@gmail.com> wrote:
> On 09/12/16 09:58, Bhumika Goyal wrote:
>> Relational and logical operators evaluate to either true or false.
>> Explicit conversion is not needed so remove the ternary operator.
>> Done
+ A b B
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8
drivers/staging/rtl8188eu/hal/phy.c | 2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 ++-
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/driv
The functions double_depth, check_card_fail, check_card_ejected are not
used anywhere in the kernel. So, remove their prototype and definition.
Grepped to find occurences.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/rts5208/rtsx_card.
The functions rtsx_disable_card_int, rtsx_undo_delink,
rtsx_check_link_ready are not used anywhere in the kernel. So,remove
their definition and prototype.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/rts5208/rtsx_chip.c | 35 ---
d
The functions rtw_enqueue_recvbuf23a and rtw_enqueue_recvbuf23a_to_head
are never used anywhere in the kernel. So, remove their definition and
prototype.
Grepped to find occurences.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_recv.c
The functions rtw_get_oper_bw23a and rtw_get_oper_ch23aoffset are never
used anywhere in the kernel. So, remove their definition and prototype.
Grepped to find occurences.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_wlan_util.c
The last two lines of these functions are compressed into one.
Also removed the variable ret as it is now not used.
Found using coccinelle:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/wlan-ng/hfa384x
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/iio/adc/ad7816.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
This patchset replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Bhumika Goyal (2):
Staging:iio:Prefer using BIT macro
Staging: iio: adc: Prefer using the BIT macro
drivers/staging/iio/adc/ad7280a.c | 4 ++--
drivers/stagi
In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
-
+ f
//
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 8 --
Removed blank line after curly braces.
Found using checkpatch.pl.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/octeon/ethernet-rgmii.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-rgmii.c
b/drivers/staging/octeon/et
Fix checkpatch.pl check:CHECK: spaces preferred around that '|'.
Add spaces around operands to fix these warnings.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/speakup/speakup_decext.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
Discard the function ccc_vmpage_page_transient as it is not used
anywhere in the kernel.
Used grep to find occurences.
Problem found using sparse.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 11 ---
1 file chang
Replaced explicit NULL comparision with its simplier form.
Found using coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/lustre/lustre/llite/dcache.c | 10 +-
1 file changed, 5 insertions(+), 5 del
Remove explicit NULL comparision and replace it with a simpier form.
Detected using checkpatch.pl.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
This patch series addresses checkpatch.pl warnings in lustre driver.
Bhumika Goyal (2):
Staging:lustre:obdclass:linux:remove unnecessary braces
Staging:lustre:obdclass:linux:simplify NULL comparison
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 12 +---
1 file
Fixed 'braces {} are not necessary for single statement blocks'
checkpatch.pl warning.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/s
Replace [0] with foo,to follow Linux coding style.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux
Fix checkpatch.pl check:CHECK: spaces preferred around that '|'.
Add spaces around operands to fix these warnings.
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/speakup/speakup_decext.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
This patch adds apace around '-' operator.Found using checkpatch.pl
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/i
This patch adds space around '-' operator.Found using checkpatch.pl
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/iio/adc/ad7192.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
These patches adds space around '-' operator.Found using checkpatch.pl.
Bhumika Goyal (2):
staging:iio:adc:added space around '-'
staging:iio:adc:add space around '-'
drivers/staging/iio/adc/ad7192.c | 2 +-
drivers/staging/iio/adc/ad7280a.c | 4 ++--
2 files changed, 3 insertions(+), 3
This patch removes the return statement at the end of a void function as
it is not necessary.This was found by checkpatch.pl .
Signed-off-by: Bhumika Goyal <bhumi...@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/llog_swab.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/d
54 matches
Mail list logo
