Re: [PATCH] staging: most: protect potential string overflow

2019-04-25 Thread Bo YU
On Wed, Apr 24, 2019 at 10:55 PM Dan Carpenter wrote: > > On Mon, Apr 22, 2019 at 10:20:18PM -0400, Bo YU wrote: > > There maybe cause potential string overflow issue due to use > > strcpy without checking the length > > > > Detected By CoversityScan CID# 144476

[PATCH] staging: most: protect potential string overflow

2019-04-22 Thread Bo YU
There maybe cause potential string overflow issue due to use strcpy without checking the length Detected By CoversityScan CID# 1444760 Fixes: 131ac62253dba:(staging: most: core: use device description as name) Signed-off-by: Bo YU --- drivers/staging/most/core.c | 2 +- 1 file changed, 1

[PATCH V2] staging: wilc1000: fix incorrent type in initializer

2019-02-27 Thread Bo YU
struct cfg80211_bss_ies const [noderef] *ies Signed-off-by: Bo YU --- V2: Adding cc wireless-list --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH V2] staging: wilc1000: fix incorrent type assignment

2019-02-25 Thread Bo YU
:25:got unsigned short [usertype] capability Signed-off-by: Bo YU --- V2: use cpu_to_le16 assign valid type according to Ajay's suggestions --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH] staging: wilc1000: fix incorrect type in initializer

2019-02-25 Thread Bo YU
:got struct cfg80211_bss_ies const [noderef] *ies Signed-off-by: Bo YU --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index cdcb52aec779

[PATCH] staging: wilc1000: Fix incorrent type in assignment

2019-02-25 Thread Bo YU
/host_interface.c:451:25:got unsigned short [usertype] capability Signed-off-by: Bo YU --- I have no hardware to test it and just to compile it --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH V3] staging: ks7010: removed unused variables

2019-02-22 Thread Bo YU
From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used [-Wunused-but-set-variable] u16 mib_val_type; drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’ set

[PATCH V2] staging: ks7070: removed unused varibales

2019-02-22 Thread Bo YU
From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used [-Wunused-but-set-variable] u16 mib_val_type; drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’ set

[PATCH] staging/ks7070: Removed unused varibale

2019-02-22 Thread Bo YU
From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used [-Wunused-but-set-variable] u16 mib_val_type; drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’ set

[PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs

2019-02-21 Thread Bo YU
From: Bo Yu Fix sparse warnings: drivers/staging/erofs/utils.c:134:6: warning: symbol 'erofs_try_to_release_workgroup' was not declared. Should it be static? Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled") Cc: Gao Xiang Cc: Chao Yu CC: Greg Kro

[PATCH 3/4] staging: speakup: in serialio.c no over 80 chars long

2017-06-05 Thread Bo YU
Fixed the checkpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/speakup/serialio.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/s

[PATCH 4/4] staging: speakup: alignment match open parens

2017-06-05 Thread Bo YU
I have aligned argument with parenthesis, so checkpatch no check also. Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/speakup/serialio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/seri

[PATCH 2/4] staging: speakup: add a space around '|'

2017-06-05 Thread Bo YU
Add a space around logical symbol '|' to wipe out checkpatch check Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/speakup/serialio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/seri

[PATCH 1/4] staging: speakup: add a missing blank line after declaration

2017-06-05 Thread Bo YU
Fixed checkpatch warning by adding a blank line after declare expression Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/speakup/serialio.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c

[PATCH 0/4] staging: speakup: fix code style

2017-06-05 Thread Bo YU
As checkpatch.pl reported, i fixed these complaint one by one. Maybe patch 04 depend on patch 02. Thanks! Bo YU (4): staging: speakup: add a missing blank line after declaration staging: speakup: add a space around '|' staging: speakup: in serialio.c no over 80 chars long staging

[PATCH] Staging: iio: return expression instead of return ret

2017-03-09 Thread Bo Yu
The following Coccinelle script was used to detect this: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/iio/meter/ade7754.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v2] Staging: wlan-ng: fixed block comments should align the * on each line

2017-02-17 Thread Bo YU
Right-shift a space key to align the * on each line. Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/wlan-ng/p80211metastruct.h | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metastruc

[PATCH] Staging: bcm2835-audio: fixed a code style issue:

2017-02-16 Thread Bo YU
Missing a blank line after declarations Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/bcm2835-audio/bcm2835-pcm.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c index 014bf7

[PATCH] Staging: wlan-ng: Fixed the code style issue:

2017-02-14 Thread Bo YU
WARNING: Block comments should align the * on each line Signed-off-by: Bo YU <tsu.y...@gmail.com> --- drivers/staging/wlan-ng/p80211metastruct.h | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211metastruc

[PATCH] Staging: wlan-ng: Fixed code style issue:

2017-02-13 Thread Bo YU
Statements should start on a tabstop Signed-off-by: YU Bo --- drivers/staging/wlan-ng/prism2mgmt.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index

Re: [PATCH] staging: xgifb: Fix comment style

2016-03-22 Thread Bo Yu
On Mon, Mar 21, 2016 at 03:38:21PM -0400, Kroah-Hartman wrote: hi, On Sat, Mar 12, 2016 at 03:40:35AM -0500, YU Bo wrote: Fix comments to use trailing */ on separste lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c|3 ++-

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-22 Thread Bo YU
e same.But Gerg reply to tell me as if my git configure that have problems. When i run ` git am patch` it reports errors.There is a problem Thanks a lot. > Regards: > Roger H. Newell > > On Sun, Feb 21, 2016 at 5:29 AM, Bo YU <tsu.y...@gmail.com> wrote: >> Hello, >>

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-21 Thread Bo YU
Hi, On Sun, Feb 21, 2016 at 11:33:48AM -0800, Kroah-Hartman wrote: >On Sun, Feb 21, 2016 at 04:59:17PM +0800, Bo YU wrote: >> Hello, >> >> On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote: >> >Patch doesn't apply :( >> I don't know that whether

Re: [PATCH] staging: xgifb: Fix comment style

2016-02-21 Thread Bo YU
Hello, On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote: >On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote: >> Fix comments to use trailing */ on separate lines. >> >> Signed-off-by: YU BO <tsu.y...@gmail.com> >> --- >> drivers/staging/x

[PATCH] staging: xgifb: Fix comment style

2016-02-16 Thread Bo YU
Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index

Re: [PATCH] Staging: xgifb: vgatypes.h: Coding style warning fix for block comments

2016-02-15 Thread Bo YU
Hi, Sorry for the delay to reply.I have send the patch to Arnaud,but he didn't reply me...Maybe i was wrong with something. Thanks again. On Mon, Feb 8, 2016 at 12:14 PM, Kroah-Hartman wrote: > On Fri, Jan 15, 2016 at 05:30:02PM +0800, YU Bo wrote: >> This patch is

Re: [PATCH] Staging: comedi: fix more characters coding style issue in comedi_pcmcia.h

2016-01-13 Thread Bo YU
This is a patch to the comedi_pcmcia.h file that fixes up a "line over 80 characters" warning found by the checkpatch.pl tool Signed-off-by: YU Bo --- drivers/staging/comedi/comedi_pcmcia.h |3 ++- 1 个文件被修改,插入 2 行(+),删除 1 行(-) diff --git

[PATCH] Staging: comedi: fix coding style issue in comedilib.h

2016-01-13 Thread Bo YU
This is a patch to the comedilib.h file that fixes "bloch comment use * on subsequent lines" warning found by the checkpatch.pl tool Signed-off-by: YU Bo --- drivers/staging/comedi/comedilib.h | 32 1 个文件被修改,插入 16 行(+),删除 16 行(-) diff