Re: [PATCH 2/3] wfx: add antenna configuration files

2022-07-07 Thread Ben Brown
On 21/02/2022 16:37, Jerome Pouiller wrote: > From: Jérôme Pouiller > diff --git a/WHENCE b/WHENCE > index 0a6cb15..96f67f7 100644 > --- a/WHENCE > +++ b/WHENCE > @@ -5845,8 +5845,18 @@ Driver: wfx - Silicon Labs Wi-Fi Transceiver > File: wfx/wfm_wf200_C0.sec > Version: 3.12.1 > > +File: wfx/

Re: [PATCH 00/10] spi: finalize 'delay_usecs' removal/transition

2021-03-12 Thread Mark Brown
On Mon, 8 Mar 2021 16:54:52 +0200, Alexandru Ardelean wrote: > A while back I started the introduction of the 'spi_delay' data type: > > https://lore.kernel.org/linux-spi/20190926105147.7839-1-alexandru.ardel...@analog.com/ > > Users of the 'delay_usecs' were removed from drivers. > > Now it's

Your response needed:

2021-02-21 Thread Femi Brown
This mail is been writing to you because we have come to understand that you have lost a lot of money all because you want to receive your fund well note that all that have been put to a stop as the federal government of Nigeria has promised to assist you with the sum of five million American funds

Re: [PATCH v5 00/21] Move Hisilicon 6421v600 SPMI driver set out of staging

2021-01-27 Thread Mark Brown
On Wed, Jan 27, 2021 at 02:32:35PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 27, 2021 at 12:04:26PM +, Mark Brown wrote: > > The whole reason the driver is in the staging tree is that Mauro has a > > requirement to do things in a way that preserves history and so won

Re: [PATCH v5 00/21] Move Hisilicon 6421v600 SPMI driver set out of staging

2021-01-27 Thread Mark Brown
On Wed, Jan 27, 2021 at 09:57:40AM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 26, 2021 at 06:11:24PM +, Mark Brown wrote: > > > Do you need a tag to pull from? > > It'd be nice but not essential. > Why do you want/need this? Having these changes in your tree

Re: [PATCH v5 00/21] Move Hisilicon 6421v600 SPMI driver set out of staging

2021-01-26 Thread Mark Brown
On Tue, Jan 26, 2021 at 07:02:39PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 26, 2021 at 05:57:52PM +, Mark Brown wrote: > > Is there a branch we can pull from? > Once 0-day passes, you can pull from my staging-testing branch from > staging.git on git.kernel.org if you wa

Re: [PATCH v5 00/21] Move Hisilicon 6421v600 SPMI driver set out of staging

2021-01-26 Thread Mark Brown
On Tue, Jan 26, 2021 at 06:54:57PM +0100, Greg Kroah-Hartman wrote: > I've applied the first 13 patches, except for patch 3, as that did not > apply, to my tree, thanks. Is there a branch we can pull from? signature.asc Description: PGP signature ___

Re: [PATCH v4 19/21] regulator: hi6421v600-regulator: move it from staging

2021-01-20 Thread Mark Brown
On Wed, Jan 20, 2021 at 12:02:44AM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > Now that the driver has been converted to regmap these are just > > duplicates of the regmap helpers. You may also be able to use them for > > the disable() and is_enabled()

Re: [PATCH v4 19/21] regulator: hi6421v600-regulator: move it from staging

2021-01-19 Thread Mark Brown
On Tue, Jan 19, 2021 at 05:10:45PM +0100, Mauro Carvalho Chehab wrote: > +static int hi6421_spmi_regulator_get_voltage_sel(struct regulator_dev *rdev) > +{ > +static int hi6421_spmi_regulator_set_voltage_sel(struct regulator_dev *rdev, > + unsigned int

Re: [PATCH v3 15/18] mfd: hi6421-spmi-pmic: move driver from staging

2021-01-19 Thread Mark Brown
On Tue, Jan 19, 2021 at 11:14:20AM +0100, Mauro Carvalho Chehab wrote: > +int hi6421_spmi_pmic_read(struct hi6421_spmi_pmic *pmic, int reg) > +{ > + struct spmi_device *pdev; > + u8 read_value = 0; > + u32 ret; > + > + pdev = to_spmi_device(pmic->dev); > + if (!pdev) { > +

Re: [PATCH v2 11/13] regulator: hi6421v600-regulator: move it from staging

2021-01-18 Thread Mark Brown
On Mon, Jan 18, 2021 at 05:02:45PM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > If for some reason the PMIC is sufficiently fragile to need a delay > > between enables it's not clear why the driver is doing it before > > enabling rather than after,

Re: [PATCH v2 11/13] regulator: hi6421v600-regulator: move it from staging

2021-01-18 Thread Mark Brown
On Mon, Jan 18, 2021 at 02:28:12PM +0100, Mauro Carvalho Chehab wrote: > index f385146d2bd1..3b23ad56b31a 100644 > --- a/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml > @@ -60,6 +60,8 @@ required:

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-12-01 Thread Mark Brown
On Tue, Dec 01, 2020 at 05:17:20PM +0300, Dmitry Osipenko wrote: > 01.12.2020 16:57, Mark Brown пишет: > > [1/1] regulator: Allow skipping disabled regulators in > > regulator_check_consumers() > > (no commit info) > Could you please hold on this patch? It won&#x

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-12-01 Thread Mark Brown
On Thu, 5 Nov 2020 02:43:57 +0300, Dmitry Osipenko wrote: > Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs, which reduces > power consumption and heating of the Tegra chips. Tegra SoC has multiple > hardware units which belong to a core power domain of the SoC and share > the core voltag

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-19 Thread Mark Brown
On Thu, Nov 19, 2020 at 05:22:43PM +0300, Dmitry Osipenko wrote: > 16.11.2020 16:33, Mark Brown пишет: > > No, you are failing to understand the purpose of this code. To > > reiterate unless the device supports operating with the supply > > physically absent then the

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mark Brown
On Tue, Nov 17, 2020 at 09:38:30AM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > This also appears to be missing a DT binding document, binding > > documentation is required for anything with DT support. > The DT binding is documented on patch 3/8, togeth

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mark Brown
On Tue, Nov 17, 2020 at 09:08:22AM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > This probe code looks very different to other regulator drivers, this > > alone should have been a warning that the driver needs some substantial > > refactoring here. As

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-16 Thread Mark Brown
On Mon, Nov 16, 2020 at 01:59:30PM +0100, Mauro Carvalho Chehab wrote: > This driver is ready for mainstream. Move it out of staging. There's quite a few issues here, to be honest I'm disappointed some of them weren't caught during staging review, this needs fairly substantial work and there's si

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-16 Thread Mark Brown
On Sun, Nov 15, 2020 at 08:42:10PM +0300, Dmitry Osipenko wrote: > 13.11.2020 20:28, Mark Brown пишет: > >> What should we do? > > As I keep saying the consumer driver should be enumerating the voltages > > it can set, if it can't find any and wants to continue then

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-13 Thread Mark Brown
On Fri, Nov 13, 2020 at 08:13:49PM +0300, Dmitry Osipenko wrote: > 13.11.2020 19:15, Mark Brown пишет: > > My point here is that the driver shouldn't be checking for a dummy > > regulator, the driver should be checking the features that are provided > > to it by the re

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-13 Thread Mark Brown
On Fri, Nov 13, 2020 at 06:55:27PM +0300, Dmitry Osipenko wrote: > 13.11.2020 17:29, Mark Brown пишет: > > It's not clear if it matters - it's more a policy decision on the part > > of the driver about what it thinks safe error handling is. If it's not > I

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-13 Thread Mark Brown
On Fri, Nov 13, 2020 at 01:37:01AM +0300, Dmitry Osipenko wrote: > 12.11.2020 23:01, Mark Brown пишет: > >> But it's not allowed to change voltage of a dummy regulator, is it > >> intentional? > > Of course not, we can't know if the requested new voltage is

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-12 Thread Mark Brown
On Thu, Nov 12, 2020 at 10:16:14PM +0300, Dmitry Osipenko wrote: > 12.11.2020 20:16, Mark Brown пишет: > > On Thu, Nov 12, 2020 at 07:59:36PM +0300, Dmitry Osipenko wrote: > >> Also, some device-trees won't have that regulator anyways because board > >> schemati

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-12 Thread Mark Brown
On Thu, Nov 12, 2020 at 07:59:36PM +0300, Dmitry Osipenko wrote: > 11.11.2020 14:55, Mark Brown пишет: > > On Wed, Nov 11, 2020 at 12:23:41AM +0300, Dmitry Osipenko wrote: > >> I already changed that code to use regulator_get_optional() for v2. > > That doesn't lo

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-11 Thread Mark Brown
On Wed, Nov 11, 2020 at 12:23:41AM +0300, Dmitry Osipenko wrote: > 10.11.2020 23:32, Mark Brown пишет: > >>> + if (!device_property_present(dc->dev, "core-supply")) > >>> + return; > >> This is a potentially heavy operation, so I think

Re: [PATCH v1 11/30] drm/tegra: dc: Support OPP and SoC core voltage scaling

2020-11-10 Thread Mark Brown
On Tue, Nov 10, 2020 at 09:29:45PM +0100, Thierry Reding wrote: > On Thu, Nov 05, 2020 at 02:44:08AM +0300, Dmitry Osipenko wrote: > > + /* > > +* Voltage scaling is optional and trying to set voltage for a dummy > > +* regulator will error out. > > +*/ > > + if (!device_property_p

hi

2020-11-06 Thread Melissa Brown
How are you doing today?Did you receive my message?Please let me know as soon as possible. Tony ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-12 Thread Mark Brown
On Fri, Jun 12, 2020 at 09:07:24PM +0530, Vaibhav Agarwal wrote: > On Thu, Jun 11, 2020 at 09:26:16AM +0100, Mark Brown wrote: > > > Kindly suggest me the preferred way to follow on this thread. > > This is effectively out of tree code, until someone submits it properly >

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-11 Thread Mark Brown
On Wed, Jun 10, 2020 at 08:01:18PM +0200, Alexandre Belloni wrote: > My point was that if we were to keep that driver, the goal would be to > have it out of staging instead of simply making it compile. Yes, definitely - that should be the goal for anything in staging. signature.asc Description:

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-11 Thread Mark Brown
On Wed, Jun 10, 2020 at 11:53:24PM +0530, Vaibhav Agarwal wrote: > With patch#6 in this series, I'm proposing some of the (dummy) helper > APIs required to link DAPM DAI widgets for the GB Audio modules > added/removed dynamically. > Eventually, I would like to propose relevant changes in snd-s

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-10 Thread Mark Brown
On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote: > The existing GB Audio codec driver is dependent on MSM8994 Audio driver. > During the development stage, this dependency was configured due to > various changes involved in MSM Audio driver to enable addtional codec > card and some

Re: [PATCH] staging: iio: ad5933: rework probe to use devm_ function variants

2020-05-08 Thread Mark Brown
On Fri, May 08, 2020 at 01:43:07PM +0100, Jonathan Cameron wrote: > Dan Carpenter wrote: > > It feels like we should just make a devm_ version of regulator_enable(). > > Or potentially this is more complicated than it seems, but in that case > > probably adding devm_add_action_or_reset() is more

Re: [PATCH] docs: dt: fix several broken doc references

2020-02-24 Thread Mark Brown
aml renames; > - file renames (still on txt format); This seems like it should've been split up a bit. :/ Acked-by: Mark Brown signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driver

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-04 Thread Mark Brown
On Wed, Dec 04, 2019 at 07:18:15AM +, Ardelean, Alexandru wrote: > One example (for spi-cpha): > if (of_property_read_u32(nc, "spi-cpha", &tmp) == 0) { > spi->mode |= SPI_CPHA_OVERRIDE; > if (tmp) > spi->mode |= SPI_CPHA; We could al

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-04 Thread Mark Brown
On Tue, Dec 03, 2019 at 04:51:54PM +, Jonathan Cameron wrote: > If the driver picks a mode because that's what it says on the datasheet > it prevents odd board configurations from working. The question > becomes whether it makes sense in general to assume those odd board > conditions don't ex

Re: [PATCH v4] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-12-03 Thread Mark Brown
On Sun, Dec 01, 2019 at 11:40:32AM +, Jonathan Cameron wrote: > +CC Mark as we probably need a more general view point on > the question of whether SPI mode should be enforced by binding > or in the driver. Not sure I see the question here, I think I was missing a bit of the conversation? It

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread Mark Brown
On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: Today's -next fails to build an ARM allmodconfig due to: > allmodconfig (arm, gcc-8) — FAIL, 1 error, 40 warnings, 0 section mismatches > > Errors: > drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > func

Re: [PATCH] spi: mt7621: Move SPI driver out of staging

2019-03-25 Thread Mark Brown
On Fri, Mar 22, 2019 at 03:02:54PM +0100, Stefan Roese wrote: > On 21.03.19 15:25, Mark Brown wrote: > > > + list_for_each_entry(t, &m->transfers, transfer_list) > > > + if (t->speed_hz < speed) > > > + speed = t->speed_hz;

Re: [PATCH] spi: mt7621: Move SPI driver out of staging

2019-03-21 Thread Mark Brown
On Thu, Mar 14, 2019 at 12:52:12PM +0100, Stefan Roese wrote: This looks pretty good, a few trivial issues below but nothing major I think. > +config SPI_MT7621 > + tristate "MediaTek MT7621 SPI Controller" > + depends on RALINK > + help > + This selects a driver for the MediaTe

[PATCH v2 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0

2019-02-18 Thread Kimberly Brown
tions. In addition, the server_monitor_latency_show() and server_monitor_conn_id_show() functions use monitor_pages index '0'. Signed-off-by: Kimberly Brown Acked-by: Stephen Hemminger --- drivers/hv/vmbus_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/vmb

[PATCH v2 2/2] Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set

2019-02-18 Thread Kimberly Brown
or_allocated" is set before accessing the monitor id or the monitor page data. If "channel->offermsg.monitor_allocated" is not set, return -EINVAL. Signed-off-by: Kimberly Brown --- Documentation/ABI/stable/sysfs-bus-vmbus | 15 -- drivers/hv/vmbus_drv.c

[PATCH v2 0/2] Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data

2019-02-18 Thread Kimberly Brown
by S. Hemminger. - Updated the sysfs documentation to describe the new return value. Kimberly Brown (2): Drivers: hv: vmbus: Change server monitor_pages index to 0 Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set Documentation/ABI/stable/sysfs-bus-vmbus | 15 +

Re: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-02-14 Thread Kimberly Brown
On Thu, Feb 14, 2019 at 08:54:31PM -0500, Sasha Levin wrote: > On Sat, Feb 02, 2019 at 03:07:35PM -0500, Kimberly Brown wrote: > > On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote: > > > > From: Kimberly Brown > > > > Sent: Thursday, January 31, 2

Re: [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set

2019-02-13 Thread Kimberly Brown
On Mon, Feb 11, 2019 at 10:02:47AM -0800, Stephen Hemminger wrote: > On Mon, 11 Feb 2019 02:01:18 -0500 > Kimberly Brown wrote: > > > On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote: > > > On Fri, 8 Feb 2019 05:01:12 -0500 > > > Kimberly Brown

Re: [PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set

2019-02-11 Thread Kimberly Brown
On Fri, Feb 08, 2019 at 02:32:09PM -0800, Stephen Hemminger wrote: > On Fri, 8 Feb 2019 05:01:12 -0500 > Kimberly Brown wrote: > > You are right, the current behavior is broken. > It would be good to add a description of under what conditions > monitor is not used. Is this some

[PATCH 2/2] Drivers: hv: vmbus: Display nothing in sysfs if monitor_allocated not set

2019-02-08 Thread Kimberly Brown
ocated to a channel. In the affected "_show" functions, verify that "channel->offermsg.monitor_allocated" is set before accessing the monitor id or the monitor_page data. If "channel->offermsg.monitor_allocated" is not set, display nothing. Signed-off-by: Kimber

[PATCH 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0

2019-02-08 Thread Kimberly Brown
tions. In addition, the server_monitor_latency_show() and server_monitor_conn_id_show() functions use monitor_pages index '0'. Signed-off-by: Kimberly Brown --- drivers/hv/vmbus_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/

[PATCH 0/2] Drivers: hv: vmbus: Fix sysfs functions that display monitor id and page data

2019-02-08 Thread Kimberly Brown
a channel, display nothing in the channel's monitor id and monitor page data sysfs files. The data that is currently shown in sysfs is incorrect. Kimberly Brown (2): Drivers: hv: vmbus: Change server monitor_pages index to 0 Drivers: hv: vmbus: Display nothing in sysfs if monitor_alloca

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-04 Thread Mark Brown
On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote: > It is extremely common in the kernel for a file to start >// SPDX-License-Identifier. > and to have that immediately followed by a comment lile: > /* > * . > * Yes, there was a lot of automated conversion AFAIC

[PATCH v4] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-02-03 Thread Kimberly Brown
files were created and observing the counter values. The values seemed to increase by a reasonable amount when the Hyper-v related drivers were in use. Signed-off-by: Kimberly Brown --- Changes in v4: - In the commit message, added a paragraph describing why the full condition counters are i

Re: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-02-02 Thread Kimberly Brown
On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote: > > From: Kimberly Brown > > Sent: Thursday, January 31, 2019 9:47 AM > > ... > > 2) Prevent a deadlock that can occur between the proposed mutex_lock() > > call in the vmbus_chan_attr_show() function and th

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

2019-02-01 Thread Mark Brown
On Fri, Feb 01, 2019 at 11:17:07AM +0100, Stefan Roese wrote: > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * spi-mt7621.c -- MediaTek MT7621 SPI controller driver > * Please convert the entire comment into a C++ comment so it looks more intentional. signature.asc Descrip

Re: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-01-31 Thread Kimberly Brown
On Thu, Jan 31, 2019 at 04:45:35PM +, Michael Kelley wrote: > From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM > > > > I've queued this one for hyper-fixes, thanks all! > > > > Actually, please hold off on queuing this one. In a conversation I had > yesterday with Kim, they had

Re: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-01-28 Thread Kimberly Brown
On Tue, Jan 22, 2019 at 06:40:30PM +, Dexuan Cui wrote: > > From: Kimberly Brown > > Sent: Monday, January 21, 2019 10:43 PM > > > > @@ -1421,7 +1422,10 @@ static ssize_t vmbus_chan_attr_show(struct > > > > kobject *kobj, > > > >

Re: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-01-21 Thread Kimberly Brown
On Tue, Jan 22, 2019 at 03:46:48AM +, Dexuan Cui wrote: > > From: Kimberly Brown > > Sent: Monday, January 21, 2019 6:08 PM > > Subject: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show > > functions > > > > The channel level "_show&quo

[PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions

2019-01-21 Thread Kimberly Brown
The channel level "_show" functions are vulnerable to race conditions. Add a mutex lock and unlock around the call to the channel level "_show" functions in vmbus_chan_attr_show(). This problem was discussed here: https://lkml.org/lkml/2018/10/18/830 Signed-off-by: Kimberly

Re: [PATCH v3] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-21 Thread Kimberly Brown
On Thu, Jan 17, 2019 at 09:11:03AM -0800, Stephen Hemminger wrote: > > > > +static ssize_t channel_intr_in_full_show(const struct vmbus_channel > > *channel, > > +char *buf) > > +{ > > + return sprintf(buf, "%llu\n", channel->intr_in_full); > > +} > > > int

[PATCH v3] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-16 Thread Kimberly Brown
-v related drivers were in use. Signed-off-by: Kimberly Brown --- Changes in v3: - Used the outbound ring buffer spinlock to protect the the full condition counters in set_channel_pending_send_size() - Corrected the KernelVersion values for the new entries in Documentation/ABI/stable/sysfs

[PATCH v2] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-04 Thread Kimberly Brown
-v related drivers were in use. Signed-off-by: Kimberly Brown --- Changes in v2: - Added mailing lists to the cc list - Removed the host to guest interrupt counters proposed in v1 because they were not accurate - Added full condition counters for the channel's outbound ring buffer

[PATCH v2] staging: mt7621-dma: Add braces around else branches

2018-10-23 Thread Kimberly Brown
Add braces around else branches in conditional statements that include branches with multiple statements. This style complies with the Linux kernel coding style and improves consistency and readability. Issues found by checkpatch. Signed-off-by: Kimberly Brown Reviewed-by: Matthias Brugger

Re: [PATCH 0/8] arm: renesas: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Mark Brown
On Fri, Apr 20, 2018 at 03:28:26PM +0200, Geert Uytterhoeven wrote: > The first 6 patches can be applied independently by subsystem > maintainers. > The last two patches depend on the first 6 patches, and are thus marked > RFC. Would it not make sense to try to apply everything en masse rather th

Re: [PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

2018-04-12 Thread Mark Brown
On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. Acked-by: Mark Brown If there's no

Re: [PATCH v2 19/21] spi: Remove depends on HAS_DMA in case of platform dependency

2018-03-18 Thread Mark Brown
m specific > symbol, or PCI. Acked-by: Mark Brown signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 01/21] ASoC: Remove depends on HAS_DMA in case of platform dependency

2018-03-18 Thread Mark Brown
m specific > symbol, or PCI. Acked-by: Mark Brown Thanks again for doing this work, it's really good to see! signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Mark Brown
On Tue, Nov 28, 2017 at 06:28:38PM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > > I think it's reasonable to ask for userspace, I'm querying why it needs > > to specifically be Android. > Does anyone other than Android use thi

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Mark Brown
On Tue, Nov 28, 2017 at 06:08:22PM +0100, Greg KH wrote: > On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > call you added? What did you do to test this out? Where are the AOSP > > > patc

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Mark Brown
On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > Where is the documentation for the new sysfs files and the new ioctl Didn't see any sysfs files in there? > call you added? What did you do to test this out? Where are the AOSP > patches to use this? Happen to have a VTS test for it?

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-27 Thread Mark Brown
On Mon, Nov 27, 2017 at 05:12:23PM +0100, Daniel Vetter wrote: > commit model ftw, we have 400+ patches for 4.16 already merged and tested > and all ready, right when -rc1 gets tagged. Makes the merge window the > most relaxed time of all, because all the other maintainers are drowning > and wont

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-02 Thread Mark Brown
On Thu, Nov 02, 2017 at 11:44:07AM +0100, Greg KH wrote: > On Tue, Oct 31, 2017 at 07:11:53PM +, Mark Brown wrote: > > There was a discussion a while ago in the context of I2C/SPI MFDs > > which concluded that if you need a bus and it's going to be effectively > >

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-10-31 Thread Mark Brown
On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote: > I'm not a fan of the platform bus but I have mixed feelings about > creating a dedicated bus type. I guess if we really need a bus > type we can do it later? There was a discussion a while ago in the context of I2C/SPI MFDs which con

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-10 Thread Mark Brown
On Mon, Oct 09, 2017 at 05:10:37PM -0700, Laura Abbott wrote: > On 10/09/2017 03:08 PM, Mark Brown wrote: > > On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > >> Anyway, to move this forward I think we need to see a proof of concept > >> of using s

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-09 Thread Mark Brown
On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > Anyway, to move this forward I think we need to see a proof of concept > of using selinux to protect access to specific heaps. Aren't Unix permissions enough with separate files or am I misunderstanding what you're looking to see a p

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-04 Thread Mark Brown
On Tue, Oct 03, 2017 at 04:08:30PM -0700, Sandeep Patil wrote: > It is entirely possible and easy in android/ueventd to create those nodes > under "/dev/ion/". (assuming the heap 'subsystem' for these new devices will > point to 'ion'). The reason I didn't say /dev/ion/foo initially is that if p

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-03 Thread Mark Brown
On Mon, Oct 02, 2017 at 11:07:48AM -0700, Laura Abbott wrote: > Thinking about this a bit more, I'm not 100% sure if this > will allow the security rules we want. Heap ids are assigned > dynamically and therefore so will the /dev/ionX designation. > From my understanding, security rules like selin

Re: [PATCH v4 2/2] staging: ion: create one device entry per heap

2017-09-26 Thread Mark Brown
On Tue, Sep 26, 2017 at 02:07:05PM +0200, Benjamin Gaignard wrote: > version 4: > - add a configuration flag to switch between legacy Ion misc device > and one device per heap version. Should this be a switch or should it just be enabling and disabling the legacy device with the per heap ones a

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-08 Thread Mark Brown
On Mon, Aug 07, 2017 at 09:20:05PM +0200, Hans de Goede wrote: > On 07-08-17 17:41, Mark Brown wrote: > > I2C has a perfectly good platform_data pointer in the board info for > > this stuff. > True, so you are suggesting that I define a bq24190_platform_data > struct with

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Mark Brown
On Mon, Aug 07, 2017 at 04:41:18PM +0200, Hans de Goede wrote: > On 07-08-17 13:10, Mark Brown wrote: > Problem 1) > The regulator in question is part of the bq24292i charger-IC attached to > a private i2c bus between the PMIC and the charger. The driver for the i2c > controller

Re: [PATCH 10/18] staging: typec: fusb302: Add support for fcs,vbus-regulator-name device-property

2017-08-07 Thread Mark Brown
On Sun, Aug 06, 2017 at 05:44:36PM +0200, Hans de Goede wrote: > On 06-08-17 16:30, Guenter Roeck wrote: > > On 08/06/2017 05:35 AM, Hans de Goede wrote: > > > On ACPI platforms, there are no phandles and we need to get the vbus by a > > > system wide unique name. Add support for a new "fcs,vbus-r

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-13 Thread Mark Brown
On Mon, Mar 13, 2017 at 10:54:33AM +, Brian Starkey wrote: > On Sun, Mar 12, 2017 at 02:34:14PM +0100, Benjamin Gaignard wrote: > > Another point is how can we put secure rules (like selinux policy) on > > heaps since all the allocations > > go to the same device (/dev/ion) ? For example, unti

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-06 Thread Mark Brown
On Mon, Mar 06, 2017 at 11:40:41AM +0100, Daniel Vetter wrote: > No one gave a thing about android in upstream, so Greg KH just dumped it > all into staging/android/. We've discussed ION a bunch of times, recorded > anything we'd like to fix in staging/android/TODO, and Laura's patch > series here

Re: [PATCH v5 4/4] net: phy: leds: add support for led triggers on phy link state change

2016-10-18 Thread Zach Brown
On Tue, Oct 18, 2016 at 09:13:50AM +0200, Andrew Lunn wrote: > On Mon, Oct 17, 2016 at 10:49:55AM -0500, Zach Brown wrote: > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a > > set of led triggers for each instantiated PHY device. There is one LED >

[PATCH v5 0/4] Add support for led triggers on phy link state change

2016-10-17 Thread Zach Brown
ist of triggers to dynamic list determined by speeds return by phy_supported_speeds. Zach Brown (4): skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace net: phy: Encapsulate actions performed during link state changes into funct

[PATCH v5 2/4] net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-17 Thread Zach Brown
ore. Actions that should occur whenever the phy link is adjusted can now be added to the phy_adjust_link function. Signed-off-by: Zach Brown --- drivers/net/phy/phy.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/ph

[PATCH v5 1/4] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-17 Thread Zach Brown
changed LED_ON to LED_REG_ON to avoid possible future conflict and for consistency. Signed-off-by: Zach Brown --- drivers/net/ethernet/marvell/skge.c | 6 +++--- drivers/net/ethernet/marvell/skge.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet

[PATCH v5 4/4] net: phy: leds: add support for led triggers on phy link state change

2016-10-17 Thread Zach Brown
this patch the leds not controlled by the phy can be configured to show the current speed of the ethernet connection. The leds controlled by the phy are unaffected. Signed-off-by: Josh Cartwright Signed-off-by: Nathan Sullivan Signed-off-by: Zach Brown --- drivers/net/phy/Kconfig| 13

[PATCH v5 3/4] net: phy: Create phy_supported_speeds function which lists speeds currently supported by a phydevice

2016-10-17 Thread Zach Brown
phy_supported_speeds provides a means to get a list of all the speeds a phy device currently supports. Signed-off-by: Zach Brown --- drivers/net/phy/phy.c | 35 +++ include/linux/phy.h | 15 +++ 2 files changed, 50 insertions(+) diff --git a

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread Zach Brown
On Thu, Oct 13, 2016 at 10:46:34AM -0400, David Miller wrote: > From: Zach Brown > Date: Tue, 11 Oct 2016 15:26:20 -0500 > > > From: Josh Cartwright > > > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > > create a set of led triggers for eac

Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

2016-10-12 Thread Zach Brown
On Mon, Oct 10, 2016 at 02:03:32AM -0700, Florian Fainelli wrote: > > + > > +#ifdef CONFIG_LED_TRIGGER_PHY > > + > > +#include > > +#include > > + > > +#define PHY_LINK_LED_MAX_TRIGGERS 5 > > +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE 7 > > +#define PHY_MII_BUS_ID_SIZE(20 - 3) > > This

Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-11 Thread Zach Brown
On Tue, Oct 11, 2016 at 02:14:07PM -0700, Stephen Hemminger wrote: > On Tue, 11 Oct 2016 15:26:18 -0500 > Zach Brown wrote: > > > Adding led support for phy causes namespace conflicts for some > > phy drivers. > > > > The marvel skge driver declared an enum for re

[PATCH v4 2/3] net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-11 Thread Zach Brown
ore. Actions that should occur whenever the phy link is adjusted can now be added to the phy_adjust_link function. Signed-off-by: Zach Brown --- drivers/net/phy/phy.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/ph

[PATCH v4 0/3] Add support for led triggers on phy link state change

2016-10-11 Thread Zach Brown
improve consistency. * Dropped rtl8712 patch that was accepted separately. v4: * tweaked commit message Josh Cartwright (1): net: phy: leds: add support for led triggers on phy link state change Zach Brown (2): skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with

[PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-11 Thread Zach Brown
changes on the phy. Signed-off-by: Josh Cartwright Signed-off-by: Nathan Sullivan Signed-off-by: Zach Brown --- drivers/net/phy/Kconfig| 13 +++- drivers/net/phy/Makefile | 1 + drivers/net/phy/phy.c | 1 + drivers/net/phy/phy_device.c | 4

[PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-11 Thread Zach Brown
changed LED_ON to LED_REG_ON to avoid possible future conflict and for consistency. Signed-off-by: Zach Brown --- drivers/net/ethernet/marvell/skge.c | 6 +++--- drivers/net/ethernet/marvell/skge.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet

[RFC v3 3/3] phy, leds: add support for led triggers on phy link state change

2016-10-07 Thread Zach Brown
changes on the phy. Signed-off-by: Josh Cartwright Signed-off-by: Nathan Sullivan Signed-off-by: Zach Brown --- drivers/net/phy/Kconfig| 13 +++- drivers/net/phy/Makefile | 1 + drivers/net/phy/phy.c | 1 + drivers/net/phy/phy_device.c | 4

[RFC v3 2/3] phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-07 Thread Zach Brown
ore. Actions that should occur whenever the phy link is adjusted can now be added to the phy_adjust_link function. Signed-off-by: Zach Brown --- drivers/net/phy/phy.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/ph

[RFC v3 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-07 Thread Zach Brown
changed LED_ON to LED_REG_ON to avoid possible future conflict and for consistency. Signed-off-by: Zach Brown --- drivers/net/ethernet/marvell/skge.c | 6 +++--- drivers/net/ethernet/marvell/skge.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet

[PATCH 0/3] Add support for led triggers on phy link state change

2016-10-07 Thread Zach Brown
improve consistency. * Dropped rtl8712 patch that was accepted separately. Josh Cartwright (1): phy,leds: add support for led triggers on phy link state change Zach Brown (2): skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace phy: Encapsulate

[RFC v2 1/4] skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace

2016-09-27 Thread Zach Brown
Signed-off-by: Zach Brown --- drivers/net/ethernet/marvell/skge.c | 4 ++-- drivers/net/ethernet/marvell/skge.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 7173836..ff5a087 100644 --- a/drivers

[RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace

2016-09-27 Thread Zach Brown
future collision LED_ON was changed to LED_STATE_ON as well. Signed-off-by: Zach Brown --- drivers/staging/rtl8712/rtl8712_led.c | 388 +- 1 file changed, 194 insertions(+), 194 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_led.c b/drivers/staging

[RFC v2 4/4] phy, leds: add support for led triggers on phy link state change

2016-09-27 Thread Zach Brown
changes on the phy. Signed-off-by: Josh Cartwright Signed-off-by: Nathan Sullivan Signed-off-by: Zach Brown --- drivers/net/phy/Kconfig| 13 +++- drivers/net/phy/Makefile | 1 + drivers/net/phy/phy.c | 1 + drivers/net/phy/phy_device.c | 4

  1   2   3   >