On Tue, Sep 20, 2016 at 3:29 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Tue, Sep 20, 2016 at 09:47:31AM +0900, Chaehyun Lim wrote:
>> As suggested by checkpatch.pl:
>>
>> CHECK: Prefer kernel type 'u32' over 'uint32_t'
>>
>> Signed-off-b
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u16' over 'uint16_t'
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/greybus/audio_codec.c | 12 ++--
drivers/staging/greybus/audio_codec.h | 16
drivers/staging/greybus/audi
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/greybus/audio_codec.c | 6 ++--
drivers/staging/greybus/audio_codec.h | 10 +++
drivers/staging/greybus/audi
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/greybus/audio_codec.c | 6 +++---
drivers/staging/greybus/audio_codec.h | 18 +-
drivers/staging/greybus/audio_gb.c
When handle_cfg_param is called in hostIFthread that is a kernel thread,
it is not checked return type of this function. This patch changes
return type to void.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 23 ++-
There is no need to use type cast of bss_type because
hif_drv->cfg_values.bss_type is u8.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() functions are used as result,
others are used as ret. It will be changed as ret in all handle_*()
functions to match variable name.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
struct set_mac_addr is not used anymore, so just remove it.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 1 -
drivers/staging/wilc1000/host_interface.h | 4
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/wi
A local bss_type variable is added to remove checkpatch warning of
line over 80 characters.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wi
This patch changes data type of result variable from s32 to int. result
is used to get return value from wilc_send_config_pkt that has return
type of int.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion
When handle_get_mac_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
d
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() functions are used as result,
others are used as ret. It will be changed as ret in all handle_*()
functions to match variable name.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
When handle_get_ip_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
d
This patch changes data type of result variable from s32 to int. result
is used to get return value from wilc_send_config_pkt that has return
type of int.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion
This patch changes conditional comparison of if statement as if (ret)
instead of using if (ret != 0)
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wi
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() functions are used as result,
others are used as ret. It will be changed as ret in all handle_*()
functions to match variable name.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
This patch changes data type of result variable from s32 to int. result
is used to get return value from wilc_send_config_pkt that has return
type of int.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion
This patch changes data type of result variable from s32 to int. result
is used to get return value from wilc_send_config_pkt that has return
type of int.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() functions are used as result,
others are used as ret. It will be changed as ret in all handle_*()
functions to match variable name.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
When handle_set_ip_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due to have
a single statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
d
When handle_set_operation_mode is called in hostIFthread that is a
kernel thread, it is not checked return type of this function. This
patch changes return type to void and removes braces if statement due to
have a single statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() functions are used as result,
others are used as ret. It will be changed as ret in all handle_*()
functions to match variable name.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
When handle_set_wfi_drv_handler is called in hostIFthread that is a
kernel thread, it is not checked return type of this function. This
patch changes return type to void and removes braces if statement due to
have a single statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
This patch changes data type of result variable from s32 to int.
result is used to get return value from wilc_send_config_pkt that has
return type of int.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. Some handle_*() function are used as result,
others are used as ret. It will be changed as ret in all handle_*()
function to match variable name.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
This patch changes return type of ret variable from s32 to int.
ret has return value from wilc_send_config_pkt that has return type of
int.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 de
This patch removes unused hif_drv in wilc_del_station.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_add_beacon.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_del_beacon.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_set_pmkid_info.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_remain_on_channel.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_set_mac_chnl_num.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_add_station.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in host_int_get_assoc_res_info.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/s
This patch removes unused hif_drv in wilc_del_allstation.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_edit_station.
There is no need to checku null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_setup_multicast_filter.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/s
This patch removes unused hif_drv in host_int_get_ipaddress.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unused hif_drv in wilc_set_power_mgmt.
There is no need to check null and print debug log.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wi
This patch changes goto label from ERRORHANDLER to unlock.
unlock is a more meaningful name than ERRORHANDLER.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 38 +++
1 file changed, 19 insertions(+), 19 del
This patch renames pu8Buffer to buffer to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/d
This patch renames strWIDList to wid_list to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 48 +++
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/wi
This patch renames u32WidsCount to index to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 58 +++
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/wi
Handle_ScanDone function declaration is moved to front of
host_interface.c file.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interfac
This patch removes unnecessary block scope braces and fix indentation of
the codes.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wi
This patch renames Handle_Scan to handle_scan to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/d
This patch renames pstrHostIFscanAttr to scan_info to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 55 +++
1 file changed, 27 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/wi
struct semaphore SemHandleUpdateStats is defined but never used in this
driver, so just remove it.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 -
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 -
2 files chan
This patch replaces struct semaphore hSemScanReq with struct mutex
scan_req_lock. It is better to use mutex than semaphore.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 10 +-
drivers/staging/wilc1000/wilc_wfi_netde
-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wlan.c | 4 ++--
drivers/staging/wilc1000/wilc_wlan.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc1000/wilc_wlan.c
index db79ae2..7
struct semaphore hif_sema_driver is used to signal completion of host
interface message. This patch replaces struct semaphore hif_sema_driver
with struct completion hif_driver_comp. It is better to use completion
than semaphore for this case.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
struct semaphore hif_sema_thread is used to signal completion of host
interface thread. This patch replaces struct semaphore hif_sema_thread
with struct completion hif_thread_comp. It is better to use completion
than semaphore for this case.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
This patch replaces struct semaphore hif_sema_deinit with struct mutex
hif_deinit_lock. It is better to use mutex because mutex gives better
performance than semaphore.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 18 +--
This patch replaces struct semaphore hif_sema_wait_response with struct
completion hif_wait_response. In case of struct hif_sema_wait_response,
it better to use completion than semaphore.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.
This patch replaces struct semaphore sem_cfg_values with struct mutex
cfg_values_lock. It is better to use mutex than semaphore.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 10 +-
drivers/staging/wilc1000/host_interface.
This patch removes commented codes in struct wilc_cfg_str.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.c
b/drivers/staging/wilc1000/wilc_wlan
This patch renames hardwareProductVersion to hw_product_version to avoid
camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan
It is more readable than multiple if-else statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_cf
TAG_PARAM_OFFSET is defined at top of this file so that it is used
to simplify codes.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wi
This patch adds a new enum cfg_type_cmd to change hard-coded command
type.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wi
This patch removes unnecessary comments because enum cfg_cmd_type
shows each command type without it.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/d
This patch removes INFINITE_SLEEP_TIME that is not used in the driver,
so just remove it.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wlan_if.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h
b/d
This patch removes typedef from struct sdio_cmd53_t and renames it to
sdio_cmd53.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_sdio.c| 10 +-
drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++--
2 files changed, 7 insertions(+), 7 del
This patch removes typedef from enum tenuConnectSts and renames it to
connect_status to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s
This patch removes unnecessary comment code in struct sdio_cmd53_t.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_wlan_if.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h
b/drivers/staging/wi
This patch removes typedef from struct sdio_cmd52_t and renames it to
sdio_cmd52.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/wilc_sdio.c| 26 +-
drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++--
2 files changed, 15 inse
This patch renames ReqIEsLen to req_ies_len to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wilc1000/wilc_wfi_cfgoperations
This patch renames u16reason to reason to remove u16 prefix. There is no
need to use prefix to show data type.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 4 ++--
d
This patch renames u16ConnectStatus to status to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 10 +-
drivers/staging/wi
This patch renames pu8ReqIEs to req_ies to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 24 +++
drivers/staging/wi
This patch renames struct tstrDisconnectNotifInfo to disconnect_info to
avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wi
This patch renames u16RespIEsLen to resp_ies_len to avoid camelcase.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 2 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations
This patch renames au8bssid to bssid to remove au8 prefix in struct
connect_info. There is no need to use prefix to show data type of this
variable.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wi
This patch renames struct tstrConnectInfo to connect_info to avoid
camelcase and removes typedef.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.h | 4 ++--
drivers/staging/wilc1000/host_interface.c | 12 ++--
d
This patch fixes logical continuations found by checkpatch
CHECK: Logical continuations should be on the previous line
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
This patch changes data type of wid_cnt from u8 to int.
This variable uses array index of struct wid_list so that it is better
to use int type.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 de
This patch removes unnecessary whitespace before a quoted newline found
by checkpatch
WARNING: unnecessary whitespace before a quoted newline
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 de
This patch fixes line over 80 characters found by checkpatch
WARNING: line over 80 characters
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wi
wid_cnt variable is used as indicating array index of struct wid_list.
This patch renames wid_cnt to i that makes more readability.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 184 +++---
1 file chang
commit 31cc9885e7c7 ("staging: wilc1000: handle_set_mac_address: use kmemdup")
introduces a new checkpatch warning, so this patch fixes it.
WARNING: Missing a blank line after declarations
FILE: drivers/staging/wilc1000/host_interface.c:430:
Signed-off-by: Chaehyun Lim <chaehyun.
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. It will be changed until all handle_*() function
has same variable name as ret.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 8
result variable gets value from wilc_send_config_pkt that has return
value of int. This patch changes data type of result variable to int.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 de
This patch uses netdev_err instead of PRINT_ER that is a custom debug
print.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/d
There is no need to print debug message when kmalloc is failed. This
message is redundant. The code already show us that kmalloc is failed.
The brace of if statement is remove as well due to have a single
statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/s
This patch replaces kmalloc followed by memcpy with kmemdup.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/s
When handle_set_mac_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes a brace of if statement due to
have a single statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.
This patch fix return error code of kmalloc as -ENOMEM instead of
-EFAULT.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/d
This patch renames pu8bssid to bssid to remove pu8 prefix in struct
user_conn_req. There is no need to use prefix to show data type of this
variable.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 30 +++---
d
This patch renames au8bssid to bssid to remove au8 prefix in struct
join_bss_param. There is no need to use prefix to show data type of this
variable.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions
This patch renames u8security to security to remove u8 prefix in struct
user_conn_req. There is no need to use prefix to show data type of this
variable.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wi
struct scan_info is defined as a new local variable in wilc_scan
function. It makes some assignment short as well as improve more
readability.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 31 ---
1 file c
This patch renames au8bssid to bssid to remove au8 prefix. There is no
need to use prefix to show data type of this variable.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/host_interface.h | 2 +-
2
This patch renames pu8ssid to ssid to remove pu8 prefix in struct
user_conn_req. There is no need to use prefix to show data type of this
variable.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 22 +++---
drivers/s
When handle_set_channel is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due
to have a single statement.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
d
result variable gets value from wilc_send_config_pkt that has
return value of int. This patch changes data type of result variable to
int.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 de
This patch renames s8rssi to rssi to remove s8 prefix in struct
found_net_info. There is no need to use prefix to show data type of this
variable.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
drivers/staging/wi
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt.
Some handle_*() function are used as result, others are used as ret.
It will start to rename as ret in all handle_*() function to sync up
with this variable name.
Signed-off-by: Chaehyun Lim <chaeh
This patch uses netdev_err instead of PRINT_ER that is a custom debug
print.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/d
counter is used as for-loop control variable and indicating index of
struct wid array so that it is better to use int type.
There is no need to set to 0 when it is declared at the top of this
function. It is initialized as 0 in for-loop statement.
Signed-off-by: Chaehyun Lim <chaeh
This patch renames the name of counter variable to i.
This change makes more readability because wilc_send_config_pkt has a
similar argument name as count.
Signed-off-by: Chaehyun Lim <chaehyun@gmail.com>
---
v2: rebase latest staging-testing
drivers/staging/wilc1000/wilc_wlan.
1 - 100 of 695 matches
Mail list logo
