On Wed, Feb 03, 2021 at 05:36:01PM +0300, Dan Carpenter wrote:
On Wed, Feb 03, 2021 at 09:45:51PM +0800, Coiby Xu wrote:
Hi Dan,
On Wed, Feb 03, 2021 at 12:42:50PM +0300, Dan Carpenter wrote:
> Hello Coiby Xu,
>
> The patch 953b94009377: "staging: qlge: Initialize devlink
(IS_ERR(priv->reporter))
netdev_warn(priv->ndev,
"Failed to create reporter, err = %ld\n",
- PTR_ERR(reporter));
+ PTR_ERR(priv->reporter));
}
--
2.29.2
Thanks for fixing this issue.
Revi
Hi Dan,
On Wed, Feb 03, 2021 at 12:42:50PM +0300, Dan Carpenter wrote:
Hello Coiby Xu,
The patch 953b94009377: "staging: qlge: Initialize devlink health
dump framework" from Jan 23, 2021, leads to the following static
checker warning:
drivers/staging/qlge/qlge_dev
devlink health could be used to get coredump. No need to send so much
data to the kernel ring buffer.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/TODO | 2 --
drivers/staging/qlge/qlge.h | 3 ---
drivers/staging/qlge/qlge_dbg.c | 11 ---
drivers/staging/qlge
With force_coredump module parameter set, devlink health dump will
reset the MPI RISC first which takes 5 secs to be finished.
Note that only NIC function that owns the firmware can do the
force_dumping. Otherwise devlink will receive an EPERM error.
Signed-off-by: Coiby Xu
---
drivers/staging
Instructions and examples on kernel data structures dumping and
coredump.
Signed-off-by: Coiby Xu
---
.../networking/device_drivers/index.rst | 1 +
.../device_drivers/qlogic/index.rst | 18 +++
.../networking/device_drivers/qlogic/qlge.rst | 118
related to the hardware (struct ql_adapter) can be obtained
by crash or drgn.
Link: https://lkml.org/lkml/2020/6/30/19
Suggested-by: Benjamin Poirier
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/TODO | 4 -
drivers/staging/qlge/qlge.h | 82
drivers/staging/qlge
},
...
"Sem Registers": {
"segment": 50,
"values": [ 0,0,0,0 ]
}
}
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_devlink.c | 132 ++--
1 file changed, 126 insertions(+), 6 deletions(-)
Stop calling ql_release_all in qlge_init_device and free things one step
at a time.
struct qlge_adapter *qdev is now a private structure of struct devlink
and memset is not necessary.
Link: https://lore.kernel.org/patchwork/patch/1321092/#1516928
Suggested-by: Dan Carpenter
Signed-off-by: Coiby
. The private data
of PCIe driver now points to qlge_adapter.
Since devlink_alloc will zero out struct qlge_adapter, memset in
qlge_init_device is not necessary.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Kconfig| 1 +
drivers/staging/qlge/Makefile | 2 +-
drivers/staging/qlge
ng-Hsi Yu]
- Remove stray newlines [Benjamin Poirier]
- force_coredump for devlink
- Remove mpi_core_to_log which will output the coredump to the kernel
ring buffer
- Put drgn script under Documentation [Benjamin Poirier]
- Rename qlge_health.* to qlge_devlink.*
Coiby Xu (8):
staging: qlge: us
Hi,
Thank you for testing this patch!
On Tue, Oct 20, 2020 at 06:27:41PM +0800, Shung-Hsi Yu wrote:
On Tue, Oct 20, 2020 at 04:57:11PM +0800, Shung-Hsi Yu wrote:
Hi,
This patch trigger the following KASAN error inside qlge_init_device().
[...] general protection fault, probably for
On Sun, Oct 18, 2020 at 08:02:53PM +0900, Benjamin Poirier wrote:
On 2020-10-17 07:16 +0800, Coiby Xu wrote:
On Thu, Oct 15, 2020 at 10:01:36AM +0900, Benjamin Poirier wrote:
> On 2020-10-14 18:43 +0800, Coiby Xu wrote:
> > To avoid namespace clashes with other qlogic drivers
On Thu, Oct 15, 2020 at 08:06:06PM +0900, Benjamin Poirier wrote:
On 2020-10-15 11:37 +0800, Coiby Xu wrote:
On Tue, Oct 13, 2020 at 09:37:04AM +0900, Benjamin Poirier wrote:
> On 2020-10-12 19:24 +0800, Coiby Xu wrote:
> [...]
> > > I think, but didn't check in depth, that i
On Thu, Oct 15, 2020 at 10:01:36AM +0900, Benjamin Poirier wrote:
On 2020-10-14 18:43 +0800, Coiby Xu wrote:
To avoid namespace clashes with other qlogic drivers and also for the
sake of naming consistency, use the "qlge_" prefix as suggested in
drivers/staging/qlge/TODO.
Instructions and examples on kernel data structures dumping and
coredump.
Signed-off-by: Coiby Xu
---
.../networking/device_drivers/index.rst | 1 +
.../device_drivers/qlogic/index.rst | 18 +++
.../networking/device_drivers/qlogic/qlge.rst | 118
related to the hardware (struct ql_adapter) can be obtained
by crash or drgn.
Link: https://lkml.org/lkml/2020/6/30/19
Suggested-by: Benjamin Poirier
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/TODO | 4 -
drivers/staging/qlge/qlge.h | 82
drivers/staging/qlge
devlink health could be used to get coredump. No need to send so much
data to the kernel ring buffer.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/TODO | 2 --
drivers/staging/qlge/qlge.h | 3 ---
drivers/staging/qlge/qlge_dbg.c | 11 ---
drivers/staging/qlge
With force_coredump module parameter set, devlink health dump will
reset the MPI RISC first which takes 5 secs to be finished.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_devlink.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/qlge/qlge_devlink.c
b
},
...
"Sem Registers": {
"segment": 50,
"values": [ 0,0,0,0 ]
}
}
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_devlink.c | 130 ++--
1 file changed, 124 insertions(+), 6 deletions(-)
Stop calling ql_release_all in qlge_init_device and free things one step
at a time.
Link: https://lore.kernel.org/patchwork/patch/1321092/#1516928
Suggested-by: Dan Carpenter
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 32
1 file changed, 20
. The private data
of PCIe driver now points to qlge_adapter.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Kconfig| 1 +
drivers/staging/qlge/Makefile | 2 +-
drivers/staging/qlge/qlge.h | 13 +++
drivers/staging/qlge/qlge_devlink.c | 31 +++
drivers/staging/qlge
mp when the interface is down [Shung-Hsi Yu]
- Remove stray newlines [Benjamin Poirier]
- force_coredump for devlink
- Remove mpi_core_to_log which will output the coredump to the kernel
ring buffer
- Put drgn script under Documentation [Benjamin Poirier]
- Rename qlge_health.* to qlge
On Thu, Oct 15, 2020 at 12:26:28PM +0800, Coiby Xu wrote:
On Thu, Oct 15, 2020 at 10:01:36AM +0900, Benjamin Poirier wrote:
On 2020-10-14 18:43 +0800, Coiby Xu wrote:
To avoid namespace clashes with other qlogic drivers and also for the
sake of naming consistency, use the "qlge_&qu
On Thu, Oct 15, 2020 at 10:01:36AM +0900, Benjamin Poirier wrote:
On 2020-10-14 18:43 +0800, Coiby Xu wrote:
To avoid namespace clashes with other qlogic drivers and also for the
sake of naming consistency, use the "qlge_" prefix as suggested in
drivers/staging/qlge/TODO.
On Wed, Oct 14, 2020 at 04:08:46PM +0300, Dan Carpenter wrote:
On Wed, Oct 14, 2020 at 06:43:01PM +0800, Coiby Xu wrote:
static int qlge_probe(struct pci_dev *pdev,
const struct pci_device_id *pci_entry)
{
struct net_device *ndev = NULL;
struct
On Tue, Oct 13, 2020 at 09:37:04AM +0900, Benjamin Poirier wrote:
On 2020-10-12 19:24 +0800, Coiby Xu wrote:
[...]
> I think, but didn't check in depth, that in those drivers, the devlink
> device is tied to the pci device and can exist independently of the
> netdev, at least in
With force_coredump module parameter set, devlink health dump will
reset the MPI RISC first which takes 5 secs to be finished.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_devlink.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/qlge/qlge_devlink.c
b
related to the hardware (struct ql_adapter) can be obtained
by crash or drgn.
Suggested-by: Benjamin Poirier
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/TODO | 4 -
drivers/staging/qlge/qlge.h | 82
drivers/staging/qlge/qlge_dbg.c | 688
devlink health could be used to get coredump. No need to send so much
data to the kernel ring buffer.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/TODO | 2 --
drivers/staging/qlge/qlge.h | 3 ---
drivers/staging/qlge/qlge_dbg.c | 11 ---
drivers/staging/qlge
},
...
"Sem Registers": {
"segment": 50,
"values": [ 0,0,0,0 ]
}
}
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_devlink.c | 130 ++--
1 file changed, 124 insertions(+), 6 deletions(-)
is down [Shung-Hsi Yu]
- Remove stray newlines [Benjamin Poirier]
- force_coredump for devlink
- Remove mpi_core_to_log which will output the coredump to the kernel
ring buffer
- Put drgn script under Documentation [Benjamin Poirier]
- Rename qlge_health.* to qlge_devlink.*
Coiby Xu (7):
staging: qlge:
-off-by: Coiby Xu
---
drivers/staging/qlge/Kconfig| 1 +
drivers/staging/qlge/Makefile | 2 +-
drivers/staging/qlge/qlge.h | 5 +++
drivers/staging/qlge/qlge_devlink.c | 31 +++
drivers/staging/qlge/qlge_devlink.h | 9 ++
drivers/staging/qlge/qlge_main.c
Instructions and examples on kernel data structures dumping and
coredump.
Signed-off-by: Coiby Xu
---
.../networking/device_drivers/index.rst | 1 +
.../device_drivers/qlogic/index.rst | 18 +++
.../networking/device_drivers/qlogic/qlge.rst | 118
On Sat, Oct 10, 2020 at 10:22:30PM +0900, Benjamin Poirier wrote:
On 2020-10-10 18:02 +0800, Coiby Xu wrote:
[...]
> > + do { \
> > + err = fill_seg_(fmsg, >seg_hdr, dump->seg_regs); \
> &g
On Sat, Oct 10, 2020 at 10:40:55PM +0900, Benjamin Poirier wrote:
On 2020-10-10 18:00 +0800, Coiby Xu wrote:
[...]
>
> Please also update drivers/staging/qlge/TODO accordingly. There is still
> a lot of debugging code IMO (the netif_printk statements - kernel
> tracing can be
On Sat, Oct 10, 2020 at 10:48:55PM +0900, Benjamin Poirier wrote:
On 2020-10-10 18:24 +0800, Coiby Xu wrote:
On Sat, Oct 10, 2020 at 04:35:14PM +0900, Benjamin Poirier wrote:
> On 2020-10-08 19:58 +0800, Coiby Xu wrote:
> > Initialize devlink health dump framework for the dlge
On Thu, Oct 08, 2020 at 08:22:44AM -0400, Willem de Bruijn wrote:
On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote:
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
@@ -4556,6 +4559,13 @@ static int qlge_probe
On Sat, Oct 10, 2020 at 04:35:14PM +0900, Benjamin Poirier wrote:
On 2020-10-08 19:58 +0800, Coiby Xu wrote:
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Kconfig| 1 +
drivers
On Sat, Oct 10, 2020 at 04:48:09PM +0900, Benjamin Poirier wrote:
On 2020-10-08 19:58 +0800, Coiby Xu wrote:
$ devlink health dump show DEVICE reporter coredump -p -j
{
"Core Registers": {
"segment": 1,
On Sat, Oct 10, 2020 at 05:01:26PM +0900, Benjamin Poirier wrote:
On 2020-10-08 19:58 +0800, Coiby Xu wrote:
The debugging code in the following ifdef land
- QL_ALL_DUMP
- QL_REG_DUMP
- QL_DEV_DUMP
- QL_CB_DUMP
- QL_IB_DUMP
- QL_OB_DUMP
becomes unnecessary because,
- Device status
On Thu, Oct 08, 2020 at 04:39:40PM +0300, Dan Carpenter wrote:
On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote:
-static int
-qlge_reporter_coredump(struct devlink_health_reporter *reporter,
- struct devlink_fmsg *fmsg, void *priv_ctx
On Thu, Oct 08, 2020 at 04:31:42PM +0300, Dan Carpenter wrote:
On Thu, Oct 08, 2020 at 07:58:03PM +0800, Coiby Xu wrote:
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Kconfig
On Thu, Oct 08, 2020 at 08:22:44AM -0400, Willem de Bruijn wrote:
On Thu, Oct 8, 2020 at 7:58 AM Coiby Xu wrote:
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
@@ -4556,6 +4559,13 @@ static int qlge_probe
related to the hardware (struct ql_adapter) can be obtained
by crash or drgn.
Suggested-by: Benjamin Poirier
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge.h | 82
drivers/staging/qlge/qlge_dbg.c | 688
drivers/staging/qlge/qlge_ethtool.c
},
...
"Sem Registers": {
"segment": 50,
"values": [ 0,0,0,0 ]
}
}
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_devlink.c | 131 ++--
1 file changed, 125 insertions(+), 6 deletions(-)
Instructions and examples on kernel data structures dumping and coredump.
Signed-off-by: Coiby Xu
---
.../networking/device_drivers/index.rst | 1 +
.../device_drivers/qlogic/index.rst | 18 +++
.../networking/device_drivers/qlogic/qlge.rst | 118
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Kconfig| 1 +
drivers/staging/qlge/Makefile | 2 +-
drivers/staging/qlge/qlge.h | 9 +++
drivers/staging/qlge
- Rename qlge_health.* to qlge_devlink.*
Coiby Xu (6):
staging: qlge: Initialize devlink health dump framework for the dlge
driver
staging: qlge: coredump via devlink health reporter
staging: qlge: support force_coredump option for devlink health dump
staging: qlge: remove mpi_core_to_lo
With force_coredump module paramter set, devlink health dump will reset
the MPI RISC first which takes 5 secs to be finished.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_devlink.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/qlge/qlge_devlink.c
b/drivers
devlink health could be used to get coredump. No need to send so much
data to the kernel ring buffer.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge.h | 3 ---
drivers/staging/qlge/qlge_dbg.c | 11 ---
drivers/staging/qlge/qlge_ethtool.c | 1 -
drivers/staging/qlge
On Tue, Oct 06, 2020 at 12:47:37AM +0530, Vaibhav Agarwal wrote:
On Sat, Oct 3, 2020 at 5:01 AM Coiby Xu wrote:
This patch fix the following warnings from sparse,
$ make C=2 drivers/staging/greybus/
drivers/staging/greybus/audio_module.c:222:25: warning: incorrect type in
assignment
On Fri, Aug 21, 2020 at 11:08:22AM +0800, Coiby Xu wrote:
On Sun, Aug 16, 2020 at 11:56:40AM +0900, Benjamin Poirier wrote:
On 2020-08-15 00:05 +0800, Coiby Xu wrote:
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby
On Sat, Oct 03, 2020 at 02:53:48PM +0900, Benjamin Poirier wrote:
On 2020-10-03 07:59 +0800, Coiby Xu wrote:
This fixes commit 0107635e15ac
("staging: qlge: replace pr_err with netdev_err") which introduced an
build breakage of missing `struct ql_adapter *qdev` for some functions
and
)
Reported-by: Benjamin Poirier
Suggested-by: Benjamin Poirier
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge.h | 20 ++--
drivers/staging/qlge/qlge_dbg.c | 28 ++--
drivers/staging/qlge/qlge_main.c | 8
3 files changed, 32 insertions(
(different base types)
drivers/staging/greybus/audio_topology.c:889:25:expected unsigned int access
drivers/staging/greybus/audio_topology.c:889:25:got restricted __le32
[usertype] access
Suggested-by: Dan Carpenter
Reviewed-by: Dan Carpenter
Reviewed-by: Alex Elder
Signed-off-by: Coiby Xu
m_format_t [usertype]
Reviewed-by: Alex Elder
Signed-off-by: Coiby Xu
---
drivers/staging/greybus/audio_codec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c
b/drivers/staging/greybus/audio_codec.c
index 74538f8c5fa4..494aa823e
ted-by: Alex Elder
Signed-off-by: Coiby Xu
---
drivers/staging/greybus/audio_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_topology.c
b/drivers/staging/greybus/audio_topology.c
index 2091031659de..662e3e8b4b63 100644
--- a/drivers/stag
On Fri, Sep 25, 2020 at 10:57:27AM -0500, Alex Elder wrote:
On 9/25/20 9:07 AM, Coiby Xu wrote:
On Thu, Sep 24, 2020 at 01:00:57PM +0200, Greg Kroah-Hartman wrote:
On Thu, Sep 24, 2020 at 06:20:39PM +0800, Coiby Xu wrote:
Use __8 to replace int and remove the unnecessary __bitwise type
On Fri, Sep 25, 2020 at 11:02:23AM -0500, Alex Elder wrote:
On 9/25/20 9:11 AM, Coiby Xu wrote:
On Thu, Sep 24, 2020 at 10:54:50AM +, David Laight wrote:
From: Coiby Xu
Sent: 24 September 2020 11:21
Use __8 to replace int and remove the unnecessary __bitwise type
attribute.
Found
On Thu, Sep 24, 2020 at 10:54:50AM +, David Laight wrote:
From: Coiby Xu
Sent: 24 September 2020 11:21
Use __8 to replace int and remove the unnecessary __bitwise type attribute.
Found by sparse,
...
diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
index
On Thu, Sep 24, 2020 at 07:50:57AM -0500, Alex Elder wrote:
On 9/24/20 5:20 AM, Coiby Xu wrote:
This patch fix the following warnings from sparse,
You need to address Greg's comment.
But in general this looks good. I have one comment below, which
you can address in v2. If you (or others
On Thu, Sep 24, 2020 at 01:00:57PM +0200, Greg Kroah-Hartman wrote:
On Thu, Sep 24, 2020 at 06:20:39PM +0800, Coiby Xu wrote:
Use __8 to replace int and remove the unnecessary __bitwise type attribute.
Found by sparse,
$ make C=2 drivers/staging/greybus/
drivers/staging/greybus
snd_ctl_elem_iface_t degrades to integer
drivers/staging/greybus/audio_topology.c:906:14: warning: restricted
snd_ctl_elem_iface_t degrades to integer
Signed-off-by: Coiby Xu
---
drivers/staging/greybus/audio_topology.c | 2 +-
include/uapi/sound/asound.h | 4 ++--
2 files changed
m_format_t [usertype]
Signed-off-by: Coiby Xu
---
drivers/staging/greybus/audio_codec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c
b/drivers/staging/greybus/audio_codec.c
index 74538f8c5fa4..494aa823e998 100644
--- a/drivers/stagi
(different base types)
drivers/staging/greybus/audio_topology.c:889:25:expected unsigned int access
drivers/staging/greybus/audio_topology.c:889:25:got restricted __le32
[usertype] access
Suggested-by: Dan Carpenter
Reviewed-by: Dan Carpenter
Signed-off-by: Coiby Xu
---
drivers/staging
On Mon, Aug 24, 2020 at 12:41:48PM +0300, Dan Carpenter wrote:
On Mon, Aug 24, 2020 at 10:50:59AM +0800, Coiby Xu wrote:
This patch fix the following warnings from sparse,
$ make C=2 drivers/staging/greybus/
drivers/staging/greybus/audio_codec.c:691:36: warning: incorrect type in
initializer
On Thu, Sep 03, 2020 at 12:49:18PM +0900, Benjamin Poirier wrote:
On 2020-09-02 22:00 +0800, Coiby Xu wrote:
This fixes commit 0107635e15ac
("staging: qlge: replace pr_err with netdev_err") which introduced an
build breakage of missing `struct ql_adapter *qdev` for some functions
and
On Thu, Aug 27, 2020 at 09:50:10AM +0900, Benjamin Poirier wrote:
On 2020-08-27 07:27 +0800, Coiby Xu wrote:
This fixes commit 0107635e15ac
("staging: qlge: replace pr_err with netdev_err") which introduced an
build breakage of missing `struct ql_adapter *qdev` for some functions
and
5 |"%s: Routing Mask %d = 0x%.08x\n",
| ^
| |
| unsigned int
Fixes: 0107635e15ac ("staging: qlge: replace pr_err with netdev_err")
Reported-by: Benjamin Poirier
Suggested-by: Benjamin Poirier
Signed-off-by: Coiby Xu
---
drivers/stag
5 |"%s: Routing Mask %d = 0x%.08x\n",
| ^
| |
| unsigned int
Fixes: 0107635e15ac ("staging: qlge: replace pr_err with netdev_err")
Reported-by: Benjamin Poirier
Suggested-by: Benjamin Poirier
Signed-off-by: Coiby Xu
---
drivers/stag
On Fri, Aug 21, 2020 at 05:31:59PM +0900, Benjamin Poirier wrote:
On 2020-08-21 15:03 +0800, Coiby Xu wrote:
This fixes commit 0107635e15ac
("staging: qlge: replace pr_err with netdev_err") which introduced an
build breakage with dumping enabled, i.e.,
$ QL_ALL_DUMP=1 QL
(different base types)
drivers/staging/greybus/audio_topology.c:889:25:expected unsigned int access
drivers/staging/greybus/audio_topology.c:889:25:got restricted __le32
[usertype] access
Signed-off-by: Coiby Xu
---
drivers/staging/greybus/audio_codec.c| 4 ++--
drivers/staging/greybus
c ("taging: qlge: replace pr_err with netdev_err")
Reported-by: Benjamin Poirier
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge.h | 42
drivers/staging/qlge/qlge_dbg.c | 36 +--
drivers/staging/qlge/qlge_main.c | 4
On Sun, Aug 16, 2020 at 11:57:17AM +0900, Benjamin Poirier wrote:
On 2020-08-15 00:06 +0800, Coiby Xu wrote:
The related code are not necessary because,
- Device status and general registers can be obtained by ethtool.
- Coredump can be done via devlink health reporter.
- Structure related
On Sun, Aug 16, 2020 at 11:56:40AM +0900, Benjamin Poirier wrote:
On 2020-08-15 00:05 +0800, Coiby Xu wrote:
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Makefile | 2 +-
drivers
The related code are not necessary because,
- Device status and general registers can be obtained by ethtool.
- Coredump can be done via devlink health reporter.
- Structure related to the hardware (struct ql_adapter) can be obtained
by crash or drgn.
Signed-off-by: Coiby Xu
---
drivers
},
...
"Sem Registers": {
"segment": 50,
"values": [ 0,0,0,0 ]
}
}
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_health.c | 125 +++--
1 file changed, 119 insertions(+), 6 deletions(-)
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Makefile | 2 +-
drivers/staging/qlge/qlge.h| 9 +++
drivers/staging/qlge/qlge_health.c | 43
On Mon, Jun 29, 2020 at 02:30:04PM +0900, Benjamin Poirier wrote:
On 2020-06-27 22:58 +0800, Coiby Xu wrote:
[...]
void ql_dump_qdev(struct ql_adapter *qdev)
{
@@ -1611,99 +1618,100 @@ void ql_dump_qdev(struct ql_adapter *qdev)
#ifdef QL_CB_DUMP
void ql_dump_wqicb(struct wqicb *wqicb
On Sat, Jun 27, 2020 at 12:47:08PM +0200, Greg Kroah-Hartman wrote:
On Sat, Jun 27, 2020 at 06:14:44PM +0800, Coiby Xu wrote:
Remove trailing "*/" in block comments.
Signed-off-by: Coiby Xu
The subject lines of all of your patches should match other patches for
this driver. It s
Replace all pr_errs with netdev_err.
Suggested-by: Joe Perches
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 568
1 file changed, 289 insertions(+), 279 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
and a bug about releasing lock.
Coiby Xu (4):
fix trailing */ in block comment
fix else after return or break
fix ql_sem_unlock
replace pr_err with netdev_err
drivers/staging/qlge/qlge_dbg.c | 583 ---
drivers/staging/qlge/qlge_main.c | 11 +-
drivers/st
Remove trailing "*/" in block comments.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 3 ++-
drivers/staging/qlge/qlge_mpi.c | 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/q
Remove unnecessary elses after return or break.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 23 ++-
drivers/staging/qlge/qlge_main.c | 8
drivers/staging/qlge/qlge_mpi.c | 4 ++--
3 files changed, 16 insertions(+), 19 deletions(-)
diff --git
Some functions return without releasing the lock. Replace return with
break.
Suggested-by Dan Carpenter .
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge
On Fri, Jun 26, 2020 at 05:06:33PM -0700, Joe Perches wrote:
On Sat, 2020-06-27 at 07:57 +0800, Coiby Xu wrote:
On Thu, Jun 25, 2020 at 03:13:14PM -0700, Joe Perches wrote:
> On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote:
> > Remove unnecessary elses after return or break.
>
Remove trailing "*/" in block comments.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 3 ++-
drivers/staging/qlge/qlge_mpi.c | 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/q
These patches fix three coding style problems for all files under
drivers/staging/qlge,
- trailing */ in block comment
- unnecessary else after return or break
- pr_err preferred over netdev_err
and a bug about releasing lock.
Coiby Xu (4):
fix trailing */ in block comment
fix
Replace all pr_errs with netdev_err.
Suggested-by: Joe Perches
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 568
1 file changed, 289 insertions(+), 279 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
Remove unnecessary elses after return or break.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 23 ++-
drivers/staging/qlge/qlge_main.c | 8
drivers/staging/qlge/qlge_mpi.c | 4 ++--
3 files changed, 16 insertions(+), 19 deletions(-)
diff --git
Some functions return without releasing the lock. Replace return with
break.
Suggested-by Dan Carpenter .
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge
On Thu, Jun 25, 2020 at 03:13:14PM -0700, Joe Perches wrote:
On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote:
Remove unnecessary elses after return or break.
unrelated trivia:
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
[]
@@ -1391,12 +1391,11
On Thu, Jun 25, 2020 at 03:13:14PM -0700, Joe Perches wrote:
On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote:
Remove unnecessary elses after return or break.
unrelated trivia:
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
[]
@@ -1391,12 +1391,11
On Fri, Jun 26, 2020 at 11:34:36AM +0300, Dan Carpenter wrote:
On Fri, Jun 26, 2020 at 05:57:55AM +0800, Coiby Xu wrote:
@@ -1404,11 +1403,10 @@ static void ql_dump_cam_entries(struct ql_adapter *qdev)
pr_err("%s: Failed read of mac index regis
On Thu, Jun 25, 2020 at 08:25:10PM +0300, Dan Carpenter wrote:
The subject isn't right (no subsystem prefix) and we need a commit
message.
regards,
dan carpenter
Thank you for pointing out the exact problems!
--
Best regards,
Coiby
___
devel
Remove trailing "*/" in block comments.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 3 ++-
drivers/staging/qlge/qlge_mpi.c | 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/q
Remove unnecessary elses after return or break.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_dbg.c | 23 ++-
drivers/staging/qlge/qlge_main.c | 8
drivers/staging/qlge/qlge_mpi.c | 4 ++--
3 files changed, 16 insertions(+), 19 deletions(-)
diff --git
These two patches fix two coding style problems for all files under
drivers/staging/qlge as reported by checkpatch.pl,
- trailing */ in block comment
- unnecessary else after return or break
Coiby Xu (2):
fix trailing */ in block comment
fix else after return or break
drivers
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/qlge_main.c | 3 ++-
drivers/staging/qlge/qlge_mpi.c | 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 1650de13842f..aaecf2b0f9a1 100644
1 - 100 of 102 matches
Mail list logo
