[PATCH v3 3/5] staging: iio: adc: ad7280a: Avoid precedence issues in macro

2019-03-24 Thread Cristian Sicilia
Enclosing parameter with parenthesis due to avoid possible precedence issue. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c

[PATCH v3 5/5] staging: iio: adc: ad7280a: Remove CamelCase notation

2019-03-24 Thread Cristian Sicilia
Fix CamelCase naming. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 4ff28f1..229dcad 100644 --- a/drivers/staging

[PATCH v3 2/5] staging: iio: adc: ad7192: Converted bool to bitfield format

2019-03-24 Thread Cristian Sicilia
Changed bool format to bitfield format to save space. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7192.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/iio/adc/ad7192.h b/drivers/staging/iio/adc/ad7192.h index 7433a43

[PATCH v2 0/5] staging: iio: adc: Code refactoring and bool to bitfield change

2019-03-24 Thread Cristian Sicilia
Some source refactoring, parameters alignment and camel case clearing. Replacement of bool to bitfield in a struct, but not found the population to check if it is done correctly. Cristian Sicilia (5): staging: iio: adc: ad7280a: Tab alignment staging: iio: adc: ad7192: Converted bool

[PATCH v3 4/5] staging: iio: adc: ad7280a: Adding temp var to improve readability

2019-03-24 Thread Cristian Sicilia
Creating a temporary variable to improve readability Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 55 ++- 1 file changed, 25 insertions(+), 30 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc

[PATCH v3 1/5] staging: iio: adc: ad7280a: Tab alignment

2019-03-24 Thread Cristian Sicilia
Aligned some parameters. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index d9df126..571535d

Re: [PATCH v2 1/5] staging: iio: adc: Tab alignment

2019-03-24 Thread Cristian Sicilia
On Sun, Mar 24, 2019 at 12:35:52PM +, Jonathan Cameron wrote: > On Sat, 23 Mar 2019 20:21:36 +0100 > Cristian Sicilia wrote: > > > Aligned some parameters. > > > > Signed-off-by: Cristian Sicilia > > --- > > drivers/staging/iio/adc/ad7280a.c | 36

[PATCH v2 1/5] staging: iio: adc: Tab alignment

2019-03-23 Thread Cristian Sicilia
Aligned some parameters. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index d9df126..55b5879

[PATCH v2 4/5] staging: iio: adc: Adding temp var to improve readability

2019-03-23 Thread Cristian Sicilia
Creating a temporary variable to improve readability Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 55 ++- 1 file changed, 25 insertions(+), 30 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc

[PATCH v2 3/5] staging: iio: adc: Avoid precedence issues in macro

2019-03-23 Thread Cristian Sicilia
Enclosing parameter with parenthesis due to avoid possible precedence issue. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c

[PATCH v2 5/5] staging: iio: adc: Remove CamelCase notation

2019-03-23 Thread Cristian Sicilia
Fix CamelCase naming. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 5d848aa..c02454c 100644 --- a/drivers/staging

[PATCH v2 0/5] staging: iio: adc: Code refactoring and bool to bitfield change

2019-03-23 Thread Cristian Sicilia
Some source refactoring, parameters alignment and camel case clearing. Replacement of bool to bitfield in a struct, but not found the population to check if it is done correctly. Cristian Sicilia (5): staging: iio: adc: Tab alignment staging: iio: adc: Converted bool to bitfield format

[PATCH v2 2/5] staging: iio: adc: Converted bool to bitfield format

2019-03-23 Thread Cristian Sicilia
Changed bool format to bitfield format to save space. Signed-off-by: Cristian Sicilia --- The strange thing is that this struct seems not populated using a DTS binding function. --- drivers/staging/iio/adc/ad7192.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 1/5] staging: iio: adc: Tab alignment

2019-03-23 Thread Cristian Sicilia
Aligned some parameters. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index d9df126..55b5879

[PATCH 5/5] staging: iio: adc: Remove CamelCase notation

2019-03-23 Thread Cristian Sicilia
Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 5d848aa..c02454c 100644 --- a/drivers/staging/iio/adc/ad7280a.c +++ b

[PATCH 2/5] staging: iio: adc: Converted bool to bitfield format

2019-03-23 Thread Cristian Sicilia
Changed bool format to bitfield format to save space. Signed-off-by: Cristian Sicilia --- The strange thing is that this struct seems not populated using a DTS binding function. --- drivers/staging/iio/adc/ad7192.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 4/5] staging: iio: adc: Adding temp var to improve readability

2019-03-23 Thread Cristian Sicilia
Creating a temporary variable to improve readability Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 55 ++- 1 file changed, 25 insertions(+), 30 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc

[PATCH 3/5] staging: iio: adc: Avoid precedence issues in macro

2019-03-23 Thread Cristian Sicilia
Enclosing parameter with parenthesis due to avoid possible precedence issue. Signed-off-by: Cristian Sicilia --- drivers/staging/iio/adc/ad7280a.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c

[PATCH 0/5] *** SUBJECT HERE ***

2019-03-23 Thread Cristian Sicilia
Some source refactoring, parameters aligment and camel case clearing. Replacement of bool to bitfield in a struct, but not found the population to check if it is done correctly. Cristian Sicilia (5): staging: iio: adc: Tab alignment staging: iio: adc: Converted bool to bitfield format

[PATCH 1/2] staging: greybus: Align function call parameters to parenthesis

2018-12-04 Thread Cristian Sicilia
Aligned some parameters to the previous parenthesis. Signed-off-by: Cristian Sicilia --- drivers/staging/greybus/loopback.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index e4d42c1

[PATCH 0/2] staging: greybus: Fix parameters alignment and strings concatenation

2018-12-04 Thread Cristian Sicilia
First patch align some parameters with parenthesis. Second patch will add some spaces between string. Cristian Sicilia (2): staging: greybus: Align function call parameters to parenthesis staging: greybus: Added space between string concatenated drivers/staging/greybus/loopback.c | 16

[PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-04 Thread Cristian Sicilia
Some concatenated strings are now spaced. Signed-off-by: Cristian Sicilia --- drivers/staging/greybus/loopback.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index 1085e06..acfa392 100644

[PATCH 2/2] staging: emxx_udc: Remove cast and move all in one line.

2018-11-27 Thread Cristian Sicilia
Remove the cast from IO_ADDRESS and use a single line. Signed-off-by: Cristian Sicilia --- As suggested by Dan we can just remove the cast and use an unique line. drivers/staging/emxx_udc/emxx_udc.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 1/2] staging: emxx_udc: Align parameter with parenthesis

2018-11-27 Thread Cristian Sicilia
Align parameters with parenthesis and removed open parenthesis at the end of line. Signed-off-by: Cristian Sicilia --- drivers/staging/emxx_udc/emxx_udc.c | 270 ++-- 1 file changed, 107 insertions(+), 163 deletions(-) diff --git a/drivers/staging/emxx_udc

[PATCH 0/2] Parenthesis fix

2018-11-27 Thread Cristian Sicilia
In the first patch there is a fix of some parenthesis that terminate on end of line and some parameters that are not aligned with previous parenthesis. The second patch is a proposal that avoid the long line refactoring code removing cast pointer. Cristian Sicilia (2): staging: emxx_udc

[PATCH 1/2] staging: emxx_udc: Align parameter with parenthesis

2018-11-26 Thread Cristian Sicilia
Align parameters with parenthesis and removed open parenthesis at the end of line. Signed-off-by: Cristian Sicilia --- drivers/staging/emxx_udc/emxx_udc.c | 270 ++-- 1 file changed, 107 insertions(+), 163 deletions(-) diff --git a/drivers/staging/emxx_udc

[PATCH 2/2] staging: emxx_udc: Added a temporary variable with address.

2018-11-26 Thread Cristian Sicilia
Replace the IO_ADDRESS call with a temporary variable. Signed-off-by: Cristian Sicilia --- drivers/staging/emxx_udc/emxx_udc.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index

[PATCH 0/2] Parenthesis fix and temp vars

2018-11-26 Thread Cristian Sicilia
on next line. Cristian Sicilia (2): staging: emxx_udc: Align parameter with parenthesis staging: emxx_udc: Added a temporary variable with address. drivers/staging/emxx_udc/emxx_udc.c | 288 +++- 1 file changed, 117 insertions(+), 171 deletions(-) -- 2.7.4

[PATCH 2/2] staging: emxx_udc: Fixing function naming

2018-11-16 Thread Cristian Sicilia
Fix function naming and parenthesis. Signed-off-by: Cristian Sicilia --- drivers/staging/emxx_udc/emxx_udc.c | 212 1 file changed, 70 insertions(+), 142 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c

[PATCH 1/2] staging: emxx_udc: Split line and fix eol parenthesis

2018-11-16 Thread Cristian Sicilia
Fix some parenthesis opened at end of line. Signed-off-by: Cristian Sicilia --- drivers/staging/emxx_udc/emxx_udc.c | 73 ++--- 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc

[PATCH 0/2] Split line, fix eol parenthesis and fix functions

2018-11-16 Thread Cristian Sicilia
;epnum - 1].EP_STATUS); The second patch try to fix the function, removing the parenthesis at end of line, and add new line only if needed (over 80 chars) Cristian Sicilia (2): staging: emxx_udc: Split line and fix eol parenthesis staging: emxx_udc: Fixing function naming drivers/staging/em

[PATCH] staging: axis-fifo: Split line to stay in 80 characters.

2018-11-16 Thread Cristian Sicilia
The line is split up to stay in 80 characters- Signed-off-by: Cristian Sicilia --- drivers/staging/axis-fifo/axis-fifo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index c18bf31..805437f

[PATCH v2 2/2] staging: rtlwifi: Add new line to stay in 80 characters

2018-11-13 Thread Cristian Sicilia
The parameter is sent to next line to stay in 80 characters Signed-off-by: Cristian Sicilia --- drivers/staging/rtlwifi/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c index ca37f75..a990281 100644

[PATCH v2 1/2] staging: rtlwifi: Add spaces to match open parenthesis

2018-11-13 Thread Cristian Sicilia
Added before parameters some spaces to match open parenthesis on previous line. Signed-off-by: Cristian Sicilia --- drivers/staging/rtlwifi/ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtlwifi/ps.c b/drivers/staging/rtlwifi/ps.c index 0ca0532

[PATCH v2 0/2] Aligh parenthesis and split lines

2018-11-13 Thread Cristian Sicilia
In the first patch I added some space to align previous parenthesis. In the second patch split a line to stay in 80 characters. Cristian Sicilia (2): staging: rtlwifi: Add spaces to match open parenthesis staging: rtlwifi: Add new line to stay in 80 characters drivers/staging/rtlwifi/core.c

[PATCH 1/1] staging: rtlwifi: Add new line to stay in 80 characters

2018-11-12 Thread Cristian Sicilia
The parameter is sent to next line to stay in 80 characters Signed-off-by: Cristian Sicilia --- drivers/staging/rtlwifi/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c index ca37f75..a990281 100644

[PATCH 1/1] staging: rtlwifi: Add spaces to match open parenthesis

2018-11-12 Thread Cristian Sicilia
Added before parameters some spaces to match open parenthesis on previous line. Signed-off-by: Cristian Sicilia --- drivers/staging/rtlwifi/ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtlwifi/ps.c b/drivers/staging/rtlwifi/ps.c index 0ca0532

[PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL.

2018-11-12 Thread Cristian Sicilia
Replace equal to NULL with logic unary operator, and removing not equal to NULL comparison. Signed-off-by: Cristian Sicilia --- drivers/staging/erofs/unzip_vle.c | 86 +++ 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/erofs

[PATCH 2/3] staging: erofs: unzip_vle.c: Constant in comparison on right side

2018-11-12 Thread Cristian Sicilia
Comparisons should place the constant on the right side of the test. Signed-off-by: Cristian Sicilia --- drivers/staging/erofs/unzip_vle.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c index

[PATCH 0/3] Clean up some syntax issue on unzip_vle.c

2018-11-12 Thread Cristian Sicilia
parenthesis. Cristian Sicilia (3): staging: erofs: unzip_vle.c: Replace comparison to NULL. staging: erofs: unzip_vle.c: Constant in comparison on right side staging: erofs: unzip_vle.c: Align parameter to the parentesis drivers/staging/erofs/unzip_vle.c | 105

[PATCH 3/3] staging: erofs: unzip_vle.c: Align parameter to the parentesis

2018-11-12 Thread Cristian Sicilia
Align parameters to the opened parentesis. Signed-off-by: Cristian Sicilia --- drivers/staging/erofs/unzip_vle.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c index 35add4e..6a283f6 100644