[PATCH v3] Staging: rtl8192e: Timer setup using macro rather assignment

From: Gnanachandran Dhanapal This patch shall replaces user defined timer setup function with standard timer setup macro. Also removes init_timer, because timer can be initialized in setup_timer macro as well. Signed-off-by: Gnanachandran Dhanapal --- v3: From name and Signed-Off-by

Re: [PATCH v2] Staging: rtl8192e: Timer setup using macro rather assignment

On Tue, Jun 16, 2015 at 12:00:28PM +0530, Sudip Mukherjee wrote: > On Mon, Jun 15, 2015 at 03:00:34PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote: > > This patch shall replaces user defined timer setup function with > > standard timer setup macro. Also removes init_timer, because t

[PATCH v2] Staging: rtl8192e: Timer setup using macro rather assignment

This patch shall replaces user defined timer setup function with standard timer setup macro. Also removes init_timer, because timer can be initialized in setup_timer macro as well. Signed-off-by: Gnanachandran Dhanapal --- Addressed review comments from v1 1. setup_timer also subs

[PATCH v5] Staging: rtl8192e: Casting correct Endianness

From: Gnanachandran Dhanapal Casting correct Endianness for __le16 variable used in assignment and condition check Signed-off-by: Gnanachandran Dhanapal --- v5: Following review comments given addressed Blank line in the wrong spot. - v4 the blank line before variab

[PATCH v4] Staging: rtl8192e: Casting correct Endianness

From: Gnanachandran Dhanapal Casting correct Endianness for __le16 variable used in assignment and condition check Signed-off-by: Gnanachandran Dhanapal --- v4: Greg review comments addressed --- drivers/staging/rtl8192e/rtllib_softmac.c | 13 + 1 file changed, 9 insertions(+),

[PATCH v3] Staging: rtl8192e: Casting correct Endianness

From: Gnanachandran Dhanapal Casting correct Endianness for __le16 variable used in assignment and condition check Signed-off-by: Gnanachandran Dhanapal --- v3: Greg review comments addressed --- drivers/staging/rtl8192e/rtllib_softmac.c | 14 ++ 1 file changed, 10 insertions(+)

[PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

setup_timer is used for timer parameter setup rather than direct assignment Signed-off-by: Gnanachandran Dhanapal --- drivers/staging/rtl8192e/rtllib_module.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8

[PATCHv2] Staging: rtl8192e: Casting correct Endianness

Casting correct Endianness for __le16 variable used in assignment and condition check. Signed-off-by: Gnanachandran Dhanapal --- v2:Since previous version of the patch had build error.This version has no build warnings and error. --- drivers/staging/rtl8192e/rtllib_softmac.c | 14 +

Re: [PATCH] Staging: rtl8192e: Casting correct Endianness

On Tue, May 12, 2015 at 08:41:05AM +, Dan Carpenter wrote: > On Tue, May 12, 2015 at 07:38:48AM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote: > > @@ -2235,7 +2235,7 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device > > *ieee, struct sk_buff *skb, > > struct rtl

[PATCH] Staging: rtl8192e: Casting correct Endianness

Casting correct Endianness for __le16 variable used in assignment and condition check. Signed-off-by: Gnanachandran Dhanapal --- drivers/staging/rtl8192e/rtllib_softmac.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/d

[PATCH] Staging: dgnc: Replace snprintf instead of sprintf

This patch replaces snprintf instead of sprintf to avoid buffer overflow Signed-off-by: Gnanachandran Dhanapal --- drivers/staging/dgnc/dgnc_mgmt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index b13

[PATCH v2] Staging: rtl8712: Removed unused return variable

This patch removes unused return variable in this file. Signed-off-by: Gnanachandran Dhanapal --- drivers/staging/rtl8712/os_intfs.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c index 6e776e5

RE: [PATCH] Staging: rtl8712: Removed unused variable

Thanks for the feedback, Greg. I have sent patch set version 2 for the same changes. -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: 23 April 2015 19:51 To: DHANAPAL, GNANACHANDRAN (G.) Cc: larry.fin...@lwfinger.net; florian.c.schilha

[PATCH] Staging: rtl8712: Removed unused variable

This patch removes unused variable in this file. Signed-off-by: Gnanachandran Dhanapal Change-Id: I59cc869773d145239d62c3185018b275239fe812 --- drivers/staging/rtl8712/os_intfs.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/d