In destruct_tty_driver() from put_tty_driver() will free the
ttys in tty_driver.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 21 -
1 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 60b7d70..db24f70 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers
When it failed to allocate for printer_ports, serial_ports
can be freed in dgap_tty_uninit().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
If printer_ports which is allocated after serial_ports is failed
to allocate, tty_port_init for serial_ports doesn't need anymore.
So move this after allocating memory for printer_ports.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |6 +++---
1 files
I was already sent for this. :-)
https://lkml.org/lkml/2014/5/16/114
Regards,
Daeseok Youn.
2014-05-21 6:48 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference
2014-05-19 17:02 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
Nice, but it needs a couple style improvements below.
On Mon, May 19, 2014 at 11:10:30AM +0900, Daeseok Youn wrote:
+ brd-dgap_major_serial_registered = TRUE;
+ dgap_boards_by_major[brd-serial_driver-major] = brd
2014-05-19 18:39 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
2014-05-19 17:02 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
Nice, but it needs a couple style improvements below.
On Mon, May 19, 2014 at 11:10:30AM +0900, Daeseok Youn wrote:
+ brd-dgap_major_serial_registered = TRUE
From 3acdda98e73a153a5fb32c2cd401d2dde1653b0a Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 25 Apr 2014 16:04:59 +0900
Subject: [PATCH] staging: dgap: implement error handling in dgap_tty_register()
- alloc_tty_driver() is deprecated so it is changed
are registered normally, and
then set TRUE to dgap_major_serial{print}_registered. If one
of drivers is failed to register, leave a default value as
FALSE.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: rebased on staging-next branch
V3: removes unneeded information in e-mail
drivers
2014-05-17 8:09 GMT+09:00, Greg KH gre...@linuxfoundation.org:
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need
From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
The devs is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default
Hi, Dan
2014-05-16 18:03 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 16 May 2014 17:02:04 +0900
The devs is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default value as empty string.
So devs cannot be NULL, removes NULL check for devs.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: remove unneeded lines for sending a patch.
drivers/staging/ozwpan/ozproto.c |2 +-
1
Hi,
This patch haven't been updated over the past 3 weeks.
Will you check for me?
Regards,
Daeseok Youn.
2014-04-28 8:21 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
OK. I'll make my patch based on Mark's patch.
Thanks.
Daeseok Youn.
2014-04-27 3:48 GMT+09:00 Dan Carpenter dan.carpen
2014-05-16 18:52 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote:
Hi,
This patch haven't been updated over the past 3 weeks.
Will you check for me?
Greg was trying to travel around the world in one month like Jackie
Chan
2014-05-09 16:59 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 10:38:43AM +0900, Daeseok Youn wrote:
clean up checkpatch.pl warning:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
This patch includes
2014-05-09 17:07 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
This patch is ok, but here are some additional hints.
On Fri, May 09, 2014 at 10:39:48AM +0900, Daeseok Youn wrote:
@@ -1100,7 +1102,9 @@ musycc_bh_rx_eom(mpi_t *pi, int gchan
Removes #if 0 blocks.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
Dan,
I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
out and make a block as RLD_DEBUG. Because i think this block need to debug
with define RLD_DEBUG. If I am wrong, let me know.
drivers
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
I'm not sure about removing RLD_DUMP_BUFDATA and RLD_DEBUG
definitions.
I think these can be defined temporarily by developer who want to debugging
this module.
drivers/staging/cxt1e1/musycc.c | 211
clean up checkpatch.pl warning:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/musycc.c | 312 ---
1 files changed, 196 insertions(+), 116 deletions(-)
diff --git a/drivers/staging
cleanup checkpatch.pl error:
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/musycc.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging
2014-05-09 19:42 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 07:02:20PM +0900, Daeseok Youn wrote:
clean up checkpatch.pl warning:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
-#ifdef
2014-05-09 19:51 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
Removes #if 0 blocks.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
Dan,
I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
out
2014-05-09 23:15 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 11:09:35PM +0900, DaeSeok Youn wrote:
2014-05-09 19:51 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
Removes #if 0 blocks.
Signed
Removes #if 0 blocks.
And the musycc_dump_rxbuffer_ring(ch, 0) which is commented
out puts in RLD_DEBUG block and uncommented.
Because this function may be used for debugging.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2 : fix the changelog, added a log
clean up checkpatch.pl warning
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/musycc.c | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/bcm/InterfaceDld.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceDld.c
b/drivers/staging/bcm/InterfaceDld.c
index 005e460..e1925bd 100644
--- a/drivers/staging/bcm
OK. I'll make my patch based on Mark's patch.
Thanks.
Daeseok Youn.
2014-04-27 3:48 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote:
Hi,
please check below my comments.
2014-04-25 23:41 GMT+09:00 Mark Hounschell ma
;
And when you send a patch for this, please check maintainers with
./scripts/get_maintainer.pl.
In case of this patch, my email is in CC list. :-)
Regards,
Daeseok Youn.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need to check NULL for them.
- If one of those is failed, it need to add proper handler for
avoiding memory leak.
Signed-off-by: Daeseok
2014-04-26 7:33 GMT+09:00, Greg KH gre...@linuxfoundation.org:
On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/silicom/bpctl_mod.c |5
Hi,
please check below my comments.
2014-04-25 23:41 GMT+09:00 Mark Hounschell ma...@compro.net:
On 04/25/2014 08:59 AM, Dan Carpenter wrote:
On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote:
On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
Hi, Dan.
2014-04-25 18:26 GMT+09:00 Dan
2014-04-23 17:35 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Wed, Apr 23, 2014 at 05:18:42PM +0900, Daeseok Youn wrote:
The pci_get_drvdata() and checking NULL for dev are
called twice in while loop in is_bypass_dev().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Replace OS_kmalloc/OS_kfree with kzalloc/kfree.
And also some allocation doesn't need to use GFP_DMA
so just use GFP_KERNEL.
c4_new() function is never called, remove it.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V4: update patch description, OS_kmalloc should be replaced
handle_goto() warn:
unsigned '(speakup_console[vc-vc_num]-go_pos)' is never less than zero.
drivers/staging/speakup/main.c:1911 handle_goto() warn:
unsigned '(speakup_console[vc-vc_num]-go_pos)' is never less than zero.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/speakup
You are right. remove whole thing and send it again.
Thanks.
Daeseok Youn
2014-04-02 18:13 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote:
coccicheck says:
drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21:
ERROR: ir
ir is already checked before calling unregister_from_lirc().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/media/lirc/lirc_igorplugusb.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c
b
Please drop this patch.
I made a patch as Dan's comment and sent it.
Thanks.
Daeseok Youn.
2014-04-02 18:41 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
You are right. remove whole thing and send it again.
Thanks.
Daeseok Youn
2014-04-02 18:13 GMT+09:00 Dan Carpenter dan.carpen
2014-03-27 3:51 GMT+09:00 Aaron Sierra asie...@xes-inc.com:
- Original Message -
From: Daeseok Youn daeseok.y...@gmail.com
Sent: Tuesday, March 25, 2014 10:01:48 PM
Subject: [PATCH] staging: vme: fix memory leak in vme_user_probe()
If vme_master_request() returns NULL when it failed
If vme_master_request() returns NULL when it failed,
it need to free buffers for master.
And also removes unreachable code in vme_user_probe().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/vme/devices/vme_user.c |9 +++--
1 files changed, 3 insertions(+), 6
Replace OS_kmalloc/OS_kfree with kmalloc/kfree.
And also some allocation doesn't need to use GFP_DMA
so just use GFP_KERNEL.
c4_new() function is never called, remove it.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v3: replace kzalloc with kmalloc.
v2: fix subject and comment
Replace kmalloc/kfree with OS_kmalloc/OS_kfree.
And also some allocation doesn't need to use GFP_DMA
so just use GFP_KERNEL.
c4_new() function is never called, remove it.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
I'm not sure what GFP_DMA use correctly for km{,z}alloc().
Please
Yes. It was already noticed by Joe Perches.
I will send it again.
Thanks.
Daeseok Youn.
2014-03-21 11:35 GMT+09:00, Greg KH gre...@linuxfoundation.org:
On Fri, Mar 21, 2014 at 10:41:39AM +0900, Daeseok Youn wrote:
Replace kmalloc/kfree with OS_kmalloc/OS_kfree.
I think you mean
Replace OS_kmalloc/OS_kfree with kmalloc/kfree.
And also some allocation doesn't need to use GFP_DMA
so just use GFP_KERNEL.
c4_new() function is never called, remove it.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: fix subject and comment correctly.
I'm not sure what GFP_DMA use
2014-03-21 13:27 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote:
Replace OS_kmalloc/OS_kfree with kmalloc/kfree.
You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed
out the allocated data:
I think some case does
It doesn't need to trace status of buffer when buffers are
allocated/deallocated. So stuff of tracing memory status
are removed. And also UISMALLOC/UISFREE macro are removed
completetly. just use kzalloc/kfree.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/unisys
OK. I will remove __GFP_NORETRY for kmalloc/kzalloc and sent this again.
Thanks.
Daeseok Youn
2014-03-20 0:28 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Mar 19, 2014 at 04:58:52PM +0900, Daeseok Youn wrote:
It doesn't need to trace status of buffer when buffers are
allocated
It doesn't need to trace status of buffer when buffers are
allocated/deallocated. So stuff of tracing memory status
are removed. And also UISMALLOC/UISFREE macro are removed
completetly. just use kzalloc/kfree.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: removed __GFP_NORETRY flag
2014-03-18 9:37 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
vmalloc/kmalloc directly.
Yes. Actually, just use kmalloc, I don't knwo why vmalloc is being
Hi, greg.
Review my comment below.
Thanks.
Daeseok Youn.
2014-03-18 17:11 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
2014-03-18 9:37 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
I think vmalloc/kmalloc in uislib_malloc() can
a patch.
Regards,
Daeseok Youn.
2014-03-18 22:00 GMT+09:00 Ken Cox j...@redhat.com:
On 03/17/2014 07:26 PM, DaeSeok Youn wrote:
I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
vmalloc/kmalloc directly.
(UISMALLOC() macro is also removed.)
And uislib_malloc() is renamed
oh...
You didn't get my reply about vmalloc usage.
My replay attach again, below.
2014-03-18 9:37 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote:
I think vmalloc/kmalloc in uislib_malloc() can be removed and just use
vmalloc/kmalloc
Thanks for reply.
I will do that.
Regards,
Daeseok Youn.
2014-03-19 11:31 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote:
oh...
You didn't get my reply about vmalloc usage.
My replay attach again, below.
2014-03-18 9:37 GMT+09
Ok. I will rebase this patch in staging-next branch and send it again.
Thanks.
Daeseok Youn.
2014-03-18 6:23 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Mar 10, 2014 at 08:54:18AM +0900, Daeseok Youn wrote:
The mkret() change a value of error from positive to
negative. This patch
...) for info_proc_read_helper().
If this change is accepted, it also need to change uislib_free().
Is it fine to change like this?
Thanks.
Daeseok Youn.
2014-03-18 6:41 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Mar 12, 2014 at 07:37:50PM +0900, Daeseok Youn wrote:
Signed-off-by: Daeseok Youn daeseok.y
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: fix a typo in subject
The banner array doens't need to set to 0.
sprintf() adds a terminating '\0'.
And the sn array can be declared and initialized to zero.
So remove redundant memset() with zero.
Remove unnecessary cast for memcpy().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/unisys/uislib/uislib.c |5 +
drivers/staging/unisys/uislib/uisutils.c |2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib
The queue_delayed_work() return false if the work is
already on the queue, true otherwise.
So return value cannot be less than zero.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
.../unisys/visorchipset/visorchipset_main.c| 14 --
1 files changed, 4 insertions
.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c | 41 ++
1 files changed, 19 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index a6c6aba..199b9d7 100644
Ok. I will check and send it again.
Thanks.
Daeseok Youn.
2014-03-09 15:38 GMT+09:00, Greg KH gre...@linuxfoundation.org:
On Fri, Mar 07, 2014 at 09:03:04AM +0900, Daeseok Youn wrote:
The mkret() change a value of error from positive to
negative. This patch is modified to return negative
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/frontier/alphatrack.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/frontier/alphatrack.c
b
OK. I will remove that comment and send again.
Thanks.
Daeseok Youn.
2014-03-07 17:14 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, Mar 07, 2014 at 05:02:25PM +0900, Daeseok Youn wrote:
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: remove the unneeded comment.
drivers/staging/frontier/alphatrack.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: replace sprintf() with snprintf() and remove memset() call
because snprintf() adds a terminating '\0'
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3
to rebase current staging-next branch.
Thanks.
Daeseok Youn.
2014-03-07 4:57 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Mar 05, 2014 at 10:21:01AM +0900, Daeseok Youn wrote:
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
Ok.
I will fix it and send again.
Thanks.
Daeseok Youn
2014-03-07 4:58 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions
Thank you for your kind explanation.
I will do that when my patch is sent again.
regards,
Daeseok Youn.
2014-03-05 17:08 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Wed, Mar 05, 2014 at 04:58:36PM +0900, DaeSeok Youn wrote:
Yes, it is not changed anything.
But I had a request
Thanks for review.
OK. I will try to change all of OS_kmalloc to kmalloc/kzalloc.
And I also check GFP_DMA flag in kmalloc/kzalloc.
Regards,
Daeseok Youn
2014-03-05 19:04 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-05 at 03:37:15 +0100, Daeseok Youn daeseok.y...@gmail.com wrote
2014-03-05 19:13 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-05 at 02:24:22 +0100, Daeseok Youn daeseok.y...@gmail.com wrote:
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
Ok.
I will use sizeof(name) for snprintf() call.
Thanks.
Daeseok Youn.
2014-03-06 16:33 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn daeseok.y...@gmail.com wrote:
2014-03-05 19:13 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-05 at 02
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1
Thanks for review.
Ok. I Will fix later.
Daeseok Youn
2014-03-04 17:45 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Tue, Mar 04, 2014 at 11:08:46AM +0900, Daeseok Youn wrote:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
Yes, it need to add brace in inner loop.
I will send again.
Thanks for review.
Daeseok Youn
2014-03-04 18:04 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote:
@@ -1174,7 +1179,8 @@ cleanup_hdlc(void)
ci
-next branch from mailing list.
Please check.
Thanks.
Daeseok Youn.
2014-03-05 9:35 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Mar 04, 2014 at 11:10:44AM +0900, Daeseok Youn wrote:
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
changed this version from v2 to v3.
Regards,
Daeseok Youn.
2014-03-05 16:20 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
Why are you resending a v3 of these?
I did a diff of the emails and the only difference is that you dropped
Ying Xue from the CC list.
regards,
dan carpenter
Hi, Joe and Krzysztof
I think that code which can be improved to hex_dump() may be used for debugging.
So that improvement will be sent with another patch.
I think it would be fine. right?
Thanks.
Daeseok Youn.
2014-03-03 16:33 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
I think line
clean up checkpatch.pl warnings in linux.c:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 524
1 files changed, 262 insertions(+), 262
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 1478
1 files changed, 743 insertions(+), 735 deletions(-)
diff --git a/drivers
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 48 +--
1 files changed, 31 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 28 +---
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c
index
.
just my opinion.
Regards.
Daeseok Youn.
2014-03-04 12:24 GMT+09:00 Joe Perches j...@perches.com:
On Tue, 2014-03-04 at 11:08 +0900, Daeseok Youn wrote:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Please run your patches through checkpatch.
diff --git
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1
checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging
clean up checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 62 +++---
1 file changed, 25 insertions(+), 37 deletions(-)
diff --git a/drivers
Youn.
2014-03-03 16:10 GMT+09:00 Joe Perches j...@perches.com:
On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote:
2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa khal...@piap.pl:
why not use some existing *hex_dump*() instead?
OK. but this patch is only for fix line length over 80 characters
bClassificationSucceed is initialized with false,
do not need to set false again.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/bcm/Qos.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 0727599
clean up checkpatch errors and bClassificationSucceed is set to TRUE
proper location.
If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed
must be set to TRUE.
Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE.
Signed-off-by: Daeseok Youn
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 02b4f8f..07de83f 100644
--- a/drivers/staging/cxt1e1
clean up checkpatch.pl warnings:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 120 +++---
1 file changed, 60 insertions(+), 60 deletions
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 585 +++---
1 file changed, 293 insertions(+), 292 deletions(-)
diff --git a/drivers
301 - 400 of 419 matches
Mail list logo
