Re: [PATCH v2 17/17] power: supply: olpc_battery: Add OLPC XO 1.75 support

2018-12-02 Thread Darren Hart
/* XO 1.75 */ > + data->new_proto = 1; > + data->little_endian = 1; > } else if (ecver < 0x44) { > /* >* We've seen a number of EC protocol changes; this driver > -- > 2.19.1 > > -- Darre

Re: [PATCH v2 13/17] power: supply: olpc_battery: Use DT to get battery version

2018-12-02 Thread Darren Hart
The code previously supported xo1.5 (it seems), and the commit message doesn't mention changing the compatible string. Was this an intentional change? If so, it should be mentioned in the commit message. > {} > }; > MODULE_DEVICE_TABLE(of, olpc_battery_ids); > -- > 2.19.1 > > -- Darren Hart VMware Open Source Technology Center ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 07/17] Platform: OLPC: Avoid a warning if the EC didn't register yet

2018-12-02 Thread Darren Hart
+ if (WARN_ON(!ec_driver->ec_cmd)) > return -ENODEV; > > if (!ec) > -- > 2.19.1 > > -- Darren Hart VMware Open Source Technology Center ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 06/17] Platform: OLPC: Add XO-1.75 EC driver

2018-12-02 Thread Darren Hart
anges. > > Basically all of the above is based on the review by Andy Shevchenko. Andy, what was your intent for Lubomir here? From the above, this looks like it should be several patches to me. Thanks, -- Darren Hart VMware Open Source Technology Center ___

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-14 Thread Darren Hart
mi_fops = { > .read = wmi_char_read, > .open = wmi_char_open, > .unlocked_ioctl = wmi_ioctl, > - .compat_ioctl = wmi_ioctl, > + .compat_ioctl = generic_compat_ioctl_ptrarg, > }; For platform/drivers/x86: Acked-by: Darren Hart (VMwa

Re: [PATCH v4 11/20] power_supply: Change ownership from driver to core

2015-02-25 Thread Darren Hart
: Darren Hart For compal-laptop.c: Acked-by: Darren Hart dvh...@linux.intel.com -- Darren Hart Intel Open Source Technology Center ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev

Re: [PATCH v3 02/20] power_supply: Move run-time configuration to separate structure

2015-02-06 Thread Darren Hart
/platform/x86/compal-laptop.c Reviewed-by: Darren Hart dvh...@linux.intel.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel