Re: [PATCH v4 1/3] mm/slab: Use memzero_explicit() in kzfree()

Waiman Long wrote: > The kzfree() function is normally used to clear some sensitive > information, like encryption keys, in the buffer before freeing it back > to the pool. Memset() "memset()" is all lowercase. > is currently used for buffer clearing. However unlikely, there is still a >

Re: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()

diting of the kfree_sensitive() kerneldoc and the > use of memzero_explicit() instead of memset(). > > Suggested-by: Joe Perches > Signed-off-by: Waiman Long Since this changes a lot of crypto stuff, does it make sense for it to go via the crypto tree? Acked-by: David Howells __

Re: [RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

Dan Carpenter wrote: > > + struct ipc_namespace *ipc_ns = fc->s_fs_info; > > + put_ipc_ns(ipc_ns); > > I feel like put_ipc_ns(info->ipc_ns) would be more readable. Not so much more readable as more correct. David ___ devel

[RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

. Signed-off-by: David Howells Reviewed-by: Christian Brauner cc: Greg Kroah-Hartman cc: "Arve Hjønnevåg" cc: Todd Kjos cc: Martijn Coenen cc: Joel Fernandes cc: de...@driverdev.osuosl.org --- drivers/android/binderfs.c | 173 1 file c

[PATCH 19/38] vfs: Convert binderfs to fs_context

Signed-off-by: David Howells Reviewed-by: Christian Brauner cc: Greg Kroah-Hartman cc: "Arve Hjønnevåg" cc: Todd Kjos cc: Martijn Coenen cc: Joel Fernandes cc: de...@driverdev.osuosl.org --- drivers/android/binderfs.c | 173 1 file c

Re: [PATCH 2/2 dhowells/mount-api] staging: erofs: update .mount and .remount_sb

Gao Xiang wrote: > This patch updates .mount and .remount_sb after > commit ("vfs: Require specification of size of > mount data for internal mounts") in reference to > drivers/usb/gadget/function/f_fs.c. > > Reported-by: Stephen Rothwell > Signed-off-by: Gao Xiang I've folded this into my

Re: [PATCH 1/2 dhowells/mount-api] staging: erofs: rename superblock flags (MS_xyz -> SB_xyz)

> > Reported-by: Stephen Rothwell > Reviewed-by: Chao Yu > Signed-off-by: Gao Xiang I recommend pushing this one to Linus now. It's trivial enough. Reviewed-by: David Howells ___ devel mailing list de...@linuxdriverproject.org http://driverdev.li

Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data}

Christoph Hellwig wrote: > + > +struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode, > + struct proc_dir_entry *parent, const struct seq_operations *ops, > + void *data) > +{ > ... > +EXPORT_SYMBOL(proc_create_seq_data); Please add

Re: [PATCH 20/39] afs: simplify procfs code

Christoph Hellwig wrote: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Note that this is likely going to clash with my patch to net-namespace all of the

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

Arnd Bergmann <a...@arndb.de> wrote: > - mn10300 appears to be wrong, broken by David Howells in > commit 83c2dc15ce82 ("MN10300: Handle cacheable PCI regions > in pci_iomap()") for any driver calling ioremap() by to get uncached > memory, It's not clea

[PATCH 29/38] Annotate hardware config module parameters in drivers/staging/speakup/

drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/speakup/. Suggested-by: Alan Cox <gno...@lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowe...@redhat.com> cc: Greg Kroah-

[PATCH 30/38] Annotate hardware config module parameters in drivers/staging/vme/

drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/vme/. Suggested-by: Alan Cox <gno...@lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowe...@redhat.com> cc: Martyn Welch <mar...@w

[PATCH 28/38] Annotate hardware config module parameters in drivers/staging/media/

drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/media/. Suggested-by: Alan Cox <gno...@lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowe...@redhat.com> cc: Mauro Carvalho

Re: [PATCH 29/39] Annotate hardware config module parameters in drivers/staging/media/

Mauro Carvalho Chehab wrote: > drivers/staging/media/lirc/lirc_parallel.c:728:19: error: Expected ) in > function declarator Did you apply patch 1 first? That defines module_param_hw*. David ___ devel mailing list

[PATCH 31/39] Annotate hardware config module parameters in drivers/staging/vme/

drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/vme/. Suggested-by: One Thousand Gnomes <gno...@lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowe...@redhat.com> cc: Marty

[PATCH 30/39] Annotate hardware config module parameters in drivers/staging/speakup/

drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/speakup/. Suggested-by: One Thousand Gnomes <gno...@lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowe...@redhat.com> cc: Greg K

[PATCH 29/39] Annotate hardware config module parameters in drivers/staging/media/

drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/media/. Suggested-by: One Thousand Gnomes <gno...@lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowe...@redhat.com> cc: Mauro Car

[PATCH 28/39] Annotate hardware config module parameters in drivers/staging/i4l/

drivers support automatic configuration (e.g. PNP or PCI) in addition to manually coded parameters. This patch annotates drivers in drivers/staging/i4l/. Suggested-by: One Thousand Gnomes <gno...@lxorguk.ukuu.org.uk> Signed-off-by: David Howells <dhowe...@redhat.com> cc: Greg Kroah-