Re: [PATCH v3 9/9] staging: iio: ad2s1200: Move driver out of staging

On 28, April 2018 17:46, Jonathan Cameron wrote: > On Mon, 23 Apr 2018 00:04:42 +0200 > David Veenstra wrote: > >> Move the iio driver for the ad2s1200 and ad2s1205 resolver-to-digital >> converter out of staging, into mainline iio subsystems. >> >> Signed-off-by: David Veenstra > A few more mi

Re: [PATCH v3 6/9] staging: iio: ad2s1200: Add scaling factor for angular velocity channel

On 28, April 2018 17:35, Jonathan Cameron wrote: > On Sat, 28 Apr 2018 18:23:44 +0100 > Jonathan Cameron wrote: > >> On Mon, 23 Apr 2018 00:03:59 +0200 >> David Veenstra wrote: >> >> > The sysfs iio ABI states radians per second is expected as the unit for >> > angular velocity, but the 12-bit

Re: [PATCH v3 5/9] staging: iio: ad2s1200: Add documentation for device tree binding

On 28, April 2018 15:27, Jonathan Cameron wrote: > On Fri, 27 Apr 2018 09:48:20 -0500 > Rob Herring wrote: > >> On Mon, Apr 23, 2018 at 12:03:47AM +0200, David Veenstra wrote: >> > Add documentation for the added device tree bindings. >> > >> > Signed-off-by: David Veenstra >> > --- >> > Change

Re: [PATCH v3 1/9] staging: iio: ad2s1200: Add kernel docs to driver state

On 28, April 2018 17:11, Jonathan Cameron wrote: > On Mon, 23 Apr 2018 00:02:51 +0200 > David Veenstra wrote: > >> Add missing kernel docs to the ad2s1200 driver state. >> >> Signed-off-by: David Veenstra > Hi David, > > Comment inline. > >> --- >> Changes in v3: >> - Added more explanation to

Re: [PATCH v2 11/13] staging: iio: Documentation: Add missing sysfs docs for angle channel

On 21, April 2018 19:08, Jonathan Cameron wrote: > On Fri, 20 Apr 2018 21:31:37 +0200 > David Veenstra wrote: > >> The iio resolver drivers in staging use angle channels. This patch >> add missing documentation for this type of channel. >> >> As was discussed in [1], radians is chosen as the un

Re: [PATCH v2 10/13] staging: iio: ad2s1200: Add scaling factor for angular velocity channel

On 21, April 2018 19:07, Jonathan Cameron wrote: > On Fri, 20 Apr 2018 21:31:09 +0200 > David Veenstra wrote: > >> The sysfs iio ABI states radians per second is expected as the unit for >> angular velocity, but the 12-bit angular velocity register has rps >> as its unit. So a fractional scaling

Re: [PATCH v2 08/13] staging: iio: ad2s1200: Replace legacy gpio API with modern API

On 21, April 2018 18:58, Jonathan Cameron wrote: > On Fri, 20 Apr 2018 21:30:44 +0200 > David Veenstra wrote: > >> The legacy, integer based gpio API is replaced with the descriptor >> based API. >> >> For compatibility, it is first tried to use the platform data to >> request the gpio's. Other

Re: [PATCH v2 07/13] staging: iio: ad2s1200: Improve readability with be16_to_cpup

On 21, April 2018 18:55, Jonathan Cameron wrote: > On Fri, 20 Apr 2018 21:30:32 +0200 > David Veenstra wrote: > >> The manual states that the data is contained in the upper 12 bits >> of the 16 bits read by spi. The code that extracts these 12 bits >> is correct for both be and le machines, but

Re: [PATCH v2 06/13] staging: iio: ad2s1200: Introduce variable for repeated value

On 21, April 2018 18:50, Jonathan Cameron wrote: > On Fri, 20 Apr 2018 21:30:19 +0200 > David Veenstra wrote: > >> Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly >> used in ad2s1200_probe. >> >> Signed-off-by: David Veenstra > No significant gain in readability. P

Re: [PATCH v2 05/13] staging: iio: ad2s1200: Add kernel docs to driver state

On 21, April 2018 18:49, Jonathan Cameron wrote: > On Fri, 20 Apr 2018 21:30:03 +0200 > David Veenstra wrote: > >> Add missing kernel docs to the ad2s1200 driver state. >> >> Signed-off-by: David Veenstra >> --- >> drivers/staging/iio/resolver/ad2s1200.c | 8 >> 1 file changed, 8 inse

Re: [PATCH 10/11] staging: iio: ad2s1200: Replace angle channel with inclination channel

On 24, March 2018 14:12, Jonathan Cameron wrote: > On Sat, 24 Mar 2018 13:36:44 +0100 > David Julian Veenstra wrote: > >> On 23, March 2018 14:27, Jonathan Cameron wrote: >> >> > On Sun, 18 Mar 2018 14:37:04 +0100 >> > David Veenstra wrote: >>

Re: [PATCH 10/11] staging: iio: ad2s1200: Replace angle channel with inclination channel

On 23, March 2018 14:27, Jonathan Cameron wrote: > On Sun, 18 Mar 2018 14:37:04 +0100 > David Veenstra wrote: > >> The angle channel is not defined in sysfs iio ABI. So it is replaced >> with an inclination channel, because it is defined in the ABI, and has the >> semantics of an angle. >> >> In

Re: [PATCH 07/11] staging: iio: ad2s1200: Ensure udelay(1) in all necessary code paths

On 23, March 2018 14:20, Jonathan Cameron wrote: > On Sun, 18 Mar 2018 14:36:15 +0100 > David Veenstra wrote: > >> After a successful spi transaction, a udelay(1) is needed. >> This doesn't happen for the default case of the switch statement >> in ad2s1200_read_raw. This patch makes sure that it

Re: [PATCH 05/11] staging: iio: ad2s1200: Introduce variable for repeated value

On 23, March 2018 14:17, Jonathan Cameron wrote: > On Sun, 18 Mar 2018 14:35:46 +0100 > David Veenstra wrote: > >> Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly >> used in ad2s1200_probe. >> >> Signed-off-by: David Veenstra > I'm a little unconvinced by this one. I