Re: [PATCH net-next] staging: irda: update MAINTAINERS

2017-08-29 Thread David Miller
From: Greg Kroah-Hartman Date: Tue, 29 Aug 2017 09:09:29 +0200 > Now that the IRDA code has moved under drivers/staging/irda/, update the > MAINTAINERS file with the new location. > > Reported-by: Joe Perches > Signed-off-by: Greg Kroah-Hartman

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-28 Thread David Miller
From: Greg Kroah-Hartman Date: Sun, 27 Aug 2017 17:03:30 +0200 > The IRDA code has long been obsolete and broken. So, to keep people > from trying to use it, and to prevent people from having to maintain it, > let's move it to drivers/staging/ so that we can delete

Re: [PATCH v3 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-28 Thread David Miller
From: Dexuan Cui Date: Sat, 26 Aug 2017 04:52:43 + > > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It uses VMBus ringbuffer as the > transportation layer. > > With hv_sock, applications between the

Re: [PATCH v2 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-24 Thread David Miller
From: Dexuan Cui Date: Wed, 23 Aug 2017 04:52:14 + > +#define VMBUS_PKT_TRAILER(sizeof(u64)) This is not the packet trailer, it's the size of the packet trailer. Please make this macro name match more accurately what it is. > + /* Have we sent the zero-length

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-17 Thread David Miller
From: Dexuan Cui Date: Thu, 17 Aug 2017 08:00:29 + > @@ -73,6 +74,10 @@ struct vmci_transport_recv_pkt_info { > struct vmci_transport_packet pkt; > }; > > +static bool skip_hypervisor_check; > +module_param(skip_hypervisor_check, bool, 0444); >

Re: [PATCH net-next 0/3] vmbus sendpacket cleanups

2017-08-16 Thread David Miller
From: Stephen Hemminger Date: Wed, 16 Aug 2017 08:56:23 -0700 > These patches remove and consolidate vmbus_sendpacket functions. > > They should go through the net-next tree since these API's > were only used by the netvsc driver. Series applied, thanks.

Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-16 Thread David Miller
From: Dexuan Cui Date: Wed, 16 Aug 2017 18:51:36 + > It looks typically modern Linux distros have CONFIG_HYPERVISOR_GUEST=y > by default It doesn't matter what any distribution does or does not do. People are going to do 'randconfig' builds over thousands and thousands

Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

2017-08-16 Thread David Miller
From: Dexuan Cui Date: Tue, 15 Aug 2017 22:13:29 + > + /* > + * Check if we are running on VMware's hypervisor and bail out > + * if we are not. > + */ > + if (x86_hyper != _hyper_vmware) > + return -ENODEV; This symbol is only

Re: [PATCH net-next 00/10] netvsc: minor fixes and improvements

2017-08-11 Thread David Miller
From: Stephen Hemminger Date: Wed, 9 Aug 2017 17:46:02 -0700 > These are non-critical bug fixes, related to functionality now in net-next. > 1. delaying the automatic bring up of VF device to allow udev to change name. > 2. performance improvement > 3. handle MAC

Re: [PATCH] hv_set_ifconfig.sh double check before setting ip

2017-08-10 Thread David Miller
From: Eduardo Otubo <ot...@redhat.com> Date: Thu, 10 Aug 2017 09:40:27 +0200 > On 08/09/2017 11:02 AM, Eduardo Otubo wrote: >> On 08/09/2017 06:11 AM, David Miller wrote: >>> From: Eduardo Otubo <ot...@redhat.com> >>> Date: Tue, 8 Aug 2017 15:53:45 +0200

Re: [PATCH net-next 1/1] netvsc: make sure and unregister datapath

2017-08-08 Thread David Miller
From: Stephen Hemminger Date: Mon, 7 Aug 2017 11:30:00 -0700 > Go back to switching datapath directly in the notifier callback. > Otherwise datapath might not get switched on unregister. > > No need for calling the NOTIFY_PEERS notifier since that is only for > a

Re: [PATCH net-next 1/1] netvsc: fix rtnl deadlock on unregister of vf

2017-08-06 Thread David Miller
From: Stephen Hemminger Date: Fri, 4 Aug 2017 12:14:00 -0700 > With new transparent VF support, it is possible to get a deadlock > when some of the deferred work is running and the unregister_vf > is trying to cancel the work element. The solution is to use > trylock

Re: [PATCH net 1/1] netvsc: fix race on sub channel creation

2017-08-06 Thread David Miller
From: Stephen Hemminger Date: Thu, 3 Aug 2017 17:13:54 -0700 > The existing sub channel code did not wait for all the sub-channels > to completely initialize. This could lead to race causing crash > in napi_netif_del() from bad list. The existing code would send > an

Re: [PATCH net-next v3 0/3] netvsc: transparent VF support

2017-08-02 Thread David Miller
From: Stephen Hemminger Date: Tue, 1 Aug 2017 19:58:52 -0700 > This patch set changes how SR-IOV Virtual Function devices are managed > in the Hyper-V network driver. This version is rebased onto current net-next. ... Series applied, thanks Stephen.

Re: [PATCH V2] hyperv: netvsc: Neaten netvsc_send_pkt by using a temporary

2017-08-02 Thread David Miller
From: Joe Perches Date: Mon, 31 Jul 2017 10:30:54 -0700 > Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be > shortened by using a temporary. Do so. > > No change in object code. > > Miscellanea: > > o Use * const for rpkt and nvchan > > Signed-off-by: Joe

Re: [PATCH net-next v2 0/3] netvsc: transparent SR-IOV VF support

2017-08-01 Thread David Miller
From: Stephen Hemminger Date: Mon, 31 Jul 2017 16:45:21 -0700 > This patch set changes how SR-IOV Virtual Function devices are managed > in the Hyper-V network driver. It was part of earlier bundle, but > is now updated. I think you need to do a rebase. I just

Re: [PATCH net-next v3 0/7] netvsc: minor fixes and optimization

2017-07-29 Thread David Miller
From: Stephen Hemminger Date: Fri, 28 Jul 2017 08:59:40 -0700 > This is a subset of earlier submission with a few more fixes > found during testing. The are two small optimizations, one is to > better manage the receive completion ring, and the other is removing > one

Re: [PATCH net-next v2 00/10] netvsc fixes and new features

2017-07-27 Thread David Miller
From: Stephen Hemminger Date: Wed, 26 Jul 2017 16:40:19 -0700 > The next group of patches aims to reduce the driver memory footprint > by reducing the size of the per-device receive and send buffers, and > the per-channel receive completion queue. Sorry Stephen, I

Re: [PATCH net 1/1] Revert "netvsc: optimize calculation of number of slots"

2017-07-25 Thread David Miller
From: Stephen Hemminger Date: Mon, 24 Jul 2017 21:03:19 -0700 > The logic for computing page buffer scatter does not take into > account the impact of compound pages. Therefore the optimization > to compute number of slots was incorrect and could cause stack >

Re: [PATCH net-next 0/6] netvsc: minor fixes

2017-07-24 Thread David Miller
From: Stephen Hemminger Date: Mon, 24 Jul 2017 10:57:24 -0700 > This fixes fallout from previous patch related to RTNL and RCU > annotaiton. Also one patch sent to wrong list. Series applied, thanks. ___ devel mailing list

Re: [PATCH] netvsc: fix ptr_ret.cocci warnings

2017-07-24 Thread David Miller
From: Stephen Hemminger <step...@networkplumber.org> Date: Mon, 24 Jul 2017 16:21:57 -0700 > On Mon, 24 Jul 2017 16:20:28 -0700 (PDT) > David Miller <da...@davemloft.net> wrote: > >> From: kbuild test robot <fengguang...@intel.com> >> Date: Sat, 22 Jul 2

Re: [PATCH] netvsc: fix ptr_ret.cocci warnings

2017-07-24 Thread David Miller
From: kbuild test robot Date: Sat, 22 Jul 2017 02:54:43 +0800 > drivers/net/hyperv/netvsc_drv.c:737:8-14: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > >

Re: [PATCH net-next 0/8] netvsc: lockdep and related fixes

2017-07-19 Thread David Miller
From: Stephen Hemminger Date: Wed, 19 Jul 2017 11:53:11 -0700 > These fix sparse and lockdep warnings from netvsc driver. > Targeting these at net-next since no actual related failures > have been observed in non-debug kernels. Series applied, thanks Stephen.

Re: [PATCH] netvsc: don't access netdev->num_rx_queues directly

2017-06-22 Thread David Miller
From: Arnd Bergmann Date: Thu, 22 Jun 2017 00:16:37 +0200 > This structure member is hidden behind CONFIG_SYSFS, and we > get a build error when that is disabled: > > drivers/net/hyperv/netvsc_drv.c: In function 'netvsc_set_channels': > drivers/net/hyperv/netvsc_drv.c:754:49:

Re: [PATCH net-next 0/6] netvsc: small cleanups

2017-06-09 Thread David Miller
From: Stephen Hemminger Date: Thu, 8 Jun 2017 16:21:17 -0700 > These are all small optimizations found during development of later features. Applied with the spelling error pointed out by Sergei fixed. ___ devel mailing

Re: [PATCH net v2 0/3] netvsc: bug fixes

2017-06-08 Thread David Miller
From: Stephen Hemminger Date: Wed, 7 Jun 2017 15:53:46 -0700 > These are bugfixes for netvsc driver in 4.12. Looks good, series applied, thanks. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-31 Thread David Miller
From: Joe Perches <j...@perches.com> Date: Wed, 31 May 2017 15:59:31 -0700 > On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote: >> From: Michael Kelley <mikel...@microsoft.com> >> Date: Tue, 30 May 2017 10:43:04 -0700 >> >> > Add d

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-31 Thread David Miller
From: Michael Kelley Date: Tue, 30 May 2017 10:43:04 -0700 > Add direct #include statements for declarations of csum_tcpudp_magic() > and csum_ipv6_magic(). While the needed #include's are picked up > indirectly for the x86 architecture, they aren't on other >

Re: [PATCH net-next 1/1] netvsc: Deal with rescinded channels correctly

2017-04-21 Thread David Miller
From: k...@exchange.microsoft.com Date: Wed, 19 Apr 2017 13:53:49 -0700 > From: K. Y. Srinivasan > > We will not be able to send packets over a channel that has been > rescinded. Make necessary adjustments so we can properly cleanup > even when the channel is rescinded. This

Re: [PATCH net-next 1/1] netvsc: Initialize all channel related state prior to opening the channel

2017-04-08 Thread David Miller
From: k...@exchange.microsoft.com Date: Thu, 6 Apr 2017 14:59:21 -0700 > From: K. Y. Srinivasan > > Prior to opening the channel we should have all the state setup to handle > interrupts. The current code does not do that; fix the bug. This bug > can result in faults in the

Re: [PATCH] netvsc: fix dereference before null check errors

2017-03-27 Thread David Miller
From: Haiyang Zhang Date: Mon, 27 Mar 2017 00:50:27 + > > >> -Original Message- >> From: Colin King [mailto:colin.k...@canonical.com] >> Sent: Saturday, March 25, 2017 10:27 AM >> To: KY Srinivasan ; Haiyang Zhang >>

Re: [PATCH net-next 0/2] netvsc: Fix miscellaneous issues

2017-03-25 Thread David Miller
From: k...@exchange.microsoft.com Date: Fri, 24 Mar 2017 20:54:08 -0700 > Fix miscellaneous issues. Series applied, thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] net: hyperv: use new api ethtool_{get|set}_link_ksettings

2017-03-12 Thread David Miller
From: Philippe Reynes Date: Wed, 8 Mar 2017 23:41:04 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] netvsc: fix use-after-free in netvsc_change_mtu()

2017-03-02 Thread David Miller
From: Dexuan Cui Date: Thu, 2 Mar 2017 13:00:53 + > 'nvdev' is freed in rndis_filter_device_remove -> netvsc_device_remove -> > free_netvsc_device, so we mustn't access it, before it's re-created in > rndis_filter_device_add -> netvsc_device_add. > > Signed-off-by:

Re: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

2017-02-06 Thread David Miller
From: Parav Pandit Date: Sat, 4 Feb 2017 11:00:49 -0600 > This patch makes use of is_vlan_dev() function instead of flag > comparison which is exactly done by is_vlan_dev() helper function. > > Signed-off-by: Parav Pandit > Reviewed-by: Daniel Jurgens

Re: [PATCH net-next] net: Remove usage of net_device last_rx member

2017-01-18 Thread David Miller
From: Tobias Klauser Date: Wed, 18 Jan 2017 17:45:01 +0100 > The network stack no longer uses the last_rx member of struct net_device > since the bonding driver switched to use its own private last_rx in > commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").

Re: [PATCH net-next] net: make ndo_get_stats64 a void function

2017-01-05 Thread David Miller
From: Stephen Hemminger Date: Thu, 5 Jan 2017 09:31:36 -0800 > The network device operation for reading statistics is only called > in one place, and it ignores the return value. Having a structure > return value is potentially confusing because some future driver

Re: [PATCH] staging: octeon: Call SET_NETDEV_DEV()

2016-12-20 Thread David Miller
From: Florian Fainelli Date: Tue, 20 Dec 2016 17:02:37 -0800 > On 12/14/2016 05:13 PM, Florian Fainelli wrote: >> The Octeon driver calls into PHYLIB which now checks for >> net_device->dev.parent, so make sure we do set it before calling into >> any MDIO/PHYLIB related

Re: Gigabit ethernet driver for Alacritechs SLIC devices (v4)

2016-12-06 Thread David Miller
From: Greg KH <gre...@linuxfoundation.org> Date: Tue, 6 Dec 2016 17:40:39 +0100 > On Tue, Dec 06, 2016 at 11:30:04AM -0500, David Miller wrote: >> From: Lino Sanfilippo <linosanfili...@gmx.de> >> Date: Mon, 5 Dec 2016 23:07:15 +0100 >> >> > this i

Re: Gigabit ethernet driver for Alacritechs SLIC devices (v4)

2016-12-06 Thread David Miller
From: Lino Sanfilippo Date: Mon, 5 Dec 2016 23:07:15 +0100 > this is the forth version of the slicoss gigabit ethernet driver (which is a > rework of the driver from Alacritech which can currently be found under > drivers/staging/slicoss). The driver is supposed to

Re: [PATCH net-next] tools: hv: Enable network manager for bonding scripts on RHEL

2016-12-06 Thread David Miller
From: Haiyang Zhang Date: Fri, 2 Dec 2016 15:55:38 -0800 > From: Haiyang Zhang > > We found network manager is necessary on RHEL to make the synthetic > NIC, VF NIC bonding operations handled automatically. So, enabling > network

Re: [PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

2016-10-21 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 19 Oct 2016 15:53:01 +0200 > Fix in commit 880988348270 ("hv_netvsc: set nvdev link after populating > chn_table") turns out to be incomplete. A crash in > netvsc_get_next_send_section() is observed on mtu change when the device > is under

Re: [PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

2016-10-21 Thread David Miller
From: Vitaly Kuznetsov <vkuzn...@redhat.com> Date: Fri, 21 Oct 2016 17:17:18 +0200 > David Miller <da...@davemloft.net> writes: > >> From: Vitaly Kuznetsov <vkuzn...@redhat.com> >> Date: Fri, 21 Oct 2016 13:15:53 +0200 >> >>> David Miller &

Re: [PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

2016-10-21 Thread David Miller
From: Vitaly Kuznetsov <vkuzn...@redhat.com> Date: Fri, 21 Oct 2016 13:15:53 +0200 > David Miller <da...@davemloft.net> writes: > >> From: Vitaly Kuznetsov <vkuzn...@redhat.com> >> Date: Thu, 20 Oct 2016 10:51:04 +0200 >> >>> Stephen Hemming

Re: [PATCH net-next] hv_netvsc: fix a race between netvsc_send() and netvsc_init_buf()

2016-10-20 Thread David Miller
From: Vitaly Kuznetsov Date: Thu, 20 Oct 2016 10:51:04 +0200 > Stephen Hemminger writes: > >> Do we need ACCESS_ONCE() here to avoid check/use issues? >> > > I think we don't: this is the only place in the function where we read > the variable so

Re: [PATCH 21/28] net/hyperv: avoid uninitialized variable

2016-10-18 Thread David Miller
From: Arnd Bergmann Date: Tue, 18 Oct 2016 00:16:09 +0200 > The hdr_offset variable is only if we deal with a TCP or UDP packet, > but as the check surrounding its usage tests for skb_is_gso() > instead, the compiler has no idea if the variable is initialized > or not at that

Re: [PATCH v5 0/4] Add support for led triggers on phy link state change

2016-10-18 Thread David Miller
From: Zach Brown Date: Mon, 17 Oct 2016 10:49:51 -0500 > Fix skge driver that declared enum contants that conflicted with enum > constants in linux/leds.h > > Create function that encapsulates actions taken during the adjust phy link > step > of phy state changes. > >

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread David Miller
From: Zach Brown Date: Thu, 13 Oct 2016 10:42:46 -0500 > Do you have suggestions on how to better handle the choice of the array size > and the speeds? All of the speed values are simply the rate in bits per second. There is therefore no reason you can't just print the raw

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread David Miller
From: Zach Brown Date: Tue, 11 Oct 2016 15:26:20 -0500 > From: Josh Cartwright > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > create a set of led triggers for each instantiated PHY device. There is > one LED trigger per

Re: [PATCH 0/6] constify ethtool_ops structures

2016-08-31 Thread David Miller
From: Julia Lawall Date: Wed, 31 Aug 2016 09:30:42 +0200 > Constify ethtool_ops structures. Patches 2-6 applied, thanks. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH net-next] hv_netvsc: Implement batching of receive completions

2016-08-19 Thread David Miller
From: Haiyang Zhang Date: Fri, 19 Aug 2016 14:47:09 -0700 > From: Haiyang Zhang > > The existing code uses busy retry when unable to send out receive > completions due to full ring buffer. It also gives up retrying after limit > is reached,

Re: [PATCH net v2 0/5] hv_netvsc: fixes for VF removal path

2016-08-15 Thread David Miller
ith PATCHes 2-5 of this > series. PATCH1 is required to support the change. > > Changes since v1: > - Re-arrange patches in the series to not introduce new issues [David Miller] > - Add PATCH5 which fixes a new issue I discovered while testing. > - Add Haiyang' A-b tags to PATCH1

Re: [RFC 1/2] netvsc: reference counting fix

2016-08-14 Thread David Miller
From: Stephen Hemminger Date: Sat, 13 Aug 2016 11:35:59 -0700 > This is how I think it should be fixed, but not tested yet. > > Subjec: netvsc: use device not module reference counts > > Fix how the cross-device reference counting is handled. When VF is >

Re: [PATCH net 2/4] hv_netvsc: reset vf_inject on VF removal

2016-08-12 Thread David Miller
From: Vitaly Kuznetsov Date: Thu, 11 Aug 2016 12:58:55 +0200 > We reset vf_inject on VF going down (netvsc_vf_down()) but we don't on > VF removal (netvsc_unregister_vf()) so vf_inject stays 'true' while > vf_netdev is already NULL and we're trying to inject packets into

Re: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-26 Thread David Miller
From: Dexuan Cui Date: Tue, 26 Jul 2016 07:09:41 + > I googled "S390 hypervisor socket" but didn't find anything related (I think). That would be net/iucv/ There's also VMWare's stuff under net/vmw_vsock It's just absolutely rediculous to make a new hypervisor socket

Re: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-25 Thread David Miller
From: Dexuan Cui Date: Tue, 26 Jul 2016 03:09:16 + > BTW, during the past month, at least 7 other people also reviewed > the patch and gave me quite a few good comments, which have > been addressed. Correction: Several people gave coding style and simple corrections to

Re: [PATCH net-next] hv_netvsc: Fix VF register on bonding devices

2016-07-25 Thread David Miller
From: Haiyang Zhang Date: Fri, 22 Jul 2016 18:14:50 -0700 > From: Haiyang Zhang > > Added a condition to avoid bonding devices with same MAC registering > as VF. > > Signed-off-by: Haiyang Zhang > Reviewed-by:

Re: [PATCH v17 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-19 Thread David Miller
From: Dexuan Cui Date: Wed, 20 Jul 2016 01:48:18 + >> From: kbuild test robot [mailto:l...@intel.com] >> Sent: Wednesday, July 20, 2016 1:10 >> >> Hi, >> >> [auto build test WARNING on net-next/master] >> >> url:

Re: [PATCH net-next,v3] tools: hv: Add a script to help bonding synthetic and VF NICs

2016-07-12 Thread David Miller
From: Haiyang Zhang Date: Mon, 11 Jul 2016 17:06:42 -0700 > From: Haiyang Zhang > > This script helps to create bonding network devices based on synthetic NIC > (the virtual network adapter usually provided by Hyper-V) and the matching >

Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-05 Thread David Miller
From: Dexuan Cui <de...@microsoft.com> Date: Tue, 5 Jul 2016 06:46:24 + >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Tuesday, July 5, 2016 14:27 >> To: Dexuan Cui <de...@microsoft.com> >> Subject: Re: [PATCH v14 net-next 1/1] hv_sock: i

Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-05 Thread David Miller
From: Dexuan Cui Date: Tue, 5 Jul 2016 01:58:31 + > Not sure if you had a chance to review this version. Why me? Other people have to review this too. > Now I have a question: may I split the include/linux/socket.h change > and ask you to pre-allocate the number for

Re: [PATCH v13 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-06-30 Thread David Miller
From: Dexuan Cui Date: Wed, 29 Jun 2016 11:30:40 + > @@ -1509,4 +1509,18 @@ static inline void commit_rd_index(struct > vmbus_channel *channel) > } > > > +struct vmpipe_proto_header { > + u32 pkt_type; It is wasteful to have two empty lines before this

Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-06-28 Thread David Miller
From: Dexuan Cui Date: Tue, 28 Jun 2016 09:59:21 + > The idea here is: IMO the syscalls sys_read()/write() shoudn't return > -ENOMEM, so I have to make sure the buffer allocation succeeds? You have to fail if resources cannot be allocated.

Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-06-28 Thread David Miller
From: Dexuan Cui Date: Fri, 24 Jun 2016 07:45:24 + > + while ((ret = vmalloc(size)) == NULL) > + ssleep(1); This is completely, and entirely, unacceptable. If the allocation fails, you return an error and release your resources. You don't just loop

Re: [PATCH net-next,v2] tools: hv: Add a script to help bonding synthetic and VF NICs

2016-06-10 Thread David Miller
From: Haiyang Zhang Date: Fri, 10 Jun 2016 14:23:12 -0700 > This script helps to create bonding network devices based on synthetic NIC > (the virtual network adapter usually provided by Hyper-V) and the matching > VF NIC (SRIOV virtual function). So the synthetic NIC and

Re: [PATCH net-next v3] netvsc: get rid of completion timeouts

2016-06-09 Thread David Miller
From: Vitaly Kuznetsov Date: Thu, 9 Jun 2016 12:44:03 +0200 > I'm hitting 5 second timeout in rndis_filter_set_rss_param() while setting > RSS parameters for the device. When this happens we end up returning > -ETIMEDOUT from the function and rndis_filter_device_add() falls

Re: [PATCH net-next v2] netvsc: get rid of completion timeouts

2016-06-08 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 8 Jun 2016 19:17:41 +0200 > I'm hitting 5 second timeout in rndis_filter_set_rss_param() while setting > RSS parameters for the device. When this happens we end up returning > -ETIMEDOUT from the function and rndis_filter_device_add() falls

Re: [PATCH net-next v2 0/5] hv_netvsc: cleanup after untangling the pointer mess

2016-06-05 Thread David Miller
From: Vitaly Kuznetsov <vkuzn...@redhat.com> Date: Fri, 3 Jun 2016 17:50:57 +0200 > Changes since v1: > - resend when net-next is open [David Miller] > - rebased to current net-next. > > After we made traveling through our internal structures explicit it became > obv

Re: [PATCH net-next] hv_netvsc: Fix VF register on vlan devices

2016-06-03 Thread David Miller
From: Haiyang Zhang Date: Thu, 2 Jun 2016 12:02:04 -0700 > Added a condition to avoid vlan devices with same MAC registering > as VF. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied.

Re: [PATCH net-next 0/5] hv_netvsc: cleanup after untangling the pointer mess

2016-05-23 Thread David Miller
From: Vitaly Kuznetsov Date: Mon, 23 May 2016 17:50:33 +0200 > After we made traveling through our internal structures explicit it became > obvious that some functions take arguments they don't need just to do > redundant pointer travel and get to what they really need while

Re: [PATCH net-next] tools: hv: Add a script for bonding synthetic and VF NICs

2016-05-23 Thread David Miller
From: Haiyang Zhang Date: Thu, 19 May 2016 10:23:38 -0700 > This example script creates bonding network devices based on synthetic NIC > (the virtual network adapter usually provided by Hyper-V) and the matching > VF NIC (SRIOV virtual function). So the synthetic NIC and

Re: [PATCH v11 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-05-18 Thread David Miller
I'm travelling and very busy with the merge window. So sorry I won't be able to think about this for some time. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net-next v2 0/6] hv_netvsc: avoid races on mtu change/set channels

2016-05-16 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 13 May 2016 13:55:19 +0200 > Changes since v1: > - Rebased to net-next [Haiyang Zhang] > > Original description: > > MTU change and set channels operations are implemented as netvsc device > re-creation destroying internal structures

Re: [PATCH v11 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-05-15 Thread David Miller
From: Dexuan Cui Date: Sun, 15 May 2016 09:52:42 -0700 > Changes since v10 > > 1) add module params: send_ring_page, recv_ring_page. They can be used to > enlarge the ringbuffer size to get better performance, e.g., > # modprobe hv_sock recv_ring_page=16 send_ring_page=16

Re: [PATCH v9 net-next 1/2] hv_sock: introduce Hyper-V Sockets

2016-05-07 Thread David Miller
From: Dexuan Cui Date: Sat, 7 May 2016 10:49:25 + > I should be able to make 'send', 'recv' here to pointers and use vmalloc() > to allocate the memory for them. I will do this. That's still unswappable kernel memory. People can open N sockets, where N is something on

Re: [PATCH v9 net-next 1/2] hv_sock: introduce Hyper-V Sockets

2016-05-06 Thread David Miller
From: Dexuan Cui Date: Wed, 4 May 2016 09:56:57 -0700 > +#define VMBUS_RINGBUFFER_SIZE_HVSOCK_RECV (5 * PAGE_SIZE) > +#define VMBUS_RINGBUFFER_SIZE_HVSOCK_SEND (5 * PAGE_SIZE) > + > +#define HVSOCK_RCV_BUF_SZVMBUS_RINGBUFFER_SIZE_HVSOCK_RECV ... > +struct hvsock_sock {

Re: [PATCH net-next] hv_netvsc: Fix the list processing for network change event

2016-04-24 Thread David Miller
From: Haiyang Zhang Date: Thu, 21 Apr 2016 16:13:01 -0700 > RNDIS_STATUS_NETWORK_CHANGE event is handled as two "half events" -- > media disconnect & connect. The second half should be added to the list > head, not to the tail. So all events are processed in normal order.

Re: [PATCH net-next] hv_netvsc: Fix the order of num_sc_offered decrement

2016-03-23 Thread David Miller
From: Haiyang Zhang Date: Wed, 23 Mar 2016 14:54:48 -0700 > Reorder the code in netvsc_sc_open(), so num_sc_offered is only decremented > after vmbus_open() is called. This avoid pontential race of removing device > before all channels are setup. > > Signed-off-by:

Re: [PATCH net-next 1/3] net: add the AF_KCM entries to family name tables

2016-03-21 Thread David Miller
Two things wrong with this submission: 1) You need to provide an initial "[PATCH net-next 0/3] ..." header posting explaining at a high level what this patch series is about and how it is implemented and why. 2) The net-next tree is closed at this time because we are in the merge window,

Re: [PATCH net-next] hv_netvsc: Move subchannel waiting to rndis_filter_device_remove()

2016-03-07 Thread David Miller
From: Haiyang Zhang Date: Fri, 4 Mar 2016 15:07:43 -0800 > During hot add, vmbus_device_register() is called from vmbus_onoffer(), on > the same workqueue as the subchannel offer message work-queue, so > subchannel offer won't be processed until the

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-03 Thread David Miller
From: Arnd Bergmann Date: Wed, 2 Mar 2016 20:06:46 +0100 > The icn, act2000 and pcbit drivers are all for very old hardware, > and it is highly unlikely that anyone is actually still using them > on modern kernels, if at all. > > All three drivers apparently are for hardware

Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

2016-02-29 Thread David Miller
From: Ben Hutchings <b...@decadent.org.uk> Date: Mon, 29 Feb 2016 22:34:38 + > On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote: >> From: Simon Xiao <six...@microsoft.com> >> Date: Thu, 25 Feb 2016 15:24:08 -0800 >> >> > This patch allows the

Re: [PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

2016-02-29 Thread David Miller
From: Simon Xiao Date: Thu, 25 Feb 2016 15:24:08 -0800 > This patch allows the user to set and retrieve speed and duplex of the > hv_netvsc device via ethtool. > > Example: > $ ethtool eth0 > Settings for eth0: > ... > Speed: Unknown! > Duplex: Unknown! (255) > ...

Re: [PATCH net-next] hv_netvsc: add software transmit timestamp support

2016-02-19 Thread David Miller
From: Simon Xiao Date: Wed, 17 Feb 2016 16:43:59 -0800 > Enable skb_tx_timestamp in hyperv netvsc. > > Signed-off-by: Simon Xiao > Reviewed-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang Applied.

Re: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE

2016-02-16 Thread David Miller
From: Haiyang Zhang Date: Tue, 9 Feb 2016 15:31:34 + > 1) I share your concern as well. Is there a universal way to immediately > trigger > DHCP renew of all current and future daemons with a single event from kernel? > If not, can we put the delay

Re: [PATCH net] hv_netvsc: Restore needed_headroom request

2016-02-13 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 5 Feb 2016 17:29:08 +0100 > Commit c0eb454034aa ("hv_netvsc: Don't ask for additional head room in the > skb") got rid of needed_headroom setting for the driver. With the change I > hit the following issue trying to use ptkgen module: > >

Re: [PATCH V2 net-next] hv_netvsc: cleanup netdev feature flags for netvsc

2016-02-11 Thread David Miller
From: Simon Xiao Date: Thu, 4 Feb 2016 15:49:34 -0800 > 1. Adding NETIF_F_TSO6 feature flag; > 2. Adding NETIF_F_HW_CSUM. NETIF_F_IPV6_CSUM and NETIF_F_IP_CSUM are > being deprecated; > 3. Cleanup the coding style of flag assignment by using macro. > > Signed-off-by:

Re: [PATCH net] hv_netvsc: Restore needed_headroom request

2016-02-10 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 10 Feb 2016 11:05:50 +0100 > I'm sorry for the ping but this is kind of a regression and it would be > nice to have it fixed in 4.5. In case you can't figure it out, I'm several days backlogged and busy conferencing, travelling, etc. so

Re: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE

2016-02-09 Thread David Miller
From: Haiyang Zhang Date: Tue, 2 Feb 2016 16:15:56 -0800 > We simulates a link down period for RNDIS_STATUS_NETWORK_CHANGE message to > trigger DHCP renew. User daemons may need multiple seconds to trigger the > link down event. (e.g. ifplugd: 5sec, network-manager:

Re: [PATCH net-next] hv_netvsc: Fix book keeping of skb during batching process

2016-01-25 Thread David Miller
From: Haiyang Zhang Date: Mon, 25 Jan 2016 09:49:31 -0800 > Since eliminating send_completion_tid from struct hv_netvsc_packet, we > haven't add proper book keeping for the skb of the batched packet. This > patch fixes this issue and allows the previous skb is properly

Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation

2016-01-25 Thread David Miller
From: Vitaly Kuznetsov Date: Mon, 25 Jan 2016 16:00:41 +0100 > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit

Re: [PATCH 25/26] sctp: Use shash

2016-01-24 Thread David Miller
From: Herbert Xu Date: Sun, 24 Jan 2016 21:20:12 +0800 > This patch replaces uses of the long obsolete hash interface with > shash. > > Signed-off-by: Herbert Xu Acked-by: David S. Miller

Re: [PATCH 19/26] ipsec: Use skcipher and ahash when probing algorithms

2016-01-24 Thread David Miller
From: Herbert Xu Date: Sun, 24 Jan 2016 21:19:11 +0800 > This patch removes the last reference to hash and ablkcipher from > IPsec and replaces them with ahash and skcipher respectively. For > skcipher there is currently no difference at all, while for ahash > the

Re: [PATCH 26/26] tcp: Use ahash

2016-01-24 Thread David Miller
From: Herbert Xu Date: Sun, 24 Jan 2016 21:20:23 +0800 > This patch replaces uses of the long obsolete hash interface with > ahash. > > Signed-off-by: Herbert Xu Acked-by: David S. Miller

Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout

2016-01-14 Thread David Miller
From: Tom Herbert Date: Thu, 14 Jan 2016 13:44:24 -0800 > The fact that we can negatively affect the output of Toeplitz so > predictably is actually a liability and not a benefit. This sort of > thing can be the basis of a DOS attack and is why we kicked out XOR > hash in

Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout

2016-01-13 Thread David Miller
From: Haiyang Zhang Date: Wed, 13 Jan 2016 23:10:57 + > I have done a comparison of the Toeplitz v.s. Jenkins Hash algorithms, > and found that the Toeplitz provides much better distribution of the > connections into send-indirection-table entries. This fails to

Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout

2016-01-10 Thread David Miller
From: Vitaly Kuznetsov Date: Thu, 7 Jan 2016 10:33:09 +0100 > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit

Re: [PATCH net-next] hv_netvsc: Use simple parser for IPv4 and v6 headers

2015-12-16 Thread David Miller
From: Haiyang Zhang Date: Wed, 16 Dec 2015 19:20:44 + > In our test, we have bisected and found the following patch introduced big > overhead into skb_flow_dissect_flow_keys(), and caused performance > regression: > commit: d34af823 > net: Add VLAN ID to flow_keys

Re: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-13 Thread David Miller
From: Haiyang Zhang Date: Thu, 10 Dec 2015 12:19:35 -0800 > In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the > locking for MSD (Multi-Send Data) field was removed. This could cause a > race condition between RNDIS control messages and data

Re: [PATCH net-next V2 08/17] hv_netvsc: Don't ask for additional head room in the skb

2015-12-01 Thread David Miller
From: "K. Y. Srinivasan" Date: Sat, 28 Nov 2015 12:20:36 -0800 > +#elseif defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25) The correct CPP directive is "#elif". ___ devel mailing list de...@linuxdriverproject.org

<    1   2   3   4   >