The call was not releasing the mutex upon error.
Reported-by: kbuild test robot
Reported-by: Julia Lawall
Signed-off-by: Davidlohr Bueso
---
drivers/staging/exfat/exfat_super.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/exfat/exfat_super.c
b
On Sun, 03 Nov 2019, Julia Lawall wrote:
The return at line 747 may need an unlock.
Good catch.
...
:: The code at line 747 was first introduced by commit
:: c48c9f7ff32b8b3965a08e40eb6763682d905b5d staging: exfat: add exfat
filesystem code to staging
Indeed, this was the case
traditional lock
ownership; that is, the lock owner is the same for both lock/unlock
operations and not under irq contexts (ie for trylock/unlock scenarios).
Therefore it is safe to convert.
Signed-off-by: Davidlohr Bueso
---
This is part of further reducing semaphore users in the kernel
.
Signed-off-by: Davidlohr Bueso
---
This is in an effort to further reduce semaphore users in the kernel.
This is a resend, which just seems simpler given the confusions.
.../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
On Mon, 28 Oct 2019, Greg KH wrote:
This is obviously not in a format I can apply it in :(
What are you talking about? I sent you the original patch,
then Cc'ed the drivers mailing list. So you still have a
patch you can apply... this is quite a common way of doing
things (Ccing for future
.
Get rid of another semaphore user by replacing it with a spinlock.
Signed-off-by: Davidlohr Bueso
---
This is in an effort to further reduce semaphore users in the kernel.
.../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
On Mon, 28 Oct 2019, Stefan Wahren wrote:
Hi Davidlohr,
Am 27.10.19 um 23:15 schrieb Davidlohr Bueso:
There seems no need to be using a semaphore, or a sleeping lock
in the first place: critical region is extremely short, does not
call into any blocking calls and furthermore lock
On Fri, 09 Nov 2018, Todd Kjos wrote:
print_binder_proc() drops proc->inner_lock and calls
binder_alloc_print_allocated() which acquires proc->alloc->mutex.
Likewise, print_binder_stats() calls print_binder_proc_stats() which
drops its locks to call binder_alloc_print_pages() which also
der can get and if it matters at all.
Anyway, that said and along with addressing Todd's comments, the ipc/ bits look
good. Feel free to add my:
Reviewed-by: Davidlohr Bueso
Thanks,
Davidlohr
___
devel mailing list
de...@linuxdriverproject.org
h
On Mon, 29 Oct 2018, chouryzhou(??) wrote:
@@ -63,6 +63,12 @@ struct ipc_namespace {
unsigned intmq_msg_default;
unsigned intmq_msgsize_default;
+ /* next fields are for binder */
+ struct mutex binder_procs_lock;
+ struct hlist_head
On Mon, 29 Oct 2018, chouryzhou(??) wrote:
+// If init_ipc_ns is not defined elsewhere,
+// we make a fake one here to put our variable.
/*
* comments like this please
*/
+#if !defined(CONFIG_SYSVIPC) && !defined(CONFIG_POSIX_MQUEUE)
+struct ipc_namespace init_ipc_ns;
...
---
On Wed, 07 Nov 2018, Bueso wrote:
On Mon, 29 Oct 2018, chouryzhou(??) wrote:
+// If init_ipc_ns is not defined elsewhere,
+// we make a fake one here to put our variable.
/*
* comments like this please
*/
Actually, just drop the comment altogether. Forward declaring does not merit it.
Boqun Feng <boqun.f...@gmail.com>
fwiw,
Acked-by: Davidlohr Bueso <d...@stgolabs.net>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Call __set_current_state() instead of assigning the new state directly.
These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments,
keeping track of who changed the state.
Signed-off-by: Davidlohr Bueso dbu...@suse.de
---
drivers/staging/comedi/drivers/me_daq.c | 2 +-
drivers/staging
On Mon, 2014-06-16 at 00:28 +0400, Wahib wrote:
Hi Davidlohr!
Don't worry. I am not discouraged. :)
I understand your concern that the patch feels superficial. It's what the task
asked us to do. I suspect the author(s) of the Eudyptula Challenge designed
this task to get us involved with
On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote:
Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c.
Sorry but unless bundled with something more meaningful, I really don't
see the value in these changes. I certainly don't want to discourage
folks or anything, but just
On Thu, 2014-06-12 at 13:35 -0700, Greg Kroah-Hartman wrote:
On Thu, Jun 12, 2014 at 01:25:34PM -0700, Davidlohr Bueso wrote:
On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote:
Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c.
Sorry but unless bundled
17 matches
Mail list logo
