Re: [PATCH] staging: fsl-dpaa2: replace simple switch case by if statement

2018-03-21 Thread Denis Kirjanov
On 3/21/18, David Laight wrote: > From: > hariprasath.ela...@gmail.com >> Sent: 21 March 2018 11:16 >> From: HariPrasath Elango >> >> Replace a couple of simple switch cases by if condition > > Why? > In principle extra 'case' might be needed in the future. I had the same question when saw it. I

Re: Future of Lustre in staging

2015-11-20 Thread Denis Kirjanov
On 11/20/15, Xose Vazquez Perez wrote: > Hi, > > From https://lwn.net/Articles/662979/ > > --cut-- > Christoph complained a bit about the staging tree. He said that it > breaks allmodconfig builds, but that problem was evidently fixed a while > ago. He also dislikes the Lustre filesystem, which ha

Re: [PATCH] staging: unisys: Fix CamelCase params in SignalInsert_withLock

2014-11-06 Thread Denis Kirjanov
On 11/6/14, Depro, Kenneth J wrote: >>> If you're going to rename things, you may as well get rid of the "p". > >> And fix the function name as well... > > Denis, > I had planned on fixing the function name in a separate patch since > I thought that would constitute two separate "work items" and a

Re: [PATCH] staging: unisys: Fix CamelCase params in SignalInsert_withLock

2014-11-06 Thread Denis Kirjanov
On 11/6/14, Dan Carpenter wrote: > On Thu, Nov 06, 2014 at 12:50:10PM -0500, Ken Depro wrote: >> From: Ken Depro >> >> This patch renames the following SignalInsert_withLock parameters >> to fix the CamelCase checks: >> pChannel to pchannel > > If you're going to rename things, you may as well ge

Re: [PATCH] staging: rtl8188eu: coding style fixup

2014-10-08 Thread Denis Kirjanov
But you haven't CCed people in the CC list On 10/9/14, Igor Bogomazov wrote: > checkpatch.pl tiny fix > get rid of 2 warnings and 2 errors for hal/fw.c > > Signed-off-by: Igor Bogomazov > Cc: Greg Kroah-Hartman > Cc: navin patidar > Cc: Stephen Rothwell > --- > for linux-next 3.17.0 > > this

Re: Eudyptula Challenge (Task 10)

2014-07-28 Thread Denis Kirjanov
On 7/28/14, Lucas Tanure wrote: > Hi Christoph, > > What kind of things that you think a newbie can fix ? You can start working on fixing the pci_map_* and dma_map_* return value checks with CONFIG_DMA_API_DEBUG enabled. A lot of drivers still missing that... > Thanks > -- > Lucas Tanure > +55 (

Re: [PATCH] staging: unisys: fix visorchipset sysfs attribute functions

2014-07-25 Thread Denis Kirjanov
On 7/25/14, Benjamin Romer wrote: > This patch cleans up the style, error handling, and string handling in the > sysfs > functions recently added to visorchipset: Split your changes and send one logical change per patch > > - Use of sscanf() was changed to type-appropriate kstrto*() functions >

Re: [PATCH] drivers: staging: cxt1e1: hwprobe Fix different address spaces

2014-03-21 Thread Denis Kirjanov
On 3/21/14, Matei Oprea wrote: > Fix different address spaces when unmapping IO. hi->addr_mapped[0] > and hi->addr_mapped[1] should be tagged __iomem. > > Signed-off-by: Matei Oprea > Cc: ROSEdu Kernel Community > --- > drivers/staging/cxt1e1/hwprobe.c |4 ++-- > 1 file changed, 2 insertion

Re: [PATCH]staging: slicoss: Fix possible reuse of freed memory in timer function

2014-02-10 Thread Denis Kirjanov
On 2/10/14, Kirill Tkhai wrote: > Do not call kfree() till timer function is finished. > > [This was found using grep. Compiled tested only] > > Signed-off-by: Kirill Tkhai > CC: Joe Perches > CC: Greg Kroah-Hartman CC Chris Harrer. The problem with that driver is that alacritech guys don't s

Re: [PATCH v3 2/5] staging: et131x: drop packet when error occurs in et131x_tx

2013-11-22 Thread Denis Kirjanov
22/13, ZHAO Gang wrote: > On Fri, Nov 22, 2013 at 5:17 PM, Denis Kirjanov wrote: >> On 11/22/13, Mark Einon wrote: >>> On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote: >>>> As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY >>>

Re: [PATCH v3 2/5] staging: et131x: drop packet when error occurs in et131x_tx

2013-11-22 Thread Denis Kirjanov
On 11/22/13, Mark Einon wrote: > On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote: >> As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY >> when tx failed. >> >> et131x_tx calls function et131x_send_packets, I put the work of >> et131x_send_packets directly into et131x_t

Re: [PATCH 2/2] staging: zram: remove init_done from zram struct

2013-09-06 Thread Denis Kirjanov
I'm not familiar with the zram code, but looking through the code and init_done flag it's obvious what is going on rather then looking at zram->meta field checks. On 9/6/13, Sergey Senozhatsky wrote: > `zram->init_done != 0' equals to `zram->meta != NULL', so init_done > can be removed. > > Signe