[PATCH v3 RESEND2 1/1] staging: ion: debugfs invalid gfp mask

2016-03-11 Thread Derek Yerger
The current code attempts assignment of -1 to an unsigned type. Note that in a downstream function ion_page_pool_shrink this mask is only ever evaluated against __GFP_HIGHMEM (drivers/staging/android/ion/ion_page_pool.c, line 125). Signed-off-by: Derek Yerger <d...@drexel.edu> Reviewed-by:

[PATCH v3 RESEND 1/1] staging: ion: debugfs invalid gfp mask

2016-03-06 Thread Derek Yerger
-off-by: Derek Yerger <d...@drexel.edu> Reviewed-by: Laura Abbott <labb...@redhat.com> --- diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index c97e82b..a9c8861 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.

[PATCH v3 1/1] staging: ion: debugfs invalid gfp mask

2016-02-26 Thread Derek Yerger
-off-by: Derek Yerger <d...@drexel.edu> Reviewed-by: Laura Abbott <labb...@redhat.com> --- diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index c97e82b..a9c8861 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.

[PATCH RESEND 1/1] staging: ion: debugfs invalid gfp mask

2016-02-25 Thread Derek Yerger
). Signed-off-by: Derek Yerger <d...@drexel.edu> --- diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index c97e82b..a9c8861 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -1524,7 +1524,7 @@ static int debug_shrink_se

Re: [PATCH 1/1] staging: ion: debugfs sparse warning, proper mask

2016-02-22 Thread Derek Yerger
else 125 high = !!(gfp_mask & __GFP_HIGHMEM); Kind Regards, Derek Yerger On 02/22/2016 02:18 PM, Laura Abbott wrote: On 02/20/2016 07:15 PM, Derek Yerger wrote: From drivers/staging/android TODO file - sparse errors. The current code attempts assignment of -1 to unsigned

[PATCH 1/1] staging: ion: debugfs sparse warning, proper mask

2016-02-20 Thread Derek Yerger
used __GFP_HIGHMEM as the mask, but was removed in a subsequent revert. This patch removes the sparse errors, and fixes the assignment as noted above. Signed-off-by: Derek Yerger <d...@drexel.edu> --- diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index c