staging: lustre: Cleanup of obd_class.h

2018-01-18 Thread Fabian Huegel
Here are the remaining patches rebased on the current staging-testing. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/2] staging: lustre: Fix comment style

2018-01-18 Thread Fabian Huegel
Most multi-line comments started on the first line, but the preferred linux kernel style is to start multi-line comments on the second line. Some comments became less readable after the change, so we changed them to single-line comments. Signed-off-by: Fabian Huegel <fabian_hue...@web.de>

[PATCH 2/2] staging: lustre: Align struct member identifiers

2018-01-18 Thread Fabian Huegel
This patch properly left aligns all member identifiers in every struct defined in obd_class.h for better readability. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_

[PATCH 8/8] staging: lustre: Align backslashes in multi-line macros

2018-01-11 Thread Fabian Huegel
This patch right aligns all backslashes in multi-line macros in obd_class.h for better readability. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_c

[PATCH 6/8] staging: lustre: Fix overlong lines

2018-01-11 Thread Fabian Huegel
Fixed four lines that went over the 80 character limit to reduce checkpatch warnings. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 14 ++ 1 file

[PATCH 7/8] staging: lustre: Align struct member identifiers

2018-01-11 Thread Fabian Huegel
This patch properly left aligns all member identifiers in every struct defined in obd_class.h for better readability. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_

[PATCH 5/8] staging: lustre: Add identifier names to function declarations

2018-01-11 Thread Fabian Huegel
it imp everywhere. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/st

[PATCH 2/8] staging: lustre: Enclose complex macros in do-while loops

2018-01-11 Thread Fabian Huegel
Some complex multi-line macros were not enclosed by a do-while(0), so we fixed that. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 16 1 file

[PATCH 1/8] staging: lustre: Enclose complex macros in parentheses

2018-01-11 Thread Fabian Huegel
Checkpatch wants complex macros to be enclosed in parentheses, so we put parentheses around these four macros. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 8

[PATCH 3/8] staging: lustre: Remove DECLARE_LU_VARS macro

2018-01-11 Thread Fabian Huegel
This macro was only used in four places to declare two variables. It saved one line of code, but in our opinion hurt readability. So we removed the macro, substituting every occurrence with the declaration of the two variables (like the preprocessor would have done). Signed-off-by: Fabian Huegel

[no subject]

2018-01-11 Thread Fabian Huegel
We cleaned up a lot of checkpatch errors and warnings in obd_class.h, but there are still some CHECKs and two warnings about flow control inside macros left. Changing those macros to inline functions would probably be a good idea, unfortunatly it's not straightforward since they use '#op' to

[PATCH 4/8] staging: lustre: Fix comment style

2018-01-11 Thread Fabian Huegel
Most multi-line comments started on the first line, but the preferred linux kernel style is to start multi-line comments on the second line. Some comments became less readable after the change, so we changed them to single-line comments. Signed-off-by: Fabian Huegel <fabian_hue...@web.de>

[PATCH 1/8] staging: lustre: Enclose complex macros in parantheses

2017-12-21 Thread Fabian Huegel
Checkpatch wants complex macros to be enclosed in parantheses, so we put parantheses around these four macros. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 8

[PATCH 5/8] staging: lustre: Add identifier names to function declarations

2017-12-21 Thread Fabian Huegel
it imp everywhere. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/st

[PATCH 6/8] staging: lustre: Fix overlong lines

2017-12-21 Thread Fabian Huegel
Fixed four lines that went over the 80 character limit to reduce checkpatch warnings. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 14 ++ 1 file

staging: lustre: Cleanup of obd_class.h

2017-12-21 Thread Fabian Huegel
We cleaned up a lot of checkpatch errors and warnings in obd_class.h, but there are still some CHECKs and two warnings about flow control inside macros left. Changing those macros to inline functions would probably be a good idea, unfortunatly it's not straightforward since they use '#op' to

[PATCH 2/8] staging: lustre: Enclose complex macros in do-while loops

2017-12-21 Thread Fabian Huegel
Some complex multi-line macros were not enclosed by a do-while(0), so we fixed that. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 16 1 file

[PATCH 3/8] staging: lustre: Remove DECLARE_LU_VARS macro

2017-12-21 Thread Fabian Huegel
This macro was only used in four places to declare two variables. It saved one line of code, but in our opinion hurt readability. So we removed the macro, substituting every occurrence with the declaration of the two variables (like the preprocessor would have done). Signed-off-by: Fabian Huegel

[PATCH 8/8] staging: lustre: Align backslashes in multi-line macros

2017-12-21 Thread Fabian Huegel
This patch right aligns all backslashes in multi-line macros in obd_class.h for better readability. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_c

[PATCH 7/8] staging: lustre: Align struct member identifiers

2017-12-21 Thread Fabian Huegel
This patch properly left aligns all member identifiers in every struct defined in obd_class.h for better readability. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_

[PATCH 1/8] staging: lustre: Enclose complex macros in parentheses

2017-12-21 Thread Fabian Huegel
Checkpatch wants complex macros to be enclosed in parentheses, so we put parentheses around these four macros. Signed-off-by: Fabian Huegel <fabian_hue...@web.de> Signed-off-by: Christoph Volkert <li...@christoph-volkert.de> --- drivers/staging/lustre/lustre/include/obd_class.h | 8