On Wed, Jul 31, 2019 at 1:34 PM Sébastien Szymanski
wrote:
>
> Document "fsl,imx6ul-csi" entry.
>
> Reviewed-by: Rob Herring
> Signed-off-by: Sébastien Szymanski
Reviewed-by: Fabio Estevam
___
devel mailing list
de...@li
On Wed, Jul 31, 2019 at 1:33 PM Sébastien Szymanski
wrote:
>
> i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support
> to imx7-media-csi driver.
>
> Signed-off-by: Sébastien Szymanski
Reviewed-by: Fabio Estevam
__
Hi Phil,
On Wed, Jun 5, 2019 at 10:59 PM Phil Reid wrote:
> > #include
> This should be removed as well.
> See comment at top of linux/gpio.h
Good catch! Just sent a v2.
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.l
function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration]
These functions are provided by the
and headers, so include them to fix these
build errors.
While at it, remove as this driver is a GPIO
consumer and not a GPIO driver.
Reported-by: Randy Dunlap
Signed-o
function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration]
These functions are provided by the
and headers, so include them to fix these
build errors.
Reported-by: Randy Dunlap
Signed-off-by: Fabio Estevam
---
drivers/staging/iio/addac/adt7316.c | 2 ++
1 file c
rgument 8 has type 'size_t {aka unsigned
int}' [-Wformat=]
Reported-by: Build bot for Mark Brown
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None
drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/kp
x27;, but argument 4 has type 'long long int'
[-Wformat=]
Reported-by: Build bot for Mark Brown
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Mark KP2000_MAGIC_VALUE to avoid build warnings in ARM32
drivers/staging/kpc2000/kpc2000/core.c | 2 +-
drivers/staging/kpc2000/kpc2000/
Hi Greg,
On Wed, Jun 5, 2019 at 6:37 PM Fabio Estevam wrote:
>
> In order to print a 'long long int' type the 'llx' specifier needs to be
> used.
>
> Change it accordingly in order to fix the following build warning:
>
> drivers/staging/kpc2000/kpc2000/co
x27;, but argument 4 has type 'long long int'
[-Wformat=]
Reported-by: Build bot for Mark Brown
Signed-off-by: Fabio Estevam
---
drivers/staging/kpc2000/kpc2000/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000/core.c
b/drivers
rgument 8 has type 'size_t {aka unsigned
int}' [-Wformat=]
Reported-by: Build bot for Mark Brown
Signed-off-by: Fabio Estevam
---
drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c
Hi Lucas,
On Sat, May 18, 2019 at 6:01 PM Lucas Oshiro wrote:
>
> Add a of_device_id struct and MODULE_DEVICE_TABLE call.
Please provide an explanation as to why you are doing this.
Thanks
___
devel mailing list
de...@linuxdriverproject.org
http://dri
On Sat, May 18, 2019 at 2:38 PM Hariprasad Kelam
wrote:
>
> fix below warning reported by coccichec
>
> drivers/staging/media/imx/imx-media-capture.c:617:5-8: Unneeded
> variable: "ret". Return "0" on line 630
>
> Signed-off-by: Hariprasad Ke
Hi Sébastien,
On Tue, Apr 30, 2019 at 4:49 AM Sébastien Szymanski
wrote:
> +static const struct of_device_id imx7_csi_of_match[] = {
> + { .compatible = "fsl,imx7-csi", .data = (void *)IMX7 },
> + { .compatible = "fsl,imx6ul-csi", .data = (void *)IMX6UL },
Please add the new "fsl,im
Hi Rui,
On Fri, Dec 7, 2018 at 10:44 AM Hans Verkuil wrote:
> I got a few checkpatch warnings about coding style:
>
> CHECK: Alignment should match open parenthesis
> #953: FILE: drivers/staging/media/imx/imx7-media-csi.c:911:
> +static struct v4l2_mbus_framefmt *imx7_csi_get_format(struct imx7_
imx-ipuv3 280.ipu: driver could not parse
port@0/endpoint@0 (-22)
[3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22
Tested-by: Fabio Estevam
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Steve,
On Thu, Jan 17, 2019 at 6:15 PM Steve Longerbeam wrote:
>
> Disable the CSI immediately after receiving the last EOF before stream
> off (and thus before disabling the IDMA channel).
>
> This fixes a complete system hard lockup on the SabreAuto when streaming
> from the ADV7180, by repe
Hi Matheus,
On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino
wrote:
> Got it, thanks for the explanation! I'll correct this in v2.
One more suggestion: in v2 you could also consider to remove the legal
text that says GPL v2, as you are adding the SPDX tag.
Hi Matheus,
On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares
wrote:
>
> This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c,
> which solves the checkpatch.pl warning:
> "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1".
>
> Signed-off-by: Matheus Tavares
> ---
Hi Renato,
On Mon, Oct 8, 2018 at 7:02 PM Renato Lui Geh wrote:
>
> This patch fixes most "Alignment should match open parenthesis" check
> warnings found by checkpatch.pl in the addac/adt7316 driver.
> ---
You missed your Signed-off-by tag, which is also reported by checkpatch.pl :-)
__
On Sat, Sep 8, 2018 at 1:33 PM, Alexey Skidanov
wrote:
> Label unlock is defined but not used
You are also removing the variable 'ret', which is a different change.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.
Hi Rui,
On Mon, May 7, 2018 at 1:21 PM, Rui Miguel Silva wrote:
> + reg_peri_3p15v: regulator-peri-3p15v {
> + compatible = "regulator-fixed";
> + regulator-name = "peri_3p15v_reg";
> + regulator-min-microvolt = <315>;
> + regulat
Hi Peter,
On Tue, Mar 13, 2018 at 7:34 PM, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer
Could you please resend with a commit log explaining the reason for this patch?
Tahnks
___
devel mailing list
de...@linuxdriverproject.org
http://driverd
On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote:
> Oh, this only works for csi ports that have pinctrl in their csi port
> node, like:
>
> &ipu1_csi0 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ipu1_csi0>;
> };
This is the case for imx6qdl-sabresd.dtsi and even in
Steve, Phiipp,
On Thu, Mar 1, 2018 at 1:02 PM, Fabio Estevam wrote:
> So imx_csi_probe() does not succeed anymore since
> devm_pinctrl_get_select_default() always fails.
>
> Not sure I understand the comments that explain the need for pinctrl
> handling inside the driver.
>
&
On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva
wrote:
> Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe.
> The proper pointer to be passed as argument is pinctrl
> instead of priv->vdev.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 52e17089d185 ("media: imx: Don't
On Tue, Jun 20, 2017 at 5:29 AM, Pavel Machek wrote:
> Hmm. I changed the subject to grab Shawn's attetion.
>
> But his acks should not be needed for forward progress. Yes, it would
> be good, but he does not react -- so just reorder the series so that
> dts changes come last, then apply the part
On Fri, Mar 10, 2017 at 6:57 PM, Pavel Machek wrote:
> And it should not depend on configuration. Hardware vendor should be
> able to ship board with working device tree...
We are talking about pin conflict here. Please read the commit log of
this patch for details.
_
On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky
wrote:
> On 3/9/2017 8:52 PM, Steve Longerbeam wrote:
>> There is a pin conflict with GPIO_6. This pin functions as a power
>> input pin to the OV5642 camera sensor, but ENET uses it as the h/w
>> workaround for erratum ERR006687, to wake-up the ARM core
Hi Steve,
On Thu, Feb 16, 2017 at 12:19 AM, Steve Longerbeam
wrote:
> Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor.
>
> The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux.
>
> The OV5640 connects to the input port on the MIPI CSI-2 receiver on
> mi
On Tue, Jan 3, 2017 at 6:57 PM, Steve Longerbeam wrote:
> + camera: ov5642@3c {
> + compatible = "ovti,ov5642";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ov5642>;
> + clocks = <&clks IMX6QDL_CLK_CKO>;
> + c
off-by's.
Tested the series on a mx6qsabresd, so:
Tested-by: Fabio Estevam
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
et includes the OF graph layout as proposed by Philipp Zabel,
> with only minor changes which are enumerated in the patch header.
Patches 13, 14 and 19 miss your Signed-off-by tag.
Tested the whole series on a mx6qsabresd:
Tested-by: Fabio Estevam
_
On Tue, Feb 23, 2016 at 5:59 PM, Laura Garcia Liebana wrote:
> Prevent a kernel panic by avoiding the use of the BUG_ON macro.
> Checkpatch detected this issue.
>
> Signed-off-by: Laura Garcia Liebana
> ---
> Changes in v2:
> - According to Marc Dietrich, module creator, the WARN_ON macro
On Wed, Nov 11, 2015 at 2:27 PM, Ranjith Thangavel
wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
I would not call it a coding style issue.
___
devel mailing list
de...@linuxdriverproject.org
htt
On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee
wrote:
> According to the kernel coding style the NULL check should not be
> written as [variable] == NULL or [variable] != NULL.
It seems this not documented in Documentation/CodingStyle .
___
devel mai
On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby wrote:
> This fixes a typo: base_flag_bumber to base_flag_number
>
> Signed-off-by: Nik Nyby
> ---
> drivers/hv/hyperv_vmbus.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
Hi German,
On Tue, Jun 9, 2015 at 6:59 PM, J. German Rivera
wrote:
> This patch series includes new functionality for the Freescale fsl-mc
> bus driver.
>
> Patch 1: MC bus IRQ support
> Patch 2: add device binding path 'driver_override'
> Patch 3: Propagate driver_override for a child DPRC's chi
On Wed, May 27, 2015 at 5:25 PM, Laurent Navet wrote:
> The same code is executed regardless ret value, so this test can be
> removed.
>
> Signed-off-by: Laurent Navet
> ---
> drivers/staging/gdm72xx/usb_boot.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/gdm72xx/usb
in a patch.
> So i was trying to search for that patch in my mails and also in lkml,
> but i could not find it, so thought of mailing and asking. :(
The problem with commit 6ad6b5ed3e247 is this hunk:
diff --git a/ret.ou b/ret.ou
new file mode 100644
index 000..e69d
ms I am not able to
> find that in my personal mails nor in lkml. can you please let me know
> when it was sent..
Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.
Regards,
Fabio Estevam
___
devel
odule.h:10,
from drivers/staging/dgap/dgap.c:47:
./arch/arm64/include/asm/memory.h:39:0: note: this is the location of the
previous definition
#define PCI_IO_SIZE SZ_16M
^
Use PCI_IO_SIZE_DGAP to avoid the name collision.
Reported-by: Olof's autobuilder
Signed-off-by: Fabio Esteva
ize_t' [-Wformat=]
drivers/staging/fbtft/fbtft-io.c: In function 'fbtft_read_spi':
drivers/staging/fbtft/fbtft-io.c:110:5: warning: format '%d' expects argument
of type 'int', but argument 4 has type 'size_t' [-Wformat=]
Use '%zu' to print 's
When building for ARM64 the following build warning is seen:
drivers/staging/fbtft/fbtft-core.c:1004:4: warning: format '%d' expects
argument of type 'int', but argument 3 has type 'size_t' [-Wformat=]
Use '%zu' to print 'size_t' format.
Signed
On Thu, Nov 27, 2014 at 7:05 PM, Willy Tarreau wrote:
> Mariusz, for people who have to parse hundreds to thousands of e-mails
> a day, dealing with non-trivial operation modes like this is never easy.
>
> I think (I'll let Greg suggest what he prefers) that the most reliable
> thing to do *right
Hi Andy,
On Mon, Nov 17, 2014 at 8:53 AM, Andy Yan wrote:
> Andy Yan (11):
> staging: imx-drm: imx-hdmi: make checkpatch happy
> staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter
> staging: imx-drm: imx-hdmi: convert imx-hdmi to drm_bridge mode
> staging: imx-drm: imx
c.c and another one
for parallel-display.c.
Then follow Documentation/SubmittingPatches for the correct process.
You need to add your Signed-off-by and do not send it as attachment.
Send it via git send-email and also Cc Phillip Zabel.
Regards,
On Wed, Oct 15, 2014 at 3:54 PM, Jeff Kirsher
wrote:
> On Wed, 2014-10-15 at 15:24 -0300, Fabio Estevam wrote:
>> On Wed, Oct 15, 2014 at 2:42 PM, Jeff Kirsher
>> wrote:
>>
>> > I like the idea, but won't this exclude other 32 bit systems like MIPS
>>
On Wed, Oct 15, 2014 at 2:42 PM, Jeff Kirsher
wrote:
> I like the idea, but won't this exclude other 32 bit systems like MIPS
> and I am sure there might be others. I could assume that Beceem WIMAX
> was intended for x86 arch's that are 32 bit only, which may be a safe
> bet. The only thing we
From: Fabio Estevam
There is no need to forward declare 'struct imx_drm_crtc' because the
"imx-drm.h" header file already includes it.
Signed-off-by: Fabio Estevam
---
drivers/staging/imx-drm/imx-drm-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/sta
On Tue, Sep 30, 2014 at 2:19 PM, Karthik Nayak wrote:
> Removes the 'out of memory' warning issues by checkpatch
>
> Signed-off-by: Karthik Nayak
> ---
> drivers/staging/et131x/et131x.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et13
Hi Mark,
On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon wrote:
>
> Hi Fabio, thanks for the review.
>
> It's a space alignment of parameters to go with the previous change, to
> keep wrapping consistent in the file:
>
> - while (i2c_wack) {
> + while (1) {
> if (pci_writ
On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon wrote:
> do {
> pci_read_config_dword(pdev,
> - LBCIF_DATA_REGISTER, &val);
> + LBCIF_DATA_REGISTER,
> +
On Tue, Aug 5, 2014 at 3:49 PM, Miguel Oliveira wrote:
> From: Miguel
Please use your full name in the From field.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Jun 11, 2014 at 5:17 AM, Russell King - ARM Linux
wrote:
> The problem here is that we need more inteligence from CCF in order to
> do that - we need it to be able to reprogram the dividers so that the
> IPU DI0 clock remains at 148.5MHz while increasing the output of
> pll5_video_div thr
Hi Tim,
On Tue, Jun 10, 2014 at 3:54 PM, Tim Harvey wrote:
> Fabio,
>
> I'm following along with this thread as I see the same thing you do on
> our Ventana boards that support both LVDS and HDMI: without
> hot-plugging the HDMI connector I get not HDMI out simply by having
> the LVDS node popul
On Tue, Jun 10, 2014 at 2:04 PM, Russell King - ARM Linux
wrote:
> This diagram is drawn from the code in clk-imx6.c, and it does not
> agree with what is in the SoC manuals - this is the representation
> redrawn from the manuals:
> The difference is, there is no clock gate between the LDB
On Tue, Jun 10, 2014 at 9:58 AM, Fabio Estevam wrote:
> On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux
> wrote:
>
>> Right, so the problem isn't at the HDMI level, but at the DI level... so
>> that's where we need to debug what's being setup.
On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux
wrote:
> Right, so the problem isn't at the HDMI level, but at the DI level... so
> that's where we need to debug what's being setup. I left some debugging
> in ipu-di.c - could you try enabling that please?
Booting the kernel with the HD
On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux
wrote:
> Right, so the problem isn't at the HDMI level, but at the DI level... so
> that's where we need to debug what's being setup. I left some debugging
> in ipu-di.c - could you try enabling that please?
Sure, will capture the logs to
On Mon, Jun 9, 2014 at 3:38 PM, Fabio Estevam wrote:
> On Mon, Jun 9, 2014 at 3:15 PM, Fabio Estevam wrote:
>>> I wonder if the problem is that HDMI and LVDS are interfering with each
>>> other wrt the required pixel clock, and LVDS is winning. If we have
>>> HDMI
On Mon, Jun 9, 2014 at 3:15 PM, Fabio Estevam wrote:
>> I wonder if the problem is that HDMI and LVDS are interfering with each
>> other wrt the required pixel clock, and LVDS is winning. If we have
>> HDMI enabled, many HDMI sinks will only work if we set one of their
>&g
On Mon, Jun 9, 2014 at 2:49 PM, Russell King - ARM Linux
wrote:
> On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote:
>> On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux
>> wrote:
>>
>> > Please check the status in /sys/class/drm/card0-HDMI
On Mon, Jun 9, 2014 at 11:33 AM, Shawn Guo wrote:
> On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote:
>> On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux
>> wrote:
>>
>> > Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This
On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux
wrote:
> Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This
> should report the current state of the hotplug detection.
/sys/class/drm/card0-HDMI-A-1/status returns the correct state for
HDMI cable connection.
> Remem
Russell,
On Fri, Jun 6, 2014 at 10:56 AM, Russell King
wrote:
> The initial state at boot is assumed to be disconnected, and we hope
> to receive an interrupt to update the status. Let's be more explicit
> about the current state - reading the PHY status register tells us
> the current level of
Philipp,
On Wed, May 14, 2014 at 6:24 PM, Philipp Zabel wrote:
> Move memory allocation and resource acquisition from the bind function into
> the probe function. This calls the devres managed functions once instead of
> possibly multiple times in the bind function and avoids leaking memory (as
>
From: Fabio Estevam
WARNING: Missing a blank line after declarations
#160: FILE: drivers/staging/imx-drm/imx-hdmi.c:160:
+ u8 val = hdmi_readb(hdmi, reg) & ~mask;
+ val |= data & mask;
WARNING: Missing a blank line after declarations
#1609: FILE: drivers/staging/imx-drm/im
From: Fabio Estevam
Fix the following checkpatch warnings:
WARNING: Missing a blank line after declarations
#162: FILE: drivers/staging/imx-drm/imx-hdmi.c:162:
+ u8 val = hdmi_readb(hdmi, reg) & ~mask;
+ val |= data & mask;
WARNING: Missing a blank line after declarati
From: Fabio Estevam
No need to return a 'fake' return value on platform_get_irq() failure.
Signed-off-by: Fabio Estevam
---
drivers/staging/imx-drm/imx-hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-hdmi.c
b/drivers/staging/i
e moment since I don't
> really know the hardware or driver code well enough to be
> sure this is the "right" way of doing it.
Does this patch still cause the visual artifacts you mentioned earlier?
Regards,
Fabio Estevam
>
> Signed-off-by
From: Fabio Estevam
Use snprintf() in order to fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
As 'dmfc' could never be null, there is no need to do such check.
Report
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
R
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol
'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v3:
- None
Change
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since
From: Fabio Estevam
Use snprintf() in order to fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan
From: Fabio Estevam
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_mode
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v3:
- No
On Wed, Feb 26, 2014 at 7:44 PM, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Fix the following static checker warning:
>
> drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
> overflow. buf_size: 16 length: 18
> probably 18 is theory and not
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan Carpenter
Signed-off-by
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol
'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v2:
- None
Change
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
R
From: Fabio Estevam
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_mode
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v2:
- No
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
R
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol
'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None
drivers/s
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan Carpenter
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since
From: Fabio Estevam
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_mode
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v1:
- C
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol
'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
drivers/staging/imx-drm/imx-drm-
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
R
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan Carpenter
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
drivers/stagi
From: Fabio Estevam
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_mode
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
drivers/staging/imx-drm/
On Tue, Feb 25, 2014 at 11:23 AM, Philipp Zabel wrote:
> +Required properties:
> + - #address-cells : should be <1>
> + - #size-cells : should be <0>
> + - compatible : should be "fsl,imx6q-hdmi" or "fsl,imx6dl-hdmi".
> + - gpr : should be <&gpr>.
> + The phandle points to the iomuxc-gpr region
On Tue, Feb 25, 2014 at 11:23 AM, Philipp Zabel wrote:
> This patch adds device tree binding documentation for the HDMI transmitter
> on i.MX6.
>
> Signed-off-by: Philipp Zabel
> ---
> .../devicetree/bindings/staging/imx-drm/hdmi.txt | 53
> ++
> 1 file changed, 53 inserti
%pa format already prints in hexadecimal format, so remove the '0x' annotation
to avoid a double '0x0x' pattern.
Signed-off-by: Fabio Estevam
---
drivers/staging/android/ion/ion_cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
1 - 100 of 141 matches
Mail list logo
