Re: [PATCH v2] staging: speakup: remove simple_strtoul()

2018-05-31 Thread Gabriel Fedel
Hello Greg, Em 27-05-2018 09:46, Greg KH escreveu: On Sat, May 26, 2018 at 04:03:35PM -0300, Gabriel Fedel wrote: Replace simple_strtoul() with kstrtoul(), because simple_strtoul() is obsolete. kstrtoul and simple_strtoul are not equal, so some new code was inserted: It was necessary to pass

Re: [PATCH v2] staging: speakup: remove simple_strtoul()

2018-05-31 Thread Gabriel Fedel
Hello Dan Em 28-05-2018 10:25, Dan Carpenter escreveu: The original code is fine. Just ignore checkpatch.pl. You added some kmalloc()s without a freeing the memory afterward. It's all way more complicated than it looks... Thank you for review. You are right. I followed the checkpatch.pl, but

Re: [PATCH v2] staging: speakup: remove simple_strtoul()

2018-05-31 Thread Gabriel Fedel
Hello Samuel, Em 26-05-2018 16:17, Samuel Thibault escreveu: Hello, Gabriel Fedel, le sam. 26 mai 2018 16:03:35 -0300, a ecrit: Replace simple_strtoul() with kstrtoul(), because simple_strtoul() is obsolete. Well, rather than putting again a dozen lines of code, if simple_strtoul is really

[PATCH v2] staging: speakup: remove simple_strtoul()

2018-05-26 Thread Gabriel Fedel
part). Signed-off-by: Gabriel Fedel --- Changes since first patch: Fix C error Change the way to use kstrtoul (on first patch just substitue simple_strtoul by kstrtoul) --- drivers/staging/speakup/kobjects.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff