Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-04 Thread George Spelvin
On Sat, Apr 04, 2020 at 08:25:37PM +0300, Dan Carpenter wrote: > On Fri, Apr 03, 2020 at 11:40:28PM +0000, George Spelvin wrote: >> I understand that it's addressed more to patch authors than >> maintainers forwarding them, but I've read that thing a dozen times, >&g

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-03 Thread George Spelvin
On Fri, Apr 03, 2020 at 12:10:29PM +0300, Dan Carpenter wrote: > On Thu, Apr 02, 2020 at 03:30:34PM +0000, George Spelvin wrote: > > On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: > > > I don't know how this patch made it through two versions without anyone

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

2020-04-02 Thread George Spelvin
en touching adjacent code anyway and it doesn't cause distracting clutter. This seemed like such a case, which is why I submitted it as one. But it's a bit of style thing. >> Cc: Adham Abozaeid >> Cc: linux-wirel...@vger.kernel.org >> Reviewed-by: Ajay