Hi
On Thu, Nov 29, 2018 at 9:18 AM Popa, Stefan Serban
wrote:
>
> On Mi, 2018-11-28 at 16:15 -0200, Giuliano Belinassi wrote:
> > Previously, the AD7780 driver only supported gpio for the 'powerdown'
> > pin. This commit adds suppport for the 'gain' and 'filter' pin.
> >
> > Signed-off-by: Giulia
Hi
>While I agree that it looks nicer to indent all these to the same level,
>you also need to think about the fact that the kernel git repo is already
>pretty big as-is, so it's a good idea if a patch adds as much code/semantic
>value [as possible] with as little change [as possible] and with as
> Just some random though. Instead of introducing extra level of indentation you
> can simply check whether is_ad778x is asserted and simply return.
I agree that the patch would be smaller if I do that, but is it really
an issue? If yes, then I will update the patch with this change
> Any reason
>(There is a linux-...@googlegroups.com mailing list
>that bounces when I reply, so I removed it from the
>cc list)
Sorry. I think this may be because my HTML mode in gmail was enabled.
> I wrote that to encourage you to do more than
> what checkpatch says.
> I just moved code around and reduced
