Re: [PATCH 03/15] [media] i2c: make device_type const

2017-08-24 Thread Guennadi Liakhovetski
On Sat, 19 Aug 2017, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Acked-by: Guennadi Liakhovetski Thanks Guennadi > --- > drivers/media/i

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-11-09 Thread Guennadi Liakhovetski
On Sun, 9 Nov 2014, Philipp Zabel wrote: > Hi Guennadi, > > On Fri, Nov 07, 2014 at 11:06:21PM +0100, Guennadi Liakhovetski wrote: > > Hi Philipp, > > > > Thanks for the patch and sorry for a late reply. I did look at your > > patches earlier too, but maybe not

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-11-07 Thread Guennadi Liakhovetski
Hi Philipp, Thanks for the patch and sorry for a late reply. I did look at your patches earlier too, but maybe not attentively enough, or maybe I'm misunderstanding something now. In the scan_of_host() function in soc_camera.c as of current -next I see: epn = of_graph_get_next_

Re: [PATCH v3 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop

2014-09-20 Thread Guennadi Liakhovetski
Hi Philippe, On Thu, 11 Sep 2014, Philipp Zabel wrote: > In preparation for a following patch, stop decrementing the endpoint node > refcount in the loop. This temporarily leaks a reference to the endpoint node, > which will be fixed by having of_graph_get_next_endpoint decrement the > refcount

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-03-06 Thread Guennadi Liakhovetski
iscussion from time to time, unfortunately I don't have too much time for it now. But in any case if this work is going to be used with imx-drm too, that should be a good direction to take, I think. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Develo

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-26 Thread Guennadi Liakhovetski
have been better to use and - if needed - extend them to cover any deficiencies? Even though the implementation is currently located under drivers/media/v4l2-code/ it's pretty generic and should be easily transferable to a more generic location. Thanks Guennadi --- Guennadi Liakhovetski, P