On 3 August 2017 at 18:53, Dan Carpenter wrote:
> On Thu, Aug 03, 2017 at 06:23:54PM +0530, hari prasath wrote:
>> On 3 August 2017 at 11:52, kbuild test robot wrote:
>> > Hi Hari,
>> >
>> > [auto build test WARNING on staging/staging-testing]
>> &
lp improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Hari-Prasath/Remove-explicit-return-type-cast/20170803-080312
> config: blackfin-allyesconfig (attached as .config)
> compiler: bfin-uclinux-gcc (GCC) 6.2.0
> reproduce:
> wget
> http
Remove explicit typecasting of return value in the interrupt handlers.
Signed-off-by: Hari Prasath
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index ed737f4
Fix checkpatch warning to add space around the substraction operation
Signed-off-by: Hari Prasath
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index d5ab83f
.of_node = indio_dev->dev.parent->of_node;
>
> - Lars
>
> On 07/17/2017 02:34 PM, Hari Prasath wrote:
>> Adding missing indio_dev->dev.of_node references to allow iio consumers
>> to access the device channels.
>>
>> Signed-off-by: Hari Prasath
>>
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath
---
v2: Wrong from mail ID in first version of patch
---
drivers/staging/iio/adc/ad7192.c | 1 -
drivers/staging/iio/adc/ad7780.c | 1 -
2 files changed
Kindly discard this patch versions. I will send a new one.
On 17 July 2017 at 17:49, Hari Prasath wrote:
> Adding missing indio_dev->dev.of_node references to allow iio consumers
> to access the device channels.
>
> Signed-off-by: Hari Prasath
> ---
> v2: Wrong f
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath
---
v2: Wrong from email ID in first version of patch
---
drivers/staging/iio/adc/ad7192.c | 1 +
drivers/staging/iio/adc/ad7780.c | 1 +
2 files chan
From: Hari Prasath
Adding missing indio_dev->dev.of_node references to allow iio consumers
to access the device channels.
Signed-off-by: Hari Prasath
---
drivers/staging/iio/adc/ad7192.c | 1 +
drivers/staging/iio/adc/ad7780.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/driv
On 10 July 2017 at 01:22, Sakari Ailus wrote:
> On Sun, Jul 09, 2017 at 05:56:15PM +0530, hari prasath wrote:
>> On 8 July 2017 at 16:31, Sakari Ailus wrote:
>> > Hi Hari,
>> >
>> > On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
>>
kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool.
Signed-off-by: Hari Prasath
---
v1: Replace kmalloc followed by memcpy with kmemdup. Based on
review comments from Alan Cox, this could better be done
On 8 July 2017 at 16:31, Sakari Ailus wrote:
> Hi Hari,
>
> On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
>> kstrdup kernel primitive can be used to replace kmalloc followed by
>> string copy. This was reported by coccinelle tool
>>
>
kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool
Signed-off-by: Hari Prasath
---
.../media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
a
On 07-Jul-2017 5:25 PM, "Alan Cox" wrote:
On Fri, 2017-07-07 at 17:20 +0530, Hari Prasath wrote:
> kmemdup can be used to replace kmalloc followed by a memcpy.This was
> pointed out by the coccinelle tool.
And kstrdup could do the job even better I think ?
> Yes & thanks
kmemdup can be used to replace kmalloc followed by a memcpy.This was
pointed out by the coccinelle tool.
Signed-off-by: Hari Prasath
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
a/drivers/staging
From: Hari Prasath Gujulan Elango
This patch makes use of wait_event_interruptible_timeout to achieve
timeout functionality.This is a TODO mentiond in the comment which is also
removed.It also aligns with what the function is supposed to do as in the
comments.
Signed-off-by: Hari Prasath
From: Hari Prasath Gujulan Elango
Prefer using the eth_broadcast_addr() instead of memset to broadcast
address 0xFF to the array.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: From email address was missing as pointed by Greg.
---
drivers/staging/rtl8192e/rtllib_softmac.c | 4
From: Hari Prasath Gujulan Elango
Replace the timer API's to initialize a timer & then assign the callback
function by the setup_timer() API.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: Unwanted text present in the commit comments
sections.Removed them
---
drivers/sta
From: Hari Prasath Gujulan Elango
Date: Thu, 4 Feb 2016 18:46:31 +0530
Replace the timer API's to initialize a timer & then assign the callback
function by the setup_timer() API.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rdma/ehca/ehca_main.c | 3 +--
drivers/sta
On Wed, Feb 03, 2016 at 03:19:50PM -0800, gre...@linuxfoundation.org wrote:
> On Mon, Jan 18, 2016 at 01:42:35PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This patch move's a macro defined in the middle of a str
On Wed, Feb 03, 2016 at 10:11:04AM -0800, Laura Abbott wrote:
> On 02/03/2016 04:03 AM, Robin Murphy wrote:
> >On 03/02/16 06:49, Gujulan Elango, Hari Prasath (H.) wrote:
> >>From: Hari Prasath Gujulan Elango
> >>
> >>Use the managed version
From: Hari Prasath Gujulan Elango
Use the managed version of the dma_alloc_coherent() i.e. the
dmam_alloc_coherent() & accordingly cleanup the error handling
part.Also,remove the references to dma_free_coherent
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:kbuild test r
From: Hari Prasath Gujulan Elango
Use the managed version of the dma_alloc_coherent() i.e. the
dmam_alloc_coherent() & accordingly cleanup the error handling
part.Also,remove the references to dma_free_coherent.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/android
This patch replaces the clk_get() with devm_clk_get().Accordingly,modified
the error paths,rename error labels and removed clk_put() in probe() &
remove functions.
Signed-off-by: Hari Prasath Gujulan Elango
---
v3: Rename error path labels to suite modified code as reviewd
On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote:
> On Thu, Jan 21, 2016 at 1:11 AM, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This patch replaces the clk_get() with devm_clk_get().
> > Accordingly,modifi
From: Hari Prasath Gujulan Elango
Replace the led_classdev_register() with the platform managed version
devm_led_classdev_register() & henceforth remove the redundant
nvec_paz00_remove() function.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/nvec/nvec_paz00.c
From: Hari Prasath Gujulan Elango
This patch replaces the clk_get() with devm_clk_get().
Accordingly,modified the error paths and removed clk_put() as well.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: email address was missing in the From field.
---
drivers/staging/iio/adc
On Thu, Jan 21, 2016 at 12:45:59PM +0300, Dan Carpenter wrote:
> On Thu, Jan 21, 2016 at 09:11:38AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
>
> Your email address is missing here.
Hello Dan,
Many thanks for not
From: Hari Prasath Gujulan Elango
This patch replaces the clk_get() with devm_clk_get().
Accordingly,modified the error paths and removed clk_put() as well.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/iio/adc/spear_adc.c | 6 ++
1 file changed, 2 insertions(+), 4
From: Hari Prasath Gujulan Elango
Prefer using the eth_broadcast_addr() instead of memset to broadcast
address 0xFF to the array.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
From: Hari Prasath Gujulan Elango
Replace the memset of array to broadcast address 0xFF by using the
eth_broadcast_addr() API
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
From: Hari Prasath Gujulan Elango
This patch move's a macro defined in the middle of a structure
definition to make it more readable.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
On Thu, Dec 24, 2015 at 08:06:26AM -0800, Joe Perches wrote:
> On Thu, 2015-12-24 at 10:49 +, Gujulan Elango, Hari Prasath (H.) wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > Replace multiple if..else if..statements with simple table lookup in two
> > functi
From: Hari Prasath Gujulan Elango
Replace multiple if..else if..statements with simple table lookup in two
functions.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/most/mostcore/core.c | 41 +---
1 file changed, 24 insertions(+), 17 deletions
This patch makes use of wait_event_interruptible_timeout to achieve timeout
functionality.This is a TODO mentiond in the comment which is also removed.
It also aligns with what the function is supposed to do as in the
comments.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgnc
From: Hari Prasath Gujulan Elango
Replace multiple if..else if..statements with simple table lookup in two
functions.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/most/mostcore/core.c | 39
1 file changed, 22 insertions(+), 17 deletions
From: Hari Prasath Gujulan Elango
Replace the pre-defined macro signifying the ethernet protocol type
defined in the kernel headers instead of the numerical constant
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Hari Prasath Gujulan Elango
This patch simplifies the 'memset' done on a static 2D array.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/stagin
From: Hari Prasath Gujulan Elango
This patch uses the BIT macro for bit shift operation.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/xgifb/XGI_main_26.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers
From: Hari Prasath Gujulan Elango
This patch removes commented code.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/lustre/lustre/osc/osc_cache.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c
b/drivers/staging/lustre
From: Hari Prasath Gujulan Elango
Prefer using the BIT macro for shifting operation
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/comedi.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging
From: Hari Prasath Gujulan Elango
This patch removes the redundant __func__ from dynamic debug prints as
the pr_xxx set of functions can be dynamically controlled to include
function name.Also fix a typo in debug statement.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Address Dan
On Mon, Jun 22, 2015 at 06:15:06PM +0300, Dan Carpenter wrote:
> On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This patch modifies few debug prints from pr_err() to pr_info() as
On Tue, Jun 23, 2015 at 11:49:24AM +0300, Dan Carpenter wrote:
> On Mon, Jun 22, 2015 at 01:13:58PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This patch removes ununsed variable 'len'
> >
> &
On Tuesday 23 June 2015 02:16 PM, Dan Carpenter wrote:
> On Mon, Jun 22, 2015 at 07:26:25AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
>> @@ -122,7 +121,7 @@ void setChipClock(unsigned int frequency)
>> * Sometime, the chip cannot set up the exact clock re
On Tuesday 23 June 2015 02:07 PM, Dan Carpenter wrote:
> On Mon, Jun 22, 2015 at 04:48:01AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
>> From: Hari Prasath Gujulan Elango
>>
>> This patch fixes a typo in the debug statement
>>
>> Signed
adding him.Greg has already
added this patch.I will ensure not to miss him next time.
> On Thu, Jun 18, 2015 at 01:27:28PM +0000, Gujulan Elango, Hari Prasath (H.)
> wrote:
>> From: Hari Prasath Gujulan Elango
>>
>> The memory allocated in dgnc_tty_register() for two objects i
On Monday 22 June 2015 08:46 PM, Dan Carpenter wrote:
> On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
>> From: Hari Prasath Gujulan Elango
>>
>> This patch modifies few debug prints from pr_err() to pr_info() as they
>
From: Hari Prasath Gujulan Elango
This patch removes ununsed variable 'len'
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wlan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drive
On Mon, Jun 22, 2015 at 06:12:11PM +0530, Sudip Mukherjee wrote:
> On Mon, Jun 22, 2015 at 07:05:04AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This patch removes ununsed variable 'ret'.
> ret or len?
From: Hari Prasath Gujulan Elango
This patch removes unused variables as reported by cppcheck
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/sm750fb/ddk750_chip.c | 3 +--
drivers/staging/sm750fb/ddk750_mode.c | 3 +--
drivers/staging/sm750fb/ddk750_sii164.c | 3 +--
3
From: Hari Prasath Gujulan Elango
This patch addresses the checkpatch warning advising the usage of the
BIT macro for Bit shift operation.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Hari Prasath Gujulan Elango
This patch removes a ununsed variable msg_len and its associated code.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan_cfg.c
b
From: Hari Prasath Gujulan Elango
This patch removes the ununsed variable 'priv' at multiple instances and
all its associated code where its assigned a value.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12
1 file c
From: Hari Prasath Gujulan Elango
This patch removes ununsed variable 'ret'.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wlan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drive
From: Hari Prasath Gujulan Elango
This patch the removes the redundant assignement of the variable ret as
its being overwritren before being used anywhere.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Hari Prasath Gujulan Elango
This patch removes a unused variable timeout and the associated code.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/linux_wlan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers
From: Hari Prasath Gujulan Elango
This patch removes a couple of ununsed variable.The lines in which these
variables are assigned are also removed as they are not necessary.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/linux_mon.c | 4
1 file changed, 4
From: Hari Prasath Gujulan Elango
This patch removes the redundant initialization of the variable 'st' as
it is reassigned a new value before its being used anywhere else.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file
From: Hari Prasath Gujulan Elango
This patch removes ununsed if..else... code blocks. Its actually some
dead code.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/coreconfigurator.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers
From: Hari Prasath Gujulan Elango
This patch removes a unused variable 'u16RespLen' that is assigned a
value that is never used. The line that does the assignment is also
removed.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/coreconfigurator.c | 4 --
From: Hari Prasath Gujulan Elango
This patch fixes a typo in the debug statement
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/sm750fb/sm750_accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c
b/drivers/staging
From: Hari Prasath Gujulan Elango
This patch removes the redundant __func__ from dynamic debug prints as
the pr_xxx set of functions can be dynamically controlled to include
function name as well
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/sm750fb/sm750_accel.c | 2 +-
1
From: Hari Prasath Gujulan Elango
This patch removes the redundant __func__ from dynamic debug prints as
the pr_xxx set of functions can be dynamically controlled to include
function name as well.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c
From: Hari Prasath Gujulan Elango
This patch fixes a typo in the comments section as warned by
checkpatch.pl
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgnc/dgnc_driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
From: Hari Prasath Gujulan Elango
The memory allocated in dgnc_tty_register() for two objects is not freed
anywhere.This patch addresses this by freeing the memory in
dgnc_tty_uninit.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgnc/dgnc_tty.c | 4
1 file changed, 4
From: Hari Prasath Gujulan Elango
This patch modifies few debug prints from pr_err() to pr_info() as they
fall under that category.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/sm750fb/sm750.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
From: Hari Prasath Gujulan Elango
This patch silences the checkpatch warning 'min() should
probably be min_t'
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/lustre/lnet/selftest/rpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stag
From: Hari Prasath Gujulan Elango
This patch removed a undefined macro and debug prints associated with
it.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wlan-ng/p80211wep.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211wep.c
On Wed, Jun 17, 2015 at 09:40:42PM -0700, gre...@linuxfoundation.org wrote:
> On Tue, Jun 16, 2015 at 05:09:35AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Mon, Jun 15, 2015 at 09:55:15PM -0700, gre...@linuxfoundation.org wrote:
> > > On Mon, Jun 15, 201
On Wed, Jun 17, 2015 at 09:40:42PM -0700, gre...@linuxfoundation.org wrote:
> On Tue, Jun 16, 2015 at 05:09:35AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Mon, Jun 15, 2015 at 09:55:15PM -0700, gre...@linuxfoundation.org wrote:
> > > On Mon, Jun 15, 201
From: Hari Prasath Gujulan Elango
This patch removes a couple of ununsed MACRO's in this header file
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/slicoss/slic.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/sl
On Tue, Jun 16, 2015 at 05:07:22PM +0100, Ian Abbott wrote:
> On 16/06/15 15:22, Gujulan Elango, Hari Prasath (H.) wrote:
> >From: Hari Prasath Gujulan Elango
> >
> >This patch fixes the checkpatch warning that suggests to use the BIT
> >macro for the shifting oper
From: Hari Prasath Gujulan Elango
This patch fixes the checkpatch warning that suggests to use the BIT
macro for the shifting operation.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/comedi.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
From: Hari Prasath Gujulan Elango
This patch silences the Checkpatch.pl warning 'Prefer using the
BIT macro'
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/comedidev.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drive
From: Hari Prasath Gujulan Elango
This patch renames the very generic variable name 'todo' to
nsamples.
Signed-off-by: Hari Prasath Gujulan Elango
---
Subject line modified and variable name kept short as per
suggestion from Ian Abbott.
---
drivers/staging/comedi/drivers/am
On Tue, Jun 16, 2015 at 02:04:21PM +0100, Ian Abbott wrote:
> On 16/06/15 06:34, Gujulan Elango, Hari Prasath (H.) wrote:
> >On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote:
> >>On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote:
> >>>Fro
On Tue, Jun 16, 2015 at 02:04:21PM +0100, Ian Abbott wrote:
> On 16/06/15 06:34, Gujulan Elango, Hari Prasath (H.) wrote:
> >On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote:
> >>On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote:
> >>>Fro
From: Hari Prasath Gujulan Elango
This patch removes SIOCDEVPRIVATE + 1 ioctl. It currently is just a
stub which does some useless printks and returns. In the original code,
if the user passes priv_cmd.total_len == 0 then it will Oops. Also it
leaks memory every time it's called. I
On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote:
> On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote:
> >From: Hari Prasath Gujulan Elango
> >
> >This patch renames the very generic variable name 'todo' to
> >num_samples_to_read.
>
On Mon, Jun 15, 2015 at 09:55:15PM -0700, gre...@linuxfoundation.org wrote:
> On Mon, Jun 15, 2015 at 11:44:24AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > Thi patch removes ununsed debug macro and its references in th
On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote:
> On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote:
> >From: Hari Prasath Gujulan Elango
> >
> >This patch renames the very generic variable name 'todo' to
> >num_samples_to_read.
>
From: Hari Prasath Gujulan Elango
This patch renames the very generic variable name 'todo' to
num_samples_to_read.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/drivers/amplc_pci230.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
From: Hari Prasath Gujulan Elango
This patch replaces hard coded values with global definitions for the
Ethernet IEEE 802.3 interface defined in standard header file.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wlan-ng/p80211conv.c | 4 ++--
1 file changed, 2 insertions
From: Hari Prasath Gujulan Elango
Thi patch removes ununsed debug macro and its references in this
file.The macro is used around pr_debug which itself can be dynamically
enabled/disabled.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wlan-ng/p80211wep.c | 7 ---
1 file
From: Hari Prasath Gujulan Elango
This patch removes commented code warned by checkpatch.pl
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/emxx_udc/emxx_udc.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.h
b/drivers/staging
From: Hari Prasath Gujulan Elango
This patch removes commented code.This was a checkpatch warning.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/comedi/comedi_fops.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers
From: Hari Prasath Gujulan Elango
This patch fixes a typo in the comment section.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b
From: Hari Prasath Gujulan Elango
This patch removes the timer related wrapper functions
WILC_TimerCreate(),WILC_TimerStart(),WILC_TimerStop() and
WILC_TimerDestroy() and uses kernel API's directly.In the process,the
unused variables,files are also deleted.
Signed-off-by: Hari Prasath Gu
On Thu, Jun 11, 2015 at 12:35:48PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> This patch removes the timer related wrapper functions
> WILC_TimerCreate(),WILC_TimerStart(),WILC_TimerStop() and
> WILC_TimerDestroy() and uses kernel AP
From: Hari Prasath Gujulan Elango
This patch removes the timer related wrapper functions
WILC_TimerCreate(),WILC_TimerStart(),WILC_TimerStop() and
WILC_TimerDestroy() and uses kernel API's directly.In the process,the
unused variables,files are also deleted.
Signed-off-by: Hari Prasath Gu
From: Hari Prasath Gujulan Elango
This patch removes code that is unused for any functionality in the
ioctl SIOCDEVPRIVATE + 1.But since it is mentioned in the TODO
list that it needs to be replaced with generic API functions,the
debug print alone is left as it is.
Signed-off-by: Hari Prasath
From: Hari Prasath Gujulan Elango
This patch replaces the kmalloc followed by copy_from_user by the
wrapper routine memdup_user.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/linux_wlan.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git
iver...
That was a mistake on my part.I was sending patches to the wilc1000
driver and thats how atmel guys were CC'd by mistake.Thanks Dan for
pointing this out and thanks sudip for copying the correct maintainers.
I will take some time to go through the code/review comments and send
out ano
On Wed, Jun 10, 2015 at 01:01:20AM +0300, Dan Carpenter wrote:
> On Tue, Jun 09, 2015 at 05:27:00PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > Deleting obvious comments
> >
> > Signed-off-by: Hari Prasath
From: Hari Prasath Gujulan Elango
This patch deletes the comments secion which is obvious and outdated
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Addrressed Dan carpenter review comments to remove the entire
comments section as its outdated and obvious.
---
drivers/staging/dgap
From: Hari Prasath Gujulan Elango
The driver remove function is not the right place to cleanup resources
allocated in the driver module init.The cleanup is moved from remove
method to module exit as appropriate.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Addressed Dan Carpenters
On Tue, Jun 09, 2015 at 10:26:54PM +0300, Dan Carpenter wrote:
> On Tue, Jun 09, 2015 at 05:26:01PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > The driver remove function is not the right place to cleanup resources
>
From: Hari Prasath Gujulan Elango
This patch fixes a build warning related to the use of the time_after_eq
macro.Adding a typecast to the second argument suppresses the
warning.This warning was created by one my previous patch.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Previous
On Tue, Jun 09, 2015 at 10:41:18AM -0700, gre...@linuxfoundation.org wrote:
> On Tue, Jun 09, 2015 at 06:43:59AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This patch fixes a build warning related to the
1 - 100 of 234 matches
Mail list logo
