[PATCH] staging: rtl8723bs: core: Remove unneeded declaration WFD_OUI

Remove unneeded declaration "extern unsigned char WFD_OUI" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 02f547

[PATCH] staging: rtl8192u: Add NULL check post kzalloc

Collect returns status of kzalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index fe1f279..3240442

[Patch v2] staging: rtl8192e: Make use kmemdup

As kmemdup API does kmalloc + memcpy . We can make use of it instead of calling kmalloc and memcpy independetly. Signed-off-by: Hariprasad Kelam --- v2 - remove the netdev_info() uses for allocation failures drivers/staging/rtl8192e/rtllib_softmac.c | 24 +++- 1 file

Re: [PATCH] staging: rtl8192e: Make use kmemdup

On Sat, Aug 03, 2019 at 10:52:04AM -0700, Joe Perches wrote: > On Sat, 2019-08-03 at 23:10 +0530, Hariprasad Kelam wrote: > > As kmemdup API does kmalloc + memcpy . We can make use of it instead of > > calling kmalloc and memcpy independetly. > [] > > diff --git a/

[PATCH] staging: rtl8192e: Make use kmemdup

As kmemdup API does kmalloc + memcpy . We can make use of it instead of calling kmalloc and memcpy independetly. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8192e/rtllib_softmac.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[Patch v2 10/10] staging: rtl8723bs: core: Remove Macro "IS_MAC_ADDRESS_BROADCAST"

Remove unused macro IS_MAC_ADDRESS_BROADCAST. In future if one wants use it ,use generic API "is_broadcast_ether_addr" Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[Patch v2 09/10] staging: rtl8723bs: core: Remove unneeded variables sgi_20m,sgi_40m and sgi_80m

htpriv.sgi_* variables are of type u8 ,instead of storing them in local variables ,its better to read value directly from structure. Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 --- 1 file changed, 4 insertions(+), 7

[Patch v2 08/10] staging: rtl8723bs: core: Remove unneeded extern WFD_OUI

Remove unneeded extern variable "extern unsigned char WFD_OUI" Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/cor

[Patch v2 07/10] staging: rtl8723bs: Remove unneeded function argument for init_addba_retry_timer

init_addba_retry_timer does not use padapter, so only keep psta Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- drivers/staging/rtl8723bs/os_dep/mlme_linux.c| 2 +- 3

[Patch v2 06/10] staging: rtl8723bs: os_dep: Remove unused defines related to combo scan

Remove below defines WEXT_CSCAN_AMOUNT WEXT_CSCAN_BUF_LEN WEXT_CSCAN_NPROBE_SECTION Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b

[Patch v2 05/10] staging: rtl8723bs: os_dep: Remove unused defines

Remove below unused defines RTW_CH_MAX_2G_CHANNEL rtw_a_rates RTW_A_RATES_NUM RTW_5G_CHANNELS_NUM Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

[Patch v2 04/10] staging: rtl8723bs: hal: Remove function argument padapter

Remove function argument "padapter" in rtl8723bs_init_recv_priv function as its not being used Signed-off-by: Hariprasad Kelam --- v4 - Add patch number drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++-- drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +- drivers/staging

[Patch v2 03/10] staging: rtl8723bs: os_dep: Remove unused function argument sdio_device_id

Remove passing pdid as function argument to rtw_sdio_if1_init as it is not being used Signed-off-by: Hariprasad Kelam --- v3 - Add patch number drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

[Patch v2 02/10] staging: rtl8723bs: os_dep: Move common code to func

Inthis file all functions has below common functionality 1.Check flag padapter->bSurpriseRemoved 2.Get sdio_func structure from intf_hdl. This patch introduces two new APIs rtw_isadapter_removed,rtw_sdio_get_func which helps to do above common functionality. Signed-off-by: Hariprasad Ke

[Patch v2 01/10] staging: rtl8723bs: os_dep: Remove function _rtw_regdomain_select

This function simply returns _regdom_rd . So replace this function with actual code Signed-off-by: Hariprasad Kelam --- v2 - Add patch number drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: core: Remove Macro "IS_MAC_ADDRESS_BROADCAST"

Remove unused macro IS_MAC_ADDRESS_BROADCAST. In future if one wants use it ,use generic API "is_broadcast_ether_addr" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8

[PATCH] staging: rtl8723bs: core: Remove unneeded variables sgi_20m,sgi_40m and sgi_80m

htpriv.sgi_* variables are of type u8 ,instead of storing them in local variables ,its better to read value directly from structure. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH] staging: rtl8723bs: core: Remove unneeded extern WFD_OUI

Remove unneeded extern variable "extern unsigned char WFD_OUI" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c ind

[PATCH] staging: rtl8723bs: Remove unneeded function argument for init_addba_retry_timer

init_addba_retry_timer does not use padapter, so only keep psta Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- drivers/staging/rtl8723bs/os_dep/mlme_linux.c| 2 +- 3 files changed, 3

[PATCH] staging: rtl8723bs: os_dep: Remove unused defines related to combo scan

Remove below defines WEXT_CSCAN_AMOUNT WEXT_CSCAN_BUF_LEN WEXT_CSCAN_NPROBE_SECTION Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging

[PATCH] staging: rtl8723bs: os_dep: Remove unused defines

Remove below unused defines RTW_CH_MAX_2G_CHANNEL rtw_a_rates RTW_A_RATES_NUM RTW_5G_CHANNELS_NUM Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b

[PATCH] staging: rtl8723bs: hal: Remove function argument padapter

Remove function argument "padapter" in rtl8723bs_init_recv_priv function as its not being used. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++-- drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +- drivers/staging/rtl8723bs/os_dep/recv_li

[PATCH] staging: rtl8723bs: os_dep: Remove unused function argument sdio_device_id

Remove passing pdid as function argument to rtw_sdio_if1_init as it is not being used Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers

[PATCH] staging: rtl8723bs: os_dep: Move common code to func

Inthis file all functions has below common functionality 1.Check flag padapter->bSurpriseRemoved 2.Get sdio_func structure from intf_hdl. This patch introduces two new APIs rtw_isadapter_removed,rtw_sdio_get_func which helps to do above common functionality. Signed-off-by: Hariprasad Ke

[PATCH] staging: rtl8723bs: os_dep: Remove function _rtw_regdomain_select

This function simply returns _regdom_rd . So replace this function with actual code Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b

[PATCH] staging: rtl8723bs: hal: Remove unneeded variable pU1Tmp

Both pu8 and pU1Tmp are of same data type u8. So replace pU1Tmp with u8. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers

[PATCH] staging: media: hantro: Remove call to memset after dma_alloc_coherent

fix below issue reported by coccicheck /drivers/staging/media/hantro/hantro_vp8.c:149:16-34: WARNING: dma_alloc_coherent use in aux_buf -> cpu already zeroes out memory, so memset is not needed Signed-off-by: Hariprasad Kelam --- drivers/staging/media/hantro/hantro_vp8.c | 2 -- 1 file chan

[PATCH] staging: kpc2000: Remove null check before kfree

As kfree already has NULL check we may not need null check before calling same. Issue found with coccicheck Signed-off-by: Hariprasad Kelam --- drivers/staging/kpc2000/kpc2000_spi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b

[PATCH] staging: rtl8723bs: core: Remove Unneeded variable ret

Remove Unneeded variable ret . Return _FAIL . We cannot change return type of on_action_spct as its callback function. Issue identified with coccicheck. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH] staging: rtl8723bs: os_dep: change return type of rtw_suspend_ap_wow

Change return type of rtw_suspend_ap_wow as its always return SUCCCESS. Issue found with coccicheck Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c

[PATCH] staging: rtl8723bs: core: Change return type of init_mlme_ext_priv

As init_mlme_ext_priv function always returns SUCCESS , We can change return type from int to void. Fixes below issue identified by coccicheck drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:464:5-8: Unneeded variable: "res". Return "_SUCCESS" on line 492 Signed-off-

[PATCH] staging: rtl8723bs: os_dep: Remove code valid only for 5GHz

As per TODO ,remove code valid only for 5 GHz(channel > 14). Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c in

[PATCH] staging: rtl8723bs: core: Remove code valid only for 5GHz

As per TODO ,remove code valid only for 5 GHz(channel > 14). Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/c

[PATCH] staging: rtl8723bs: hal: Remove code valid only for 5GHz

As per TODO ,remove code valid only for 5 GHz(channel > 14). Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_com.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_co

[PATCH] staging/media/davinci_vpfe: Add null check post kmalloc

Add NULL check post memory operations Signed-off-by: Hariprasad Kelam --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 52397ad

[PATCH] staging: netlogic: Change GFP_ATOMIC to GFP_KERNEL

Below is data path of xlr_config_spill xlr_net_probe -->xlr_config_fifo_spill_area --->xlr_config_spill We can use GFP_KERNEL as this function is getting called from xlr_net_probe and there are no locks. Signed-off-by: Hariprasad Kelam --- drivers/staging/netlogic/xlr_net.c | 2 +-

[PATCH] staging/rtl8188eu/os_dep: Remove unneeded variable ret

Below list of functions returns 0 in success and -EINVAL in failure. So directly return 0 on Success. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging

Re: [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

On Sat, Jun 29, 2019 at 03:57:22PM +0530, Hariprasad Kelam wrote: Please ignore this patch > fix below issues reported by checkpatch > > CHECK: Using comparison to false is error prone > CHECK: Using comparison to true is error prone > > Signed-off-by: Hariprasad Kelam > -

[PATCH 10/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 09/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 08/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_phy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 06/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 05/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_DIG.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 04/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 03/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 02/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 01/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_intf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[Patch v3] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData

Remove set but unsed variable pHalData in below functions _InitOperationMode, SetHwReg8723BS. Signed-off-by: Hariprasad Kelam --- v2 add clean change log v3 remove unneeded blank lines --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData

On Thu, Jun 27, 2019 at 09:38:35AM +0300, Dan Carpenter wrote: > On Wed, Jun 26, 2019 at 11:14:59PM +0530, Hariprasad Kelam wrote: > > @@ -1433,7 +1430,6 @@ static void SetHwReg8723BS(struct adapter *padapter, > > u8 variable, u8 *val) > > #endif > > #endif > >

[Patch v2] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData

Remove set but unsed variable pHalData in below functions _InitOperationMode, SetHwReg8723BS. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging

[PATCH] staging: rtl8723bs: hal: rtl8723b_rf6052: collect return status directly

Remove variable rtStatus and return phy_RF6052_Config_ParaFile function directly Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers

[PATCH] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData

Remove set but unsed variable pHalData in below functions _InitOperationMode SetHwReg8723BS Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging

[PATCH] staging: rtl8723bs: hal: rtl8723b_hal_init: remove set but unused variable pHalData

Remove set but unsed variable pHalData in hw_var_set_mlme_join function Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal

[PATCH] staging: rtl8723bs: hal: rtl8723b_cmd: remove set but unused variable

Remove set but unsed variable pHalData in rtl8723b_set_FwRsvdPagePkt function Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal

[PATCH 2/2] staging: rtl8723bs: hal: hal_btcoex: Remove unneeded variable PHalData

pHalData is not being used in halbtcoutsrc_LeaveLowPower. So remove the same. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal

[PATCH 1/2] staging: rtl8723bs: hal: hal_btcoex: Using comparison to true is error prone

fix below issues reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH] staging: rtl8723bs: hal: hal_btcoex: Remove variables pHalData and pU1Tmp

Remove pHalData variable as it is set but unused in function. Remove pU1Tmp and replace this with pu8 Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH] staging: rtl8723bs: HalBtc8723b1Ant: fix Using comparison to true is error prone

This patch fixes below issue reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 1 file changed, 4 insertions(+), 4 deletions

[PATCH] staging: rtl8723bs: hal: odm_RegConfig8723B: fix Lines should not end with a '('

this patch fixes below issue reported by checkpatch.pl CHECK: Lines should not end with a '(' CHECK: Lines should not end with a '(' Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/odm_RegConfig8723B.h | 61 ++ 1 file changed, 28 insertions(+), 33

[Patch v3] staging: rtl8723bs: os_dep: ioctl_linux: make use of kzalloc

() check is not accurate when preempt is disabled. In this code we are not in IRQ context and we are not holding any spin_locks so GFP_KERNEL is safe. Signed-off-by: Hariprasad Kelam changes in v2: Replace rtw_zmalloc with kzalloc changes in v3: Add proper changelog --- --- drivers/staging

[PATCH 2/2] staging: rtl8723bs: hal: rtl8723b_cmd: fix comparison to true is error prone

this patch fixes below issues reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions

[PATCH 1/2] staging: rtl8723bs: hal: rtl8723b_cmd: fix Comparison to NULL

This patch fixes below issues reported by checkpatch CHECK: Comparison to NULL could be written "psta" CHECK: Comparison to NULL could be written "pmlmepriv->wps_probe_resp_ie" CHECK: Comparison to NULL could be written "psta" Signed-off-by: Hariprasad Kelam -

[PATCH] staging: wilc1000: Remove redundant memset

alloc_etherdev function internally calls kvzalloc . So we may not need explicit memset after this call. Signed-off-by: Hariprasad Kelam --- drivers/staging/wilc1000/wilc_netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_netdev.c b/drivers/staging

[PATCH] staging: rtl8192e: rtllib_module: Remove redundant memset

alloc_etherdev function internally calls kvzalloc . So we may not need explicit memset after this call. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8192e/rtllib_module.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging

[PATCH] staging: rtl8192u: ieee80211: Remove redundant memset

alloc_etherdev function internally calls kvzalloc . So we may not need explicit memset after this call. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH] staging: rtl8712: rtl87x_io : make use of kzalloc

kmalloc followed by memset can be replaced with kzalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8712/rtl871x_io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_io.c b/drivers/staging/rtl8712/rtl871x_io.c index 17dafef

[Patch v3] staging: rtl8723bs: hal: odm_HWConfig: Unneeded variable: "result". Return "HAL_STATUS_SUCCESS"

Remove function ODM_ConfigMACWithHeaderFile as trace is not necessary and as it is getting called only once and call direct function "ODM_ReadAndConfig_MP_8723B_MAC_REG" Issue identified by coccicheck Signed-off-by: Hariprasad Kelam changes v2: fixed typo in commit message

[Patch v2] staging: rtl8723bs: os_dep: ioctl_linux: make use of kzalloc

kmalloc with memset can be replaced with kzalloc. Signed-off-by: Hariprasad Kelam - changes in v2: Replace rtw_zmalloc with kzalloc --- --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging: rtl8723bs: os_dep: ioctl_linux: Make use rtw_zmalloc

On Sun, Jun 16, 2019 at 10:15:22AM +0300, Dan Carpenter wrote: > On Sun, Jun 16, 2019 at 11:02:50AM +0530, Hariprasad Kelam wrote: > > rtw_malloc with memset can be replace with rtw_zmalloc. > > > > Signed-off-by: Hariprasad Kelam > > --- > > drivers/staging/rt

[PATCH] staging: rtl8723bs: hal: rtl8723b_rf6052: fix spaces preferred around unary operator

ERROR: spaces required around that '<<' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c b/drivers/staging/rtl8723

[PATCH 3/3] staging: rtl8723bs: hal: rtl8723b_hal_init: Remove set but unused variable

Remove variable pHalData as it is not being used in function. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal

[PATCH 2/3] staging: rtl8723bs: hal: rtl8723b_hal_init: fix Using comparison to true is error prone

This patch tries to fix below issues reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to true is false prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 38 +++ 1 file changed, 19

[PATCH 1/3] staging: rtl8723bs: hal: rtl8723b_hal_init: fix Comparison to NULL

This patch tries to fix below issues reported by checkpatch CHECK: Comparison to NULL could be written "!efuseTbl" CHECK: Comparison to NULL could be written "!psta" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++-- 1 file c

[PATCH] staging: rtl8723bs: os_dep: ioctl_linux: Make use rtw_zmalloc

rtw_malloc with memset can be replace with rtw_zmalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: os_dep: Make use rtw_zmalloc

rtw_malloc with memset can be replaced with rtw_zmalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs

[PATCH] staging/rtl8723bs/core/rtw_ap: Remove redundant call to memset

rtw_zmalloc is internally doing memset . So there is no need to call memset again. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c

[PATCH] staging/rtl8723bs/core: Remove redundant call to memset

rtw_zmalloc is doing memset . So there is no need to call memset again. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index

[PATCH] staging: rtl8723bs: hal: Add null check after memory allocation

Add NULL check post call to rtw_zmalloc. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index ac79de8..9177c18 100644

[Patch v2 1/2] staging: rtl8723bs: hal: Remove return type of initrecvbuf

change return of initrecvbuf from s32 to void. As this function always returns SUCCESS . Signed-off-by: Hariprasad Kelam --- changes in v2: break the patch for specific change --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions

[Patch v2 2/2] staging: rtl8723bs: hal: fix Using comparison to false is error prone

fix below issue reported by checkpatch CHECK: Using comparison to false is error prone Signed-off-by: Hariprasad Kelam --- changes in v2: break the patch for specific change --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] staging: rtl8723bs: hal: Remove return type of initrecvbuf

change return of initrecvbuf from s32 to void. As this function always returns SUCCESS . fix checkpatch warning "Comparison to false is error prone" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 10 +++--- 1 file changed, 3 insertions(+), 7

[PATCH 2/2] staging: rtl8723bs: hal: spaces preferred around unary operator

This patch fixes below issues reported by checkpatch CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 1 file changed, 4 insertions(+), 4 deletions

[PATCH 1/2] staging: rtl8723bs: hal: Using comparison to true is error prone

fix below issue reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 26 +- 1 file changed, 13 insertions(+), 13

[Patch v2 2/3] staging: rtl8723bs: hal: sdio_halinit: fix spaces preferred around that unary operator

This patch fixes below issues reported by checkpatch CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Hariprasad Kelam -- changes in v2: Send proper patch without corr

[Patch v2 3/3] staging: rtl8723bs: hal: sdio_halinit: fix Comparison to NULL

This patch fixes below issue reported by checkpatch CHECK: Comparison to NULL could be written "psta" CHECK: Comparison to NULL could be written "psta" Signed-off-by: Hariprasad Kelam - changes in v2: Send proper patch with out corruption --- drivers/s

[Patch v2 1/3] staging: rtl8723bs: hal: sdio_halinit: fix comparison to true/false is error prone

fix below issues reported by checkpatch CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam changes in v2: send proper patch without corruption --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 18

[PATCH 1/2] staging: rtl8723bs: hal: sdio_halinit: fix comparison to true/false is error prone

CHECK: Using comparison to false is error prone CHECK: Using comparison to true is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH 2/2] staging: rtl8723bs: hal: sdio_halinit: fix spaces preferred around that unary operator

CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '<<' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 92 ++-- 1 file chang

[PATCH] staging: rtl8723bs: hal: Change return type to void from u8

The function HalQueryTxOQTBufferStatus8723BSdio always returns true and caller functions are not bother about return status. Change return type to void. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +-- drivers/staging/rtl8723bs/include/sdio_ops.h | 2

[PATCH 3/3] staging: rtl8723bs: hal: sdio_ops: fix braces {} are not necessary for single statement blocks

This patch fixes below issue reported by checkpatch WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 2/3] staging: rtl8723bs: hal: sdio_ops: fix spaces preferred around unary operator

CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 12

[PATCH 1/3] staging: rtl8723bs: hal: sdio_ops: fix Comparison to NULL

this patch fixes below warning reported by checkpatch CHECK: Comparison to NULL could be written "c2h_evt" Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/

[PATCH 2/2] rtl8723bs: os_dep: fix spaces preferred around unary operator

CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 24 1 file changed, 12 insertions

[PATCH 1/2] staging: rtl8723bs: fix issue Comparison to NULL

This patch fixes below issues reported by checkpatch CHECK: Comparison to NULL could be written "rtw_proc" CHECK: Comparison to NULL could be written "!rtw_proc" CHECK: Comparison to NULL could be written "!rtw_proc" Signed-off-by: Hariprasad Kelam --- dr

[PATCH] staging: rtl8723bs: fix spaces required around unary operator

this patch fixes below issues reported by checkpatch ERROR: spaces required around that '=' (ctx:WxV) ERROR: spaces required around that '=' (ctx:WxV) ERROR: spaces required around that '<' (ctx:VxV) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/osdep_service.c |

[PATCH 3/3] staging: rtl8723bs: provide spaces around unary operators

mitframe_cnt > (NR_XMITFRAME/4)) { ^ Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_lin

[PATCH 2/3] staging: rtl8723bs: fix issue "Using comparison to true is error prone"

this patch fixes below issue reported by checkpatch CHECK: Using comparison to true is error prone + if (res == true) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] staging: rtl8723bs: fix warning comparison to NULL

This patch fixes below issue reported by checkpatch CHECK: Comparison to NULL could be written "!pxmitbuf->pallocated_buf" + if (pxmitbuf->pallocated_buf == NULL) Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +- 1 file chan

  1   2   >