On 11/4/20 3:45 PM, Maxime Ripard wrote:
> On Wed, Nov 04, 2020 at 01:38:08PM -0300, Helen Koike wrote:
>>
>>
>> On 11/4/20 8:17 AM, Paul Kocialkowski wrote:
>>> Hi,
>>>
>>> On Mon 02 Nov 20, 10:21, Maxime Ripard wrote:
>>>>
On 11/4/20 8:17 AM, Paul Kocialkowski wrote:
> Hi,
>
> On Mon 02 Nov 20, 10:21, Maxime Ripard wrote:
>> On Fri, Oct 30, 2020 at 07:45:18PM -0300, Helen Koike wrote:
>>> On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
>>>> The A31 MIPI CSI-2 controller
Hi Paul,
On 11/4/20 8:11 AM, Paul Kocialkowski wrote:
> Hi Helen,
>
> On Fri 30 Oct 20, 19:44, Helen Koike wrote:
>> Hi Paul,
>>
>> I have some comments through the series, I hope this helps.
>
> Thanks for your comments :)
>
>> On 10/23/20 2:45 PM
Hi Paul,
On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
> Both 10 and 12-bit Bayer formats are stored aligned as 16-bit values
> in memory, not unaligned 10 or 12 bits.
>
> Since the current code for retreiving the bpp is used only to
> calculate the memory storage size of the picture (which is
Hi Paul,
On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
> The A31 MIPI CSI-2 controller is a dedicated MIPI CSI-2 controller
> found on Allwinner SoCs such as the A31 and V3/V3s.
>
> It is a standalone block, connected to the CSI controller on one side
> and to the MIPI D-PHY block on the other.
Hello,
On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
> The Allwinner A31 D-PHY supports both Rx and Tx modes. While the latter
> is already supported and used for MIPI DSI this adds support for the
> former, to be used with MIPI CSI-2.
>
> This implementation is inspired by the Allwinner BSP
Hi Paul,
I have some comments through the series, I hope this helps.
On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
> This series introduces support for MIPI CSI-2, with the A31 controller that is
> found on most SoCs (A31, V3s and probably V5) as well as the A83T-specific
> controller. While the
sensor->lanes, cfg);
> - phy_set_mode(sensor->dphy, PHY_MODE_MIPI_DPHY);
> + phy_set_mode_ext(cdev->dphy, PHY_MODE_MIPI_DPHY,
> + PHY_MIPI_DPHY_SUBMODE_RX);
>From rkisp1 pov, looks good to me
Acked-by: Helen Koike
Regards,
He
Hi Rob,
On 10/20/20 12:14 PM, Rob Herring wrote:
> On Wed, Oct 14, 2020 at 11:46 AM Helen Koike
> wrote:
>>
>> Hi Rob,
>>
>> Thnaks for your reply.
>>
>> On 9/22/20 11:24 AM, Rob Herring wrote:
>>> On Wed, Jul 22, 2020 at 9:56 AM Helen Ko
The Rockchip ISP bindings was moved out of staging.
Update MAINTAINERS file with the new path.
Fields sorted according to output of
./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS
--order
Signed-off-by: Helen Koike
Reviewed-by: Tomasz Figa
---
MAINTAINERS | 2 ++
1
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Verified with:
make ARCH=arm64 dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../devicetree/bindings
Organize properties order in dt-bindings to move it out of staging.
On top: compatible, reg and interrupts.
Then alphabetical order, then properties starting with '#'.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../bindings/media/rockchip-isp1.yaml
hclk_isp1_wrapper
aclk_isp0_wrapper
aclk_isp0_noc
hclk_isp0
hclk_isp0_wrapper
hclk_isp0_noc
pclkin_isp1_wrapper
Signed-off-by: Helen Koike
Reviewed-by: Tomasz Figa
---
Changes in V6:
- Define clocks in the top
From: Shunqian Zheng
RK3399 has two ISPs, but only isp0 was tested.
Add isp0 node in rk3399 dtsi
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen
-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../Documentation/devicetree/bindings/media/rockchip-isp1.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
b/drivers
From: Eddie Cai
Enable ISP and camera sensor ov2685 and ov5695 for Scarlet Chromebook
Verified with:
make ARCH=arm64 dtbs_check
Signed-off-by: Shunqian Zheng
Signed-off-by: Eddie Cai
Signed-off-by: Tomasz Figa
Signed-off-by: Helen Koike
Reviewed-by: Tomasz Figa
---
.../boot/dts
Add missing required items in Rockchip ISP1 dt-bindings example for
a complete i2c node.
Drop unit address to Fix error:
/example-0/parent/i2c@ff16: node has a unit name, but no reg or ranges
property
Remove unecessary fields for the example.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Add missing required nodes in json-schema yaml file for
Rockchip ISP1 dt-bindings.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 8
1 file changed, 8 insertions(+)
diff --git
a/drivers
, as sugested by Johan Jonker in v1,
before moving them out of staging.
Eddie Cai (1):
arm64: dts: rockchip: add isp and sensors for Scarlet
Helen Koike (7):
media: staging: dt-bindings: rkisp1: add missing required nodes
media: staging: dt-bindings: rkisp1: drop i2c unit address
media:
Thank you Tomasz and Robin for your comments,
On 10/14/20 1:43 PM, Tomasz Figa wrote:
> On Wed, Oct 14, 2020 at 6:27 PM Helen Koike wrote:
>>
>> Hi Tomasz,
>>
>> On 9/26/20 10:00 AM, Tomasz Figa wrote:
>>> Hi Helen,
>>>
>>> On Wed, Jul 22,
Hi Rob,
Thnaks for your reply.
On 9/22/20 11:24 AM, Rob Herring wrote:
> On Wed, Jul 22, 2020 at 9:56 AM Helen Koike wrote:
>>
>> aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of
>> hclk_isp, thus we can remove parents from the list.
>>
>>
Hi Tomasz,
On 9/26/20 10:00 AM, Tomasz Figa wrote:
> Hi Helen,
>
> On Wed, Jul 22, 2020 at 12:55:32PM -0300, Helen Koike wrote:
>> From: Shunqian Zheng
>>
>> RK3399 has two ISPs, but only isp0 was tested.
>> Add isp0 node in rk3399 dtsi
>>
>>
From: Eddie Cai
Enable ISP and camera sensor ov2685 and ov5695 for Scarlet Chromebook
Verified with:
make ARCH=arm64 dtbs_check
Signed-off-by: Shunqian Zheng
Signed-off-by: Eddie Cai
Signed-off-by: Tomasz Figa
Signed-off-by: Helen Koike
---
This patch is based on:
https://chromium
From: Shunqian Zheng
RK3399 has two ISPs, but only isp0 was tested.
Add isp0 node in rk3399 dtsi
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen
The Rockchip ISP bindings was moved out of staging.
Update MAINTAINERS file with the new path.
Fields sorted according to output of
./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS
--order
Signed-off-by: Helen Koike
---
V3:
- Add line:
L: linux-rockc
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Verified with:
make ARCH=arm64 dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Helen Koike
Acked-by: Rob Herring
---
.../devicetree/bindings/media/rockchip-isp1.yaml
Add missing required items in Rockchip ISP1 dt-bindings example for
a complete i2c node.
Drop unit address to Fix error:
/example-0/parent/i2c@ff16: node has a unit name, but no reg or ranges
property
Remove unecessary fields for the example.
Signed-off-by: Helen Koike
---
Changes in v5
Add missing required nodes in json-schema yaml file for
Rockchip ISP1 dt-bindings.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
---
Changes in v2:
- New patch in the series
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 8
1 file changed, 8 insertions(+)
diff
hclk_isp1_wrapper
aclk_isp0_wrapper
aclk_isp0_noc
hclk_isp0
hclk_isp0_wrapper
hclk_isp0_noc
pclkin_isp1_wrapper
Signed-off-by: Helen Koike
---
Changes in V5:
- Use if/then schema as suggested by Rob Herring
-by: Helen Koike
---
V5:
- Patch re-written to drop the unit address instead of adding reg
V3:
- this is a new patch in the series
---
.../Documentation/devicetree/bindings/media/rockchip-isp1.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/staging/media/rkisp1
Organize properties order in dt-bindings to move it out of staging.
On top: compatible, reg and interrupts.
Then alphabetical order, then properties starting with '#'.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
---
V5:
- s/binbings/bindings
V2:
- this is a new patch in the series
patches modifying bindings, as sugested by Johan Jonker in v1,
before moving them out of staging.
Eddie Cai (1):
arm64: dts: rockchip: add isp and sensors for Scarlet
Helen Koike (7):
media: staging: dt-bindings: rkisp1: add missing required nodes
media: staging: dt-bindings: rkisp1: dr
Hi Rob,
Thanks for your review.
On 7/17/20 2:49 PM, Rob Herring wrote:
> On Thu, Jul 2, 2020 at 1:13 PM Helen Koike wrote:
>>
>> aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of
>> hclk_isp, thus we can remove parents from the list.
>
> But i
From: Eddie Cai
Enable ISP and camera sensor ov2685 and ov5695 for Scarlet Chromebook
Verified with:
make ARCH=arm64 dtbs_check
Signed-off-by: Shunqian Zheng
Signed-off-by: Eddie Cai
Signed-off-by: Tomasz Figa
Signed-off-by: Helen Koike
---
This patch is based on:
https://chromium
From: Shunqian Zheng
RK3399 has two ISPs, but only isp0 was tested.
Add isp0 node in rk3399 dtsi
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen
The Rockchip ISP bindings was moved out of staging.
Update MAINTAINERS file with the new path.
Fields sorted according to output of
./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS
--order
Signed-off-by: Helen Koike
---
V3:
- Add line:
L: linux-rockc
pclkin_isp1_wrapper
Signed-off-by: Helen Koike
---
Changes in V4:
- update binding according to suggestion by Robin Murphy
on https://patchwork.kernel.org/patch/11475007/
Changes in V3:
- this is a new patch in the series
---
.../bindings/media/rockchip-isp1.yaml | 30 +--
drivers
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Verified with:
make ARCH=arm64 dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Helen Koike
Acked-by: Rob Herring
---
.../devicetree/bindings/media/rockchip-isp1.yaml
t in MAINTAINERS and reorder items
- add Scarlet sensors dt nodes to the series
Changes in v2:
Add patches modifying bindings, as sugested by Johan Jonker in v1,
before moving them out of staging.
Eddie Cai (1):
arm64: dts: rockchip: add isp and sensors for Scarlet
Helen Koike (7):
media: s
-by: Helen Koike
---
V3:
- this is a new patch in the series
---
.../Documentation/devicetree/bindings/media/rockchip-isp1.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git
a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
b/drivers/staging/media
Add missing required items in Rockchip ISP1 dt-bindings example for
a complete i2c node.
Signed-off-by: Helen Koike
---
Changes in v2:
- new patch in the series
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 5 +
1 file changed, 5 insertions(+)
diff --git
a/drivers
Organize properties order in dt-binbings to move it out of staging.
On top: compatible, reg and interrupts.
Then alphabetical order, then properties starting with '#'.
Signed-off-by: Helen Koike
---
V2:
- this is a new patch in the series
---
.../bindings/media/rockchip-isp1.yaml
Add missing required nodes in json-schema yaml file for
Rockchip ISP1 dt-bindings.
Signed-off-by: Helen Koike
---
Changes in v2:
- New patch in the series
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 8
1 file changed, 8 insertions(+)
diff --git
a/drivers/staging
On 7/2/20 1:54 PM, Helen Koike wrote:
> aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of
> hclk_isp, thus we can remove parents from the list, with the goal to
> cleanup the dt-bindings and remove it from staging.
>
> For reference, this is the isp
From: Shunqian Zheng
RK3399 has two ISPs, but only isp0 was tested.
Add isp0 node in rk3399 dtsi
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen
From: Eddie Cai
Enable ISP and camera sensor ov2685 and ov5695 for Scarlet Chromebook
Verified with:
make ARCH=arm64 dtbs_check
Signed-off-by: Shunqian Zheng
Signed-off-by: Eddie Cai
Signed-off-by: Tomasz Figa
Signed-off-by: Helen Koike
---
This patch is based on:
https://chromium
-by: Helen Koike
---
V3:
- this is a new patch in the series
---
.../Documentation/devicetree/bindings/media/rockchip-isp1.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git
a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
b/drivers/staging/media
Add missing required nodes in json-schema yaml file for
Rockchip ISP1 dt-bindings.
Signed-off-by: Helen Koike
---
Changes in v3: None
Changes in v2:
- New patch in the series
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 8
1 file changed, 8 insertions(+)
diff --git
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Verified with:
make ARCH=arm64 dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Helen Koike
Acked-by: Rob Herring
---
.../devicetree/bindings/media/rockchip-isp1.yaml
Organize properties order in dt-binbings to move it out of staging.
On top: compatible, reg and interrupts.
Then alphabetical order, then properties starting with '#'.
Signed-off-by: Helen Koike
---
V3: none
V2:
- this is a new patch in the series
---
.../bindings/media/rockchip-isp1.yaml
The Rockchip ISP bindings was moved out of staging.
Update MAINTAINERS file with the new path.
Fields sorted according to output of
./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS
--order
Signed-off-by: Helen Koike
---
V3:
- Add line:
L: linux-rockc
Add missing required items in Rockchip ISP1 dt-bindings example for
a complete i2c node.
Signed-off-by: Helen Koike
---
Changes in v3: None
Changes in v2:
- new patch in the series
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 5 +
1 file changed, 5 insertions
g them out of staging.
Eddie Cai (1):
arm64: dts: rockchip: add isp and sensors for scarlet
Helen Koike (7):
media: staging: dt-bindings: rkisp1: add missing required nodes
media: staging: dt-bindings: rkisp1: add required items in i2c example
media: staging: dt-bindings: rkisp1: re-order
hclk_isp0
hclk_isp0_wrapper
hclk_isp0_noc
pclkin_isp1_wrapper
Signed-off-by: Helen Koike
---
Changes in V3:
- this is a new patch in the series
---
.../bindings/media/rockchip-isp1.yaml | 33 ++-
drivers/staging/media/rkisp1/rkisp1-dev.c | 2
The Rockchip ISP bindings was moved out of staging.
Update MAINTAINERS file with the new path.
Suggested-by: Johan Jonker
Signed-off-by: Helen Koike
---
V2:
- This is a new patch in the series
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
-by: Helen Koike
---
V2:
- re-order power-domains property
V1:
This patch was originally part of this patchset:
https://patchwork.kernel.org/patch/10267431/
The only difference is:
- add phy properties
- add ports
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 27
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Verified with:
make ARCH=arm64 dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Helen Koike
---
V2:
- no changes
.../devicetree/bindings/media/rockchip-isp1.yaml
reg property is not used in Rockchip MIPI DPHY RX0 bindings, thus remove
it.
Suggested-by: Johan Jonker
Signed-off-by: Helen Koike
---
Changes in v2:
- this is a new patch in the series
---
.../devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml| 3 ---
1 file changed, 3 deletions
Add missing required nodes in json-schema yaml file for
Rockchip ISP1 dt-bindings.
Suggested-by: Johan Jonker
Signed-off-by: Helen Koike
---
Changes in v2:
- New patch in the series
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 8
1 file changed, 8 insertions
Organize properties order in dt-binbings to move it out of staging.
On top: compatible, reg and interrupts.
Then alphabetical order, then properties starting with '#'.
Suggested-by: Johan Jonker
Signed-off-by: Helen Koike
---
V2:
- this is a new patch in the series
---
.../bindings/media
From: Shunqian Zheng
Designware MIPI D-PHY, used for ISP0 in rk3399.
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen Koike
---
Changes
Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy
Verified with:
make ARCH=arm64 dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
Signed-off-by: Helen Koike
---
V2:
- no changes
.../devicetree/bindings/phy/rockchip
Add missing required items in Rockchip ISP1 dt-bindings example for
a complete i2c node.
Suggested-by: Johan Jonker
Signed-off-by: Helen Koike
---
Changes in v2:
- new patch in the series
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 5 +
1 file changed, 5 insertions
.
Changes in v2:
Add patches modifying bindings, as sugested by Johan Jonker in v1,
before moving them out of staging.
Johan, I added a Suggested-by tag in the commits, please let me know if
you prefer not having the tag there.
Helen Koike (7):
media: staging: dt-bindings: rkisp1: add missing required
On 4/2/20 1:17 PM, Ezequiel Garcia wrote:
> (+Kishon)
>
> Hi Helen,
>
> I was wondering if we couldn't also move the phy driver out of staging.
I think we can, let's move it.
Regards,
Helen
>
> Thanks,
> Ezequiel
>
> On Wed, 2020-04-01 at 21:02 -0300,
On 4/2/20 2:20 PM, Johan Jonker wrote:
> Hi Helen,
>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> index fc0295d2a65a1..815099a0cd0dd 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++
>>
>> title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings
>>
>> maintainers:
>> - Helen Koike
>> - Ezequiel Garcia
>>
>> description: |
>> The Rockchip SoC has a MIPI D-PHY bus with an RX0 entry which connects to
>>
ta-schemas/core.yaml#
>>
>
>> title: Rockchip SoC Image Signal Processing unit v1
>
> Where do we need 'v1' for? Is there a 'v2'?
ISPv1 is the Rockchip's name for the IP block.
>
>>
>> maintainers:
>> - Helen Koike
>>
>> description: |
>
Hi,
On 4/2/20 11:31 AM, Heiko Stübner wrote:
> Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker:
>> Hi Helen,
>>
>>> From: Helen Koike
>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> b/arch/arm64/boot/
Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy
Signed-off-by: Helen Koike
---
.../devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename {drivers/staging/media/phy-rockchip-dphy-rx0/Documentation
Move the bindings out of drivers/staging and place them in
Documentation/devicetree/bindings instead.
Also, add DT nodes for RK3399 and verify with make ARCH=arm64 dtbs_check
Tested by verifying images streamed from RockPi 4 board with imx219
module.
Helen Koike (2):
dt-bindings: phy: phy
From: Shunqian Zheng
Designware MIPI D-PHY, used for ISP0 in rk3399.
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen Koike
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Signed-off-by: Helen Koike
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename {drivers/staging/media/rkisp1/Documentation =>
Documentation}/devicet
-by: Helen Koike
---
This patch was originally part of this patchset:
https://patchwork.kernel.org/patch/10267431/
The only difference is:
- add phy properties
- add ports
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 27
1 file changed, 27 insertions(+)
diff
Hello,
On 3/25/20 1:03 PM, Mauro Carvalho Chehab wrote:
> That's the second part of media Kconfig changes. The entire series is
> at:
>
> https://git.linuxtv.org/mchehab/experimental.git/log/?h=media-kconfig
I made a quick experiment (using this branch) with someone who works with the
On 1/17/20 8:36 PM, Niklas Söderlund wrote:
> Hi Helen,
>
> Thanks for your work.
>
> On 2020-01-17 17:12:18 -0300, Helen Koike wrote:
>> The only places which make sese to allow users to enable or disable
>> links are:
>>
>> * between sensors and i
fy userspace:
rkisp1_resizer_mainpath -> rkisp1_mainpath
rkisp1_resizer_selfpath -> rkisp1_selfpath
rkisp1_params -> rkisp1_isp
rkisp1_isp -> rkisp1_stats
Signed-off-by: Helen Koike
---
This is the topology graph after disabling all the links with
media -r
http://col.la/rkisp
On 1/13/20 11:53 PM, zhangxiaoxu (A) wrote:
>
>
> 在 2020/1/14 1:34, Helen Koike 写道:
>> Hi Zhang,
>>
>> Thank you for the patch.
>>
>> On 1/13/20 1:48 AM, Zhang Xiaoxu wrote:
>>> If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error:
&
Hi Zhang,
Thank you for the patch.
On 1/13/20 1:48 AM, Zhang Xiaoxu wrote:
> If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error:
>
> drivers/staging/media/rkisp1/rkisp1-isp.o:
> In function `rkisp1_mipi_csi2_start.isra.5':
> rkisp1-isp.c:(.text+0x1238):
> undefined
Hi,
On Fri, Aug 2, 2019 at 6:55 PM Stephen Hemminger
wrote:
>
> On Fri, 2 Aug 2019 19:50:17 +
> Ricardo Bruno Lopes da Silva wrote:
>
> > Fix error bellow from checkpatch.
> >
> > WARNING: Block comments use * on subsequent lines
> >
Hi,
On Mon, Aug 5, 2019 at 11:51 AM Dan Carpenter wrote:
>
> This driver is obselete so we're just keeping it around for a couple
> kernel releases and then deleting it. We're not taking cleanups for it.
I'm sorry, it was me who suggested Thiago to make this change
as his first contribution, I
Hi Beatriz,
Thank you for the patch, just some small comments.
Regarding the patch title, if you run
git log drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
You will see that commits starts with the following tags "staging:
rtl8723bs: "
Also, try to add a bit more information to the title,
82 matches
Mail list logo
