Re: [PATCH v3 0/7] crypto: mark ecb(arc4) skcipher as obsolete

d a Kconfig option to en/disable obsolete algorithms that are only kept > around to prevent breaking users that rely on it via the socket interface > - add a patch to clean up some bogus Kconfig dependencies > - add acks to patches #1, #2 and #3 > > [0] > https://lore.kernel

Re: [PATCH v3 7/7] crypto: arc4 - mark ecb(arc4) skcipher as obsolete

On Mon, Aug 31, 2020 at 06:16:49PM +0300, Ard Biesheuvel wrote: > > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include This needs kernel.h too for the pr_warn_ratelimited. I'll add it when I apply the series. Thanks, -- Email: Herbert X

Re: [PATCH v2 7/7] crypto: arc4 - mark ecb(arc4) skcipher as obsolete

or af_alg. CRYPTO_USER is the configuration interface which has nothing to do with af_alg. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ devel mailing list de...@linux

Re: [PATCH 0/6] lib/crc32: treewide: Use existing define with polynomial

| 11 ++- > lib/crc32defs.h | 14 -- > lib/decompress_bunzip2.c | 3 ++- > lib/gen_crc32table.c | 5 +++-- > lib/xz/xz_crc32.c| 3 ++- >

Re: [PATCH v3 03/20] crypto: Remove depends on HAS_DMA in case of platform dependency

t; > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Reviewed-by: Mark Brown <broo...@kernel.org> > Acked-by: Robin Murphy <robin.mur...@arm.com> > Acked-by: Herbert Xu <herb...@gondor.apana.org.au> > --- > v3: > - Add Acked-by, > - Rebas

Re: [PATCH v2 00/21] Allow compile-testing NO_DMA (drivers)

idn't notice it :) > Apart from introducing build failures in allmodconfig/allyesconfig builds on > (uncommon) NO_DMA=y platforms, they can be applied directly and individually. I think I'll leave this with you then. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: ht

Re: [PATCH v2 03/21] crypto: Remove depends on HAS_DMA in case of platform dependency

t; > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Reviewed-by: Mark Brown <broo...@kernel.org> > Acked-by: Robin Murphy <robin.mur...@arm.com> Acked-by: Herbert Xu <herb...@gondor.apana.org.au> -- Email: Herbert Xu <herb...@gondor.apana.org.au> H

Re: [PATCH v2 00/21] Allow compile-testing NO_DMA (drivers)

Can they be applied directly in a subsystem tree? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ devel mailing list de...@linu

Re: [PATCH v2 0/7] crypto: ccree: Introduce Arm TrustZone CryptoCell

iver > crypto: ccree: add skcipher support > crypto: ccree: add ahash support > crypto: ccree: add AEAD support > crypto: ccree: add FIPS support > MAINTAINERS: update ccree entry All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://g

Re: Getting the ccree driver out of staging

On Thu, Jan 11, 2018 at 08:33:00AM +0200, Gilad Ben-Yossef wrote: > > Herbert, it's up to you - shall I send a new patch set or do you want to just > move what's in the staging tree? Please send a new patch. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au>

Re: [PATCHi v2] dt-bindings: add device tree binding for Arm TrustZone CryptoCell crypto engine

> > Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> > Acked-by: Rob Herring <r...@kernel.org> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://

Re: [PATCH v2 1/3] staging: ccree: copy IV to DMAable memory

that the pointer can be DMAed you can opt in to the new interface. The crypto API can then provide a helper to do the copying where necessary. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana

Re: [RFC PATCH 00/10] crypto: caam - add DPAA2 (DPSECI) driver

t in time. I'm fine with these patches. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ devel mailing list de...@linuxd

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote: > > > On 28/04/17 12:30 AM, Herbert Xu wrote: > > You are right. Indeed the existing code looks buggy as they > > don't take sg->offset into account when doing the kmap. Could > > you send me some p

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > Very straightforward conversion to the new function in the caam driver > and shash library. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Herbert Xu <herb...@gondor.apana.org.au>

Re: [RFC PATCH v1 18/28] crypto: add AMD Platform Security Processor driver

y <thomas.lenda...@amd.com> > Signed-off-by: Brijesh Singh <brijesh.si...@amd.com> This driver doesn't seem to hook into the Crypto API at all, is there any reason why it should be in drivers/crypto? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://g

Re: [PATCH 5/6] staging: lustre: Use ahash

've CCed you on the earlier patches in the series too. But yes it would be easier to take this through the cryptodev tree as a later patch removes the crypto_hash interface. > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Thanks, -- Email: Herbert Xu <herb...@gondor.apana

[PATCH 5/6] staging: lustre: Use ahash

This patch replaces uses of the long obsolete hash interface with ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/staging/lustre/lustre/libcfs/linux/linux-crypto.c | 92 +++--- 1 file changed, 52 insertions(+), 40 deletions(-) diff --git a/drivers/s

Re: [PATCH 16/26] libceph: Use skcipher

On Tue, Jan 26, 2016 at 12:29:57PM +0100, Ilya Dryomov wrote: > > LGTM. You want to take it through crypto? That's probably the easiest route since I'd like to take the first patch through cryptodev. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Hom

Re: [PATCH 16/26] libceph: Use skcipher

ypto_skcipher_setkey((void *)tfm, key, key_len); - memcpy(iv, aes_iv, ivsize); + memcpy(iv, aes_iv, AES_BLOCK_SIZE); skcipher_request_set_tfm(req, tfm); skcipher_request_set_callback(req, 0, NULL, NULL); -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Pag

[v2 PATCH 9/26] eCryptfs: Use skcipher and shash

On Sun, Jan 24, 2016 at 07:10:50PM +0100, Julia Lawall wrote: > Maybe the goto on line 1726 needs a preceding mutex_unlock? Good catch! Thanks. ---8<--- This patch replaces uses of ablkcipher and blkcipher with skcipher, and the long obsolete hash interface with shash. Signed-off-by: Herb

[PATCH 26/26] tcp: Use ahash

This patch replaces uses of the long obsolete hash interface with ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- include/net/tcp.h |6 +- net/ipv4/tcp.c | 41 ++--- net/ipv4/tcp_fastopen.c |1 + ne

[PATCH 10/26] ext4: Use skcipher

This patch replaces uses of ablkcipher with skcipher. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- fs/ext4/crypto.c | 24 +++- fs/ext4/crypto_fname.c | 32 +++- fs/ext4/crypto_key.c

[PATCH 12/26] sunrpc: Use skcipher and ahash/shash

This patch replaces uses of blkcipher with skcipher and the long obsolete hash interface with either shash (for non-SG users) and ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- include/linux/sunrpc/gss_krb5.h | 32 +-- net/sunrpc/auth_gss/gss_krb5_crypto.c

[PATCH 11/26] f2fs: Use skcipher

This patch replaces uses of ablkcipher with skcipher. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- fs/f2fs/crypto.c | 24 +++- fs/f2fs/crypto_fname.c | 32 +++- fs/f2fs/crypto_key.c

[PATCH 9/26] eCryptfs: Use skcipher and shash

This patch replaces uses of ablkcipher and blkcipher with skcipher, and the long obsolete hash interface with shash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- fs/ecryptfs/crypto.c | 107 +--- fs/ecryptfs/ecryptfs_kernel.h | 12 +- fs/ec

[PATCH 17/26] mac802154: Use skcipher

This patch replaces uses of blkcipher with skcipher. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- net/mac802154/llsec.c | 41 +++-- net/mac802154/llsec.h |3 +-- 2 files changed, 24 insertions(+), 20 deletions(-) diff --git

[PATCH 15/26] Bluetooth: Use skcipher and hash

This patch replaces uses of blkcipher with skcipher and the long obsolete hash interface with shash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- net/bluetooth/smp.c | 135 1 file changed, 63 insertions(+), 72 del

[PATCH 18/26] rxrpc: Use skcipher

This patch replaces uses of blkcipher with skcipher. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- net/rxrpc/ar-internal.h |2 net/rxrpc/ar-key.c | 12 +-- net/rxrpc/rxkad.c | 172 +--- 3 files change

[PATCH 16/26] libceph: Use skcipher

This patch replaces uses of blkcipher with skcipher. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- net/ceph/crypto.c | 97 +++--- 1 file changed, 56 insertions(+), 41 deletions(-) diff --git a/net/ceph/crypto.c b/ne

[PATCH 6/26] staging: rtl8192u: Use skcipher and ahash

This patch replaces uses of blkcipher with skcipher, and the long obsolete hash interface with ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 92 +++--- drivers/staging/rtl8192u/iee

[PATCH 7/26] wusb: Use skcipher

This patch replaces uses of blkcipher with skcipher. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/usb/wusbcore/crypto.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/usb/wusbcore/crypto.c b/drive

[PATCH 8/26] cifs: Use skcipher

This patch replaces uses of blkcipher with skcipher. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- fs/cifs/cifsencrypt.c | 32 +--- fs/cifs/smbencrypt.c | 26 +++--- 2 files changed, 40 insertions(+), 18 deletions(-)

[PATCH 13/26] lib80211: Use skcipher and ahash

This patch replaces uses of blkcipher with skcipher and the long obsolete hash interface with ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- net/wireless/lib80211_crypt_tkip.c | 99 - net/wireless/lib80211_crypt_wep.c

[PATCH 2/26] ppp_mppe: Use skcipher and ahash

This patch replaces uses of blkcipher with skcipher, and the long obsolete hash interface with ahash. This is a bug-for-bug conversion and no attempt has been made to fix bugs such as the ignored return values of the crypto operations. Signed-off-by: Herbert Xu <herb...@gondor.apana.org

[PATCH 4/26] dm crypt: Use skcipher and ahash

This patch replaces uses of ablkcipher with skcipher, and the long obsolete hash interface with ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/md/dm-crypt.c | 93 +- 1 file changed, 48 insertions(+), 45 del

[PATCH 3/26] staging: rtl8192e: Replace uses of obsolete blkcipher and hash

The interfaces blkcipher and hash are obsolete. This patch replaces them with skcipher and ahash respectively. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 99 ++- drivers/staging/rt

[PATCH 5/26] orinoco: Use ahash

This patch replaces uses the long obsolete hash interface with ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/net/wireless/intersil/orinoco/mic.c | 29 ++-- drivers/net/wireless/intersil/orinoco/mic.h |4 +-- drivers/net/wi

[PATCH 1/26] block: cryptoloop - Use new skcipher interface

This patch replaces uses of blkcipher with the new skcipher interface. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/block/cryptoloop.c | 48 +++-- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/drivers

Re: [PATCH 1/26] block: cryptoloop - Use new skcipher interface

pend on the two helpers that I posted yesterday so unfortunately we'll be getting quite a few build errors from the bot. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.a

[PATCH 23/26] iscsi-target: Use shash and ahash

This patch replaces uses of the long obsolete hash interface with either shash (for non-SG users) or ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/target/iscsi/iscsi_target.c | 86 ++ drivers/target/iscsi/iscsi_target_auth.c

[PATCH 21/26] nfc: s3fwrn5: Use shash

This patch replaces uses of the long obsolete hash interface with shash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/nfc/s3fwrn5/firmware.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/drivers/nfc/s

[PATCH 20/26] drbd: Use shash and ahash

This patch replaces uses of the long obsolete hash interface with either shash (for non-SG users) or ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/block/drbd/drbd_int.h | 16 +- drivers/block/drbd/drbd_main.c | 16 +- drivers/bloc

[PATCH 24/26] nfsd: Use shash

This patch replaces uses of the long obsolete hash interface with shash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- fs/nfsd/nfs4recover.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/fs/nfsd/nfs4recover.c b/f

[PATCH 25/26] sctp: Use shash

This patch replaces uses of the long obsolete hash interface with shash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- include/net/sctp/auth.h|4 +-- include/net/sctp/structs.h |6 ++--- net/sctp/auth.c| 36 --- ne

[PATCH 22/26] iscsi_tcp: Use ahash

This patch replaces uses of the long obsolete hash interface with ahash. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- drivers/scsi/iscsi_tcp.c| 54 ++-- drivers/scsi/iscsi_tcp.h|4 +-- drivers/scsi/libiscsi_tcp.c

[PATCH 14/26] KEYS: Use skcipher

This patch replaces uses of blkcipher with skcipher. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- security/keys/encrypted-keys/encrypted.c | 82 ++- 1 file changed, 50 insertions(+), 32 deletions(-) diff --git a/security/keys/encrypte

[PATCH 19/26] ipsec: Use skcipher and ahash when probing algorithms

. Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au> --- net/xfrm/xfrm_algo.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c index f07224d..250e567 100644 --- a/net/xfrm/xfrm_algo.c +++ b/net/xfrm/xfrm_algo.c @

[PATCH 0/26] crypto: Use skcipher and ahash/shash where possible

would like to take these patches through the cryptodev tree so we can proceed with phasing out the obsolete interfaces. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubk