Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

2017-06-14 Thread Ian W MORRISON
On 14 June 2017 at 00:36, Dan Carpenter wrote: > Kernel style is to have spaces around the operators. This is staging > code so we do all the style fixes. We don't always update older drivers > but sometimes we do. No one is planning to change those drivers though > so I guess the answer is no

Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

2017-06-13 Thread Ian W MORRISON
On 12 June 2017 at 20:46, Fabian Wolff wrote: > This patch adds spaces around the binary operators '-' and '+', which > is the preferred style, and reformats a pointer argument declaration > to fix a false positive "spaces preferred around that '*'" message > reported by checkpatch.pl. > > Signed-

Re: [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-08 Thread Ian W MORRISON
On 9 May 2017 at 00:42, Andy Shevchenko wrote: > On Sun, May 7, 2017 at 1:04 PM, Ian W MORRISON wrote: > > What are you trying to achieve by posting this patch over and over so often? > > Version 5 look pretty good to me. Just stop posting it again and wait > when Greg tak

[PATCH v6] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-08 Thread Ian W MORRISON
A re-positioned call to kfree() in drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c causes a segmentation error. This patch removed the kfree() call. Fixes 6557ddfec348 ("staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c") Signed-off-by: Ian W Morrison Reviewed-b

[PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-07 Thread Ian W MORRISON
(version 5) has tabs rather than spaces, no wrap around, a changelog and a sign-off email. Reviewed-by: Hans de Goede Signed-off-by: Ian W Morrison --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211

[PATCH v4] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-06 Thread Ian W MORRISON
(version 4) has tabs rather than spaces, no wrap around and a changelog. The patch has received one review: Patch looks good to me: Reviewed-by: Hans de Goede Signed-off-by: Ian W Morrison --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - 1 file changed, 1 deletion(-) diff --git a

[PATCH v3] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-06 Thread Ian W MORRISON
(version 3) has tabs rather than spaces and no wrap around. The patch has received one review: Patch looks good to me: Reviewed-by: Hans de Goede Regards, Ian From: Ian W Morrison Date: Fri, 28 Apr 2017 02:20:38 +1000 Subject: [PATCH] staging: rtl8723bs: remove a call to kfree in os_dep

Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

2017-05-06 Thread Ian W MORRISON
On 5/6/17 11:41 PM, Greg KH wrote: On Sat, May 06, 2017 at 06:00:24PM +1000, Ian W MORRISON wrote: The kernel when booted with Ubuntu 17.04 results in an unusable system however with the following patch booting is successful and the system is usable. The patch and kernel builds have been

Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

2017-05-06 Thread Ian W MORRISON
en booted with Ubuntu 17.04 results in an unusable system however with the following patch booting is successful and the system is usable. The patch and kernel builds have been tested against on an Intel Compute Stick (STCK1A32WFC model). Regards, Ian From: Ian W Morrison Date: Fri, 28 Apr 2017 02:2

Re: [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-05 Thread Ian W MORRISON
y: Hans de Goede ". This patch is to remove the re-positioned call to kfree() in drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise results in segmentation fault. Signed-off-by: Ian W Morrison --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - 1 file changed, 1 deletion