Re: [PATCH 1/2 v3] drivers: staging: rtl8723au: Changed rssi_cmd to little-endian param

> I am fine with this code in principle, but has it been tested? This > stuff will break the driver miserably if it's wrong. > > Thanks, > Jes > This patchset has not been tested. Unfortunately, I don't have to proper card to test this patch on my local. It built for me, and that's as far as I

Re: [PATCH v2] staging: rtl8723au: Fix sparse errors in rtl8723a_cmd.c

Hello This patch set fixes the same sparse errors as v2, taking Al's advice into consideration and changing the interfaces to little-endian. Jake >From 8c66f23a08417c59400a60c2dcf5a519795e401f Mon Sep 17 00:00:00 2001 From: Jacob Kiefer <jt...@cornell.edu> Date: Sat, 10 Oct 2015 14:33

[PATCH 2/2 v3] drivers: staging: rtl8723au: Changed raid_cmd to little-endian mask

From: Jacob Kiefer <jt...@cornell.edu> Changed raid_cmd interface to accept le32 mask instead of u32 and converting internally. Updated existing calls to raid_cmd. This patch pushes responsibility to the caller to convert the mask to le32 and opts for a temp local struct instead of memset/

Re: [PATCH v2] staging: rtl8723au: Fix sparse errors in rtl8723a_cmd.c

On Wed, Oct 07, 2015 at 12:11:34AM +0100, Al Viro wrote: > On Tue, Oct 06, 2015 at 12:32:28AM -0400, Jacob Kiefer wrote: > > > int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u8 *param) > > { > > - *((u32 *)param) = cpu_to_le32(*((u32 *)param))

[PATCH v2] staging: rtl8723au: Fix sparse errors in rtl8723a_cmd.c

From: Jacob Kiefer <jt...@cornell.edu> This patch fixes the following sparse errors: CHECK drivers/staging/rtl8723au/hal/rtl8723a_cmd.c ... drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25: \ warning: incorrect type in assignment (different base types) drivers/staging/rtl8723

Re: [PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c

Hi Greg, Thanks for the response! It's always good to get notes on a patch. Some responses to your points: > Why __le32? Does this variable go across the user/kernel boundry > somehow? If not, just use le32. Good point, this should probably have been le32. > At first glance, you aren't doing

[PATCH] staging: rtl8723au: Fix Sparse errors in rtl8723a_cmd.c

From: Jacob Kiefer <jt...@cornell.edu> This patch fixes the following sparse errors: CHECK drivers/staging/rtl8723au/hal/rtl8723a_cmd.c ... drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:118:25: warning: incorrect type in assignment (different base types) drivers/staging/rtl8723

[PATCH] type assignment and restricted type cast error fixes for rtl8723au/core/rtw_security.c

to restricted __le32 Signed-off-by: Jacob Kiefer jt...@cornell.edu --- drivers/staging/rtl8723au/core/rtw_security.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index

[PATCH V2] staging: rtl8723au: Fix Sparse errors in rtw_security.c

in assignment (different base types) drivers/staging/rtl8723au/core/rtw_security.c:694:39:\ expected unsigned int [unsigned] [usertype] noident drivers/staging/rtl8723au/core/rtw_security.c:694:39:\ got restricted __le32 [usertype] noident Signed-off-by: Jacob Kiefer jt...@cornell.edu --- In V2

[PATCH] staging: style fix for octeon/ethernet-tx.c

Broke line with greater than 80 characters into two lines and improved logical operator readability in hardware checksum if statement. Signed-off-by: Jacob Kiefer jt...@cornell.edu --- drivers/staging/octeon/ethernet-tx.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH] staging: style fix for octeon/ethernet-tx.c

From: Jacob Kiefer jt...@cornell.edu Style fix for octeon/ethernet-tx.c Signed-off-by: Jacob Kiefer jt...@cornell.edu --- drivers/staging/octeon/ethernet-tx.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging