Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-20 Thread Jani Nikula
er > without modifying the argument list that calls > hex_dump_to_buffer with whatever added argument content > you need. > > Something like: > > static inline > int hex_dump_to_buffer(const void *buf, size_t len, int rowsize, > int groupsize, ch

Re: [PATCH v3 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-17 Thread Jani Nikula
line, sizeof(line), > - false) >= sizeof(line)); > + 0) >= sizeof(line)); > drm_printf(m, "[%04zx] %s\n", pos, line); > > prev = buf + pos;

Re: [PATCH v2 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-05-08 Thread Jani Nikula
ine_cs.c| 2 +- For i915, Acked-by: Jani Nikula > drivers/isdn/hardware/mISDN/mISDNisar.c | 6 -- > drivers/mailbox/mailbox-test.c| 2 +- > drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- > drivers/net/ethernet/synopsys/dwc-xlgmac-comm

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-19 Thread Jani Nikula
On Tue, 19 Dec 2017, Joe Perches <j...@perches.com> wrote: > drivers/gpu/drm/i915/i915_sysfs.c | 12 ++-- For i915, Acked-by: Jani Nikula <jani.nik...@intel.com> -- Jani Nikula, Intel Open Source Technology Center __

Re: [Intel-gfx] [PATCH 0/3] Kconfig dependencies: acpi-video, backlight and thermal

2017-07-31 Thread Jani Nikula
letions(-) >> >> To: dri-de...@lists.freedesktop.org >> Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> >> Cc: Len Brown <l...@kernel.org> >> Cc: Lucas Stach <l.st...@pengutronix.de> >> Cc: Russell King <linux+etna...@armlinux.org.uk&

Re: [PATCH 2/3] Documentation: Move visorbus documentation from staging to Documentation/

2017-06-06 Thread Jani Nikula
ot something as specific as this. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] format-security: move static strings to const

2017-04-06 Thread Jani Nikula
an interesting comparison of the generated code. I'm a bit surprised by what gcc does, I would have expected no difference, like clang. https://godbolt.org/g/OdqUvN The other changes adding const in this patch are, of course, good. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

Re: [PATCH v2 3/3] doc: add documentation for uio-hv-generic

2016-10-18 Thread Jani Nikula
> +Which if successful should print > + > + .../vmbus-ed963694-e847-4b2a-85af-bc9cfc11d6f3/driver - > ../../../bus/vmbus/drivers/uio_hv_generic > + > + > + > + > + > +Things to know about uio_hv_generic > + > +On each interrupt, uio_hv_generic se

Re: [PATCH 1/6] lib: string: add function strtolower()

2016-07-01 Thread Jani Nikula
On Fri, 01 Jul 2016, Markus Mayer <markus.ma...@broadcom.com> wrote: > On 1 July 2016 at 03:52, Jani Nikula <jani.nik...@linux.intel.com> wrote: >> On Fri, 01 Jul 2016, Markus Mayer <mma...@broadcom.com> wrote: >>> Add a function called strtolower() to conver

Re: [PATCH 1/6] lib: string: add function strtolower()

2016-07-01 Thread Jani Nikula
dentation? See scripts/checkpatch.pl. > + > + for (p = s; *p; p++) > + *p = tolower(*p); > + > + return s; Why does it return a value? Could be void? BR, Jani. > +} > +EXPORT_SYMBOL(strtolower); -- Jani Nikula, Intel Open Source Technology Center