Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type

int ret; Maybe inside ks_wlan_start_xmit, instead of "return 0;", there should be "return NETDEV_TX_OK;" and "return NETDEV_TX_BUSY;" otherwise. It is just suggestion. Br, Janusz Lisiecki

Re: [PATCH] staging: ks7010: fix ks_wlan_start_xmit()'s return type

int ret; Maybe inside ks_wlan_start_xmit, instead of "return 0;", there should be "return NETDEV_TX_OK;" and "return NETDEV_TX_BUSY;" otherwise. It is just suggestion. Br, Janusz Lisiecki

Re: [PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

W dniu 2017-07-02 o 23:23, Luc Van Oostenryck pisze: On Sun, Jul 2, 2017 at 10:49 PM, Janusz Lisiecki wrote: W dniu 2017-07-02 o 21:38, Luc Van Oostenryck pisze: On Sun, Jul 2, 2017 at 4:27 PM, Janusz Lisiecki wrote: This patch fixes the following Sparse warnings in ks_wlan_net.c: drivers

[PATCH 0/1] Fix cast to restricted __le16 in ks7010 driver

) on it is wrong and must be removed. As this is not HW related structure we are free to choose its byte order and it is easier just to remove one wrong casting than rework all other places to treat it as __le16. Janusz Lisiecki (1): staging: ks7010: Fix warning of cast to restricted

[PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

current_ap). Both sides of assignment are u16 (native order) so 'le16_to_cpu' is not needed and wrong. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/dr

Re: [PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

W dniu 2017-07-02 o 21:38, Luc Van Oostenryck pisze: On Sun, Jul 2, 2017 at 4:27 PM, Janusz Lisiecki wrote: This patch fixes the following Sparse warnings in ks_wlan_net.c: drivers/staging/ks7010/ks_wlan_net.c:1359:24: warning: cast to restricted __le16 Both sides of assignment are u16 so (as

[PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

capabilities' type of u16) 'le16_to_cpu' is not needed Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index 0c778aa..9a7

[PATCH 0/1] Fix cast to restricted __le16 in ks7010 driver

This patch fixes Sparse warining found in ks_wlan_net.c. This seems to be last of it reported by Sparse for that driver. Janusz Lisiecki (1): staging: ks7010: Fix warning of cast to restricted __le16 in ks_wlan_net.c drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1

[PATCH v5 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 26 +- drivers/staging/ks7010/ks_hostif.h | 2 +- 2 files changed, 14 insertions(+), 14 deletions

[PATCH v5 0/1] Avoid CamelCases in ks7010 driver

/staging git (others from v1 and v2 are already there) v4: - Rebased remaing patch to staging-testing branch of gregkh/staging git v5: - Fixed commit message Janusz Lisiecki (1): staging: ks7010: avoid CamelCase: receiveDTIMs drivers/staging/ks7010/ks_hostif.c | 26

[PATCH v4 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki Conflicts: drivers/staging/ks7010/ks_hostif.h --- drivers/staging/ks7010/ks_hostif.c | 26 +- drivers/staging/ks7010/ks_hostif.h | 2

[PATCH v4 0/1] Avoid CamelCases in ks7010 driver

/staging git (others from v1 and v2 are already there) v4: - Rebased remaing patch to staging-testing branch of gregkh/staging git Janusz Lisiecki (1): staging: ks7010: avoid CamelCase: receiveDTIMs drivers/staging/ks7010/ks_hostif.c | 26 +- drivers/staging/ks7010/ks_hostif.h

[PATCH v3 0/2] Avoid CamelCases in ks7010 driver

/staging git (others from v1 and v2 are already there) Janusz Lisiecki (2): staging: ks7010: avoid CamelCase: receiveDTIMs staging: ks7010: avoid CamelCase: local variables in ks_hostif.c drivers/staging/ks7010/ks_hostif.c | 59 +++--- drivers/staging/ks7010

[PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 26 +- drivers/staging/ks7010/ks_hostif.h | 2 +- 2 files changed, 14 insertions(+), 14 deletions

[PATCH v3 2/2] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c

Replace CamelCase local variables' name with underscores to comply with the standard kernel coding style. Changed: - LinkSpeed - TransmittedFrameCount - ReceivedFragmentCount - FailedCount - FCSErrorCount Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c

Re: [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t

W dniu 2017-05-07 o 05:37, Greg Kroah-Hartman pisze: On Sat, Apr 29, 2017 at 10:58:41PM +0200, Janusz Lisiecki wrote: Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Janusz Lisiecki Reviewed-by: Tobin C. Harding Not all of

[PATCH v2 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size

Replace CamelCase association_request_t and association_response_t struct field names with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 10 +- drivers/staging/ks7010/ks_hostif.h | 6 +++--- 2 files

[PATCH v2 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields

Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - maxDuration - durRemaining Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t

Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 6 +++--- drivers/staging/ks7010/ks_wlan.h | 8 drivers/staging/ks7010/ks_wlan_net.c | 20

[PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c

Replace CamelCase local variables' name with underscores to comply with the standard kernel coding style. Changed: - LinkSpeed - TransmittedFrameCount - ReceivedFragmentCount - FailedCount - FCSErrorCount Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c

[PATCH v2 6/8] staging: ks7010: avoid CamelCase: atimWindow

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging

[PATCH v2 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 26 +- drivers/staging/ks7010/ks_hostif.h | 2 +- 2 files changed, 14 insertions(+), 14 deletions

[PATCH v2 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields

Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - FhParms_t - DsParms_t - CfParms_t - IbssParms_t - ErpParams_t Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 20 ++-- 1 file changed, 10

[PATCH v2 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields

Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - dwellTime - hopSet - hopPattern - hopIndex Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v2 0/8] Avoid CamelCases in ks7010 driver

This patchset fix CamelCases in ks7010 driver except michael_mic which will be replaced by kernel implementation in the future. --- v2: - Rebased all patches to next-20170512. 2 and 8 should apply cleanly now Janusz Lisiecki (8): staging: ks7010: avoid CamelCase in fields of struct

[PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c

Replace CamelCase local variables' name with underscores to comply with the standard kernel coding style. Changed: - LinkSpeed - TransmittedFrameCount - ReceivedFragmentCount - FailedCount - FCSErrorCount Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c

[PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 26 +- drivers/staging/ks7010/ks_hostif.h | 2 +- 2 files changed, 14 insertions(+), 14 deletions

[PATCH 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_hostif.h | 2 +- 2 files changed, 13 insertions(+), 13 deletions

[PATCH 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields

Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - maxDuration - durRemaining Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 6/8] staging: ks7010: avoid CamelCase: atimWindow

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging

[PATCH 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields

Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - dwellTime - hopSet - hopPattern - hopIndex Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size

Replace CamelCase association_request_t and association_response_t struct field names with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 10 +- drivers/staging/ks7010/ks_hostif.h | 6 +++--- 2 files

[PATCH 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c

Replace CamelCase local variables' name with underscores to comply with the standard kernel coding style. Changed: - LinkSpeed - TransmittedFrameCount - ReceivedFragmentCount - FailedCount - FCSErrorCount Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c

[PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields

Replace CamelCase struct field names with underscores to comply with the standard kernel coding style. Changed: - FhParms_t - DsParms_t - CfParms_t - IbssParms_t - ErpParams_t Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.h | 20 ++-- 1 file changed, 10

[PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t

Replace CamelCase fields of struct with underscores to comply with the standard kernel coding style Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 6 +++--- drivers/staging/ks7010/ks_wlan.h | 8 drivers/staging/ks7010/ks_wlan_net.c | 20

[PATCH 0/8] Avoid CamelCases in ks7010 driver

This patchset fix CamelCases in ks7010 driver except michael_mic which will be replaced by kernel implementation in the future. Janusz Lisiecki (8): staging: ks7010: avoid CamelCase in fields of struct local_gain_t staging: ks7010: avoid CamelCase: receiveDTIMs staging: ks7010: avoid