Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg

2018-09-16 Thread Jarkko Sakkinen
mpat_ioctl = vtpmx_fops_compat_ioctl, > -#endif > + .compat_ioctl = generic_compat_ioctl_ptrarg, > .llseek = noop_llseek, > }; Reviewed-by: Jarkko Sakkinen /Jarkko ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > &g

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 03:52:08PM +0200, Julia Lawall wrote: > > > On Mon, 12 Sep 2016, Felipe Balbi wrote: > > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >>

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > Constify local structures. > > > > > > The semantic patch that

Re: [PATCH 00/26] constify local structures

2016-09-11 Thread Jarkko Sakkinen
On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > Constify local structures. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) Just my two cents but: 1. You *can* use a static analysis too to find bugs or other issues. 2. However, you shoul

Re: [PATCH 6/6] intel_sgx: TODO file for the staging area

2016-05-17 Thread Jarkko Sakkinen
On Tue, Apr 26, 2016 at 11:38:22PM -0700, Jethro Beekman wrote: > On 26-04-16 04:23, Jarkko Sakkinen wrote: > > In order to write test code I would need to use the SDK at minimum to > > generate EINITTOKEN for the test enclave. > > You could do this right now with the

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-09 Thread Jarkko Sakkinen
On Mon, May 09, 2016 at 08:27:04AM +0200, Thomas Gleixner wrote: > On Mon, 9 May 2016, Jarkko Sakkinen wrote: > > On Fri, May 06, 2016 at 01:54:14PM +0200, Thomas Gleixner wrote: > > > On Fri, 6 May 2016, Jarkko Sakkinen wrote: > > > > > > > On Tue, May

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-09 Thread Jarkko Sakkinen
On Mon, May 09, 2016 at 09:04:09AM +0200, Greg KH wrote: > On Mon, May 09, 2016 at 08:38:25AM +0300, Jarkko Sakkinen wrote: > > On Fri, May 06, 2016 at 01:54:14PM +0200, Thomas Gleixner wrote: > > > On Fri, 6 May 2016, Jarkko Sakkinen wrote: > > > > > > > O

Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-05-09 Thread Jarkko Sakkinen
On Mon, May 09, 2016 at 08:29:17AM +0300, Jarkko Sakkinen wrote: > On Fri, Apr 29, 2016 at 03:22:19PM -0700, Jethro Beekman wrote: > > On 29-04-16 13:04, Jarkko Sakkinen wrote: > > >>> Why would you want to do that? > > >> > > >> ... > > > &

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-08 Thread Jarkko Sakkinen
On Fri, May 06, 2016 at 01:54:14PM +0200, Thomas Gleixner wrote: > On Fri, 6 May 2016, Jarkko Sakkinen wrote: > > > On Tue, May 03, 2016 at 04:06:27AM -0500, Dr. Greg Wettstein wrote: > > > It would be helpful and instructive for anyone involved in this debate > > &g

Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-05-08 Thread Jarkko Sakkinen
On Fri, Apr 29, 2016 at 03:22:19PM -0700, Jethro Beekman wrote: > On 29-04-16 13:04, Jarkko Sakkinen wrote: > >>> Why would you want to do that? > >> > >> ... > > > > Do you see this as a performance issue or why do you think that this > &

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-06 Thread Jarkko Sakkinen
On Fri, May 06, 2016 at 09:14:43AM +0200, Pavel Machek wrote: > On Fri 2016-05-06 01:52:04, Jarkko Sakkinen wrote: > > On Mon, May 02, 2016 at 11:37:52AM -0400, Austin S. Hemmelgarn wrote: > > > On 2016-04-29 16:17, Jarkko Sakkinen wrote: > > > >On Tue, Apr 26, 2

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-06 Thread Jarkko Sakkinen
On Tue, May 03, 2016 at 04:06:27AM -0500, Dr. Greg Wettstein wrote: > It would be helpful and instructive for anyone involved in this debate > to review the following URL which details Intel's SGX licening > program: > > https://software.intel.com/en-us/articles/intel-sgx-product-licensing I thin

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-06 Thread Jarkko Sakkinen
On Wed, Apr 27, 2016 at 10:18:05AM +0200, Ingo Molnar wrote: > > * Andy Lutomirski wrote: > > > > What new syscalls would be needed for ssh to get all this support? > > > > This patchset or similar, plus some user code and an enclave to use. > > > > Sadly, on current CPUs, you also need Intel

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-05-05 Thread Jarkko Sakkinen
On Mon, May 02, 2016 at 11:37:52AM -0400, Austin S. Hemmelgarn wrote: > On 2016-04-29 16:17, Jarkko Sakkinen wrote: > >On Tue, Apr 26, 2016 at 09:00:10PM +0200, Pavel Machek wrote: > >>On Mon 2016-04-25 20:34:07, Jarkko Sakkinen wrote: > >>>Intel(R) SGX is a set o

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-04-29 Thread Jarkko Sakkinen
On Tue, Apr 26, 2016 at 09:00:10PM +0200, Pavel Machek wrote: > On Mon 2016-04-25 20:34:07, Jarkko Sakkinen wrote: > > Intel(R) SGX is a set of CPU instructions that can be used by > > applications to set aside private regions of code and data. The code > > outside the enc

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-04-29 Thread Jarkko Sakkinen
On Tue, Apr 26, 2016 at 09:00:10PM +0200, Pavel Machek wrote: > On Mon 2016-04-25 20:34:07, Jarkko Sakkinen wrote: > > Intel(R) SGX is a set of CPU instructions that can be used by > > applications to set aside private regions of code and data. The code > > outside the enc

Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-04-29 Thread Jarkko Sakkinen
On Wed, Apr 27, 2016 at 04:32:23PM -0700, Jethro Beekman wrote: > On 27-04-16 05:40, Jarkko Sakkinen wrote: > >> The hardware supports calling EEXTEND on only a part of a page, I think the > >> driver should also support that. > > > > Why would you want to do that

Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-04-27 Thread Jarkko Sakkinen
On Tue, Apr 26, 2016 at 11:49:38PM -0700, Jethro Beekman wrote: > On 25-04-16 10:34, Jarkko Sakkinen wrote: > > diff --git a/drivers/staging/intel_sgx/isgx_ioctl.c > b/drivers/staging/intel_sgx/isgx_ioctl.c > > new file mode 100644 > > index 000..9d8b36b > > -

Re: [PATCH 6/6] intel_sgx: TODO file for the staging area

2016-04-26 Thread Jarkko Sakkinen
On Mon, Apr 25, 2016 at 01:01:24PM -0700, Andi Kleen wrote: > Jarkko Sakkinen writes: > > > > diff --git a/drivers/staging/intel_sgx/TODO b/drivers/staging/intel_sgx/TODO > > new file mode 100644 > > index 000..05f68c2 > > --- /dev/null > > +++ b/dri

Re: [PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-04-25 Thread Jarkko Sakkinen
On Mon, Apr 25, 2016 at 10:55:36AM -0700, Greg KH wrote: > On Mon, Apr 25, 2016 at 08:34:10PM +0300, Jarkko Sakkinen wrote: > > Intel(R) SGX is a set of CPU instructions that can be used by > > applications to set aside private regions of code and data. The code > > o

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-04-25 Thread Jarkko Sakkinen
On Mon, Apr 25, 2016 at 10:53:52AM -0700, Greg KH wrote: > On Mon, Apr 25, 2016 at 08:34:07PM +0300, Jarkko Sakkinen wrote: > > Intel(R) SGX is a set of CPU instructions that can be used by > > applications to set aside private regions of code and data. The code > > o

Re: [PATCH 6/6] intel_sgx: TODO file for the staging area

2016-04-25 Thread Jarkko Sakkinen
On Mon, Apr 25, 2016 at 10:54:26AM -0700, Greg KH wrote: > On Mon, Apr 25, 2016 at 08:34:13PM +0300, Jarkko Sakkinen wrote: > > Signed-off-by: Jarkko Sakkinen > > --- > > drivers/staging/intel_sgx/TODO | 25 + > > 1 file changed, 25 insertions

[PATCH 4/6] intel_sgx: ptrace() support for the driver

2016-04-25 Thread Jarkko Sakkinen
ned-off-by: Jarkko Sakkinen --- drivers/staging/intel_sgx/isgx_vma.c | 118 +++ 1 file changed, 118 insertions(+) diff --git a/drivers/staging/intel_sgx/isgx_vma.c b/drivers/staging/intel_sgx/isgx_vma.c index f6cfb02..2788ab9 100644 --- a/drivers/staging/intel_sgx/

[PATCH 6/6] intel_sgx: TODO file for the staging area

2016-04-25 Thread Jarkko Sakkinen
Signed-off-by: Jarkko Sakkinen --- drivers/staging/intel_sgx/TODO | 25 + 1 file changed, 25 insertions(+) create mode 100644 drivers/staging/intel_sgx/TODO diff --git a/drivers/staging/intel_sgx/TODO b/drivers/staging/intel_sgx/TODO new file mode 100644 index 000

[PATCH 3/6] intel_sgx: driver for Intel Secure Guard eXtensions

2016-04-25 Thread Jarkko Sakkinen
initializing enclaves and a pager in order to support oversubscription. Signed-off-by: Jarkko Sakkinen --- arch/x86/include/asm/sgx.h| 4 +- drivers/staging/Kconfig | 2 + drivers/staging/Makefile | 1 + drivers/staging/intel_sgx

[PATCH 0/6] Intel Secure Guard Extensions

2016-04-25 Thread Jarkko Sakkinen
memory called Enclave Page Cache (EPC). There is a hardware unit in the processor called Memory Encryption Engine. The MEE encrypts and decrypts the EPC pages as they enter and leave the processor package. Jarkko Sakkinen (5): x86, sgx: common macros and definitions intel_sgx: driver for