[PATCH] staging: rtl8723bs: remove conversion to bool in halbtcoutsrc_Get()

2020-05-04 Thread Jason Yan
Fix the following coccicheck warning: drivers/staging/rtl8723bs/hal/hal_btcoex.c:410:59-64: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging: rtl8723bs: os_dep: remove rtw_spt_band_free()

2020-04-28 Thread Jason Yan
Now that rtw_spt_band_free() is only a direct wrapper of kfree, we can remove it and just use kfree(). Signed-off-by: Jason Yan --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep

Re: [PATCH 2/7] staging: rtl8723bs: os_dep: remove set but not used 'size'

2020-04-28 Thread Jason Yan
在 2020/4/28 20:28, Greg KH 写道: On Mon, Apr 27, 2020 at 11:23:37AM +0800, Jason Yan wrote: And also remove the NULL check before kfree() because kfree() can handle NULL pointers correctly. Fix the following gcc warning: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:157:6: warning

[PATCH 0/7] staging: rtl8723bs: some code cleanup

2020-04-26 Thread Jason Yan
Fix some warnings of '-Wunused-but-set-variable'. Jason Yan (7): staging: rtl8723bs: os_dep: remove set but not used 'uintRet' staging: rtl8723bs: os_dep: remove set but not used 'size' Staging: rtl8723bs: core: remove set but not used 'ptxservq'

[PATCH 1/7] staging: rtl8723bs: os_dep: remove set but not used 'uintRet'

2020-04-26 Thread Jason Yan
Fix the following gcc warning: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2564:22: warning: variable ‘uintRet’ set but not used [-Wunused-but-set-variable] unsigned int uintRet = 0; ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/staging

[PATCH 4/7] staging: rtl8723bs: core: remove set but not used 'algthm'

2020-04-26 Thread Jason Yan
Fix the following gcc warning: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1087:33: warning: variable ‘algthm’ set but not used [-Wunused-but-set-variable] unsigned int seq, len, status, algthm, offset; ^~ Reported-by: Hulk Robot Signed-off-by: Jason Yan

[PATCH 5/7] staging: rtl8723bs: core: remove set but not used 'listen_interval'

2020-04-26 Thread Jason Yan
Fix the following gcc warning: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1173:18: warning: variable ‘listen_interval’ set but not used [-Wunused-but-set-variable] u16 capab_info, listen_interval; ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan

[PATCH 7/7] staging: rtl8723bs: core: remove set but not used 'pframe'

2020-04-26 Thread Jason Yan
Fix the following gcc warning: drivers/staging/rtl8723bs/core/rtw_mlme.c:2920:6: warning: variable ‘pframe’ set but not used [-Wunused-but-set-variable] u8 *pframe; ^~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 +-- 1 file

[PATCH 3/7] Staging: rtl8723bs: core: remove set but not used 'ptxservq'

2020-04-26 Thread Jason Yan
Fix the following gcc warning: drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:556:19: warning: variable ‘ptxservq’ set but not used [-Wunused-but-set-variable] struct tx_servq *ptxservq; ^~~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/staging/rtl8723bs

[PATCH 6/7] staging: rtl8723bs: core: remove set but not used 'pwrpriv'

2020-04-26 Thread Jason Yan
Fix the following gcc warning: drivers/staging/rtl8723bs/core/rtw_mlme.c:1100:24: warning: variable ‘pwrpriv’ set but not used [-Wunused-but-set-variable] struct pwrctrl_priv *pwrpriv; ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/staging

[PATCH 2/7] staging: rtl8723bs: os_dep: remove set but not used 'size'

2020-04-26 Thread Jason Yan
: Hulk Robot Signed-off-by: Jason Yan --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 1ba85a43f05a..b037868fbf22 100644

Re: [PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv'

2020-04-26 Thread Jason Yan
Sorry, it has already been fixed by YueHaibing. Please ignore this. 在 2020/4/26 17:43, Jason Yan 写道: Fix the following gcc warning: drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable ‘pregistrypriv’ set but not used [-Wunused-but-set-variable] struct registry_priv

[PATCH] staging: rtl8723bs: remove set but not used 'pregistrypriv'

2020-04-26 Thread Jason Yan
Fix the following gcc warning: drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable ‘pregistrypriv’ set but not used [-Wunused-but-set-variable] struct registry_priv *pregistrypriv; ^ Reported-by: Hulk Robot Signed-off-by: Jason Yan

Re: [PATCH v2] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof

2020-04-20 Thread Jason Yan
在 2020/4/20 21:07, Greg KH 写道: On Mon, Apr 20, 2020 at 08:41:51PM +0800, Jason Yan wrote: Fix the following coccicheck warning: drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use correct pointer type argument for sizeof Signed-off-by: Jason Yan --- drivers/staging

[PATCH v3] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof

2020-04-20 Thread Jason Yan
Fix the following coccicheck warning: drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use correct pointer type argument for sizeof Signed-off-by: Jason Yan --- v2->v3: Add this description of v1->v2. v1->v2: Use sizeof(*p->func) instead of sizeof(struct rt2

[PATCH v2] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof

2020-04-20 Thread Jason Yan
Fix the following coccicheck warning: drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use correct pointer type argument for sizeof Signed-off-by: Jason Yan --- drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof

2020-04-20 Thread Jason Yan
在 2020/4/20 20:19, Dan Carpenter 写道: On Mon, Apr 20, 2020 at 08:37:55PM +0800, Jason Yan wrote: Fix the following coccicheck warning: drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use correct pointer type argument for sizeof Signed-off-by: Jason Yan --- drivers

[PATCH] staging: mt7621-pinctrl: Use correct pointer type argument for sizeof

2020-04-20 Thread Jason Yan
Fix the following coccicheck warning: drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use correct pointer type argument for sizeof Signed-off-by: Jason Yan --- drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: rtl8723bs: remove defined but not used 'dB_Invert_Table'

2020-04-17 Thread Jason Yan
Fix the following gcc warning: drivers/staging/rtl8723bs/hal/odm.c:10:18: warning: ‘dB_Invert_Table’ defined but not used [-Wunused-const-variable=] static const u16 dB_Invert_Table[8][12] = { ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers

[PATCH] staging: rtl8723bs: remove some variables in hal_btcoex.c

2020-04-17 Thread Jason Yan
/hal_btcoex.c:15:26: warning: ‘BtProfileString’ defined but not used [-Wunused-const-variable=] static const char *const BtProfileString[] = { ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 43

[PATCH] staging: vc04_services: remove set but not used 'local_entity_uc'

2020-04-09 Thread Jason Yan
Fix the following gcc warning: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2356:16: warning: variable ‘local_entity_uc’ set but not used [-Wunused-but-set-variable] int local_uc, local_entity_uc; ^~~ Reported-by: Hulk Robot Signed-off-by: Jason