The i2c-dev module is for access to I2C buses from user-space.
Kernel drivers do not care about its presence.
Signed-off-by: Jean Delvare
Cc: Matt Sickler
Cc: Greg Kroah-Hartman
---
drivers/staging/kpc2000/kpc_i2c/i2c_driver.c |1 -
1 file changed, 1 deletion(-)
--- linux-5.2-rc7.orig
it is deemed not worth the maintenance effort then it should be
deleted. I don't care either way.
--
Jean Delvare
SUSE L3 Support
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
MEDIA_CEC is no longer a tristate option, so the user can't actually
choose M. Whether the code is built-in or built as a module is
decided somewhere else.
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Fixes: 5bb2399a4fe4 ("[media] cec: fix Kconfig dependency problems")
ed, or they are correct and you should not touch them.
>
> Do you find such changes worthwhile (without touching also any surrounding
> source code)?
You keep asking more and more from me. May I remind you this is your
"project" in the first place, not mine? If you have no idea what
ernel/2106190
Personally I see no value in such statistics. Either labels are wrong
(either wrong indentation or wrong name) and should be fixed, or they
are correct and you should not touch them. Whether the same label name
is used somewhere else is irrelevant. Labels are local
label position in osc_get_info()
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c71d264543f759fea147734cb63de36397817534
> https://lkml.org/lkml/2015/12/21/401
Intending labels with a tab is wrong, so fixing it is welcome. I'd turn
the tab into a space instead, fo
abel renaming?
Renaming from "out0:", "out1:" etc to something meaningful, yes. Did
you have anything else in mind?
--
Jean Delvare
SUSE L3 Support
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
on, which should be fixed. One space before label is the way
to go.
> > Quoting Jean Delvare:
I'm honored :)
> > "> It is generally accepted to indent labels with a single space. This
> > > avoids breaking the -p option of diff."
>
> Would you like to tak
in the future and still readable IMO.
It was having space originally. I changed that into tab as it was
looking good with them as aligned.
As the driver maintainer, I am fine with both unaligned or tab-aligned.
Space-aligned as I did originally was not a good idea, I admit.
--
Jean Delvare
block.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Benjamin Romer benjamin.ro...@unisys.com
Cc: David Kershner david.kersh...@unisys.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This is an humble proposal if you like it. I don't use the driver
myself, I don't even know what
to the gspca_sonixb
driver now, so that it gets sufficient testing before the sn9c102
driver is finally phased out.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Hans de Goede hdego...@redhat.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: Luca Risolia luca.riso...@studio.unibo.it
Cc: Greg Kroah
11 matches
Mail list logo
