Re: [PATCH 03/10] staging: wfx: format comments on 100 columns

2022-03-01 Thread Jeff Johnson
On 2/28/2022 5:12 PM, Joe Perches wrote: On Fri, 2022-02-25 at 12:23 +0100, Jerome Pouiller wrote: From: Jérôme Pouiller A few comments were not yet formatted on 100 columns. IMO, none of these changes are necessary or good changes. 80 columns is preferred. Really comments should most alwa

Re: [PATCH 03/34] net/ceph: convert put_page() to put_user_page*()

2019-08-02 Thread Jeff Layton
t; - } > + put_user_pages_dirty_lock(pages, num_pages, dirty); > kvfree(pages); > } > EXPORT_SYMBOL(ceph_put_page_vector); This patch looks sane enough. Assuming that the earlier patches are OK: Acked-by: Jeff Layton ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 24/39] docs: driver-model: move it to the driver-api book

2019-06-28 Thread Jeff Kirsher
On Fri, 2019-06-28 at 09:30 -0300, Mauro Carvalho Chehab wrote: > The audience for the Kernel driver-model is clearly Kernel hackers. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Jeff Kirsher For the 'ice' driver changes. > --- > Documentation/{ => driver-a

[PATCH] fs: convert a pile of fsync routines to errseq_t based reporting

2017-07-28 Thread Jeff Layton
From: Jeff Layton This patch converts most of the in-kernel filesystems that do writeback out of the pagecache to report errors using the errseq_t-based infrastructure that was recently added. This allows them to report errors once for each open file description. Most filesystems have a fairly

Re: [PATCH 3/3] staging/lustre, 9p, ceph, cifs, dlm: negate remote pids for F_GETLK

2017-06-27 Thread Jeff Layton
> fl->fl_type = (op->info.ex) ? F_WRLCK : F_RDLCK; > fl->fl_flags = FL_POSIX; > - fl->fl_pid = op->info.pid; > + fl->fl_pid = -op->info.pid; > fl->fl_start = op->info.start; > fl-&

Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)

2017-02-24 Thread Jeff King
On Fri, Feb 24, 2017 at 12:03:45PM +0100, Geert Uytterhoeven wrote: > > The problem isn't on the applying end, but rather on the generating end. > > The From header in the attached mbox is: > > > > From: =?us-ascii?B?PT9VVEYtOD9xP1NpbW9uPTIwU2FuZHN0cj1DMz1CNm0/PQ==?= > > > > Slightly related,

Re: git email From: parsing (was Re: [GIT PULL] Staging/IIO driver patches for 4.11-rc1)

2017-02-22 Thread Jeff King
On Thu, Feb 23, 2017 at 07:04:44AM +0100, Greg KH wrote: > > Poor Simon Sandström. > > > > Funnily enough, this only exists for one commit. You've got several > > other commits from Simon that get his name right. > > > > What happened? > > I don't know what happened, I used git for this, I don'

Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

2016-04-19 Thread Jeff Kirsher
On Tue, 2016-04-19 at 19:17 -0700, K. Y. Srinivasan wrote: > On Hyper-V, the VF/PF communication is a via software mediated path > as opposed to the hardware mailbox. Make the necessary > adjustments to support Hyper-V. > > Signed-off-by: K. Y. Srinivasan > --- > V2: Addressed most of the

Re: [PATCH net-next 0/2] ethernet: intel: Support Hyper-V hosts

2016-04-14 Thread Jeff Kirsher
On Thu, Apr 14, 2016 at 4:55 PM, K. Y. Srinivasan wrote: > Make adjustments to the Intel 10G VF driver to support > running on Hyper-V hosts. > > K. Y. Srinivasan (2): > ethernet: intel: Add the device ID's presented while running on > Hyper-V > intel: ixgbevf: Support Windows hosts (Hyper

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread Jeff Mahoney
g redoing the lloop > driver anyways. Just need to find the cycles. I guess my memory was flakey and I was recalling the first comments in LU-4000. The updated version should be ok. -Jeff >> -- >> Jeff Mahoney >> (apologies for the top post -- from my mobile) >&g

Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64

2016-04-10 Thread Jeff Mahoney
This patch was shown not to work. I just haven't removed it from opensuse yet. -Jeff -- Jeff Mahoney (apologies for the top post -- from my mobile) > On Apr 10, 2016, at 9:13 AM, James Simmons wrote: > > From: Jeff Mahoney > > On ppc64 with 64k pages, we get a bu

about our photo clipping path

2015-03-05 Thread Jeff
free testing to check quality. Looking foroward to receive your soonest response. Thanks, Jeff Email: lovocont...@tom.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

about our photo retouching

2015-03-05 Thread Jeff
free testing to check quality. Looking foroward to receive your soonest response. Thanks, Jeff Email: lovocont...@tom.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

2014-12-02 Thread Jeff Leung
> We have had the Hyper-V clocksource for sometime now and this patch just marks this > clocksource as being continuous. Nothing has changed with regards to timesynch. Alright, that cleared up that question. Gleaning around from the source tree, I don't seem to comprehend what changes are being m

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

2014-12-02 Thread Jeff Leung
Does this mean that host-to guest timesync now works properly with Linux guests? -- Jeff > -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] > On Behalf Of K. Y. Srinivasan > Sent: Tuesday, December 2, 2014 1

[PATCH] scsi: storvsc: Force SPC-3 for Win8 Hosts or Later

2014-10-20 Thread Jeff Leung
SPC-3 compliance for hosts earlier than Win10 also enables TRIM support. Suggested by: James Bottomley Signed-off-by: Jeff Leung --- drivers/scsi/storvsc_drv.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_

RE: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-20 Thread Jeff Leung
> Is it OK to replace a scsi_level of SCSI-2 with SCSI_SPC_3? Additionally is > it also OK to force > SCSI_SPC_3 on Hyper-V 2008? I would patch the driver accordingly to force the SPC-3 flag. For a Win2k8 host, I don't know what the side effects are, so it's safe to say it's not a good idea to

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-20 Thread Jeff Epler
On Tue, Oct 21, 2014 at 03:18:58AM +, Thomas Shao wrote: > In some situation, the user is not able to enable guest VM to sync with > external > time source, like NTP. But the host is still synced with a trusted time > source. > In this case, host-guest time synchronization is useful. It's

Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Jeff Kirsher
On Thu, 2014-10-16 at 10:52 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 01:26:07PM -0700, Jeff Kirsher wrote: > > On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote: > > > On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote: > > > > From: Fabio

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Jeff Kirsher
On Thu, 2014-10-16 at 10:48 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 01:03:49PM -0700, Joe Perches wrote: > > On Wed, 2014-10-15 at 22:53 +0300, Dan Carpenter wrote: > > > On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > > > > On Wed, 2

Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote: > From: Fabio Estevam > > The Beceem WIMAX was generating compile warnings on 64bit machines, > which were: > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > drivers/staging/bcm/CmHost.c:

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Thu, 2014-10-16 at 00:24 +0200, Matthias Beyer wrote: > On 15-10-2014 15:19:44, Jeff Kirsher wrote: > > I will just go ahead and create a patch to remove the driver. Greg > can > > then decide to either accept the patch to fix the Kconfig or accept > the > >

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 23:41 +0200, Matthias Beyer wrote: > On 15-10-2014 06:03:33, Jeff Kirsher wrote: > > > > I thought I remember Greg saying something about getting rid of this > > driver anyway, but I could be wrong. If Greg decides to keep this > > driver aro

Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote: > > From: Fabio Estevam > > > > The Beceem WIMAX was generating compile warnings on 64bit machines, > > which were: > > > > dr

[PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
d-off-by: Jeff Kirsher --- v2: change fix from using typecast u64 in the code to altering Kconfig to prevent the driver from compiling on 64 bit arch's based on feedback drivers/staging/bcm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 15:24 -0300, Fabio Estevam wrote: > On Wed, Oct 15, 2014 at 2:42 PM, Jeff Kirsher > wrote: > > > I like the idea, but won't this exclude other 32 bit systems like MIPS > > and I am sure there might be others. I could assume that Beceem WIMAX >

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 09:11 -0700, Joe Perches wrote: > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > [] > > I thought I remember Greg saying something about getting rid of this > > driver anyway, but I could be wrong. If Greg decides to keep this > > driver

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
On Wed, 2014-10-15 at 15:59 +0300, Dan Carpenter wrote: > Or we could fix it but add a multi-line comment with lots of capital > letters and exclamation marks. I guess we would need to make a > function > since this cast is in several places. > > void *silence_buggy_casting(u32 pointer) > { >

[PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-15 Thread Jeff Kirsher
-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( This resolves the issue by generating 64bit friendly code. Signed-off-by: Jeff Kirsher --- drivers/staging/bcm/CmHost.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/staging/bcm/CmHost.c b/drivers/staging/bcm

RE: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-11 Thread Jeff Leung
esn't get accidentally enabled for hypervisors below Win10? I do know for a fact that Ubuntu's kernels already force SPC3 compliance to enable specific features such as TRIM on earlier versions of Hyper-V (Namely Hyper-V 2012 and 2012 R2). --Jeff > Regards, > > K. Y > > &g

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Jeff King
On Sat, Sep 13, 2014 at 08:45:56AM -0700, Greg KH wrote: > On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote: > > On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > > > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > > > multicast_pkts_xmtd, broadcast_pkts_rcv

RE: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2

2014-08-06 Thread Jeff Leung
> WS2008R2 is a supported platform and it turns out that the maximum sendbuf > size that ws2008R2 can support is only 15MB. Make the necessary > adjustment. > > Signed-off-by: K. Y. Srinivasan > --- > drivers/net/hyperv/hyperv_net.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >

[PATCH] staging: rtl8188eu: Fix static symbol sparse warnings

2014-07-24 Thread Jeff Oczek
tic? drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static? drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3109:5: warning: symbol 'rtw_ioctl' was not declared. Should it be static? Signed-

[PATCH v2 2/2] staging: cxt1e1: Fix static symbol sparse warnings for global vars in linux.c

2014-07-22 Thread Jeff Oczek
symbol 'cxt1e1_max_rxdesc_default' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:106:13: warning: symbol 'cxt1e1_max_rxdesc_used' was not declared. Should it be static? Signed-off-by: Jeff Oczek --- drivers/staging/cxt1e1/cxt1e1_common.h | 14 ++

[PATCH v2 1/2] staging: cxt1e1: Prefix ambiguous variable names with 'cxt1e1_' for clarity

2014-07-22 Thread Jeff Oczek
max_rxdesc_used max_rxdesc_default -> cxt1e1_max_rxdesc_default Since max_txdesc_used, max_rxdesc_used are module parameters, these were changed from global to static and the module init function assigns the values to the newly named global variables Signed-off-by: Jeff Oczek --- driv

[PATCH v2 0/2] staging: cxt1e1: Fix ambiguous global var names, reduce sparse warnings

2014-07-22 Thread Jeff Oczek
This patch set: changes ambiguous global names, such as "error_flag" to "cxt1e1_error_flag" puts globals in header file to reduce externs used in c files as well as sparse warnings Jeff Oczek (2): staging: cxt1e1: Prefix ambiguous variable names with 'cxt1e1_' for

Re: [PATCH] staging: cxt1e1: Fix static symbol sparse warnings for global vars in linux.c

2014-07-22 Thread Jeff Oczek
On Tue, Jul 22, 2014 at 01:17:22PM -0700, Greg KH wrote: > On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote: > > Put extern declarations in cxt1e1_common.h to reduce sparse warnings for > > linux.c: > > I know you didn't name this variable, but wow, that'

[PATCH] staging: cxt1e1: Fix static symbol sparse warnings for global vars in linux.c

2014-07-22 Thread Jeff Oczek
drivers/staging/cxt1e1/linux.c:171:1: warning: symbol 'c4_wk_chan_init' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:186:1: warning: symbol 'c4_wq_port_init' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:208:1: warning: symbo

[PATCH v2 2/2] staging: tidspbridge: Fix whitespace for pointers in function headers

2014-06-14 Thread Jeff Oczek
Change style in function headers from 'type * ptr' to 'type *ptr' Signed-off-by: Jeff Oczek --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/tidspbridge/include/dspbridge/d

[PATCH v2 1/2] staging: tidspbridge: Add parameter names to function ptrs in struct dbll_attrs

2014-06-14 Thread Jeff Oczek
Add more descriptive names to function pointers in definition of struct dbll_attrs Signed-off-by: Jeff Oczek --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/tidspbridge/include/dspbridge

Re: [PATCH 2/2] staging: tidspbridge: Fix function pointer spacing in struct definition

2014-06-14 Thread Jeff Oczek
On Fri, Jun 13, 2014 at 08:31:40PM -0700, Joe Perches wrote: > On Fri, 2014-06-13 at 22:48 -0400, Jeff Oczek wrote: > > -s32(*fread) (void *, size_t, size_t, void *); > > -s32(*fseek) (void *, long, int); > > -s32(*ftell) (void *); > > -s32(*fclose) (voi

[PATCH 1/2] staging: tidspbridge: Fix pointer spacing

2014-06-13 Thread Jeff Oczek
Simple coding style changes This is for Eudyptula Challenge task 10 Signed-off-by: Jeff Oczek --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h b/drivers

[PATCH 2/2] staging: tidspbridge: Fix function pointer spacing in struct definition

2014-06-13 Thread Jeff Oczek
Simple coding style changes This is for the Eudyptula Challenge task 10 Signed-off-by: Jeff Oczek --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h

Re: [linux-nics] [PATCHv3 2/3] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-08 Thread Jeff Kirsher
ktop.org > Cc: e1000-de...@lists.sourceforge.net > Cc: net...@vger.kernel.org > Cc: de...@driverdev.osuosl.org > Cc: linux-fsde...@vger.kernel.org > Cc: b.a.t.m@lists.open-mesh.org > Cc: bri...@lists.linux-foundation.org For the Intel driver changes... Acked-by: Jeff Kirsher > --- &

[PATCH] locks: ensure that fl_owner is always initialized properly in flock and lease codepaths

2014-04-28 Thread Jeff Layton
ported-by: Trond Myklebust Signed-off-by: Jeff Layton --- drivers/staging/lustre/lustre/llite/file.c | 17 ++--- fs/9p/vfs_file.c | 3 --- fs/afs/flock.c | 4 fs/ceph/locks.c

[PATCH] staging: ozwpan: remove unneeded __GFP_ZERO to kzalloc() at oz_elt_stream_create()

2013-11-01 Thread Jeff Liu
From: Jie Liu Get rid of the needless __GFP_ZERO flag for kzalloc() at oz_elt_stream_create(). Signed-off-by: Jie Liu --- drivers/staging/ozwpan/ozeltbuf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozeltbuf.c b/drivers/staging/ozwpan/ozeltbu

Re: [PATCH 08/51] DMA-API: net: intel/ixgbevf: fix 32-bit DMA mask handling

2013-09-20 Thread Jeff Kirsher
out > if either fails. > > Signed-off-by: Russell King > --- > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 15 > +-- > 1 files changed, 5 insertions(+), 10 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part

Re: [PATCH 12/51] DMA-API: net: intel/e1000: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-09-20 Thread Jeff Kirsher
--- > drivers/net/ethernet/intel/e1000/e1000_main.c |9 ++--- > 1 files changed, 2 insertions(+), 7 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part ___ devel mailing list

Re: [PATCH 07/51] DMA-API: net: intel/ixgbe: fix 32-bit DMA mask handling

2013-09-20 Thread Jeff Kirsher
s. > > Signed-off-by: Russell King > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 15 +-- > 1 files changed, 5 insertions(+), 10 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part __

Re: [PATCH 06/51] DMA-API: net: intel/ixgb: fix 32-bit DMA mask handling

2013-09-20 Thread Jeff Kirsher
Russell King > --- > drivers/net/ethernet/intel/ixgb/ixgb_main.c | 16 +--- > 1 files changed, 5 insertions(+), 11 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 04/51] DMA-API: net: intel/igb: fix 32-bit DMA mask handling

2013-09-20 Thread Jeff Kirsher
error out > if either fails. > > Signed-off-by: Russell King > --- > drivers/net/ethernet/intel/igb/igb_main.c | 18 ++ > 1 files changed, 6 insertions(+), 12 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is

Re: [PATCH 05/51] DMA-API: net: intel/igbvf: fix 32-bit DMA mask handling

2013-09-20 Thread Jeff Kirsher
and to error out > if either fails. > > Signed-off-by: Russell King > --- > drivers/net/ethernet/intel/igbvf/netdev.c | 18 ++ > 1 files changed, 6 insertions(+), 12 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: T

Re: [PATCH 03/51] DMA-API: net: intel/e1000e: fix 32-bit DMA mask handling

2013-09-20 Thread Jeff Kirsher
error out > if either fails. > > Signed-off-by: Russell King > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 18 ++ > 1 files changed, 6 insertions(+), 12 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is

[PATCH] staging/zcache: Fix memory leak while dropping an o2net_sock_container object

2013-08-04 Thread Jeff Liu
From: Jie Liu Free sc->sc_page when releasing a struct o2net_sock_container object to avoid memory leaks. This issue has been fixed by Younger Liu for OCFS2, so I sync that patch to zcache as we share the same network code base. Cc: Younger Liu Cc: Bob Liu Cc: Greg Kroah-Hartman Cc: Konrad R