[PATCH] staging: rtl8188eu: Fix static symbol sparse warnings

/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static? drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:3109:5: warning: symbol 'rtw_ioctl' was not declared. Should it be static? Signed-off-by: Jeff Oczek jeffoc...@gmail.com

[PATCH] staging: cxt1e1: Fix static symbol sparse warnings for global vars in linux.c

. Should it be static? drivers/staging/cxt1e1/linux.c:186:1: warning: symbol 'c4_wq_port_init' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:208:1: warning: symbol 'c4_wq_port_cleanup' was not declared. Should it be static? Signed-off-by: Jeff Oczek jeffoc...@gmail.com

Re: [PATCH] staging: cxt1e1: Fix static symbol sparse warnings for global vars in linux.c

On Tue, Jul 22, 2014 at 01:17:22PM -0700, Greg KH wrote: On Tue, Jul 22, 2014 at 04:07:51PM -0400, Jeff Oczek wrote: Put extern declarations in cxt1e1_common.h to reduce sparse warnings for linux.c: I know you didn't name this variable, but wow, that's a horrid name for a global variable

[PATCH v2 0/2] staging: cxt1e1: Fix ambiguous global var names, reduce sparse warnings

This patch set: changes ambiguous global names, such as error_flag to cxt1e1_error_flag puts globals in header file to reduce externs used in c files as well as sparse warnings Jeff Oczek (2): staging: cxt1e1: Prefix ambiguous variable names with 'cxt1e1_' for clarity staging: cxt1e1

[PATCH v2 2/2] staging: cxt1e1: Fix static symbol sparse warnings for global vars in linux.c

it be static? drivers/staging/cxt1e1/linux.c:106:13: warning: symbol 'cxt1e1_max_rxdesc_used' was not declared. Should it be static? Signed-off-by: Jeff Oczek jeffoc...@gmail.com --- drivers/staging/cxt1e1/cxt1e1_common.h | 14 ++ drivers/staging/cxt1e1/hwprobe.c | 2

[PATCH v2 1/2] staging: cxt1e1: Prefix ambiguous variable names with 'cxt1e1_' for clarity

max_rxdesc_default - cxt1e1_max_rxdesc_default Since max_txdesc_used, max_rxdesc_used are module parameters, these were changed from global to static and the module init function assigns the values to the newly named global variables Signed-off-by: Jeff Oczek jeffoc...@gmail.com --- drivers/staging

[PATCH v2 1/2] staging: tidspbridge: Add parameter names to function ptrs in struct dbll_attrs

Add more descriptive names to function pointers in definition of struct dbll_attrs Signed-off-by: Jeff Oczek jeffoc...@gmail.com --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH v2 2/2] staging: tidspbridge: Fix whitespace for pointers in function headers

Change style in function headers from 'type * ptr' to 'type *ptr' Signed-off-by: Jeff Oczek jeffoc...@gmail.com --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/tidspbridge/include/dspbridge

[PATCH 2/2] staging: tidspbridge: Fix function pointer spacing in struct definition

Simple coding style changes This is for the Eudyptula Challenge task 10 Signed-off-by: Jeff Oczek jeffoc...@gmail.com --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/tidspbridge/include

[PATCH 1/2] staging: tidspbridge: Fix pointer spacing

Simple coding style changes This is for Eudyptula Challenge task 10 Signed-off-by: Jeff Oczek jeffoc...@gmail.com --- drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/tidspbridge/include/dspbridge