Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2014-05-06 Thread Jens Frederich
Acked-by: Jens Frederich 2014-05-06 18:32 GMT+02:00 Nicolas Joseph : > WARNING: Missing a blank line after declarations > > Signed-off-by: Nicolas Joseph > --- > drivers/staging/olpc_dcon/olpc_dcon.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > &

[PATCH] Staging: olpc_dcon: Removed more completed TODO entries

2013-08-20 Thread Jens Frederich
1. Console event notifier support: No one I've asked knows what this all about. 2. Audit code for unnecessary code: This is done. 3. Verify sane i2cAPI usage: This is also done. Signed-off-by: Jens Frederich diff --git a/drivers/staging/olpc_dcon/TODO b/drivers/staging/olpc_dcon/TODO

Re: [PATCH 2/3] Staging: olpc_dcon: replace some magic numbers

2013-08-16 Thread Jens Frederich
On Fri, Aug 16, 2013 at 10:54 AM, Dan Carpenter wrote: > On Fri, Aug 16, 2013 at 09:40:38AM +0200, Jens Frederich wrote: >> On Fri, Aug 16, 2013 at 9:13 AM, Dan Carpenter >> wrote: >> > On Thu, Aug 15, 2013 at 09:34:55PM +0200, Jens Frederich wrote: >> >>

[PATCH] Staging: olpc_dcon: fix typo in olpc_dcon.h

2013-08-16 Thread Jens Frederich
The backlight brightness register (DCON_REG_BRIGHT) address is 0xa. Signed-off-by: Jens Frederich diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h index 524ee49..e2663b1 100644 --- a/drivers/staging/olpc_dcon/olpc_dcon.h +++ b/drivers/staging/olpc_dcon

Re: [PATCH 2/3] Staging: olpc_dcon: replace some magic numbers

2013-08-16 Thread Jens Frederich
On Fri, Aug 16, 2013 at 9:13 AM, Dan Carpenter wrote: > On Thu, Aug 15, 2013 at 09:34:55PM +0200, Jens Frederich wrote: >> The 0x42 initialize squence 0x101 is wrong. According to >> the specification Bit 8 is reserved, thus not in use. >> I removed it. > > Really thes

Re: [PATCH] Staging: olpc_dcon: more big endian conformity

2013-08-15 Thread Jens Frederich
> > What happened to patch 1/3, I never got that. > You never got it, okay I'll resend it to you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: olpc_dcon: more big endian conformity

2013-08-15 Thread Jens Frederich
On Mon, Aug 12, 2013 at 11:07 PM, Greg KH wrote: > On Sun, Aug 04, 2013 at 11:04:16PM +0200, Jens Frederich wrote: >> Using an int which is casted to unsigned char as inbuf is messy. >> The code won't work on big endian systems. The patch should fix >> this. >>

[PATCH 2/3] Staging: olpc_dcon: replace some magic numbers

2013-08-15 Thread Jens Frederich
ence 0x101 means: enable memory power down function and special SDRAM clock delay for synchronize SDRAM output and clock signal. The 0x42 initialize squence 0x101 is wrong. According to the specification Bit 8 is reserved, thus not in use. I removed it. Signed-off-by: Jens Frederich diff --git

[PATCH 3/3] Staging: olpc_dcon: more big endian conformity

2013-08-15 Thread Jens Frederich
Using an int which is casted to unsigned char as inbuf is messy. The code won't work on big endian systems. The patch should fix this. Signed-off-by: Jens Frederich diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index 5ca4fa4..198595e 100644

[PATCH 3/3] Staging: olpc_dcon: more big endian conformity

2013-08-15 Thread Jens Frederich
Using an int which is casted to unsigned char as inbuf is messy. The code won't work on big endian systems. The patch should fix this. Signed-off-by: Jens Frederich diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index 5ca4fa4..198595e 100644

Re: [PATCH] Staging: olpc_dcon: more big endian conformity

2013-08-15 Thread Jens Frederich
On Mon, Aug 12, 2013 at 11:07 PM, Greg KH wrote: > On Sun, Aug 04, 2013 at 11:04:16PM +0200, Jens Frederich wrote: >> Using an int which is casted to unsigned char as inbuf is messy. >> The code won't work on big endian systems. The patch should fix >> this. >>

[PATCH] Staging: olpc_dcon: more big endian conformity

2013-08-04 Thread Jens Frederich
Using an int which is casted to unsigned char as inbuf is messy. The code won't work on big endian systems. The patch should fix this. Signed-off-by: Jens Frederich diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index 5ca4fa4..198595e 100644

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-04 Thread Jens Frederich
On Sun, Aug 4, 2013 at 1:14 AM, Dan Carpenter wrote: > On Sat, Aug 03, 2013 at 10:44:35PM +0200, Jens Frederich wrote: >> @@ -126,7 +127,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, >> int is_powered_down) >> power_up: >> if (is_powered_dow

[PATCH] Staging: olpc_dcon: updating MAINTAINERS

2013-08-04 Thread Jens Frederich
Andres Salomon and Chris Ball are not longer at OLPC. Daniel Drake is the new OLPC go-to guy. And I wanna also be CC'd on DCON and other OLPC patches. Signed-off-by: Jens Frederich diff --git a/MAINTAINERS b/MAINTAINERS index d83f70f..2076caa 100644 --- a/MAINTAINERS +++ b/MAINTA

[PATCH] Staging: olpc_dcon: updating MAINTAINERS

2013-08-04 Thread Jens Frederich
Andres Salomon and Chris Ball are not longer at OLPC. Daniel Drake is the new OLPC go-to guy. And I wanna also be CC'd on DCON and other OLPC patches. Signed-off-by: Jens Frederich diff --git a/MAINTAINERS b/MAINTAINERS index d83f70f..2076caa 100644 --- a/MAINTAINERS +++ b/MAINTA

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-04 Thread Jens Frederich
On Sun, Aug 4, 2013 at 5:57 AM, Jon Nettleton wrote: > > On Aug 3, 2013 11:38 PM, "Andres Salomon" wrote: >> >> On Sat, 3 Aug 2013 23:36:15 +0200 >> Jens Frederich wrote: >> >> > On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon >> > wr

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon wrote: > Please Cc Daniel on these. Cjb and myself are no longer at olpc. > Do you know what's with Jon Nettleton? He is also on the TODO list? ___ devel mailing list de...@linuxdriverproject.org http://d

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon wrote: > Please Cc Daniel on these. Cjb and myself are no longer at olpc. > Sorry, I've forgotten it. I will update the the TODO list. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.l

[PATCH] Staging: olpc_dcon: Already completed TODO entry removed

2013-08-03 Thread Jens Frederich
The TODO entry - drop global variables, use a proper olpc_dcon_priv struct - is already finished. The driver has no global variables. It uses the private structure 'dcon_priv'. Signed-off-by: Jens Frederich diff --git a/drivers/staging/olpc_dcon/TODO b/drivers/staging/olpc_dcon/

[PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
ence 0x101 means: enable memory power down function and special SDRAM clock delay for synchronize SDRAM output and clock signal. The 0x42 initialize squence 0x101 is wrong. According to the specification Bit 8 is reserved, thus not in use. I removed it. Signed-off-by: Jens Frederich diff --git

[PATCH] staging: olpc_dcon: provide detailed FB_OLPC_DCON help section

2013-07-30 Thread Jens Frederich
The FB_OLPC_DCON help section is to short according to checkpatch.pl. We want more information about the controller type, its task, its video pipeline position and so on. There are no style issues, remove checkpatch.pl TODO entry. Signed-off-by: Jens Frederich diff --git a/drivers/staging

[PATCH 2/2] staging: olpc_dcon: provide detailed FB_OLPC_DCON help section

2013-07-29 Thread Jens Frederich
The FB_OLPC_DCON help section is to short according to checkpatch.pl. We want more information about the controller type, its task, its video pipeline position and so on. There are no style issues, remove checkpatch.pl TODO entry. Signed-off-by: Jens Frederich --- drivers/staging/olpc_dcon

[PATCH] Staging: olpc_dcon: change to msleep to usleep_range

2013-07-25 Thread Jens Frederich
The resolution of msleep is related to HZ, so with HZ set to 100 any msleep of less then 10ms will become ~10ms. This is not what we want. Use usleep_range to get more control of what is happening here. Signed-off-by: Jens Frederich --- drivers/staging/olpc_dcon/olpc_dcon.c |4 ++-- 1 file

Re: driverdev mailing list status

2013-07-24 Thread Jens Frederich
Hello Greg, that's my second try to check the list. thanks, Jens On Sat, Jul 20, 2013 at 10:47 PM, Greg KH wrote: > The mailing list seems to be dead again, is anyone succeeding on sending > any mail through it? > > thanks, > > greg k-h > ___ > devel