atches with checkpatch.pl before submitting them.
There are a bunch of "space required after ','" errors in this patch.
--
- Jeremiah Mahler
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah
of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
edca_setting_UL[HT_IOT_PEER_MAX] = {
> + 0x5e4322, 0xa44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f
> +};
But this change is not related to C99 comments and you didn't
explain why this change was made in your log message.
It should probably be in a separate patch.
[...]
--
- Jeremiah
is incorrect because they are being used outside
of this file.
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majo
t; #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majo
It is better than no description at all. But listing each identical
error is redundant. I would have just said something to the effect of
"fix three space prohibited errors ...".
> Signed-off-by: Jonas Lundqvist
> ---
> drivers/staging/line6/pcm.h | 6 +++
ns(+), 3 deletions(-)
>
[...]
--
- Jeremiah Mahler
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
uffer' - unexpected unlock
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/lnet/selftest/rpc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c
b/drivers/staging/lustre/lnet/selftest/rpc.c
index 2e9094b..1f7d9a6 100644
--- a/drivers/stag
ssion' - unexpected unlock
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/selftest/framework.c
b/drivers/staging/lustre/lnet/selftest/framework.c
index 56b4ef4..5709
uffer' - unexpected unlock
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/lnet/selftest/rpc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c
b/drivers/staging/lustre/lnet/selftest/rpc.c
index bb6aa2e..2e9094b 100644
--- a/drivers/staging/l
Fix several "symbol '...' was not declared" sparse warnings
for variables which are only used locally by declaring them static.
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
drivers/staging/lustre/lnet/selftest/rpc.c | 2
These patches fix most of the "undeclared" and "context imbalance"
sparse warnings for the lustre code in the selftest/ directory.
Jeremiah Mahler (5):
staging: lustre: selftest: fix "not declared" by declaring in header
staging: lustre: selftest: fix &quo
Fix several "symbol '...' was not declared" sparse warnings which
are caused by global variables by declaring them in the header file.
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/lnet/selftest/selftest.h | 12
1 file changed, 12 insertions(+)
Switch from MIN to min_t and remove the previous cast of the second
argument to int.
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
b/drivers/staging
: Jeremiah Mahler
---
drivers/staging/lustre/lnet/lnet/lib-move.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c
b/drivers/staging/lustre/lnet/lnet/lib-move.c
index 706c5ee..76eb238 100644
--- a/drivers/staging/lustre/lnet/lnet/lib
Switch from MIN/MAX to min_t/max_t with a size_t type. The size_t type
was chosen because one operand is a size_t and all the others are
immediate integer values.
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/lnet/lnet/router_proc.c | 2 +-
1 file changed, 1 insertion(+), 1
Custom MIN/MAX operations are being used which are not as robust
as the built in min/max operations which will warn about potentially
problematic type comparisons.
For the simple cases, where no type warning is produced, simply
replace MIN/MAX with min/max.
Signed-off-by: Jeremiah Mahler
Remove all custom MIN/MAX and min_t operations since they are
no longer needed.
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 8
drivers/staging/lustre/lustre/osc/osc_internal.h | 5 -
2 files changed, 13 deletions
Switch from MIN to the built in min_t with the int type.
Signed-off-by: Jeremiah Mahler
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
b/drivers/staging/lustre
the built in min/max
functions.
Jeremiah Mahler (6):
staging: lustre: use min/max instead of MIN/MAX, simple cases
staging: lustre: replace MIN with min_t
staging: lustre: replace MIN/MAX with min_t/max_t
staging: lustre: replace MIN with min, cast (__kernel_size_t)
staging: lustre
NT |
DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
- dev->iobase + DMM32AT_INTCLK_REG);
+dev->iobase + DMM32AT_INTCLK_REG);
}
static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice
*s)
--
- Jeremiah Mahler
___
he body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Dec 24, 2014 at 12:01:10AM +0800, Gmail wrote:
> People say that is not a legal name, therefore I create this English name
> sound like my real name.
>
I'm confused. So Ben Chan isn't your real name, just one you made up?
> > On Dec 23, 2014, at 11:57 P
http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
; practice. Would switching back to the space be preferable? And as far as
> width, should I add a \(enter) where necessary?
>
The spacing in the code was fine. I was referring to your log message
(below).
> And the blank line and two patch bit: understood, simple fix.
>
> - Sage
one.
Interestingly, if you go back to this commit and compile it, no error
is generated unless you enable sparse checks.
--
- Jeremiah Mahler
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
pr_err("%s: bug, invalid multiplier=%i\n", __func__,
> multiplier);
> --
> 2.2.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> M
quot;,
> - __func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
> + __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
>
> /* bitmap[0:27] = tx_rate_bitmap */
> /* bitmap[28:31]= Rate Adaptive
e Adaptive id */
> --
> Gangadhar V
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Plea
- return (triggered != 0);
> + return triggered != 0;
> }
>
[...]
When I run checkpatch.pl it doesn't find any errors and the parenthesis
haven't been removed. How are you running checkpatch.pl? Are you using
any extra options?
--
- Jeremiah Mahler
_
Andy,
On Mon, Dec 15, 2014 at 03:47:04PM +, Andy Whitcroft wrote:
> On Sun, Dec 14, 2014 at 11:59:19PM -0800, Jeremiah Mahler wrote:
[...]
>
> The calculation appears identical to my reading, the original form was:
>
> next_gpadl_handle = atomic_read(&vmbus_connectio
Dan,
On Mon, Dec 15, 2014 at 04:43:34PM +0300, Dan Carpenter wrote:
> On Mon, Dec 15, 2014 at 05:03:46AM -0800, Jeremiah Mahler wrote:
> >
> > Or another way mentioned in K&R that produces a compile error
> >
> > if (NULL = x)
> >
>
> Y
On Mon, Dec 15, 2014 at 11:44:21AM +, One Thousand Gnomes wrote:
> On Sat, 13 Dec 2014 11:46:47 -0800
> Jeremiah Mahler wrote:
>
> > Loïc,
> >
> > On Sat, Dec 13, 2014 at 07:22:38PM +0100, Loic Pefferkorn wrote:
> > > > Whose conventio
KY Srinivasan,
On Mon, Dec 15, 2014 at 07:00:45AM +, KY Srinivasan wrote:
>
>
> > -Original Message-
> > From: Jeremiah Mahler [mailto:jmmah...@gmail.com]
> > Sent: Wednesday, December 10, 2014 6:10 PM
> > To: KY Srinivasan
> > Cc: g
> total: 0 errors, 0 warnings, 5 checks, 442 lines checked
>
> drivers/staging/goldfish/goldfish_nand.c has style problems, please review.
>
> I have also found another commit having the same purpose:
> 7f376cd6dc1c9bfd14514c70765e6900a961c4b8
>
> --
> Cheers,
> Loïc
It looks like you're ri
form_set_drvdata(pdev, data);
>
> r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (r == NULL) {
> + if (!r) {
> dev_err(&pdev->dev, "platform_get_resource failed\n");
> return -ENODEV;
> }
> data->reg_base =
adl_header(kbuffer, size, &msginfo, &msgcount);
> if (ret)
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More
isutils.c
> +++ b/drivers/staging/unisys/uislib/uisutils.c
> @@ -27,7 +27,6 @@
> #include "vbushelper.h"
> #include
> #include
> -#include
> #ifdef CONFIG_HIGHMEM
> #include
> #endif
There are two duplicates of the second one. Lines: 21, 28 an
the default log level is 4 which corresponds to
KERN_WARNING. So switching to pr_err() would change the log level
of these messages. Using pr_warn() might be a better choice.
--
- Jeremiah Mahler
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
rning. Fix the sparse warning by moving these
prototypes from r8192U_core.c to ieee80211.h.
Signed-off-by: Jeremiah Mahler
Cc: Greg Kroah-Hartman
Cc: Joel Pelaez Jorge
Cc: Andrea Merello
Cc: "John W. Linville"
Cc: Joe Perches
Cc: Himangi Saraogi
Cc: Arnd Bergmann
Cc: Peter P Was
ers/staging/rtl8192u/ieee80211/ieee80211_module.c:297:13: warning:
symbol 'ieee80211_debug_exit' was not declared. Should it be static?
These functions are used outside of this file so using static will not
work. Fix the warning by declaring the functions in the header file,
ieee80211.h
Signed
ers/staging/rtl8192u/ieee80211/ieee80211_module.c:297:13: warning:
symbol 'ieee80211_debug_exit' was not declared. Should it be static?
These functions are used outside of this file so using static will not
work. Fix the warning by declaring the functions in the header file,
ieee80211.h
Signed
Place 'else' on same line as closing brace '}' as per
Documentation/CodingStyle. Fixes 1 error found by checkpatch.pl.
Signed-off-by: Jeremiah Mahler
---
drivers/staging/xillybus/xillybus_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/driv
Enclose the body of the multi-statement DGNC_VERIFY_BOARD macro inside a
do - while block as per Documentation/CodingStyle. Fixes 1 error found
by checkpatch.pl.
Signed-off-by: Jeremiah Mahler
---
drivers/staging/dgnc/dgnc_sysfs.c | 20 +++-
1 file changed, 11 insertions(+), 9
46 matches
Mail list logo
